Passed
Push — hotfix/fix-counts ( 767bb7...0ee906 )
by Paul
05:43
created
plugin/Modules/Html/Builder.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	{
67 67
 		$instance = new static;
68 68
 		$instance->setTagFromMethod( $method );
69
-		call_user_func_array( [$instance, 'normalize'], $args += ['',''] );
69
+		call_user_func_array( [$instance, 'normalize'], $args += ['', ''] );
70 70
 		$tags = array_merge( static::TAGS_FORM, static::TAGS_SINGLE, static::TAGS_STRUCTURE, static::TAGS_TEXT );
71 71
 		do_action_ref_array( 'site-reviews/builder', [$instance] );
72 72
 		$generatedTag = in_array( $instance->tag, $tags )
@@ -91,8 +91,8 @@  discard block
 block discarded – undo
91 91
 			'render' => 'is_bool',
92 92
 			'tag' => 'is_string',
93 93
 		];
94
-		if( !isset( $properties[$property] )
95
-			|| empty( array_filter( [$value], $properties[$property] ))
94
+		if( !isset($properties[$property])
95
+			|| empty(array_filter( [$value], $properties[$property] ))
96 96
 		)return;
97 97
 		$this->$property = $value;
98 98
 	}
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 */
103 103
 	public function getClosingTag()
104 104
 	{
105
-		if( empty( $this->tag ))return;
105
+		if( empty($this->tag) )return;
106 106
 		return '</'.$this->tag.'>';
107 107
 	}
108 108
 
@@ -111,8 +111,8 @@  discard block
 block discarded – undo
111 111
 	 */
112 112
 	public function getOpeningTag()
113 113
 	{
114
-		if( empty( $this->tag ))return;
115
-		$attributes = glsr( Attributes::class )->{$this->tag}( $this->args )->toString();
114
+		if( empty($this->tag) )return;
115
+		$attributes = glsr( Attributes::class )->{$this->tag}($this->args)->toString();
116 116
 		return '<'.trim( $this->tag.' '.$attributes ).'>';
117 117
 	}
118 118
 
@@ -121,10 +121,10 @@  discard block
 block discarded – undo
121 121
 	 */
122 122
 	public function getTag()
123 123
 	{
124
-		if( in_array( $this->tag, static::TAGS_SINGLE )) {
124
+		if( in_array( $this->tag, static::TAGS_SINGLE ) ) {
125 125
 			return $this->getOpeningTag();
126 126
 		}
127
-		if( !in_array( $this->tag, static::TAGS_FORM )) {
127
+		if( !in_array( $this->tag, static::TAGS_FORM ) ) {
128 128
 			return $this->buildDefaultTag();
129 129
 		}
130 130
 		return call_user_func( [$this, 'buildForm'.ucfirst( $this->tag )] ).$this->buildFieldDescription();
@@ -135,8 +135,8 @@  discard block
 block discarded – undo
135 135
 	 */
136 136
 	public function raw( array $field )
137 137
 	{
138
-		unset( $field['label'] );
139
-		return $this->{$field['type']}( $field );
138
+		unset($field['label']);
139
+		return $this->{$field['type']}($field);
140 140
 	}
141 141
 
142 142
 	/**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	protected function buildCustomField()
146 146
 	{
147 147
 		$className = $this->getCustomFieldClassName();
148
-		if( class_exists( $className )) {
148
+		if( class_exists( $className ) ) {
149 149
 			return (new $className( $this ))->build();
150 150
 		}
151 151
 		glsr_log()->error( 'Field missing: '.$className );
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 	 */
157 157
 	protected function buildDefaultTag( $text = '' )
158 158
 	{
159
-		if( empty( $text )) {
159
+		if( empty($text) ) {
160 160
 			$text = $this->args['text'];
161 161
 		}
162 162
 		return $this->getOpeningTag().$text.$this->getClosingTag();
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 */
168 168
 	protected function buildFieldDescription()
169 169
 	{
170
-		if( empty( $this->args['description'] ))return;
170
+		if( empty($this->args['description']) )return;
171 171
 		if( $this->args['is_widget'] ) {
172 172
 			return $this->small( $this->args['description'] );
173 173
 		}
@@ -179,13 +179,13 @@  discard block
 block discarded – undo
179 179
 	 */
180 180
 	protected function buildFormInput()
181 181
 	{
182
-		if( !in_array( $this->args['type'], ['checkbox', 'radio'] )) {
183
-			if( isset( $this->args['multiple'] )) {
184
-				$this->args['name'].= '[]';
182
+		if( !in_array( $this->args['type'], ['checkbox', 'radio'] ) ) {
183
+			if( isset($this->args['multiple']) ) {
184
+				$this->args['name'] .= '[]';
185 185
 			}
186 186
 			return $this->buildFormLabel().$this->getOpeningTag();
187 187
 		}
188
-		return empty( $this->args['options'] )
188
+		return empty($this->args['options'])
189 189
 			? $this->buildFormInputChoice()
190 190
 			: $this->buildFormInputMultiChoice();
191 191
 	}
@@ -195,19 +195,19 @@  discard block
 block discarded – undo
195 195
 	 */
196 196
 	protected function buildFormInputChoice()
197 197
 	{
198
-		if( !empty( $this->args['text'] )) {
198
+		if( !empty($this->args['text']) ) {
199 199
 			$this->args['label'] = $this->args['text'];
200 200
 		}
201 201
 		if( !$this->args['is_public'] ) {
202
-			return $this->buildFormLabel([
202
+			return $this->buildFormLabel( [
203 203
 				'class' => 'glsr-'.$this->args['type'].'-label',
204 204
 				'text' => $this->getOpeningTag().' '.$this->args['label'].'<span></span>',
205
-			]);
205
+			] );
206 206
 		}
207
-		return $this->getOpeningTag().$this->buildFormLabel([
207
+		return $this->getOpeningTag().$this->buildFormLabel( [
208 208
 			'class' => 'glsr-'.$this->args['type'].'-label',
209 209
 			'text' => $this->args['label'].'<span></span>',
210
-		]);
210
+		] );
211 211
 	}
212 212
 
213 213
 	/**
@@ -216,22 +216,22 @@  discard block
 block discarded – undo
216 216
 	protected function buildFormInputMultiChoice()
217 217
 	{
218 218
 		if( $this->args['type'] == 'checkbox' ) {
219
-			$this->args['name'].= '[]';
219
+			$this->args['name'] .= '[]';
220 220
 		}
221 221
 		$index = 0;
222
-		$options = array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) use( &$index ) {
222
+		$options = array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) use(&$index) {
223 223
 			return $carry.$this->li( $this->{$this->args['type']}([
224 224
 				'checked' => in_array( $key, (array)$this->args['value'] ),
225 225
 				'id' => $this->args['id'].'-'.$index++,
226 226
 				'name' => $this->args['name'],
227 227
 				'text' => $this->args['options'][$key],
228 228
 				'value' => $key,
229
-			]));
229
+			]) );
230 230
 		});
231 231
 		return $this->ul( $options, [
232 232
 			'class' => $this->args['class'],
233 233
 			'id' => $this->args['id'],
234
-		]);
234
+		] );
235 235
 	}
236 236
 
237 237
 	/**
@@ -239,13 +239,13 @@  discard block
 block discarded – undo
239 239
 	 */
240 240
 	protected function buildFormLabel( array $customArgs = [] )
241 241
 	{
242
-		if( empty( $this->args['label'] ) || $this->args['type'] == 'hidden' )return;
242
+		if( empty($this->args['label']) || $this->args['type'] == 'hidden' )return;
243 243
 		return $this->label( wp_parse_args( $customArgs, [
244 244
 			'for' => $this->args['id'],
245 245
 			'is_public' => $this->args['is_public'],
246 246
 			'text' => $this->args['label'],
247 247
 			'type' => $this->args['type'],
248
-		]));
248
+		] ) );
249 249
 	}
250 250
 
251 251
 	/**
@@ -262,11 +262,11 @@  discard block
 block discarded – undo
262 262
 	protected function buildFormSelectOptions()
263 263
 	{
264 264
 		return array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) {
265
-			return $carry.$this->option([
265
+			return $carry.$this->option( [
266 266
 				'selected' => $this->args['value'] == $key,
267 267
 				'text' => $this->args['options'][$key],
268 268
 				'value' => $key,
269
-			]);
269
+			] );
270 270
 		});
271 271
 	}
272 272
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 	protected function mergeArgsWithRequiredDefaults()
303 303
 	{
304 304
 		$className = $this->getCustomFieldClassName();
305
-		if( class_exists( $className )) {
305
+		if( class_exists( $className ) ) {
306 306
 			$this->args = $className::merge( $this->args );
307 307
 		}
308 308
 		$this->args = glsr( BuilderDefaults::class )->merge( $this->args );
@@ -314,16 +314,16 @@  discard block
 block discarded – undo
314 314
 	 */
315 315
 	protected function normalize( ...$params )
316 316
 	{
317
-		if( is_string( $params[0] ) || is_numeric( $params[0] )) {
317
+		if( is_string( $params[0] ) || is_numeric( $params[0] ) ) {
318 318
 			$this->setNameOrTextAttributeForTag( $params[0] );
319 319
 		}
320
-		if( is_array( $params[0] )) {
320
+		if( is_array( $params[0] ) ) {
321 321
 			$this->args += $params[0];
322 322
 		}
323
-		else if( is_array( $params[1] )) {
323
+		else if( is_array( $params[1] ) ) {
324 324
 			$this->args += $params[1];
325 325
 		}
326
-		if( !isset( $this->args['is_public'] )) {
326
+		if( !isset($this->args['is_public']) ) {
327 327
 			$this->args['is_public'] = false;
328 328
 		}
329 329
 	}
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
 	protected function setTagFromMethod( $method )
348 348
 	{
349 349
 		$this->tag = strtolower( $method );
350
-		if( in_array( $this->tag, static::INPUT_TYPES )) {
350
+		if( in_array( $this->tag, static::INPUT_TYPES ) ) {
351 351
 			$this->args['type'] = $this->tag;
352 352
 			$this->tag = 'input';
353 353
 		}
Please login to merge, or discard this patch.
plugin/Modules/Style.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -50,12 +50,12 @@  discard block
 block discarded – undo
50 50
 			'templates/form/submit-button',
51 51
 			'templates/reviews-form',
52 52
 		];
53
-		if( !preg_match( '('.implode( '|', $styledViews ).')', $view )) {
53
+		if( !preg_match( '('.implode( '|', $styledViews ).')', $view ) ) {
54 54
 			return $view;
55 55
 		}
56 56
 		$views = $this->generatePossibleViews( $view );
57 57
 		foreach( $views as $possibleView ) {
58
-			if( !file_exists( glsr()->file( $possibleView )))continue;
58
+			if( !file_exists( glsr()->file( $possibleView ) ) )continue;
59 59
 			return glsr( Helper::class )->removePrefix( 'views/', $possibleView );
60 60
 		}
61 61
 		return $view;
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	 */
89 89
 	public function modifyField( Builder $instance )
90 90
 	{
91
-		if( !$this->isPublicInstance( $instance ) || empty( array_filter( $this->fields )))return;
91
+		if( !$this->isPublicInstance( $instance ) || empty(array_filter( $this->fields )) )return;
92 92
 		call_user_func_array( [$this, 'customize'], [$instance] );
93 93
 	}
94 94
 
@@ -105,10 +105,10 @@  discard block
 block discarded – undo
105 105
 	 */
106 106
 	protected function customize( Builder $instance )
107 107
 	{
108
-		if( !array_key_exists( $instance->tag, $this->fields ))return;
109
-		$args = wp_parse_args( $instance->args, array_fill_keys( ['class', 'type'], '' ));
108
+		if( !array_key_exists( $instance->tag, $this->fields ) )return;
109
+		$args = wp_parse_args( $instance->args, array_fill_keys( ['class', 'type'], '' ) );
110 110
 		$key = $instance->tag.'_'.$args['type'];
111
-		$classes = glsr_get( $this->fields, $key, glsr_get( $this->fields, $instance->tag ));
111
+		$classes = glsr_get( $this->fields, $key, glsr_get( $this->fields, $instance->tag ) );
112 112
 		$instance->args['class'] = trim( $args['class'].' '.$classes );
113 113
 		do_action_ref_array( 'site-reviews/customize/'.$this->style, [$instance] );
114 114
 	}
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 		$args = wp_parse_args( $instance->args, [
141 141
 			'is_public' => false,
142 142
 			'is_raw' => false,
143
-		]);
143
+		] );
144 144
 		if( is_admin() || !$args['is_public'] || $args['is_raw'] ) {
145 145
 			return false;
146 146
 		}
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -55,7 +55,9 @@  discard block
 block discarded – undo
55 55
 		}
56 56
 		$views = $this->generatePossibleViews( $view );
57 57
 		foreach( $views as $possibleView ) {
58
-			if( !file_exists( glsr()->file( $possibleView )))continue;
58
+			if( !file_exists( glsr()->file( $possibleView ))) {
59
+				continue;
60
+			}
59 61
 			return glsr( Helper::class )->removePrefix( 'views/', $possibleView );
60 62
 		}
61 63
 		return $view;
@@ -88,7 +90,9 @@  discard block
 block discarded – undo
88 90
 	 */
89 91
 	public function modifyField( Builder $instance )
90 92
 	{
91
-		if( !$this->isPublicInstance( $instance ) || empty( array_filter( $this->fields )))return;
93
+		if( !$this->isPublicInstance( $instance ) || empty( array_filter( $this->fields ))) {
94
+			return;
95
+		}
92 96
 		call_user_func_array( [$this, 'customize'], [$instance] );
93 97
 	}
94 98
 
@@ -105,7 +109,9 @@  discard block
 block discarded – undo
105 109
 	 */
106 110
 	protected function customize( Builder $instance )
107 111
 	{
108
-		if( !array_key_exists( $instance->tag, $this->fields ))return;
112
+		if( !array_key_exists( $instance->tag, $this->fields )) {
113
+			return;
114
+		}
109 115
 		$args = wp_parse_args( $instance->args, array_fill_keys( ['class', 'type'], '' ));
110 116
 		$key = $instance->tag.'_'.$args['type'];
111 117
 		$classes = glsr_get( $this->fields, $key, glsr_get( $this->fields, $instance->tag ));
Please login to merge, or discard this patch.