Inspection of "create excerpts for languages that do not use word..." - pryley/site-reviews - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 75fa9a...bcead5 )

by Paul

created 2018-07-11 06:52 UTC

Status

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 				'navigation' => $navigation,
 			],
 			'reviews' => $this->buildReviews(),
-		]);
+		] );
 	}
 
 	/**
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
 		$reviewValues = [];
 		foreach( $review as $key => $value ) {
 			$method = glsr( Helper::class )->buildMethodName( $key, 'buildOption' );
-			if( !method_exists( $this, $method ))continue;
+			if( !method_exists( $this, $method ) )continue;
 			$reviewValues[$key] = $this->$method( $key, $value );
 		}
 		$reviewValues = apply_filters( 'site-reviews/review/build/after', $reviewValues );
@@ -96,12 +96,12 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionAssignedTo( $key, $value )
 	{
-		if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' ))return;
-		$post = get_post( intval( $value ));
-		if( !( $post instanceof WP_Post ))return;
+		if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' ) )return;
+		$post = get_post( intval( $value ) );
+		if( !($post instanceof WP_Post) )return;
 		$permalink = glsr( Builder::class )->a( get_the_title( $post->ID ), [
 			'href' => get_the_permalink( $post->ID ),
-		]);
+		] );
 		$assignedTo = sprintf( __( 'Review of %s', 'site-reviews' ), $permalink );
 		return $this->wrap( $key, '<span>'.$assignedTo.'</span>' );
 	}
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionAuthor( $key, $value )
 	{
-		if( $this->isHidden( $key ))return;
+		if( $this->isHidden( $key ) )return;
 		$prefix = !$this->isOptionEnabled( 'settings.reviews.avatars.enabled' )
 			? apply_filters( 'site-reviews/review/author/prefix', '&mdash;' )
 			: '';
@@ -127,13 +127,13 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionAvatar( $key, $value )
 	{
-		if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' ))return;
+		if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' ) )return;
 		$size = $this->getOption( 'settings.reviews.avatars.size', 40 );
-		return $this->wrap( $key, glsr( Builder::class )->img([
+		return $this->wrap( $key, glsr( Builder::class )->img( [
 			'src' => $this->generateAvatar( $value ),
 			'height' => $size,
 			'width' => $size,
-		]));
+		] ) );
 	}
 
 	/**
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
 	protected function buildOptionContent( $key, $value )
 	{
 		$text = $this->normalizeText( $value );
-		if( $this->isHiddenOrEmpty( $key, $text ))return;
+		if( $this->isHiddenOrEmpty( $key, $text ) )return;
 		return $this->wrap( $key, '<p>'.$text.'</p>' );
 	}
 
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionDate( $key, $value )
 	{
-		if( $this->isHidden( $key ))return;
+		if( $this->isHidden( $key ) )return;
 		$dateFormat = $this->getOption( 'settings.reviews.date.format', 'default' );
 		if( $dateFormat == 'relative' ) {
 			$date = glsr( Date::class )->relative( $value );
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
 			$format = $dateFormat == 'custom'
 				? $this->getOption( 'settings.reviews.date.custom', 'M j, Y' )
 				: (string)get_option( 'date_format' );
-			$date = date_i18n( $format, strtotime( $value ));
+			$date = date_i18n( $format, strtotime( $value ) );
 		}
 		return $this->wrap( $key, '<span>'.$date.'</span>' );
 	}
@@ -176,10 +176,10 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionRating( $key, $value )
 	{
-		if( $this->isHiddenOrEmpty( $key, $value ))return;
+		if( $this->isHiddenOrEmpty( $key, $value ) )return;
 		$rating = glsr( Html::class )->buildPartial( 'star-rating', [
 			'rating' => $value,
-		]);
+		] );
 		return $this->wrap( $key, $rating );
 	}
 
@@ -190,8 +190,8 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionResponse( $key, $value )
 	{
-		if( $this->isHiddenOrEmpty( $key, $value ))return;
-		$title = sprintf( __( 'Response from %s', 'site-reviews' ), get_bloginfo( 'name' ));
+		if( $this->isHiddenOrEmpty( $key, $value ) )return;
+		$title = sprintf( __( 'Response from %s', 'site-reviews' ), get_bloginfo( 'name' ) );
 		$text = $this->normalizeText( $value );
 		$text = '<p><strong>'.$title.'</strong></p><p>'.$text.'</p>';
 		return $this->wrap( $key,
@@ -207,8 +207,8 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionTitle( $key, $value )
 	{
-		if( $this->isHidden( $key ))return;
-		if( empty( $value )) {
+		if( $this->isHidden( $key ) )return;
+		if( empty($value) ) {
 			$value = __( 'No Title', 'site-reviews' );
 		}
 		return $this->wrap( $key, '<h3>'.$value.'</h3>' );
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
 			return $avatarUrl;
 		}
 		$authorIdOrEmail = get_the_author_meta( 'ID', $review->user_id );
-		if( empty( $authorIdOrEmail )) {
+		if( empty($authorIdOrEmail) ) {
 			$authorIdOrEmail = $review->email;
 		}
 		return (string)get_avatar_url( $authorIdOrEmail );
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
 	 */
 	protected function generateSchema()
 	{
-		if( !wp_validate_boolean( $this->args['schema'] ))return;
+		if( !wp_validate_boolean( $this->args['schema'] ) )return;
 		glsr( Schema::class )->store(
 			glsr( Schema::class )->build( $this->args )
 		);
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
 	 */
 	protected function getExcerpt( $text )
 	{
-		$limit = intval( $this->getOption( 'settings.reviews.excerpt.length', 55 ));
+		$limit = intval( $this->getOption( 'settings.reviews.excerpt.length', 55 ) );
 		$text = extension_loaded( 'intl' )
 			? $this->buildIntlExcerpt( $text, $limit )
 			: $this->buildExcerpt( $text, $limit );
@@ -278,15 +278,15 @@  discard block
 block discarded – undo
 		if( str_word_count( $text, 0 ) <= $limit ) {
 			return $text;
 		}
-		$words = array_keys( str_word_count( $text, 2 ));
-		$excerpt = ltrim( substr( $text, 0, $words[$limit] ));
+		$words = array_keys( str_word_count( $text, 2 ) );
+		$excerpt = ltrim( substr( $text, 0, $words[$limit] ) );
 
-		$hiddenText = substr( $text, strlen( $excerpt ));
+		$hiddenText = substr( $text, strlen( $excerpt ) );
 		$showMore = glsr( Builder::class )->span( $hiddenText, [
 			'class' => 'glsr-hidden glsr-hidden-text',
 			'data-show-less' => __( 'Show less', 'site-reviews' ),
 			'data-show-more' => __( 'Show more', 'site-reviews' ),
-		]);
+		] );
 		return $excerpt.$showMore;
 	}
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
 		$words->setText( $text );
 		$count = 0;
 		$break = strlen( $text );
-		foreach( $words as $offset ){
+		foreach( $words as $offset ) {
 			if( \IntlBreakIterator::WORD_NONE === $words->getRuleStatus() )continue;
 			$count++;
 			if( $count == $limit ) {
@@ -311,14 +311,14 @@  discard block
 block discarded – undo
 		}
 		$excerpt = substr( $text, 0, $break );
 		$hiddenText = substr( $text, $break );
-		if( empty( $hiddenText )) {
+		if( empty($hiddenText) ) {
 			return $excerpt;
 		}
 		$showMore = glsr( Builder::class )->span( $hiddenText, [
 			'class' => 'glsr-hidden glsr-hidden-text',
 			'data-show-less' => __( 'Show less', 'site-reviews' ),
 			'data-show-more' => __( 'Show more', 'site-reviews' ),
-		]);
+		] );
 		return $excerpt.$showMore;
 	}
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
 	 */
 	protected function getOption( $path, $fallback = '' )
 	{
-		if( array_key_exists( $path, $this->options )) {
+		if( array_key_exists( $path, $this->options ) ) {
 			return $this->options[$path];
 		}
 		return $fallback;
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
 	 */
 	protected function isHidden( $key, $path = '' )
 	{
-		$isOptionEnabled = !empty( $path )
+		$isOptionEnabled = !empty($path)
 			? $this->isOptionEnabled( $path )
 			: true;
 		return in_array( $key, $this->args['hide'] ) || !$isOptionEnabled;
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
 	 */
 	protected function isHiddenOrEmpty( $key, $value )
 	{
-		return $this->isHidden( $key ) || empty( $value );
+		return $this->isHidden( $key ) || empty($value);
 	}
 
 	/**
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
 	protected function normalizeText( $text )
 	{
 		$text = wp_kses( $text, wp_kses_allowed_html() );
-		$text = convert_smilies( wptexturize( strip_shortcodes( $text )));
+		$text = convert_smilies( wptexturize( strip_shortcodes( $text ) ) );
 		$text = str_replace( ']]>', ']]&gt;', $text );
 		$text = preg_replace( '/(\R){2,}/', '$1', $text );
 		return $this->isOptionEnabled( 'settings.reviews.excerpt.enabled' )
@@ -391,6 +391,6 @@  discard block
 block discarded – undo
 	{
 		return glsr( Builder::class )->div( $value, [
 			'class' => 'glsr-review-'.$key,
-		]);
+		] );
 	}
 }

Please login to merge, or discard this patch.

Braces +36 added lines, -12 removed lines patch added patch discarded remove patch

@@ -82,7 +82,9 @@  discard block
 block discarded – undo
 		$reviewValues = [];
 		foreach( $review as $key => $value ) {
 			$method = glsr( Helper::class )->buildMethodName( $key, 'buildOption' );
-			if( !method_exists( $this, $method ))continue;
+			if( !method_exists( $this, $method )) {
+				continue;
+			}
 			$reviewValues[$key] = $this->$method( $key, $value );
 		}
 		$reviewValues = apply_filters( 'site-reviews/review/build/after', $reviewValues );
@@ -96,9 +98,13 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionAssignedTo( $key, $value )
 	{
-		if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' ))return;
+		if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' )) {
+			return;
+		}
 		$post = get_post( intval( $value ));
-		if( !( $post instanceof WP_Post ))return;
+		if( !( $post instanceof WP_Post )) {
+			return;
+		}
 		$permalink = glsr( Builder::class )->a( get_the_title( $post->ID ), [
 			'href' => get_the_permalink( $post->ID ),
 		]);
@@ -113,7 +119,9 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionAuthor( $key, $value )
 	{
-		if( $this->isHidden( $key ))return;
+		if( $this->isHidden( $key )) {
+			return;
+		}
 		$prefix = !$this->isOptionEnabled( 'settings.reviews.avatars.enabled' )
 			? apply_filters( 'site-reviews/review/author/prefix', '&mdash;' )
 			: '';
@@ -127,7 +135,9 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionAvatar( $key, $value )
 	{
-		if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' ))return;
+		if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' )) {
+			return;
+		}
 		$size = $this->getOption( 'settings.reviews.avatars.size', 40 );
 		return $this->wrap( $key, glsr( Builder::class )->img([
 			'src' => $this->generateAvatar( $value ),
@@ -144,7 +154,9 @@  discard block
 block discarded – undo
 	protected function buildOptionContent( $key, $value )
 	{
 		$text = $this->normalizeText( $value );
-		if( $this->isHiddenOrEmpty( $key, $text ))return;
+		if( $this->isHiddenOrEmpty( $key, $text )) {
+			return;
+		}
 		return $this->wrap( $key, '<p>'.$text.'</p>' );
 	}
 
@@ -155,7 +167,9 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionDate( $key, $value )
 	{
-		if( $this->isHidden( $key ))return;
+		if( $this->isHidden( $key )) {
+			return;
+		}
 		$dateFormat = $this->getOption( 'settings.reviews.date.format', 'default' );
 		if( $dateFormat == 'relative' ) {
 			$date = glsr( Date::class )->relative( $value );
@@ -176,7 +190,9 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionRating( $key, $value )
 	{
-		if( $this->isHiddenOrEmpty( $key, $value ))return;
+		if( $this->isHiddenOrEmpty( $key, $value )) {
+			return;
+		}
 		$rating = glsr( Html::class )->buildPartial( 'star-rating', [
 			'rating' => $value,
 		]);
@@ -190,7 +206,9 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionResponse( $key, $value )
 	{
-		if( $this->isHiddenOrEmpty( $key, $value ))return;
+		if( $this->isHiddenOrEmpty( $key, $value )) {
+			return;
+		}
 		$title = sprintf( __( 'Response from %s', 'site-reviews' ), get_bloginfo( 'name' ));
 		$text = $this->normalizeText( $value );
 		$text = '<p><strong>'.$title.'</strong></p><p>'.$text.'</p>';
@@ -207,7 +225,9 @@  discard block
 block discarded – undo
 	 */
 	protected function buildOptionTitle( $key, $value )
 	{
-		if( $this->isHidden( $key ))return;
+		if( $this->isHidden( $key )) {
+			return;
+		}
 		if( empty( $value )) {
 			$value = __( 'No Title', 'site-reviews' );
 		}
@@ -237,7 +257,9 @@  discard block
 block discarded – undo
 	 */
 	protected function generateSchema()
 	{
-		if( !wp_validate_boolean( $this->args['schema'] ))return;
+		if( !wp_validate_boolean( $this->args['schema'] )) {
+			return;
+		}
 		glsr( Schema::class )->store(
 			glsr( Schema::class )->build( $this->args )
 		);
@@ -302,7 +324,9 @@  discard block
 block discarded – undo
 		$count = 0;
 		$break = strlen( $text );
 		foreach( $words as $offset ){
-			if( \IntlBreakIterator::WORD_NONE === $words->getRuleStatus() )continue;
+			if( \IntlBreakIterator::WORD_NONE === $words->getRuleStatus() ) {
+				continue;
+			}
 			$count++;
 			if( $count == $limit ) {
 				$break = $offset;

Please login to merge, or discard this patch.

		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	'navigation' => $navigation,
57	57	],
58	58	'reviews' => $this->buildReviews(),
59		- ]);
	59	+ ] );
60	60	}
61	61
62	62	/**
		@@ -82,7 +82,7 @@ discard block
		block discarded – undo
82	82	$reviewValues = [];
83	83	foreach( $review as $key => $value ) {
84	84	$method = glsr( Helper::class )->buildMethodName( $key, 'buildOption' );
85		- if( !method_exists( $this, $method ))continue;
	85	+ if( !method_exists( $this, $method ) )continue;
86	86	$reviewValues[$key] = $this->$method( $key, $value );
87	87	}
88	88	$reviewValues = apply_filters( 'site-reviews/review/build/after', $reviewValues );
		@@ -96,12 +96,12 @@ discard block
		block discarded – undo
96	96	*/
97	97	protected function buildOptionAssignedTo( $key, $value )
98	98	{
99		- if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' ))return;
100		- $post = get_post( intval( $value ));
101		- if( !( $post instanceof WP_Post ))return;
	99	+ if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' ) )return;
	100	+ $post = get_post( intval( $value ) );
	101	+ if( !($post instanceof WP_Post) )return;
102	102	$permalink = glsr( Builder::class )->a( get_the_title( $post->ID ), [
103	103	'href' => get_the_permalink( $post->ID ),
104		- ]);
	104	+ ] );
105	105	$assignedTo = sprintf( __( 'Review of %s', 'site-reviews' ), $permalink );
106	106	return $this->wrap( $key, '<span>'.$assignedTo.'</span>' );
107	107	}
		@@ -113,7 +113,7 @@ discard block
		block discarded – undo
113	113	*/
114	114	protected function buildOptionAuthor( $key, $value )
115	115	{
116		- if( $this->isHidden( $key ))return;
	116	+ if( $this->isHidden( $key ) )return;
117	117	$prefix = !$this->isOptionEnabled( 'settings.reviews.avatars.enabled' )
118	118	? apply_filters( 'site-reviews/review/author/prefix', '—' )
119	119	: '';
		@@ -127,13 +127,13 @@ discard block
		block discarded – undo
127	127	*/
128	128	protected function buildOptionAvatar( $key, $value )
129	129	{
130		- if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' ))return;
	130	+ if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' ) )return;
131	131	$size = $this->getOption( 'settings.reviews.avatars.size', 40 );
132		- return $this->wrap( $key, glsr( Builder::class )->img([
	132	+ return $this->wrap( $key, glsr( Builder::class )->img( [
133	133	'src' => $this->generateAvatar( $value ),
134	134	'height' => $size,
135	135	'width' => $size,
136		- ]));
	136	+ ] ) );
137	137	}
138	138
139	139	/**
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	protected function buildOptionContent( $key, $value )
145	145	{
146	146	$text = $this->normalizeText( $value );
147		- if( $this->isHiddenOrEmpty( $key, $text ))return;
	147	+ if( $this->isHiddenOrEmpty( $key, $text ) )return;
148	148	return $this->wrap( $key, '<p>'.$text.'</p>' );
149	149	}
150	150
		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	*/
156	156	protected function buildOptionDate( $key, $value )
157	157	{
158		- if( $this->isHidden( $key ))return;
	158	+ if( $this->isHidden( $key ) )return;
159	159	$dateFormat = $this->getOption( 'settings.reviews.date.format', 'default' );
160	160	if( $dateFormat == 'relative' ) {
161	161	$date = glsr( Date::class )->relative( $value );
		@@ -164,7 +164,7 @@ discard block
		block discarded – undo
164	164	$format = $dateFormat == 'custom'
165	165	? $this->getOption( 'settings.reviews.date.custom', 'M j, Y' )
166	166	: (string)get_option( 'date_format' );
167		- $date = date_i18n( $format, strtotime( $value ));
	167	+ $date = date_i18n( $format, strtotime( $value ) );
168	168	}
169	169	return $this->wrap( $key, '<span>'.$date.'</span>' );
170	170	}
		@@ -176,10 +176,10 @@ discard block
		block discarded – undo
176	176	*/
177	177	protected function buildOptionRating( $key, $value )
178	178	{
179		- if( $this->isHiddenOrEmpty( $key, $value ))return;
	179	+ if( $this->isHiddenOrEmpty( $key, $value ) )return;
180	180	$rating = glsr( Html::class )->buildPartial( 'star-rating', [
181	181	'rating' => $value,
182		- ]);
	182	+ ] );
183	183	return $this->wrap( $key, $rating );
184	184	}
185	185
		@@ -190,8 +190,8 @@ discard block
		block discarded – undo
190	190	*/
191	191	protected function buildOptionResponse( $key, $value )
192	192	{
193		- if( $this->isHiddenOrEmpty( $key, $value ))return;
194		- $title = sprintf( __( 'Response from %s', 'site-reviews' ), get_bloginfo( 'name' ));
	193	+ if( $this->isHiddenOrEmpty( $key, $value ) )return;
	194	+ $title = sprintf( __( 'Response from %s', 'site-reviews' ), get_bloginfo( 'name' ) );
195	195	$text = $this->normalizeText( $value );
196	196	$text = '<p><strong>'.$title.'</strong></p><p>'.$text.'</p>';
197	197	return $this->wrap( $key,
		@@ -207,8 +207,8 @@ discard block
		block discarded – undo
207	207	*/
208	208	protected function buildOptionTitle( $key, $value )
209	209	{
210		- if( $this->isHidden( $key ))return;
211		- if( empty( $value )) {
	210	+ if( $this->isHidden( $key ) )return;
	211	+ if( empty($value) ) {
212	212	$value = __( 'No Title', 'site-reviews' );
213	213	}
214	214	return $this->wrap( $key, '<h3>'.$value.'</h3>' );
		@@ -226,7 +226,7 @@ discard block
		block discarded – undo
226	226	return $avatarUrl;
227	227	}
228	228	$authorIdOrEmail = get_the_author_meta( 'ID', $review->user_id );
229		- if( empty( $authorIdOrEmail )) {
	229	+ if( empty($authorIdOrEmail) ) {
230	230	$authorIdOrEmail = $review->email;
231	231	}
232	232	return (string)get_avatar_url( $authorIdOrEmail );
		@@ -237,7 +237,7 @@ discard block
		block discarded – undo
237	237	*/
238	238	protected function generateSchema()
239	239	{
240		- if( !wp_validate_boolean( $this->args['schema'] ))return;
	240	+ if( !wp_validate_boolean( $this->args['schema'] ) )return;
241	241	glsr( Schema::class )->store(
242	242	glsr( Schema::class )->build( $this->args )
243	243	);
		@@ -261,7 +261,7 @@ discard block
		block discarded – undo
261	261	*/
262	262	protected function getExcerpt( $text )
263	263	{
264		- $limit = intval( $this->getOption( 'settings.reviews.excerpt.length', 55 ));
	264	+ $limit = intval( $this->getOption( 'settings.reviews.excerpt.length', 55 ) );
265	265	$text = extension_loaded( 'intl' )
266	266	? $this->buildIntlExcerpt( $text, $limit )
267	267	: $this->buildExcerpt( $text, $limit );
		@@ -278,15 +278,15 @@ discard block
		block discarded – undo
278	278	if( str_word_count( $text, 0 ) <= $limit ) {
279	279	return $text;
280	280	}
281		- $words = array_keys( str_word_count( $text, 2 ));
282		- $excerpt = ltrim( substr( $text, 0, $words[$limit] ));
	281	+ $words = array_keys( str_word_count( $text, 2 ) );
	282	+ $excerpt = ltrim( substr( $text, 0, $words[$limit] ) );
283	283
284		- $hiddenText = substr( $text, strlen( $excerpt ));
	284	+ $hiddenText = substr( $text, strlen( $excerpt ) );
285	285	$showMore = glsr( Builder::class )->span( $hiddenText, [
286	286	'class' => 'glsr-hidden glsr-hidden-text',
287	287	'data-show-less' => __( 'Show less', 'site-reviews' ),
288	288	'data-show-more' => __( 'Show more', 'site-reviews' ),
289		- ]);
	289	+ ] );
290	290	return $excerpt.$showMore;
291	291	}
292	292
		@@ -301,7 +301,7 @@ discard block
		block discarded – undo
301	301	$words->setText( $text );
302	302	$count = 0;
303	303	$break = strlen( $text );
304		- foreach( $words as $offset ){
	304	+ foreach( $words as $offset ) {
305	305	if( \IntlBreakIterator::WORD_NONE === $words->getRuleStatus() )continue;
306	306	$count++;
307	307	if( $count == $limit ) {
		@@ -311,14 +311,14 @@ discard block
		block discarded – undo
311	311	}
312	312	$excerpt = substr( $text, 0, $break );
313	313	$hiddenText = substr( $text, $break );
314		- if( empty( $hiddenText )) {
	314	+ if( empty($hiddenText) ) {
315	315	return $excerpt;
316	316	}
317	317	$showMore = glsr( Builder::class )->span( $hiddenText, [
318	318	'class' => 'glsr-hidden glsr-hidden-text',
319	319	'data-show-less' => __( 'Show less', 'site-reviews' ),
320	320	'data-show-more' => __( 'Show more', 'site-reviews' ),
321		- ]);
	321	+ ] );
322	322	return $excerpt.$showMore;
323	323	}
324	324
		@@ -329,7 +329,7 @@ discard block
		block discarded – undo
329	329	*/
330	330	protected function getOption( $path, $fallback = '' )
331	331	{
332		- if( array_key_exists( $path, $this->options )) {
	332	+ if( array_key_exists( $path, $this->options ) ) {
333	333	return $this->options[$path];
334	334	}
335	335	return $fallback;
		@@ -342,7 +342,7 @@ discard block
		block discarded – undo
342	342	*/
343	343	protected function isHidden( $key, $path = '' )
344	344	{
345		- $isOptionEnabled = !empty( $path )
	345	+ $isOptionEnabled = !empty($path)
346	346	? $this->isOptionEnabled( $path )
347	347	: true;
348	348	return in_array( $key, $this->args['hide'] ) \|\| !$isOptionEnabled;
		@@ -355,7 +355,7 @@ discard block
		block discarded – undo
355	355	*/
356	356	protected function isHiddenOrEmpty( $key, $value )
357	357	{
358		- return $this->isHidden( $key ) \|\| empty( $value );
	358	+ return $this->isHidden( $key ) \|\| empty($value);
359	359	}
360	360
361	361	/**
		@@ -374,7 +374,7 @@ discard block
		block discarded – undo
374	374	protected function normalizeText( $text )
375	375	{
376	376	$text = wp_kses( $text, wp_kses_allowed_html() );
377		- $text = convert_smilies( wptexturize( strip_shortcodes( $text )));
	377	+ $text = convert_smilies( wptexturize( strip_shortcodes( $text ) ) );
378	378	$text = str_replace( ']]>', ']]>', $text );
379	379	$text = preg_replace( '/(\R){2,}/', '$1', $text );
380	380	return $this->isOptionEnabled( 'settings.reviews.excerpt.enabled' )
		@@ -391,6 +391,6 @@ discard block
		block discarded – undo
391	391	{
392	392	return glsr( Builder::class )->div( $value, [
393	393	'class' => 'glsr-review-'.$key,
394		- ]);
	394	+ ] );
395	395	}
396	396	}

		@@ -82,7 +82,9 @@ discard block
		block discarded – undo
82	82	$reviewValues = [];
83	83	foreach( $review as $key => $value ) {
84	84	$method = glsr( Helper::class )->buildMethodName( $key, 'buildOption' );
85		- if( !method_exists( $this, $method ))continue;
	85	+ if( !method_exists( $this, $method )) {
	86	+ continue;
	87	+ }
86	88	$reviewValues[$key] = $this->$method( $key, $value );
87	89	}
88	90	$reviewValues = apply_filters( 'site-reviews/review/build/after', $reviewValues );
		@@ -96,9 +98,13 @@ discard block
		block discarded – undo
96	98	*/
97	99	protected function buildOptionAssignedTo( $key, $value )
98	100	{
99		- if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' ))return;
	101	+ if( $this->isHiddenOrEmpty( $key, 'settings.reviews.assigned_links.enabled' )) {
	102	+ return;
	103	+ }
100	104	$post = get_post( intval( $value ));
101		- if( !( $post instanceof WP_Post ))return;
	105	+ if( !( $post instanceof WP_Post )) {
	106	+ return;
	107	+ }
102	108	$permalink = glsr( Builder::class )->a( get_the_title( $post->ID ), [
103	109	'href' => get_the_permalink( $post->ID ),
104	110	]);
		@@ -113,7 +119,9 @@ discard block
		block discarded – undo
113	119	*/
114	120	protected function buildOptionAuthor( $key, $value )
115	121	{
116		- if( $this->isHidden( $key ))return;
	122	+ if( $this->isHidden( $key )) {
	123	+ return;
	124	+ }
117	125	$prefix = !$this->isOptionEnabled( 'settings.reviews.avatars.enabled' )
118	126	? apply_filters( 'site-reviews/review/author/prefix', '—' )
119	127	: '';
		@@ -127,7 +135,9 @@ discard block
		block discarded – undo
127	135	*/
128	136	protected function buildOptionAvatar( $key, $value )
129	137	{
130		- if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' ))return;
	138	+ if( $this->isHidden( $key, 'settings.reviews.avatars.enabled' )) {
	139	+ return;
	140	+ }
131	141	$size = $this->getOption( 'settings.reviews.avatars.size', 40 );
132	142	return $this->wrap( $key, glsr( Builder::class )->img([
133	143	'src' => $this->generateAvatar( $value ),
		@@ -144,7 +154,9 @@ discard block
		block discarded – undo
144	154	protected function buildOptionContent( $key, $value )
145	155	{
146	156	$text = $this->normalizeText( $value );
147		- if( $this->isHiddenOrEmpty( $key, $text ))return;
	157	+ if( $this->isHiddenOrEmpty( $key, $text )) {
	158	+ return;
	159	+ }
148	160	return $this->wrap( $key, '<p>'.$text.'</p>' );
149	161	}
150	162
		@@ -155,7 +167,9 @@ discard block
		block discarded – undo
155	167	*/
156	168	protected function buildOptionDate( $key, $value )
157	169	{
158		- if( $this->isHidden( $key ))return;
	170	+ if( $this->isHidden( $key )) {
	171	+ return;
	172	+ }
159	173	$dateFormat = $this->getOption( 'settings.reviews.date.format', 'default' );
160	174	if( $dateFormat == 'relative' ) {
161	175	$date = glsr( Date::class )->relative( $value );
		@@ -176,7 +190,9 @@ discard block
		block discarded – undo
176	190	*/
177	191	protected function buildOptionRating( $key, $value )
178	192	{
179		- if( $this->isHiddenOrEmpty( $key, $value ))return;
	193	+ if( $this->isHiddenOrEmpty( $key, $value )) {
	194	+ return;
	195	+ }
180	196	$rating = glsr( Html::class )->buildPartial( 'star-rating', [
181	197	'rating' => $value,
182	198	]);
		@@ -190,7 +206,9 @@ discard block
		block discarded – undo
190	206	*/
191	207	protected function buildOptionResponse( $key, $value )
192	208	{
193		- if( $this->isHiddenOrEmpty( $key, $value ))return;
	209	+ if( $this->isHiddenOrEmpty( $key, $value )) {
	210	+ return;
	211	+ }
194	212	$title = sprintf( __( 'Response from %s', 'site-reviews' ), get_bloginfo( 'name' ));
195	213	$text = $this->normalizeText( $value );
196	214	$text = '<p><strong>'.$title.'</strong></p><p>'.$text.'</p>';
		@@ -207,7 +225,9 @@ discard block
		block discarded – undo
207	225	*/
208	226	protected function buildOptionTitle( $key, $value )
209	227	{
210		- if( $this->isHidden( $key ))return;
	228	+ if( $this->isHidden( $key )) {
	229	+ return;
	230	+ }
211	231	if( empty( $value )) {
212	232	$value = __( 'No Title', 'site-reviews' );
213	233	}
		@@ -237,7 +257,9 @@ discard block
		block discarded – undo
237	257	*/
238	258	protected function generateSchema()
239	259	{
240		- if( !wp_validate_boolean( $this->args['schema'] ))return;
	260	+ if( !wp_validate_boolean( $this->args['schema'] )) {
	261	+ return;
	262	+ }
241	263	glsr( Schema::class )->store(
242	264	glsr( Schema::class )->build( $this->args )
243	265	);
		@@ -302,7 +324,9 @@ discard block
		block discarded – undo
302	324	$count = 0;
303	325	$break = strlen( $text );
304	326	foreach( $words as $offset ){
305		- if( \IntlBreakIterator::WORD_NONE === $words->getRuleStatus() )continue;
	327	+ if( \IntlBreakIterator::WORD_NONE === $words->getRuleStatus() ) {
	328	+ continue;
	329	+ }
306	330	$count++;
307	331	if( $count == $limit ) {
308	332	$break = $offset;

pryley / site-reviews

Push — master ( 75fa9a...bcead5 )

Status

Category

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

Braces +36 added lines, -12 removed lines patch added patch discarded remove patch