Test Failed
Push — master ( 7ab2d6...9e5b16 )
by Paul
04:34
created
plugin/Router.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 	public function routeAdminPostRequest()
17 17
 	{
18 18
 		$request = $this->getRequest();
19
-		if( !$this->isValidPostRequest( $request ))return;
19
+		if( !$this->isValidPostRequest( $request ) )return;
20 20
 		check_admin_referer( $request['action'] );
21 21
 		$this->routeRequest( 'admin', $request['action'], $request );
22 22
 	}
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
40 40
 	{
41 41
 		if( is_admin() )return;
42 42
 		$request = $this->getRequest();
43
-		if( !$this->isValidPostRequest( $request ))return;
44
-		if( !$this->isValidPublicNonce( $request ))return;
43
+		if( !$this->isValidPostRequest( $request ) )return;
44
+		if( !$this->isValidPublicNonce( $request ) )return;
45 45
 		$this->routeRequest( 'public', $request['action'], $request );
46 46
 	}
47 47
 
@@ -51,10 +51,10 @@  discard block
 block discarded – undo
51 51
 	protected function checkAjaxNonce( array $request )
52 52
 	{
53 53
 		if( !is_user_logged_in() )return;
54
-		if( !isset( $request['nonce'] )) {
54
+		if( !isset($request['nonce']) ) {
55 55
 			$this->sendAjaxError( 'The request is missing a nonce', $request );
56 56
 		}
57
-		if( !wp_verify_nonce( $request['nonce'], $request['action'] )) {
57
+		if( !wp_verify_nonce( $request['nonce'], $request['action'] ) ) {
58 58
 			$this->sendAjaxError( 'The request failed the nonce check', $request, 403 );
59 59
 		}
60 60
 	}
@@ -64,10 +64,10 @@  discard block
 block discarded – undo
64 64
 	 */
65 65
 	protected function checkAjaxRequest( array $request )
66 66
 	{
67
-		if( !isset( $request['action'] )) {
67
+		if( !isset($request['action']) ) {
68 68
 			$this->sendAjaxError( 'The request must include an action', $request );
69 69
 		}
70
-		if( empty( $request['ajax_request'] )) {
70
+		if( empty($request['ajax_request']) ) {
71 71
 			$this->sendAjaxError( 'The request is invalid', $request );
72 72
 		}
73 73
 	}
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 			return [];
84 84
 		}
85 85
 		$request = glsr( Helper::class )->filterInputArray( 'request' );
86
-		if( empty( $request )) {
86
+		if( empty($request) ) {
87 87
 			$request = glsr( Helper::class )->filterInputArray( Application::ID );
88 88
 		}
89 89
 		return $this->normalizeRequest( $request );
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	 */
95 95
 	protected function isValidPostRequest( array $request = [] )
96 96
 	{
97
-		return !empty( $request['action'] ) && empty( $request['ajax_request'] );
97
+		return !empty($request['action']) && empty($request['ajax_request']);
98 98
 	}
99 99
 
100 100
 	/**
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	 */
103 103
 	protected function isValidPublicNonce( array $request )
104 104
 	{
105
-		if( is_user_logged_in() && !wp_verify_nonce( $request['nonce'], $request['action'] )) {
105
+		if( is_user_logged_in() && !wp_verify_nonce( $request['nonce'], $request['action'] ) ) {
106 106
 			glsr_log()->error( 'Nonce check failed for public request' )->info( $request );
107 107
 			return false;
108 108
 		}
@@ -131,11 +131,11 @@  discard block
 block discarded – undo
131 131
 	protected function routeRequest( $type, $action, array $request = [] )
132 132
 	{
133 133
 		$actionHook = 'site-reviews/route/'.$type.'/request';
134
-		$controller = glsr( glsr( Helper::class )->buildClassName( $type.'-controller', 'Controllers' ));
134
+		$controller = glsr( glsr( Helper::class )->buildClassName( $type.'-controller', 'Controllers' ) );
135 135
 		$method = glsr( Helper::class )->buildMethodName( $action, 'router' );
136 136
 		$request = apply_filters( 'site-reviews/route/request', $request, $action, $type );
137 137
 		do_action( $actionHook, $action, $request );
138
-		if( is_callable( [$controller, $method] )) {
138
+		if( is_callable( [$controller, $method] ) ) {
139 139
 			call_user_func( [$controller, $method], $request );
140 140
 			return;
141 141
 		}
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	protected function sendAjaxError( $error, array $request, $statusCode = 400 )
153 153
 	{
154 154
 		glsr_log()->error( $error )->info( $request );
155
-		wp_send_json_error([
155
+		wp_send_json_error( [
156 156
 			'message' => __( 'The form could not be submitted. Please notify the site administrator.', 'site-reviews' ),
157 157
 			'error' => $error,
158 158
 		], $statusCode );
Please login to merge, or discard this patch.
plugin/Controllers/AjaxController.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	 */
23 23
 	public function routerChangeReviewStatus( array $request )
24 24
 	{
25
-		wp_send_json_success( $this->execute( new ChangeStatus( $request )));
25
+		wp_send_json_success( $this->execute( new ChangeStatus( $request ) ) );
26 26
 	}
27 27
 
28 28
 	/**
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
 	public function routerClearConsole()
32 32
 	{
33 33
 		glsr( AdminController::class )->routerClearConsole();
34
-		wp_send_json_success([
34
+		wp_send_json_success( [
35 35
 			'console' => glsr( Console::class )->get(),
36 36
 			'notices' => glsr( Notice::class )->get(),
37
-		]);
37
+		] );
38 38
 	}
39 39
 
40 40
 	/**
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
44 44
 	{
45 45
 		$shortcode = $request['shortcode'];
46 46
 		$response = false;
47
-		if( array_key_exists( $shortcode, glsr()->mceShortcodes )) {
47
+		if( array_key_exists( $shortcode, glsr()->mceShortcodes ) ) {
48 48
 			$data = glsr()->mceShortcodes[$shortcode];
49
-			if( !empty( $data['errors'] )) {
49
+			if( !empty($data['errors']) ) {
50 50
 				$data['btn_okay'] = [esc_html__( 'Okay', 'site-reviews' )];
51 51
 			}
52 52
 			$response = [
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
66 66
 	public function routerSearchPosts( array $request )
67 67
 	{
68 68
 		$results = glsr( Database::class )->searchPosts( $request['search'] );
69
-		wp_send_json_success([
69
+		wp_send_json_success( [
70 70
 			'empty' => '<div>'.__( 'Nothing found.', 'site-reviews' ).'</div>',
71 71
 			'items' => $results,
72
-		]);
72
+		] );
73 73
 	}
74 74
 
75 75
 	/**
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	 */
78 78
 	public function routerSearchTranslations( array $request )
79 79
 	{
80
-		if( empty( $request['exclude'] )) {
80
+		if( empty($request['exclude']) ) {
81 81
 			$request['exclude'] = [];
82 82
 		}
83 83
 		$results = glsr( Translator::class )
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
85 85
 			->exclude()
86 86
 			->exclude( $request['exclude'] )
87 87
 			->renderResults();
88
-		wp_send_json_success([
88
+		wp_send_json_success( [
89 89
 			'empty' => '<div>'.__( 'Nothing found.', 'site-reviews' ).'</div>',
90 90
 			'items' => $results,
91
-		]);
91
+		] );
92 92
 	}
93 93
 
94 94
 	/**
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 			'message' => glsr( Session::class )->get( $request['form_id'].'message', '', true ),
103 103
 			'recaptcha' => glsr( Session::class )->get( $request['form_id'].'recaptcha', false, true ),
104 104
 		];
105
-		if( !wp_validate_boolean( $data['errors'] )) {
105
+		if( !wp_validate_boolean( $data['errors'] ) ) {
106 106
 			wp_send_json_success( $data );
107 107
 		}
108 108
 		wp_send_json_error( $data );
@@ -113,10 +113,10 @@  discard block
 block discarded – undo
113 113
 	 */
114 114
 	public function routerTogglePinned( array $request )
115 115
 	{
116
-		$isPinned = $this->execute( new TogglePinned( $request ));
117
-		wp_send_json_success([
116
+		$isPinned = $this->execute( new TogglePinned( $request ) );
117
+		wp_send_json_success( [
118 118
 			'notices' => glsr( Notice::class )->get(),
119 119
 			'pinned' => $isPinned,
120
-		]);
120
+		] );
121 121
 	}
122 122
 }
Please login to merge, or discard this patch.