Passed
Push — master ( 59c1b9...1f2705 )
by Paul
04:56
created
plugin/Widgets/Widget.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@  discard block
 block discarded – undo
15 15
 	public function __construct( $idBase, $name, $values )
16 16
 	{
17 17
 		$controlOptions = $widgetOptions = [];
18
-		if( isset( $values['class'] )) {
18
+		if( isset($values['class']) ) {
19 19
 			$widgetOptions['classname'] = $values['class'];
20 20
 		}
21
-		if( isset( $values['description'] )) {
21
+		if( isset($values['description']) ) {
22 22
 			$widgetOptions['description'] = $values['description'];
23 23
 		}
24
-		if( isset( $values['width'] )) {
24
+		if( isset($values['width']) ) {
25 25
 			$controlOptions['width'] = $values['width'];
26 26
 		}
27 27
 		parent::__construct( $idBase, $name, $widgetOptions, $controlOptions );
@@ -34,10 +34,10 @@  discard block
 block discarded – undo
34 34
 	protected function renderField( $tag, array $args = [] )
35 35
 	{
36 36
 		$args = $this->normalizeFieldAttributes( $tag, $args );
37
-		$field = glsr( Builder::class )->{$tag}( $args['name'], $args );
37
+		$field = glsr( Builder::class )->{$tag}($args['name'], $args);
38 38
 		echo glsr( Builder::class )->div( $field, [
39 39
 			'class' => 'glsr-field',
40
-		]);
40
+		] );
41 41
 	}
42 42
 
43 43
 	/**
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
 	 */
47 47
 	protected function normalizeFieldAttributes( $tag, array $args )
48 48
 	{
49
-		if( empty( $args['value'] )) {
49
+		if( empty($args['value']) ) {
50 50
 			$args['value'] = $this->widgetArgs[$args['name']];
51 51
 		}
52
-		if( empty( $this->widgetArgs['options'] ) && in_array( $tag, ['checkbox', 'radio'] )) {
52
+		if( empty($this->widgetArgs['options']) && in_array( $tag, ['checkbox', 'radio'] ) ) {
53 53
 			$args['checked'] = in_array( $args['value'], (array)$this->widgetArgs[$args['name']] );
54 54
 		}
55 55
 		$args['id'] = $this->get_field_id( $args['name'] );
Please login to merge, or discard this patch.
plugin/Modules/Html/Field.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 			'is_valid' => true,
26 26
 			'is_widget' => false,
27 27
 			'path' => '',
28
-		]);
28
+		] );
29 29
 		$this->normalize();
30 30
 	}
31 31
 
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
 		return glsr( Template::class )->build( 'partials/form/field', [
72 72
 			'context' => [
73 73
 				'class' => $this->getFieldClass(),
74
-				'field' => glsr( Builder::class )->{$this->field['type']}( $this->field ),
74
+				'field' => glsr( Builder::class )->{$this->field['type']}($this->field),
75 75
 			],
76
-		]);
76
+		] );
77 77
 	}
78 78
 
79 79
 	/**
@@ -84,10 +84,10 @@  discard block
 block discarded – undo
84 84
 		return glsr( Template::class )->build( 'partials/form/table-row', [
85 85
 			'context' => [
86 86
 				'class' => $this->getFieldClass(),
87
-				'field' => glsr( Builder::class )->{$this->field['type']}( $this->field ),
87
+				'field' => glsr( Builder::class )->{$this->field['type']}($this->field),
88 88
 				'label' => glsr( Builder::class )->label( $this->field['legend'], ['for' => $this->field['id']] ),
89 89
 			],
90
-		]);
90
+		] );
91 91
 	}
92 92
 
93 93
 	/**
@@ -96,16 +96,16 @@  discard block
 block discarded – undo
96 96
 	protected function buildSettingMultiField()
97 97
 	{
98 98
 		$dependsOn = $this->getFieldDependsOn();
99
-		unset( $this->field['data-depends'] );
99
+		unset($this->field['data-depends']);
100 100
 		return glsr( Template::class )->build( 'partials/form/table-row-multiple', [
101 101
 			'context' => [
102 102
 				'class' => $this->getFieldClass(),
103 103
 				'depends_on' => $dependsOn,
104
-				'field' => glsr( Builder::class )->{$this->field['type']}( $this->field ),
104
+				'field' => glsr( Builder::class )->{$this->field['type']}($this->field),
105 105
 				'label' => glsr( Builder::class )->label( $this->field['legend'], ['for' => $this->field['id']] ),
106 106
 				'legend' => $this->field['legend'],
107 107
 			],
108
-		]);
108
+		] );
109 109
 	}
110 110
 
111 111
 	/**
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 		if( $this->field['is_hidden'] ) {
118 118
 			$classes[] = 'hidden';
119 119
 		}
120
-		if( !empty( $this->field['required'] )) {
120
+		if( !empty($this->field['required']) ) {
121 121
 			$classes[] = 'glsr-required';
122 122
 		}
123 123
 		return implode( ' ', $classes );
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	 */
129 129
 	protected function getFieldDependsOn()
130 130
 	{
131
-		return !empty( $this->field['data-depends'] )
131
+		return !empty($this->field['data-depends'])
132 132
 			? $this->field['data-depends']
133 133
 			: '';
134 134
 	}
@@ -153,13 +153,13 @@  discard block
 block discarded – undo
153 153
 			'name', 'type',
154 154
 		];
155 155
 		foreach( $requiredValues as $value ) {
156
-			if( isset( $this->field[$value] ))continue;
156
+			if( isset($this->field[$value]) )continue;
157 157
 			$missingValues[] = $value;
158 158
 			$this->field['is_valid'] = false;
159 159
 		}
160
-		if( !empty( $missingValues )) {
160
+		if( !empty($missingValues) ) {
161 161
 			glsr_log()
162
-				->warning( 'Field is missing: '.implode( ', ', $missingValues ))
162
+				->warning( 'Field is missing: '.implode( ', ', $missingValues ) )
163 163
 				->info( $this->field );
164 164
 		}
165 165
 		return $this->field['is_valid'];
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 		if( !$this->isFieldValid() )return;
174 174
 		$this->field['path'] = $this->field['name'];
175 175
 		$className = glsr( Helper::class )->buildClassName( $this->field['type'], __NAMESPACE__.'\Fields' );
176
-		if( class_exists( $className )) {
176
+		if( class_exists( $className ) ) {
177 177
 			$this->field = array_merge(
178 178
 				wp_parse_args( $this->field, $className::defaults() ),
179 179
 				$className::required()
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 	 */
189 189
 	protected function normalizeId()
190 190
 	{
191
-		if( isset( $this->field['id'] ) || $this->field['is_raw'] )return;
191
+		if( isset($this->field['id']) || $this->field['is_raw'] )return;
192 192
 		$this->field['id'] = glsr( Helper::class )->convertPathToId(
193 193
 			$this->field['path'],
194 194
 			$this->getFieldPrefix()
Please login to merge, or discard this patch.
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -42,7 +42,9 @@  discard block
 block discarded – undo
42 42
 	 */
43 43
 	public function build()
44 44
 	{
45
-		if( !$this->field['is_valid'] )return;
45
+		if( !$this->field['is_valid'] ) {
46
+			return;
47
+		}
46 48
 		if( $this->field['is_raw'] ) {
47 49
 			return glsr( Builder::class )->hidden( $this->field );
48 50
 		}
@@ -153,7 +155,9 @@  discard block
 block discarded – undo
153 155
 			'name', 'type',
154 156
 		];
155 157
 		foreach( $requiredValues as $value ) {
156
-			if( isset( $this->field[$value] ))continue;
158
+			if( isset( $this->field[$value] )) {
159
+				continue;
160
+			}
157 161
 			$missingValues[] = $value;
158 162
 			$this->field['is_valid'] = false;
159 163
 		}
@@ -170,7 +174,9 @@  discard block
 block discarded – undo
170 174
 	 */
171 175
 	protected function normalize()
172 176
 	{
173
-		if( !$this->isFieldValid() )return;
177
+		if( !$this->isFieldValid() ) {
178
+			return;
179
+		}
174 180
 		$this->field['path'] = $this->field['name'];
175 181
 		$className = glsr( Helper::class )->buildClassName( $this->field['type'], __NAMESPACE__.'\Fields' );
176 182
 		if( class_exists( $className )) {
@@ -188,7 +194,9 @@  discard block
 block discarded – undo
188 194
 	 */
189 195
 	protected function normalizeId()
190 196
 	{
191
-		if( isset( $this->field['id'] ) || $this->field['is_raw'] )return;
197
+		if( isset( $this->field['id'] ) || $this->field['is_raw'] ) {
198
+			return;
199
+		}
192 200
 		$this->field['id'] = glsr( Helper::class )->convertPathToId(
193 201
 			$this->field['path'],
194 202
 			$this->getFieldPrefix()
Please login to merge, or discard this patch.
plugin/Modules/Html/Fields/Honeypot.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 	{
14 14
 		$this->builder->args = wp_parse_args( $this->builder->args, [
15 15
 			'name' => $this->builder->args['text'],
16
-		]);
16
+		] );
17 17
 		$this->builder->tag = 'input';
18 18
 		$this->mergeFieldArgs();
19 19
 		return $this->builder->getOpeningTag();
Please login to merge, or discard this patch.
plugin/Modules/Html/Builder.php 2 patches
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	{
56 56
 		$instance = new static;
57 57
 		$instance->setTagFromMethod( $method );
58
-		call_user_func_array( [$instance, 'normalize'], $args += ['',''] );
58
+		call_user_func_array( [$instance, 'normalize'], $args += ['', ''] );
59 59
 		$tags = array_merge( static::TAGS_FORM, static::TAGS_SINGLE, static::TAGS_STRUCTURE, static::TAGS_TEXT );
60 60
 		$generatedTag = in_array( $instance->tag, $tags )
61 61
 			? $instance->buildTag()
@@ -78,8 +78,8 @@  discard block
 block discarded – undo
78 78
 			'render' => 'is_bool',
79 79
 			'tag' => 'is_string',
80 80
 		];
81
-		if( !isset( $properties[$property] )
82
-			|| empty( array_filter( [$value], $properties[$property] ))
81
+		if( !isset($properties[$property])
82
+			|| empty(array_filter( [$value], $properties[$property] ))
83 83
 		)return;
84 84
 		$this->$property = $value;
85 85
 	}
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 	 */
98 98
 	public function getOpeningTag()
99 99
 	{
100
-		$attributes = glsr( Attributes::class )->{$this->tag}( $this->args )->toString();
100
+		$attributes = glsr( Attributes::class )->{$this->tag}($this->args)->toString();
101 101
 		return '<'.trim( $this->tag.' '.$attributes ).'>';
102 102
 	}
103 103
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	protected function buildCustomField()
108 108
 	{
109 109
 		$className = $this->getCustomFieldClassName();
110
-		if( class_exists( $className )) {
110
+		if( class_exists( $className ) ) {
111 111
 			return (new $className( $this ))->build();
112 112
 		}
113 113
 		glsr_log()->error( 'Field missing: '.$className );
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 	 */
119 119
 	protected function buildDefaultTag( $text = '' )
120 120
 	{
121
-		if( empty( $text )) {
121
+		if( empty($text) ) {
122 122
 			$text = $this->args['text'];
123 123
 		}
124 124
 		return $this->getOpeningTag().$text.$this->getClosingTag();
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	 */
130 130
 	protected function buildFieldDescription()
131 131
 	{
132
-		if( empty( $this->args['description'] ))return;
132
+		if( empty($this->args['description']) )return;
133 133
 		if( $this->args['is_widget'] ) {
134 134
 			return $this->small( $this->args['description'] );
135 135
 		}
@@ -141,10 +141,10 @@  discard block
 block discarded – undo
141 141
 	 */
142 142
 	protected function buildFormInput()
143 143
 	{
144
-		if( !in_array( $this->args['type'], ['checkbox', 'radio'] )) {
144
+		if( !in_array( $this->args['type'], ['checkbox', 'radio'] ) ) {
145 145
 			return $this->buildFormLabel().$this->getOpeningTag();
146 146
 		}
147
-		return empty( $this->args['options'] )
147
+		return empty($this->args['options'])
148 148
 			? $this->buildFormInputChoice()
149 149
 			: $this->buildFormInputMultiChoice();
150 150
 	}
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	protected function buildFormInputMultiChoice()
164 164
 	{
165 165
 		if( $this->args['type'] == 'checkbox' ) {
166
-			$this->args['name'].= '[]';
166
+			$this->args['name'] .= '[]';
167 167
 		}
168 168
 		$options = array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) {
169 169
 			return $carry.$this->li( $this->{$this->args['type']}([
@@ -171,12 +171,12 @@  discard block
 block discarded – undo
171 171
 				'name' => $this->args['name'],
172 172
 				'text' => $this->args['options'][$key],
173 173
 				'value' => $key,
174
-			]));
174
+			]) );
175 175
 		});
176 176
 		return $this->ul( $options, [
177 177
 			'class' => $this->args['class'],
178 178
 			'id' => $this->args['id'],
179
-		]);
179
+		] );
180 180
 	}
181 181
 
182 182
 	/**
@@ -184,11 +184,11 @@  discard block
 block discarded – undo
184 184
 	 */
185 185
 	protected function buildFormLabel()
186 186
 	{
187
-		if( empty( $this->args['label'] ) || $this->args['type'] == 'hidden' )return;
188
-		return $this->label([
187
+		if( empty($this->args['label']) || $this->args['type'] == 'hidden' )return;
188
+		return $this->label( [
189 189
 			'for' => $this->args['id'],
190 190
 			'text' => $this->args['label'],
191
-		]);
191
+		] );
192 192
 	}
193 193
 
194 194
 	/**
@@ -205,11 +205,11 @@  discard block
 block discarded – undo
205 205
 	protected function buildFormSelectOptions()
206 206
 	{
207 207
 		return array_reduce( array_keys( $this->args['options'] ), function( $carry, $key ) {
208
-			return $carry.$this->option([
208
+			return $carry.$this->option( [
209 209
 				'selected' => $this->args['value'] == $key,
210 210
 				'text' => $this->args['options'][$key],
211 211
 				'value' => $key,
212
-			]);
212
+			] );
213 213
 		});
214 214
 	}
215 215
 
@@ -227,10 +227,10 @@  discard block
 block discarded – undo
227 227
 	protected function buildTag()
228 228
 	{
229 229
 		$this->mergeArgsWithRequiredDefaults();
230
-		if( in_array( $this->tag, static::TAGS_SINGLE )) {
230
+		if( in_array( $this->tag, static::TAGS_SINGLE ) ) {
231 231
 			return $this->getOpeningTag();
232 232
 		}
233
-		if( !in_array( $this->tag, static::TAGS_FORM )) {
233
+		if( !in_array( $this->tag, static::TAGS_FORM ) ) {
234 234
 			return $this->buildDefaultTag();
235 235
 		}
236 236
 		return call_user_func( [$this, 'buildForm'.ucfirst( $this->tag )] ).$this->buildFieldDescription();
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 	{
252 252
 		$args = glsr( BuilderDefaults::class )->merge( $this->args );
253 253
 		$className = $this->getCustomFieldClassName();
254
-		if( class_exists( $className )) {
254
+		if( class_exists( $className ) ) {
255 255
 			$args = array_merge(
256 256
 				wp_parse_args( $args, $className::defaults() ),
257 257
 				$className::required()
@@ -266,13 +266,13 @@  discard block
 block discarded – undo
266 266
 	 */
267 267
 	protected function normalize( ...$params )
268 268
 	{
269
-		if( is_string( $params[0] ) || is_numeric( $params[0] )) {
269
+		if( is_string( $params[0] ) || is_numeric( $params[0] ) ) {
270 270
 			$this->setNameOrTextAttributeForTag( $params[0] );
271 271
 		}
272
-		if( is_array( $params[0] )) {
272
+		if( is_array( $params[0] ) ) {
273 273
 			$this->args += $params[0];
274 274
 		}
275
-		else if( is_array( $params[1] )) {
275
+		else if( is_array( $params[1] ) ) {
276 276
 			$this->args += $params[1];
277 277
 		}
278 278
 	}
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
 	protected function setTagFromMethod( $method )
297 297
 	{
298 298
 		$this->tag = strtolower( $method );
299
-		if( in_array( $this->tag, static::INPUT_TYPES )) {
299
+		if( in_array( $this->tag, static::INPUT_TYPES ) ) {
300 300
 			$this->args['type'] = $this->tag;
301 301
 			$this->tag = 'input';
302 302
 		}
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -80,7 +80,9 @@  discard block
 block discarded – undo
80 80
 		];
81 81
 		if( !isset( $properties[$property] )
82 82
 			|| empty( array_filter( [$value], $properties[$property] ))
83
-		)return;
83
+		) {
84
+			return;
85
+		}
84 86
 		$this->$property = $value;
85 87
 	}
86 88
 
@@ -129,7 +131,9 @@  discard block
 block discarded – undo
129 131
 	 */
130 132
 	protected function buildFieldDescription()
131 133
 	{
132
-		if( empty( $this->args['description'] ))return;
134
+		if( empty( $this->args['description'] )) {
135
+			return;
136
+		}
133 137
 		if( $this->args['is_widget'] ) {
134 138
 			return $this->small( $this->args['description'] );
135 139
 		}
@@ -184,7 +188,9 @@  discard block
 block discarded – undo
184 188
 	 */
185 189
 	protected function buildFormLabel()
186 190
 	{
187
-		if( empty( $this->args['label'] ) || $this->args['type'] == 'hidden' )return;
191
+		if( empty( $this->args['label'] ) || $this->args['type'] == 'hidden' ) {
192
+			return;
193
+		}
188 194
 		return $this->label([
189 195
 			'for' => $this->args['id'],
190 196
 			'text' => $this->args['label'],
Please login to merge, or discard this patch.