Passed
Push — master ( 65c96d...e99773 )
by Paul
08:33 queued 04:19
created
plugin/Review.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
 	 */
47 47
 	public function __get( $key )
48 48
 	{
49
-		if( property_exists( $this, $key )) {
49
+		if( property_exists( $this, $key ) ) {
50 50
 			return $this->$key;
51 51
 		}
52
-		if( is_array( $this->custom ) && array_key_exists( $key, $this->custom )) {
52
+		if( is_array( $this->custom ) && array_key_exists( $key, $this->custom ) ) {
53 53
 			return $this->custom[$key];
54 54
 		}
55 55
 		return '';
@@ -77,13 +77,13 @@  discard block
 block discarded – undo
77 77
 			'review_type' => 'local',
78 78
 		];
79 79
 		$meta = array_filter(
80
-			array_map( 'array_shift', (array)get_post_meta( $post->ID )),
80
+			array_map( 'array_shift', (array)get_post_meta( $post->ID ) ),
81 81
 			'strlen'
82 82
 		);
83
-		$properties = glsr( CreateReviewDefaults::class )->restrict( array_merge( $defaults, $meta ));
83
+		$properties = glsr( CreateReviewDefaults::class )->restrict( array_merge( $defaults, $meta ) );
84 84
 		$this->modified = $this->isModified( $properties );
85 85
 		array_walk( $properties, function( $value, $key ) {
86
-			if( !property_exists( $this, $key ) || isset( $this->$key ))return;
86
+			if( !property_exists( $this, $key ) || isset($this->$key) )return;
87 87
 			$this->$key = maybe_unserialize( $value );
88 88
 		});
89 89
 	}
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	protected function setTermIds( WP_Post $post )
95 95
 	{
96 96
 		$this->term_ids = [];
97
-		if( !is_array( $terms = get_the_terms( $post, Application::TAXONOMY )))return;
97
+		if( !is_array( $terms = get_the_terms( $post, Application::TAXONOMY ) ) )return;
98 98
 		foreach( $terms as $term ) {
99 99
 			$this->term_ids[] = $term->term_id;
100 100
 		}
Please login to merge, or discard this patch.
plugin/Database/CountsManager.php 1 patch
Spacing   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 			$this->getCounts(),
67 67
 			$review->review_type,
68 68
 			$review->rating
69
-		));
69
+		) );
70 70
 	}
71 71
 
72 72
 	/**
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	 */
75 75
 	public function decreasePostCounts( Review $review )
76 76
 	{
77
-		if( empty( $counts = $this->getPostCounts( $review->assigned_to )))return;
77
+		if( empty($counts = $this->getPostCounts( $review->assigned_to )) )return;
78 78
 		$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
79 79
 		$this->setPostCounts( $review->assigned_to, $counts );
80 80
 	}
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	public function decreaseTermCounts( Review $review )
86 86
 	{
87 87
 		foreach( $review->term_ids as $termId ) {
88
-			if( empty( $counts = $this->getTermCounts( $termId )))continue;
88
+			if( empty($counts = $this->getTermCounts( $termId )) )continue;
89 89
 			$counts = $this->decreaseRating( $counts, $review->review_type, $review->rating );
90 90
 			$this->setTermCounts( $termId, $counts );
91 91
 		}
@@ -97,17 +97,17 @@  discard block
 block discarded – undo
97 97
 	public function flatten( array $reviewCounts, array $args = [] )
98 98
 	{
99 99
 		$counts = [];
100
-		array_walk_recursive( $reviewCounts, function( $num, $index ) use( &$counts ) {
101
-			$counts[$index] = isset( $counts[$index] )
100
+		array_walk_recursive( $reviewCounts, function( $num, $index ) use(&$counts) {
101
+			$counts[$index] = isset($counts[$index])
102 102
 				? $num + $counts[$index]
103 103
 				: $num;
104 104
 		});
105 105
 		$args = wp_parse_args( $args, [
106 106
 			'max' => Rating::MAX_RATING,
107 107
 			'min' => Rating::MIN_RATING,
108
-		]);
108
+		] );
109 109
 		foreach( $counts as $index => &$num ) {
110
-			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ))continue;
110
+			if( $index >= intval( $args['min'] ) && $index <= intval( $args['max'] ) )continue;
111 111
 			$num = 0;
112 112
 		}
113 113
 		return $counts;
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 			'post_ids' => [],
123 123
 			'term_ids' => [],
124 124
 			'type' => 'local',
125
-		]);
125
+		] );
126 126
 		$counts = [];
127 127
 		foreach( glsr( Polylang::class )->getPostIds( $args['post_ids'] ) as $postId ) {
128 128
 			$counts[] = $this->getPostCounts( $postId );
@@ -130,12 +130,12 @@  discard block
 block discarded – undo
130 130
 		foreach( $args['term_ids'] as $termId ) {
131 131
 			$counts[] = $this->getTermCounts( $termId );
132 132
 		}
133
-		if( empty( $counts )) {
133
+		if( empty($counts) ) {
134 134
 			$counts[] = $this->getCounts();
135 135
 		}
136 136
 		return in_array( $args['type'], ['', 'all'] )
137 137
 			? $this->normalize( [$this->flatten( $counts )] )
138
-			: $this->normalize( array_column( $counts, $args['type'] ));
138
+			: $this->normalize( array_column( $counts, $args['type'] ) );
139 139
 	}
140 140
 
141 141
 	/**
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	public function getCounts()
145 145
 	{
146 146
 		$counts = glsr( OptionManager::class )->get( 'counts', [] );
147
-		if( !is_array( $counts )) {
147
+		if( !is_array( $counts ) ) {
148 148
 			glsr_log()->error( 'CountsManager: counts is not an array' )->debug( $counts );
149 149
 			return [];
150 150
 		}
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 	 */
158 158
 	public function getPostCounts( $postId )
159 159
 	{
160
-		return array_filter( (array)get_post_meta( $postId, static::META_COUNT, true ));
160
+		return array_filter( (array)get_post_meta( $postId, static::META_COUNT, true ) );
161 161
 	}
162 162
 
163 163
 	/**
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 	 */
167 167
 	public function getTermCounts( $termId )
168 168
 	{
169
-		return array_filter( (array)get_term_meta( $termId, static::META_COUNT, true ));
169
+		return array_filter( (array)get_term_meta( $termId, static::META_COUNT, true ) );
170 170
 	}
171 171
 
172 172
 	/**
@@ -184,14 +184,14 @@  discard block
 block discarded – undo
184 184
 	 */
185 185
 	public function increaseCounts( Review $review )
186 186
 	{
187
-		if( empty( $counts = $this->getCounts() )) {
187
+		if( empty($counts = $this->getCounts()) ) {
188 188
 			$counts = $this->buildCounts();
189 189
 		}
190 190
 		$this->setCounts( $this->increaseRating(
191 191
 			$counts,
192 192
 			$review->review_type,
193 193
 			$review->rating
194
-		));
194
+		) );
195 195
 	}
196 196
 
197 197
 	/**
@@ -199,9 +199,9 @@  discard block
 block discarded – undo
199 199
 	 */
200 200
 	public function increasePostCounts( Review $review )
201 201
 	{
202
-		if( !( get_post( $review->assigned_to ) instanceof WP_Post ))return;
202
+		if( !(get_post( $review->assigned_to ) instanceof WP_Post) )return;
203 203
 		$counts = $this->getPostCounts( $review->assigned_to );
204
-		$counts = empty( $counts )
204
+		$counts = empty($counts)
205 205
 			? $this->buildPostCounts( $review->assigned_to )
206 206
 			: $this->increaseRating( $counts, $review->review_type, $review->rating );
207 207
 		$this->setPostCounts( $review->assigned_to, $counts );
@@ -212,10 +212,10 @@  discard block
 block discarded – undo
212 212
 	 */
213 213
 	public function increaseTermCounts( Review $review )
214 214
 	{
215
-		$termIds = glsr( ReviewManager::class )->normalizeTerms( implode( ',', $review->term_ids ));
215
+		$termIds = glsr( ReviewManager::class )->normalizeTerms( implode( ',', $review->term_ids ) );
216 216
 		foreach( $termIds as $termId ) {
217 217
 			$counts = $this->getTermCounts( $termId );
218
-			$counts = empty( $counts )
218
+			$counts = empty($counts)
219 219
 				? $this->buildTermCounts( $termId )
220 220
 				: $this->increaseRating( $counts, $review->review_type, $review->rating );
221 221
 			$this->setTermCounts( $termId, $counts );
@@ -238,8 +238,8 @@  discard block
 block discarded – undo
238 238
 	{
239 239
 		$ratingCounts = $this->flatten( $reviewCounts );
240 240
 		update_post_meta( $postId, static::META_COUNT, $reviewCounts );
241
-		update_post_meta( $postId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
242
-		update_post_meta( $postId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ));
241
+		update_post_meta( $postId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ) );
242
+		update_post_meta( $postId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ) );
243 243
 	}
244 244
 
245 245
 	/**
@@ -248,11 +248,11 @@  discard block
 block discarded – undo
248 248
 	 */
249 249
 	public function setTermCounts( $termId, array $reviewCounts )
250 250
 	{
251
-		if( !term_exists( $termId ))return;
251
+		if( !term_exists( $termId ) )return;
252 252
 		$ratingCounts = $this->flatten( $reviewCounts );
253 253
 		update_term_meta( $termId, static::META_COUNT, $reviewCounts );
254
-		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ));
255
-		update_term_meta( $termId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ));
254
+		update_term_meta( $termId, static::META_AVERAGE, glsr( Rating::class )->getAverage( $ratingCounts ) );
255
+		update_term_meta( $termId, static::META_RANKING, glsr( Rating::class )->getRanking( $ratingCounts ) );
256 256
 	}
257 257
 
258 258
 	/**
@@ -263,14 +263,14 @@  discard block
 block discarded – undo
263 263
 	{
264 264
 		$counts = [];
265 265
 		$lastPostId = 0;
266
-		while( $reviews = $this->queryReviews( $args, $lastPostId, $limit )) {
267
-			$types = array_keys( array_flip( array_column( $reviews, 'type' )));
266
+		while( $reviews = $this->queryReviews( $args, $lastPostId, $limit ) ) {
267
+			$types = array_keys( array_flip( array_column( $reviews, 'type' ) ) );
268 268
 			foreach( $types as $type ) {
269
-				if( isset( $counts[$type] ))continue;
269
+				if( isset($counts[$type]) )continue;
270 270
 				$counts[$type] = array_fill_keys( range( 0, Rating::MAX_RATING ), 0 );
271 271
 			}
272 272
 			foreach( $reviews as $review ) {
273
-				$type = empty( $review->type ) || !is_string( $review->type )
273
+				$type = empty($review->type) || !is_string( $review->type )
274 274
 					? 'local'
275 275
 					: $review->type;
276 276
 				$counts[$type][$review->rating]++;
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 	 */
288 288
 	protected function decreaseRating( array $reviewCounts, $type, $rating )
289 289
 	{
290
-		if( isset( $reviewCounts[$type][$rating] )) {
290
+		if( isset($reviewCounts[$type][$rating]) ) {
291 291
 			$reviewCounts[$type][$rating] = max( 0, $reviewCounts[$type][$rating] - 1 );
292 292
 		}
293 293
 		return $reviewCounts;
@@ -300,10 +300,10 @@  discard block
 block discarded – undo
300 300
 	 */
301 301
 	protected function increaseRating( array $reviewCounts, $type, $rating )
302 302
 	{
303
-		if( !array_key_exists( $type, glsr()->reviewTypes )) {
303
+		if( !array_key_exists( $type, glsr()->reviewTypes ) ) {
304 304
 			return $reviewCounts;
305 305
 		}
306
-		if( !array_key_exists( $type, $reviewCounts )) {
306
+		if( !array_key_exists( $type, $reviewCounts ) ) {
307 307
 			$reviewCounts[$type] = [];
308 308
 		}
309 309
 		$reviewCounts = $this->normalize( $reviewCounts );
@@ -316,12 +316,12 @@  discard block
 block discarded – undo
316 316
 	 */
317 317
 	protected function normalize( array $reviewCounts )
318 318
 	{
319
-		if( empty( $reviewCounts )) {
319
+		if( empty($reviewCounts) ) {
320 320
 			$reviewCounts = [[]];
321 321
 		}
322 322
 		foreach( $reviewCounts as &$counts ) {
323 323
 			foreach( range( 0, Rating::MAX_RATING ) as $index ) {
324
-				if( isset( $counts[$index] ))continue;
324
+				if( isset($counts[$index]) )continue;
325 325
 				$counts[$index] = 0;
326 326
 			}
327 327
 			ksort( $counts );
@@ -336,14 +336,14 @@  discard block
 block discarded – undo
336 336
 	 */
337 337
 	protected function queryReviews( array $args = [], $lastPostId, $limit )
338 338
 	{
339
-		$args = wp_parse_args( $args, array_fill_keys( ['post_id', 'term_id'], '' ));
340
-		if( empty( array_filter( $args ))) {
339
+		$args = wp_parse_args( $args, array_fill_keys( ['post_id', 'term_id'], '' ) );
340
+		if( empty(array_filter( $args )) ) {
341 341
 			return glsr( SqlQueries::class )->getReviewCounts( $lastPostId, $limit );
342 342
 		}
343
-		if( !empty( $args['post_id'] )) {
343
+		if( !empty($args['post_id']) ) {
344 344
 			return glsr( SqlQueries::class )->getReviewPostCounts( $args['post_id'], $lastPostId, $limit );
345 345
 		}
346
-		if( !empty( $args['term_id'] )) {
346
+		if( !empty($args['term_id']) ) {
347 347
 			return glsr( SqlQueries::class )->getReviewTermCounts( $args['term_id'], $lastPostId, $limit );
348 348
 		}
349 349
 	}
Please login to merge, or discard this patch.
plugin/Modules/System.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 			'setting' => 'Plugin Settings',
41 41
 			'reviews' => 'Review Counts',
42 42
 		];
43
-		$systemInfo = array_reduce( array_keys( $details ), function( $carry, $key ) use( $details ) {
43
+		$systemInfo = array_reduce( array_keys( $details ), function( $carry, $key ) use($details) {
44 44
 			$methodName = glsr( Helper::class )->buildMethodName( 'get-'.$key.'-details' );
45 45
 			if( method_exists( $this, $methodName ) && $systemDetails = $this->$methodName() ) {
46 46
 				return $carry.$this->implode( strtoupper( $details[$key] ), $systemDetails );
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
57 57
 	{
58 58
 		$plugins = get_plugins();
59 59
 		$activePlugins = (array)get_option( 'active_plugins', [] );
60
-		$inactive = array_diff_key( $plugins, array_flip( $activePlugins ));
61
-		return $this->normalizePluginList( array_diff_key( $plugins, $inactive ));
60
+		$inactive = array_diff_key( $plugins, array_flip( $activePlugins ) );
61
+		return $this->normalizePluginList( array_diff_key( $plugins, $inactive ) );
62 62
 	}
63 63
 
64 64
 	/**
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	public function getInactivePluginDetails()
93 93
 	{
94 94
 		$activePlugins = (array)get_option( 'active_plugins', [] );
95
-		return $this->normalizePluginList( array_diff_key( get_plugins(), array_flip( $activePlugins )));
95
+		return $this->normalizePluginList( array_diff_key( get_plugins(), array_flip( $activePlugins ) ) );
96 96
 	}
97 97
 
98 98
 	/**
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
 	{
103 103
 		$plugins = array_merge(
104 104
 			get_mu_plugins(),
105
-			get_plugins( '/../'.basename( WPMU_PLUGIN_DIR ))
105
+			get_plugins( '/../'.basename( WPMU_PLUGIN_DIR ) )
106 106
 		);
107
-		if( empty( $plugins ))return;
107
+		if( empty($plugins) )return;
108 108
 		return $this->normalizePluginList( $plugins );
109 109
 	}
110 110
 
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 	 */
114 114
 	public function getMultisitePluginDetails()
115 115
 	{
116
-		if( !is_multisite() || empty( get_site_option( 'active_sitewide_plugins', [] )))return;
116
+		if( !is_multisite() || empty(get_site_option( 'active_sitewide_plugins', [] )) )return;
117 117
 		return $this->normalizePluginList( wp_get_active_network_plugins() );
118 118
 	}
119 119
 
@@ -139,11 +139,11 @@  discard block
 block discarded – undo
139 139
 			'Max Input Vars' => ini_get( 'max_input_vars' ),
140 140
 			'Memory Limit' => ini_get( 'memory_limit' ),
141 141
 			'Post Max Size' => ini_get( 'post_max_size' ),
142
-			'Session Cookie Path' => esc_html( ini_get( 'session.cookie_path' )),
143
-			'Session Name' => esc_html( ini_get( 'session.name' )),
144
-			'Session Save Path' => esc_html( ini_get( 'session.save_path' )),
145
-			'Session Use Cookies' => var_export( wp_validate_boolean( ini_get( 'session.use_cookies' )), true ),
146
-			'Session Use Only Cookies' => var_export( wp_validate_boolean( ini_get( 'session.use_only_cookies' )), true ),
142
+			'Session Cookie Path' => esc_html( ini_get( 'session.cookie_path' ) ),
143
+			'Session Name' => esc_html( ini_get( 'session.name' ) ),
144
+			'Session Save Path' => esc_html( ini_get( 'session.save_path' ) ),
145
+			'Session Use Cookies' => var_export( wp_validate_boolean( ini_get( 'session.use_cookies' ) ), true ),
146
+			'Session Use Only Cookies' => var_export( wp_validate_boolean( ini_get( 'session.use_only_cookies' ) ), true ),
147 147
 			'Upload Max Filesize' => ini_get( 'upload_max_filesize' ),
148 148
 		];
149 149
 	}
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
 	{
156 156
 		$counts = glsr( CountsManager::class )->getCounts();
157 157
 		$counts = glsr( Helper::class )->flattenArray( $counts );
158
- 		array_walk( $counts, function( &$ratings ) use( $counts ) {
159
-			if( !is_array( $ratings )) {
158
+ 		array_walk( $counts, function( &$ratings ) use($counts) {
159
+			if( !is_array( $ratings ) ) {
160 160
 				glsr_log()
161 161
 					->error( '$ratings is not an array, possibly due to incorrectly imported reviews that are missing their review type.' )
162 162
 					->debug( $ratings )
@@ -195,8 +195,8 @@  discard block
 block discarded – undo
195 195
 		ksort( $settings );
196 196
 		$details = [];
197 197
 		foreach( $settings as $key => $value ) {
198
-			if( $helper->startsWith( 'strings', $key ) && $helper->endsWith( 'id', $key ))continue;
199
-			$value = htmlspecialchars( trim( preg_replace('/\s\s+/', '\\n', $value )), ENT_QUOTES, 'UTF-8' );
198
+			if( $helper->startsWith( 'strings', $key ) && $helper->endsWith( 'id', $key ) )continue;
199
+			$value = htmlspecialchars( trim( preg_replace( '/\s\s+/', '\\n', $value ) ), ENT_QUOTES, 'UTF-8' );
200 200
 			$details[$key] = $value;
201 201
 		}
202 202
 		return $details;
@@ -268,10 +268,10 @@  discard block
 block discarded – undo
268 268
 			'WPE_APIKEY' => 'WP Engine',
269 269
 		];
270 270
 		foreach( $checks as $key => $value ) {
271
-			if( !$this->isWebhostCheckValid( $key ))continue;
271
+			if( !$this->isWebhostCheckValid( $key ) )continue;
272 272
 			return $value;
273 273
 		}
274
-		return implode( ',', array_filter( [DB_HOST, filter_input( INPUT_SERVER, 'SERVER_NAME' )] ));
274
+		return implode( ',', array_filter( [DB_HOST, filter_input( INPUT_SERVER, 'SERVER_NAME' )] ) );
275 275
 	}
276 276
 
277 277
 	/**
@@ -292,8 +292,8 @@  discard block
 block discarded – undo
292 292
 	{
293 293
 		$plugins = get_plugins();
294 294
 		$activePlugins = (array)get_option( 'active_plugins', [] );
295
-		$inactive = $this->normalizePluginList( array_diff_key( $plugins, array_flip( $activePlugins )));
296
-		$active = $this->normalizePluginList( array_diff_key( $plugins, $inactive ));
295
+		$inactive = $this->normalizePluginList( array_diff_key( $plugins, array_flip( $activePlugins ) ) );
296
+		$active = $this->normalizePluginList( array_diff_key( $plugins, $inactive ) );
297 297
 		return $active + $inactive;
298 298
 	}
299 299
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
 	protected function implode( $title, array $details )
305 305
 	{
306 306
 		$strings = ['['.$title.']'];
307
-		$padding = max( array_map( 'strlen', array_keys( $details )) );
307
+		$padding = max( array_map( 'strlen', array_keys( $details ) ) );
308 308
 		$padding = max( [$padding, static::PAD] );
309 309
 		foreach( $details as $key => $value ) {
310 310
 			$strings[] = is_string( $key )
@@ -347,9 +347,9 @@  discard block
 block discarded – undo
347 347
 		$keys = [
348 348
 			'licenses.', 'submissions.recaptcha.key', 'submissions.recaptcha.secret',
349 349
 		];
350
-		array_walk( $settings, function( &$value, $setting ) use( $keys ) {
350
+		array_walk( $settings, function( &$value, $setting ) use($keys) {
351 351
 			foreach( $keys as $key ) {
352
-				if( !glsr( Helper::class )->startsWith( $key, $setting ) || empty( $value ))continue;
352
+				if( !glsr( Helper::class )->startsWith( $key, $setting ) || empty($value) )continue;
353 353
 				$value = str_repeat( '•', 13 );
354 354
 				return;
355 355
 			}
Please login to merge, or discard this patch.