Passed
Push — master ( 06feff...e4a90e )
by Paul
02:34
created
src/MetaBox.php 2 patches
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -26,16 +26,16 @@  discard block
 block discarded – undo
26 26
 	{
27 27
 		$this->normalize();
28 28
 
29
-		add_filter( 'rwmb_show',       [$this, 'isVisible'], 10, 2 );
30
-		add_action( 'rwmb_meta_boxes', [$this, 'register'] );
29
+		add_filter( 'rwmb_show', [ $this, 'isVisible' ], 10, 2 );
30
+		add_action( 'rwmb_meta_boxes', [ $this, 'register' ] );
31 31
 	}
32 32
 
33 33
 	/**
34 34
 	 * @return array
35 35
 	 */
36
-	public function register( $metaboxes = [] )
36
+	public function register( $metaboxes = [ ] )
37 37
 	{
38
-		if( current_user_can( 'switch_themes' )) {
38
+		if( current_user_can( 'switch_themes' ) ) {
39 39
 			$this->addInstructions();
40 40
 		}
41 41
 		return array_merge( $metaboxes, $this->metaboxes );
@@ -47,11 +47,11 @@  discard block
 block discarded – undo
47 47
 	public function isVisible( $bool, array $metabox )
48 48
 	{
49 49
 		if( defined( 'DOING_AJAX' ) && DOING_AJAX
50
-			|| !isset( $metabox['condition'] )
51
-			|| !$this->hasPostType( $metabox )) {
50
+			|| !isset( $metabox[ 'condition' ] )
51
+			|| !$this->hasPostType( $metabox ) ) {
52 52
 			return $bool;
53 53
 		}
54
-		return $this->verifyMetaBoxCondition( $metabox['condition'] );
54
+		return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] );
55 55
 	}
56 56
 
57 57
 	/**
@@ -72,17 +72,17 @@  discard block
 block discarded – undo
72 72
 	{
73 73
 		if( !count( array_filter( $this->metaboxes, function( $metabox ) {
74 74
 			return $this->isVisible( false, $metabox );
75
-		})))return;
76
-		$this->metaboxes[] = [
75
+		}) ) )return;
76
+		$this->metaboxes[ ] = [
77 77
 			'id' => 'infodiv',
78 78
 			'post_types' => $this->getPostTypes(),
79 79
 			'title' => __( 'How to use in your theme', 'pollux' ),
80 80
 			'context' => 'side',
81 81
 			'priority' => 'low',
82
-			'fields' => [[
82
+			'fields' => [ [
83 83
 				'type' => 'custom_html',
84 84
 				'std' => $this->generateInstructions(),
85
-			]],
85
+			] ],
86 86
 		];
87 87
 	}
88 88
 
@@ -92,12 +92,12 @@  discard block
 block discarded – undo
92 92
 	protected function generateInstructions()
93 93
 	{
94 94
 		return array_reduce( $this->getInstructions(), function( $html, $metabox ) {
95
-			$fields = array_reduce( array_column( $metabox['fields'], 'slug' ), function( $html, $slug ) use( $metabox ) {
95
+			$fields = array_reduce( array_column( $metabox[ 'fields' ], 'slug' ), function( $html, $slug ) use( $metabox ) {
96 96
 				$hook = sprintf( 'pollux/%s/instruction', $this->getClassname() );
97
-				return $html . apply_filters( $hook, "PostMeta::get('{$slug}');", $slug, $metabox['slug'] ) . PHP_EOL;
97
+				return $html . apply_filters( $hook, "PostMeta::get('{$slug}');", $slug, $metabox[ 'slug' ] ) . PHP_EOL;
98 98
 			});
99 99
 			return $html . sprintf( '<p><strong>%s</strong></p><pre class="my-sites nav-tab-active misc-pub-section">%s</pre>',
100
-				$metabox['title'],
100
+				$metabox[ 'title' ],
101 101
 				$fields
102 102
 			);
103 103
 		});
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	protected function getInstructions()
110 110
 	{
111 111
 		return array_filter( $this->metaboxes, function( $metabox ) {
112
-			return $this->verifyMetaBoxCondition( $metabox['condition'] )
112
+			return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] )
113 113
 				&& $this->hasPostType( $metabox );
114 114
 		});
115 115
 	}
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 	 */
120 120
 	protected function getPostId()
121 121
 	{
122
-		if( !( $postId = filter_input( INPUT_GET, 'post' ))) {
122
+		if( !( $postId = filter_input( INPUT_GET, 'post' ) ) ) {
123 123
 			$postId = filter_input( INPUT_POST, 'post_ID' );
124 124
 		}
125 125
 		return intval( $postId );
@@ -132,10 +132,10 @@  discard block
 block discarded – undo
132 132
 	{
133 133
 		return array_unique( iterator_to_array(
134 134
 			new RecursiveIteratorIterator(
135
-				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ))
135
+				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ) )
136 136
 			),
137 137
 			false
138
-		));
138
+		) );
139 139
 	}
140 140
 
141 141
 	/**
@@ -143,10 +143,10 @@  discard block
 block discarded – undo
143 143
 	 */
144 144
 	protected function hasPostType( array $metabox )
145 145
 	{
146
-		if( !isset( $metabox['post_types'] )) {
146
+		if( !isset( $metabox[ 'post_types' ] ) ) {
147 147
 			return true;
148 148
 		}
149
-		return in_array( get_post_type( $this->getPostId() ), $metabox['post_types'] );
149
+		return in_array( get_post_type( $this->getPostId() ), $metabox[ 'post_types' ] );
150 150
 	}
151 151
 
152 152
 	/**
@@ -154,16 +154,16 @@  discard block
 block discarded – undo
154 154
 	 */
155 155
 	protected function normalize()
156 156
 	{
157
-		$this->metaboxes = [];
158
-		foreach( $this->app->config['meta_boxes'] as $id => $metabox ) {
157
+		$this->metaboxes = [ ];
158
+		foreach( $this->app->config[ 'meta_boxes' ] as $id => $metabox ) {
159 159
 			$defaults = [
160
-				'condition' => [],
161
-				'fields' => [],
160
+				'condition' => [ ],
161
+				'fields' => [ ],
162 162
 				'id' => $id,
163
-				'post_types' => [],
163
+				'post_types' => [ ],
164 164
 				'slug' => $id,
165 165
 			];
166
-			$this->metaboxes[] = $this->normalizeThis( $metabox, $defaults, $id );
166
+			$this->metaboxes[ ] = $this->normalizeThis( $metabox, $defaults, $id );
167 167
 		}
168 168
 	}
169 169
 
@@ -174,9 +174,9 @@  discard block
 block discarded – undo
174 174
 	protected function normalizeCondition( $conditions )
175 175
 	{
176 176
 		$conditions = $this->toArray( $conditions );
177
-		if( count( array_filter( array_keys( $conditions ), 'is_string' )) == 0 ) {
177
+		if( count( array_filter( array_keys( $conditions ), 'is_string' ) ) == 0 ) {
178 178
 			foreach( $conditions as $key ) {
179
-				$conditions[str_replace( '!', '', $key )] = substr( $key, 0, 1 ) == '!' ? 0 : 1;
179
+				$conditions[ str_replace( '!', '', $key ) ] = substr( $key, 0, 1 ) == '!' ? 0 : 1;
180 180
 			}
181 181
 			$conditions = array_filter( $conditions, function( $key ) {
182 182
 				return !is_numeric( $key );
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 		$hook = sprintf( 'pollux/%s/conditions', $this->getClassname() );
186 186
 		return array_intersect_key(
187 187
 			$conditions,
188
-			array_flip( apply_filters( $hook, self::CONDITIONS ))
188
+			array_flip( apply_filters( $hook, self::CONDITIONS ) )
189 189
 		);
190 190
 	}
191 191
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	protected function normalizeFields( array $fields, array $data, $parentId )
196 196
 	{
197 197
 		return array_map( function( $id, $field ) use( $parentId ) {
198
-			$defaults =  [
198
+			$defaults = [
199 199
 				'id' => $id,
200 200
 				'field_name' => '',
201 201
 				'slug' => $id,
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 	 */
241 241
 	protected function validateIsFrontPage( $value )
242 242
 	{
243
-		return $value == ( $this->getPostId() == get_option( 'page_on_front' ));
243
+		return $value == ( $this->getPostId() == get_option( 'page_on_front' ) );
244 244
 	}
245 245
 
246 246
 	/**
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 	 */
250 250
 	protected function validateIsHome( $value )
251 251
 	{
252
-		return $value == ( $this->getPostId() == get_option( 'page_for_posts' ));
252
+		return $value == ( $this->getPostId() == get_option( 'page_for_posts' ) );
253 253
 	}
254 254
 
255 255
 	/**
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
 	 */
259 259
 	protected function validateIsPageTemplate( $value )
260 260
 	{
261
-		return basename( get_page_template_slug( $this->getPostId() )) == $value;
261
+		return basename( get_page_template_slug( $this->getPostId() ) ) == $value;
262 262
 	}
263 263
 
264 264
 	/**
Please login to merge, or discard this patch.
Braces   +17 added lines, -8 removed lines patch added patch discarded remove patch
@@ -59,7 +59,8 @@  discard block
 block discarded – undo
59 59
 	 */
60 60
 	public function verifyMetaBoxCondition( array $conditions )
61 61
 	{
62
-		array_walk( $conditions, function( &$value, $key ) {
62
+		array_walk( $conditions, function( &$value, $key )
63
+		{
63 64
 			$method = $this->app->buildMethodName( $key, 'validate' );
64 65
 			$value = method_exists( $this, $method )
65 66
 				? $this->$method( $value )
@@ -70,9 +71,12 @@  discard block
 block discarded – undo
70 71
 
71 72
 	protected function addInstructions()
72 73
 	{
73
-		if( !count( array_filter( $this->metaboxes, function( $metabox ) {
74
+		if( !count( array_filter( $this->metaboxes, function( $metabox )
75
+		{
74 76
 			return $this->isVisible( false, $metabox );
75
-		})))return;
77
+		}))) {
78
+			return;
79
+		}
76 80
 		$this->metaboxes[] = [
77 81
 			'id' => 'infodiv',
78 82
 			'post_types' => $this->getPostTypes(),
@@ -91,8 +95,10 @@  discard block
 block discarded – undo
91 95
 	 */
92 96
 	protected function generateInstructions()
93 97
 	{
94
-		return array_reduce( $this->getInstructions(), function( $html, $metabox ) {
95
-			$fields = array_reduce( array_column( $metabox['fields'], 'slug' ), function( $html, $slug ) use( $metabox ) {
98
+		return array_reduce( $this->getInstructions(), function( $html, $metabox )
99
+		{
100
+			$fields = array_reduce( array_column( $metabox['fields'], 'slug' ), function( $html, $slug ) use( $metabox )
101
+			{
96 102
 				$hook = sprintf( 'pollux/%s/instruction', $this->getClassname() );
97 103
 				return $html . apply_filters( $hook, "PostMeta::get('{$slug}');", $slug, $metabox['slug'] ) . PHP_EOL;
98 104
 			});
@@ -108,7 +114,8 @@  discard block
 block discarded – undo
108 114
 	 */
109 115
 	protected function getInstructions()
110 116
 	{
111
-		return array_filter( $this->metaboxes, function( $metabox ) {
117
+		return array_filter( $this->metaboxes, function( $metabox )
118
+		{
112 119
 			return $this->verifyMetaBoxCondition( $metabox['condition'] )
113 120
 				&& $this->hasPostType( $metabox );
114 121
 		});
@@ -178,7 +185,8 @@  discard block
 block discarded – undo
178 185
 			foreach( $conditions as $key ) {
179 186
 				$conditions[str_replace( '!', '', $key )] = substr( $key, 0, 1 ) == '!' ? 0 : 1;
180 187
 			}
181
-			$conditions = array_filter( $conditions, function( $key ) {
188
+			$conditions = array_filter( $conditions, function( $key )
189
+			{
182 190
 				return !is_numeric( $key );
183 191
 			}, ARRAY_FILTER_USE_KEY );
184 192
 		}
@@ -194,7 +202,8 @@  discard block
 block discarded – undo
194 202
 	 */
195 203
 	protected function normalizeFields( array $fields, array $data, $parentId )
196 204
 	{
197
-		return array_map( function( $id, $field ) use( $parentId ) {
205
+		return array_map( function( $id, $field ) use( $parentId )
206
+		{
198 207
 			$defaults =  [
199 208
 				'id' => $id,
200 209
 				'field_name' => '',
Please login to merge, or discard this patch.
src/Settings.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -27,15 +27,15 @@  discard block
 block discarded – undo
27 27
 	 */
28 28
 	public function init()
29 29
 	{
30
-		if( !is_plugin_active( 'meta-box/meta-box.php' ))return;
30
+		if( !is_plugin_active( 'meta-box/meta-box.php' ) )return;
31 31
 
32 32
 		$this->normalize();
33 33
 
34
-		add_action( 'admin_menu',                             [$this, 'addPage'] );
35
-		add_action( 'pollux/settings/init',                   [$this, 'addSubmitMetaBox'] );
36
-		add_filter( 'pollux/settings/instruction',            [$this, 'filterInstruction'], 10, 3 );
37
-		add_action( 'current_screen',                         [$this, 'register'] );
38
-		add_action( 'admin_footer-toplevel_page_' . self::ID, [$this, 'renderFooterScript'] );
34
+		add_action( 'admin_menu', [ $this, 'addPage' ] );
35
+		add_action( 'pollux/settings/init', [ $this, 'addSubmitMetaBox' ] );
36
+		add_filter( 'pollux/settings/instruction', [ $this, 'filterInstruction' ], 10, 3 );
37
+		add_action( 'current_screen', [ $this, 'register' ] );
38
+		add_action( 'admin_footer-toplevel_page_' . self::ID, [ $this, 'renderFooterScript' ] );
39 39
 
40 40
 		// add_filter( 'pollux/settings/save',        [$this, 'save'] );
41 41
 	}
@@ -50,10 +50,10 @@  discard block
 block discarded – undo
50 50
 			__( 'Site Settings', 'pollux' ),
51 51
 			'edit_theme_options',
52 52
 			self::ID,
53
-			[$this, 'renderPage'],
53
+			[ $this, 'renderPage' ],
54 54
 			'dashicons-screenoptions',
55 55
 			1313
56
-		]));
56
+		] ) );
57 57
 	}
58 58
 
59 59
 	/**
@@ -64,11 +64,11 @@  discard block
 block discarded – undo
64 64
 		call_user_func_array( 'add_meta_box', apply_filters( 'pollux/settings/metabox/submit', [
65 65
 			'submitdiv',
66 66
 			__( 'Save Settings', 'pollux' ),
67
-			[ $this, 'renderSubmitMetaBox'],
67
+			[ $this, 'renderSubmitMetaBox' ],
68 68
 			$this->hook,
69 69
 			'side',
70 70
 			'high',
71
-		]));
71
+		] ) );
72 72
 	}
73 73
 
74 74
 	/**
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	/**
86 86
 	 * @return void
87 87
 	 */
88
-	public function register( $metaboxes = [] )
88
+	public function register( $metaboxes = [ ] )
89 89
 	{
90 90
 		if( get_current_screen()->id != $this->hook )return;
91 91
 		foreach( parent::register() as $metabox ) {
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 			'confirm' => __( 'Are you sure want to do this?', 'pollux' ),
105 105
 			'hook' => $this->hook,
106 106
 			'id' => self::ID,
107
-		]);
107
+		] );
108 108
 	}
109 109
 
110 110
 	/**
@@ -114,10 +114,10 @@  discard block
 block discarded – undo
114 114
 	{
115 115
 		// add_screen_option( 'layout_columns', ['max' => 2, 'default' => 2] );
116 116
 		$this->render( 'settings/index', [
117
-			'columns' => 2,//get_current_screen()->get_columns(),
117
+			'columns' => 2, //get_current_screen()->get_columns(),
118 118
 			'id' => self::ID,
119 119
 			'title' => __( 'Site Settings', 'pollux' ),
120
-		]);
120
+		] );
121 121
 	}
122 122
 
123 123
 	/**
@@ -126,15 +126,15 @@  discard block
 block discarded – undo
126 126
 	public function renderSubmitMetaBox()
127 127
 	{
128 128
 		$query = [
129
-			'_wpnonce' => wp_create_nonce( sprintf( '%s-reset', self::ID )),
129
+			'_wpnonce' => wp_create_nonce( sprintf( '%s-reset', self::ID ) ),
130 130
 			'action' => 'reset_settings',
131 131
 			'page' => self::ID,
132 132
 		];
133 133
 		$this->render( 'settings/submit', [
134 134
 			'reset' => __( 'Reset Settings', 'pollux' ),
135
-			'reset_url' => esc_url( add_query_arg( $query, admin_url( 'admin.php' ))),
135
+			'reset_url' => esc_url( add_query_arg( $query, admin_url( 'admin.php' ) ) ),
136 136
 			'submit' => get_submit_button( __( 'Save', 'pollux' ), 'primary', 'submit', false ),
137
-		]);
137
+		] );
138 138
 	}
139 139
 
140 140
 	/**
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	protected function getInstructions()
144 144
 	{
145 145
 		return array_filter( $this->metaboxes, function( $metabox ) {
146
-			return $this->verifyMetaBoxCondition( $metabox['condition'] );
146
+			return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] );
147 147
 		});
148 148
 	}
149 149
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	 */
153 153
 	protected function getPostTypes()
154 154
 	{
155
-		return [];
155
+		return [ ];
156 156
 	}
157 157
 
158 158
 	/**
@@ -160,16 +160,16 @@  discard block
 block discarded – undo
160 160
 	 */
161 161
 	protected function normalize()
162 162
 	{
163
-		$this->metaboxes = [];
164
-		foreach( $this->app->config['settings'] as $id => $metabox ) {
165
-			unset( $metabox['post_types'], $metabox['pages'] );
163
+		$this->metaboxes = [ ];
164
+		foreach( $this->app->config[ 'settings' ] as $id => $metabox ) {
165
+			unset( $metabox[ 'post_types' ], $metabox[ 'pages' ] );
166 166
 			$defaults = [
167
-				'condition' => [],
168
-				'fields' => [],
167
+				'condition' => [ ],
168
+				'fields' => [ ],
169 169
 				'id' => $id,
170 170
 				'slug' => $id,
171 171
 			];
172
-			$this->metaboxes[] = $this->normalizeThis( $metabox, $defaults, $id );
172
+			$this->metaboxes[ ] = $this->normalizeThis( $metabox, $defaults, $id );
173 173
 		}
174 174
 	}
175 175
 
@@ -180,10 +180,10 @@  discard block
 block discarded – undo
180 180
 	 */
181 181
 	protected function normalizeFieldName( $name, array $data, $parentId )
182 182
 	{
183
-		if( !empty( $name )) {
183
+		if( !empty( $name ) ) {
184 184
 			return $name;
185 185
 		}
186
-		$name = str_replace( sprintf( '%s-%s-', self::ID, $parentId ), '', $data['id'] );
186
+		$name = str_replace( sprintf( '%s-%s-', self::ID, $parentId ), '', $data[ 'id' ] );
187 187
 		return sprintf( '%s[%s][%s]', self::ID, $parentId, $name );
188 188
 	}
189 189
 
Please login to merge, or discard this patch.