pryley / pollux

src/MetaBox.php

Spacing +33 added lines, -33 removed lines

@@ -26,8 +26,8 @@ 
 	{
 		$this->normalize();
 
-		add_filter( 'rwmb_show',       [$this, 'isVisible'], 10, 2 );
-		add_action( 'rwmb_meta_boxes', [$this, 'register'] );
+		add_filter( 'rwmb_show', [ $this, 'isVisible' ], 10, 2 );
+		add_action( 'rwmb_meta_boxes', [ $this, 'register' ] );
 	}
 
 	/**
@@ -36,19 +36,19 @@ 
 	public function isVisible( $bool, array $metabox )
 	{
 		if( defined( 'DOING_AJAX' )
-			|| !isset( $metabox['condition'] )
-			|| !$this->hasPostType( $metabox )) {
+			|| !isset( $metabox[ 'condition' ] )
+			|| !$this->hasPostType( $metabox ) ) {
 			return $bool;
 		}
-		return $this->verifyMetaBoxCondition( $metabox['condition'] );
+		return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] );
 	}
 
 	/**
 	 * @return array
 	 */
-	public function register( $metaboxes = [] )
+	public function register( $metaboxes = [ ] )
 	{
-		if( current_user_can( 'switch_themes' )) {
+		if( current_user_can( 'switch_themes' ) ) {
 			$this->addInstructions();
 		}
 		return array_merge( $metaboxes, $this->metaboxes );
@@ -72,18 +72,18 @@ 
 	{
 		if( !count( array_filter( $this->metaboxes, function( $metabox ) {
 			return $this->isVisible( false, $metabox );
-		})))return;
-		$this->metaboxes[] = [
+		}) ) )return;
+		$this->metaboxes[ ] = [
 			'id' => 'infodiv',
 			'post_types' => $this->getPostTypes(),
 			'title' => __( 'How to use in your theme', 'pollux' ),
 			'context' => 'side',
 			'priority' => 'low',
-			'fields' => [[
+			'fields' => [ [
 				'slug' => '',
 				'std' => $this->generateInstructions(),
 				'type' => 'custom_html',
-			]],
+			] ],
 		];
 	}
 
@@ -93,12 +93,12 @@ 
 	protected function generateInstructions()
 	{
 		return array_reduce( $this->getInstructions(), function( $html, $metabox ) {
-			$fields = array_reduce( array_column( $metabox['fields'], 'slug' ), function( $html, $slug ) use( $metabox ) {
+			$fields = array_reduce( array_column( $metabox[ 'fields' ], 'slug' ), function( $html, $slug ) use( $metabox ) {
 				$hook = sprintf( 'pollux/%s/instruction', $this->getClassname() );
-				return $html . apply_filters( $hook, "PostMeta::get('{$slug}');", $slug, $metabox['slug'] ) . PHP_EOL;
+				return $html . apply_filters( $hook, "PostMeta::get('{$slug}');", $slug, $metabox[ 'slug' ] ) . PHP_EOL;
 			});
 			return $html . sprintf( '<p><strong>%s</strong></p><pre class="my-sites nav-tab-active misc-pub-section">%s</pre>',
-				$metabox['title'],
+				$metabox[ 'title' ],
 				$fields
 			);
 		});
@@ -110,7 +110,7 @@ 
 	protected function getInstructions()
 	{
 		return array_filter( $this->metaboxes, function( $metabox ) {
-			return $this->verifyMetaBoxCondition( $metabox['condition'] )
+			return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] )
 				&& $this->hasPostType( $metabox );
 		});
 	}
@@ -120,7 +120,7 @@ 
 	 */
 	protected function getPostId()
 	{
-		if( !( $postId = filter_input( INPUT_GET, 'post' ))) {
+		if( !( $postId = filter_input( INPUT_GET, 'post' ) ) ) {
 			$postId = filter_input( INPUT_POST, 'post_ID' );
 		}
 		return intval( $postId );
@@ -133,10 +133,10 @@ 
 	{
 		return array_unique( iterator_to_array(
 			new RecursiveIteratorIterator(
-				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ))
+				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ) )
 			),
 			false
-		));
+		) );
 	}
 
 	/**
@@ -144,10 +144,10 @@ 
 	 */
 	protected function hasPostType( array $metabox )
 	{
-		if( !isset( $metabox['post_types'] )) {
+		if( !isset( $metabox[ 'post_types' ] ) ) {
 			return true;
 		}
-		return in_array( get_post_type( $this->getPostId() ), $metabox['post_types'] );
+		return in_array( get_post_type( $this->getPostId() ), $metabox[ 'post_types' ] );
 	}
 
 	/**
@@ -155,16 +155,16 @@ 
 	 */
 	protected function normalize()
 	{
-		$this->metaboxes = [];
-		foreach( $this->app->config['meta_boxes'] as $id => $metabox ) {
+		$this->metaboxes = [ ];
+		foreach( $this->app->config[ 'meta_boxes' ] as $id => $metabox ) {
 			$defaults = [
-				'condition' => [],
-				'fields' => [],
+				'condition' => [ ],
+				'fields' => [ ],
 				'id' => $id,
-				'post_types' => [],
+				'post_types' => [ ],
 				'slug' => $id,
 			];
-			$this->metaboxes[] = $this->normalizeThis( $metabox, $defaults, $id );
+			$this->metaboxes[ ] = $this->normalizeThis( $metabox, $defaults, $id );
 		}
 	}
 
@@ -175,9 +175,9 @@ 
 	protected function normalizeCondition( $conditions )
 	{
 		$conditions = $this->toArray( $conditions );
-		if( count( array_filter( array_keys( $conditions ), 'is_string' )) == 0 ) {
+		if( count( array_filter( array_keys( $conditions ), 'is_string' ) ) == 0 ) {
 			foreach( $conditions as $key ) {
-				$conditions[str_replace( '!', '', $key )] = substr( $key, 0, 1 ) == '!' ? 0 : 1;
+				$conditions[ str_replace( '!', '', $key ) ] = substr( $key, 0, 1 ) == '!' ? 0 : 1;
 			}
 			$conditions = array_filter( $conditions, function( $key ) {
 				return !is_numeric( $key );
@@ -186,7 +186,7 @@ 
 		$hook = sprintf( 'pollux/%s/conditions', $this->getClassname() );
 		return array_intersect_key(
 			$conditions,
-			array_flip( apply_filters( $hook, static::CONDITIONS ))
+			array_flip( apply_filters( $hook, static::CONDITIONS ) )
 		);
 	}
 
@@ -196,7 +196,7 @@ 
 	protected function normalizeFields( array $fields, array $data, $parentId )
 	{
 		return array_map( function( $id, $field ) use( $parentId ) {
-			$defaults =  [
+			$defaults = [
 				'id' => $id,
 				'field_name' => '',
 				'slug' => $id,
@@ -241,7 +241,7 @@ 
 	 */
 	protected function validateIsFrontPage( $value )
 	{
-		return $value == ( $this->getPostId() == get_option( 'page_on_front' ));
+		return $value == ( $this->getPostId() == get_option( 'page_on_front' ) );
 	}
 
 	/**
@@ -250,7 +250,7 @@ 
 	 */
 	protected function validateIsHome( $value )
 	{
-		return $value == ( $this->getPostId() == get_option( 'page_for_posts' ));
+		return $value == ( $this->getPostId() == get_option( 'page_for_posts' ) );
 	}
 
 	/**
@@ -259,7 +259,7 @@ 
 	 */
 	protected function validateIsPageTemplate( $value )
 	{
-		return basename( get_page_template_slug( $this->getPostId() )) == $value;
+		return basename( get_page_template_slug( $this->getPostId() ) ) == $value;
 	}
 
 	/**

src/Settings.php

Spacing +31 added lines, -31 removed lines

@@ -28,18 +28,18 @@ 
 	public function init()
 	{
 		// @todo: run GateKeeper here instead to check dependencies and capability
-		if( !is_plugin_active( 'meta-box/meta-box.php' ))return;
+		if( !is_plugin_active( 'meta-box/meta-box.php' ) )return;
 
 		$this->normalize();
 
-		add_action( 'admin_menu',                               [$this, 'addPage'] );
-		add_action( 'pollux/settings/init',                     [$this, 'addSubmitMetaBox'] );
-		add_filter( 'pollux/settings/instruction',              [$this, 'filterInstruction'], 10, 3 );
-		add_filter( 'wp_redirect',                              [$this, 'filterRedirectOnSave'] );
-		add_action( 'current_screen',                           [$this, 'register'] );
-		add_action( 'admin_menu',                               [$this, 'registerSetting'] );
-		add_action( 'pollux/settings/init',                     [$this, 'reset'] );
-		add_action( 'admin_footer-toplevel_page_' . static::ID, [$this, 'renderFooterScript'] );
+		add_action( 'admin_menu', [ $this, 'addPage' ] );
+		add_action( 'pollux/settings/init', [ $this, 'addSubmitMetaBox' ] );
+		add_filter( 'pollux/settings/instruction', [ $this, 'filterInstruction' ], 10, 3 );
+		add_filter( 'wp_redirect', [ $this, 'filterRedirectOnSave' ] );
+		add_action( 'current_screen', [ $this, 'register' ] );
+		add_action( 'admin_menu', [ $this, 'registerSetting' ] );
+		add_action( 'pollux/settings/init', [ $this, 'reset' ] );
+		add_action( 'admin_footer-toplevel_page_' . static::ID, [ $this, 'renderFooterScript' ] );
 	}
 
 	/**
@@ -52,10 +52,10 @@ 
 			__( 'Site Settings', 'pollux' ),
 			'edit_theme_options',
 			static::ID,
-			[$this, 'renderPage'],
+			[ $this, 'renderPage' ],
 			'dashicons-screenoptions',
 			1313
-		]));
+		] ) );
 	}
 
 	/**
@@ -66,11 +66,11 @@ 
 		call_user_func_array( 'add_meta_box', apply_filters( 'pollux/settings/metabox/submit', [
 			'submitdiv',
 			__( 'Save Settings', 'pollux' ),
-			[ $this, 'renderSubmitMetaBox'],
+			[ $this, 'renderSubmitMetaBox' ],
 			$this->hook,
 			'side',
 			'high',
-		]));
+		] ) );
 	}
 
 	/**
@@ -91,19 +91,19 @@ 
 	public function filterRedirectOnSave( $location )
 	{
 		if( strpos( $location, 'settings-updated=true' ) === false
-			|| strpos( $location, sprintf( 'page=%s', static::ID )) === false ) {
+			|| strpos( $location, sprintf( 'page=%s', static::ID ) ) === false ) {
 			return $location;
 		}
-		return add_query_arg([
+		return add_query_arg( [
 			'page' => static::ID,
 			'settings-updated' => 'true',
-		], admin_url( 'admin.php' ));
+		], admin_url( 'admin.php' ) );
 	}
 
 	/**
 	 * @return void
 	 */
-	public function register( $metaboxes = [] )
+	public function register( $metaboxes = [ ] )
 	{
 		if( get_current_screen()->id != $this->hook )return;
 		foreach( parent::register() as $metabox ) {
@@ -112,7 +112,7 @@ 
 		add_screen_option( 'layout_columns', [
 			'max' => 2,
 			'default' => 2,
-		]);
+		] );
 		do_action( 'pollux/settings/init' );
 	}
 
@@ -133,7 +133,7 @@ 
 			'confirm' => __( 'Are you sure want to do this?', 'pollux' ),
 			'hook' => $this->hook,
 			'id' => static::ID,
-		]);
+		] );
 	}
 
 	/**
@@ -145,7 +145,7 @@ 
 			'columns' => get_current_screen()->get_columns(),
 			'id' => static::ID,
 			'title' => __( 'Site Settings', 'pollux' ),
-		]);
+		] );
 	}
 
 	/**
@@ -160,9 +160,9 @@ 
 		];
 		$this->render( 'settings/submit', [
 			'reset' => __( 'Reset Settings', 'pollux' ),
-			'reset_url' => esc_url( add_query_arg( $query, admin_url( 'admin.php' ))),
+			'reset_url' => esc_url( add_query_arg( $query, admin_url( 'admin.php' ) ) ),
 			'submit' => get_submit_button( __( 'Save', 'pollux' ), 'primary', 'submit', false ),
-		]);
+		] );
 	}
 
 	/**
@@ -173,12 +173,12 @@ 
 		if( filter_input( INPUT_GET, 'page' ) !== static::ID
 			|| filter_input( INPUT_GET, 'action' ) !== 'reset'
 		)return;
-		if( wp_verify_nonce( filter_input( INPUT_GET, '_wpnonce' ), $this->hook )) {
+		if( wp_verify_nonce( filter_input( INPUT_GET, '_wpnonce' ), $this->hook ) ) {
 			delete_option( static::ID );
 			// @todo: now trigger save to restore defaults
 			return add_settings_error( static::ID, 'reset', __( 'Settings reset to defaults.', 'pollux' ), 'updated' );
 		}
-		add_settings_error( static::ID, 'reset', __( 'Failed to reset settings. Please refresh the page and try again.', 'pollux' ));
+		add_settings_error( static::ID, 'reset', __( 'Failed to reset settings. Please refresh the page and try again.', 'pollux' ) );
 	}
 
 	/**
@@ -186,15 +186,15 @@ 
 	 */
 	protected function normalize()
 	{
-		$this->metaboxes = [];
-		foreach( $this->app->config['settings'] as $id => $metabox ) {
+		$this->metaboxes = [ ];
+		foreach( $this->app->config[ 'settings' ] as $id => $metabox ) {
 			$defaults = [
-				'condition' => [],
-				'fields' => [],
+				'condition' => [ ],
+				'fields' => [ ],
 				'id' => $id,
 				'slug' => $id,
 			];
-			$this->metaboxes[] = $this->normalizeThis( $metabox, $defaults, $id );
+			$this->metaboxes[ ] = $this->normalizeThis( $metabox, $defaults, $id );
 		}
 	}
 
@@ -205,10 +205,10 @@ 
 	 */
 	protected function normalizeFieldName( $name, array $data, $parentId )
 	{
-		if( !empty( $name )) {
+		if( !empty( $name ) ) {
 			return $name;
 		}
-		$name = str_replace( sprintf( '%s-%s-', static::ID, $parentId ), '', $data['id'] );
+		$name = str_replace( sprintf( '%s-%s-', static::ID, $parentId ), '', $data[ 'id' ] );
 		return sprintf( '%s[%s][%s]', static::ID, $parentId, $name );
 	}
 

Braces +9 added lines, -3 removed lines

@@ -28,7 +28,9 @@ 
 	public function init()
 	{
 		// @todo: run GateKeeper here instead to check dependencies and capability
-		if( !is_plugin_active( 'meta-box/meta-box.php' ))return;
+		if( !is_plugin_active( 'meta-box/meta-box.php' )) {
+			return;
+		}
 
 		$this->normalize();
 
@@ -105,7 +107,9 @@ 
 	 */
 	public function register( $metaboxes = [] )
 	{
-		if( get_current_screen()->id != $this->hook )return;
+		if( get_current_screen()->id != $this->hook ) {
+			return;
+		}
 		foreach( parent::register() as $metabox ) {
 			new SettingsMetaBox( $metabox );
 		}
@@ -172,7 +176,9 @@ 
 	{
 		if( filter_input( INPUT_GET, 'page' ) !== static::ID
 			|| filter_input( INPUT_GET, 'action' ) !== 'reset'
-		)return;
+		) {
+			return;
+		}
 		if( wp_verify_nonce( filter_input( INPUT_GET, '_wpnonce' ), $this->hook )) {
 			delete_option( static::ID );
 			// @todo: now trigger save to restore defaults