Passed
Push — master ( 9b930a...aebf2b )
by Paul
02:24
created
src/PostType.php 2 patches
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -13,10 +13,10 @@  discard block
 block discarded – undo
13 13
 
14 14
 	const POST_TYPE_DEFAULTS = [
15 15
 		'capability_type' => 'post',
16
-		'columns' => [],
16
+		'columns' => [ ],
17 17
 		'has_archive' => false,
18 18
 		'hierarchical' => false,
19
-		'labels' => [],
19
+		'labels' => [ ],
20 20
 		'map_meta_cap' => true,
21 21
 		'menu_icon' => null,
22 22
 		'menu_name' => '',
@@ -29,8 +29,8 @@  discard block
 block discarded – undo
29 29
 		'show_ui' => true,
30 30
 		'single' => '',
31 31
 		'slug' => '',
32
-		'supports' => ['title', 'editor', 'thumbnail'],
33
-		'taxonomies' => [],
32
+		'supports' => [ 'title', 'editor', 'thumbnail' ],
33
+		'taxonomies' => [ ],
34 34
 	];
35 35
 
36 36
 	/**
@@ -50,13 +50,13 @@  discard block
 block discarded – undo
50 50
 	{
51 51
 		$this->normalize();
52 52
 
53
-		add_action( 'init', [$this, 'register'] );
53
+		add_action( 'init', [ $this, 'register' ] );
54 54
 
55 55
 		foreach( $this->types as $type => $args ) {
56
-			add_action( "manage_{$type}_posts_custom_column", [$this, 'printColumnValue'], 10, 2 );
56
+			add_action( "manage_{$type}_posts_custom_column", [ $this, 'printColumnValue' ], 10, 2 );
57 57
 			add_filter( "manage_{$type}_posts_columns", function( $columns ) use( $args ) {
58
-				return count( $args['columns'] ) > 1
59
-					? $args['columns']
58
+				return count( $args[ 'columns' ] ) > 1
59
+					? $args[ 'columns' ]
60 60
 					: $columns;
61 61
 			});
62 62
 		}
@@ -69,10 +69,10 @@  discard block
 block discarded – undo
69 69
 	{
70 70
 		$types = array_diff_key(
71 71
 			$this->types,
72
-			get_post_types( ['_builtin' => true] )
72
+			get_post_types( [ '_builtin' => true ] )
73 73
 		);
74 74
 		array_walk( $types, function( $args, $type ) {
75
-			register_post_type( $type, array_diff_key( $args, array_flip( static::CUSTOM_KEYS )));
75
+			register_post_type( $type, array_diff_key( $args, array_flip( static::CUSTOM_KEYS ) ) );
76 76
 		});
77 77
 	}
78 78
 
@@ -95,8 +95,8 @@  discard block
 block discarded – undo
95 95
 	protected function normalize()
96 96
 	{
97 97
 		$this->setColumns();
98
-		foreach( $this->app->config['post_types'] as $type => $args ) {
99
-			$this->types[$type] = apply_filters( 'pollux/post_type/args',
98
+		foreach( $this->app->config[ 'post_types' ] as $type => $args ) {
99
+			$this->types[ $type ] = apply_filters( 'pollux/post_type/args',
100 100
 				$this->normalizeThis( $args, static::POST_TYPE_DEFAULTS, $type ),
101 101
 				$type
102 102
 			);
@@ -109,8 +109,8 @@  discard block
 block discarded – undo
109 109
 	protected function normalizeColumns( array $columns )
110 110
 	{
111 111
 		$columns = array_flip( $columns );
112
-		$columns = array_merge( $columns, array_intersect_key( $this->columns, $columns ));
113
-		return ['cb' => '<input type="checkbox">'] + $columns;
112
+		$columns = array_merge( $columns, array_intersect_key( $this->columns, $columns ) );
113
+		return [ 'cb' => '<input type="checkbox">' ] + $columns;
114 114
 	}
115 115
 
116 116
 	/**
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 	 */
120 120
 	protected function normalizeLabels( $labels, array $args )
121 121
 	{
122
-		return wp_parse_args( $labels, $this->setLabels( $args ));
122
+		return wp_parse_args( $labels, $this->setLabels( $args ) );
123 123
 	}
124 124
 
125 125
 	/**
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	protected function normalizeMenuName( $menuname, array $args )
130 130
 	{
131 131
 		return empty( $menuname )
132
-			? $args['plural']
132
+			? $args[ 'plural' ]
133 133
 			: $menuname;
134 134
 	}
135 135
 
@@ -140,10 +140,10 @@  discard block
 block discarded – undo
140 140
 	protected function normalizeRewrite( $rewrite, array $args )
141 141
 	{
142 142
 		if( $rewrite === true ) {
143
-			$slug = empty( $args['slug'] )
144
-				? sanitize_title( $args['plural'] )
145
-				: $args['slug'];
146
-			$rewrite = ['slug' => $slug, 'with_front' => false];
143
+			$slug = empty( $args[ 'slug' ] )
144
+				? sanitize_title( $args[ 'plural' ] )
145
+				: $args[ 'slug' ];
146
+			$rewrite = [ 'slug' => $slug, 'with_front' => false ];
147 147
 		}
148 148
 		return $rewrite;
149 149
 	}
@@ -155,10 +155,10 @@  discard block
 block discarded – undo
155 155
 	protected function getColumnImage( $postId )
156 156
 	{
157 157
 		if( has_post_thumbnail( $postId ) ) {
158
-			list( $src, $width, $height ) = wp_get_attachment_image_src( get_post_thumbnail_id( $postId ), [96, 48] );
158
+			list( $src, $width, $height ) = wp_get_attachment_image_src( get_post_thumbnail_id( $postId ), [ 96, 48 ] );
159 159
 			$image = sprintf( '<img src="%s" alt="%s" width="%s" height="%s">',
160
-				esc_url( set_url_scheme( $src )),
161
-				esc_attr( get_the_title( $postId )),
160
+				esc_url( set_url_scheme( $src ) ),
161
+				esc_attr( get_the_title( $postId ) ),
162 162
 				$width,
163 163
 				$height
164 164
 			);
@@ -173,10 +173,10 @@  discard block
 block discarded – undo
173 173
 	 */
174 174
 	protected function getColumnMedia()
175 175
 	{
176
-		return count( (new PostMeta)->get( 'media', [
177
-			'fallback' => [],
176
+		return count( ( new PostMeta )->get( 'media', [
177
+			'fallback' => [ ],
178 178
 			'single' => false,
179
-		]));
179
+		] ) );
180 180
 	}
181 181
 
182 182
 	/**
@@ -195,11 +195,11 @@  discard block
 block discarded – undo
195 195
 	{
196 196
 		$comments = sprintf(
197 197
 			'<span class="vers comment-grey-bubble" title="%1$s"><span class="screen-reader-text">%1$s</span></span>',
198
-			$this->app->config['columns']['comments']
198
+			$this->app->config[ 'columns' ][ 'comments' ]
199 199
 		);
200
-		$columns = wp_parse_args( $this->app->config['columns'], [
200
+		$columns = wp_parse_args( $this->app->config[ 'columns' ], [
201 201
 			'comments' => $comments,
202
-		]);
202
+		] );
203 203
 		$this->columns = apply_filters( 'pollux/post_type/columns', $columns );
204 204
 	}
205 205
 
@@ -210,17 +210,17 @@  discard block
 block discarded – undo
210 210
 	{
211 211
 		return apply_filters( 'pollux/post_type/labels', [
212 212
 			'add_new' => __( 'Add New', 'pollux' ),
213
-			'add_new_item' => sprintf( _x( 'Add New %s', 'Add new post', 'pollux' ), $args['single'] ),
214
-			'all_items' => sprintf( _x( 'All %s', 'All posts', 'pollux' ), $args['plural'] ),
215
-			'edit_item' => sprintf( _x( 'Edit %s', 'Edit post', 'pollux' ), $args['single'] ),
216
-			'menu_name' => $this->normalizeMenuName( $args['menu_name'], $args ),
217
-			'name' => $args['plural'],
218
-			'new_item' => sprintf( _x( 'New %s', 'New post', 'pollux' ), $args['single'] ),
219
-			'not_found' => sprintf( _x( 'No %s found', 'No posts found', 'pollux' ), $args['plural'] ),
220
-			'not_found_in_trash' => sprintf( _x( 'No %s found in Trash', 'No posts found in trash', 'pollux' ), $args['plural'] ),
221
-			'search_items' => sprintf( _x( 'Search %s', 'Search posts', 'pollux' ), $args['plural'] ),
222
-			'singular_name' => $args['single'],
223
-			'view_item' => sprintf( _x( 'View %s', 'View post', 'pollux' ), $args['single'] ),
213
+			'add_new_item' => sprintf( _x( 'Add New %s', 'Add new post', 'pollux' ), $args[ 'single' ] ),
214
+			'all_items' => sprintf( _x( 'All %s', 'All posts', 'pollux' ), $args[ 'plural' ] ),
215
+			'edit_item' => sprintf( _x( 'Edit %s', 'Edit post', 'pollux' ), $args[ 'single' ] ),
216
+			'menu_name' => $this->normalizeMenuName( $args[ 'menu_name' ], $args ),
217
+			'name' => $args[ 'plural' ],
218
+			'new_item' => sprintf( _x( 'New %s', 'New post', 'pollux' ), $args[ 'single' ] ),
219
+			'not_found' => sprintf( _x( 'No %s found', 'No posts found', 'pollux' ), $args[ 'plural' ] ),
220
+			'not_found_in_trash' => sprintf( _x( 'No %s found in Trash', 'No posts found in trash', 'pollux' ), $args[ 'plural' ] ),
221
+			'search_items' => sprintf( _x( 'Search %s', 'Search posts', 'pollux' ), $args[ 'plural' ] ),
222
+			'singular_name' => $args[ 'single' ],
223
+			'view_item' => sprintf( _x( 'View %s', 'View post', 'pollux' ), $args[ 'single' ] ),
224 224
 		], $args );
225 225
 	}
226 226
 }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,8 @@  discard block
 block discarded – undo
54 54
 
55 55
 		foreach( $this->types as $type => $args ) {
56 56
 			add_action( "manage_{$type}_posts_custom_column", [$this, 'printColumnValue'], 10, 2 );
57
-			add_filter( "manage_{$type}_posts_columns", function( $columns ) use( $args ) {
57
+			add_filter( "manage_{$type}_posts_columns", function( $columns ) use( $args )
58
+			{
58 59
 				return count( $args['columns'] ) > 1
59 60
 					? $args['columns']
60 61
 					: $columns;
@@ -71,7 +72,8 @@  discard block
 block discarded – undo
71 72
 			$this->types,
72 73
 			get_post_types( ['_builtin' => true] )
73 74
 		);
74
-		array_walk( $types, function( $args, $type ) {
75
+		array_walk( $types, function( $args, $type )
76
+		{
75 77
 			register_post_type( $type, array_diff_key( $args, array_flip( static::CUSTOM_KEYS )));
76 78
 		});
77 79
 	}
Please login to merge, or discard this patch.
src/SettingsMetaBox.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -14,11 +14,11 @@  discard block
 block discarded – undo
14 14
 		parent::__construct( $metabox );
15 15
 		$this->meta_box = static::normalize( $this->meta_box );
16 16
 
17
-		remove_action( 'add_meta_boxes', [$this, 'add_meta_boxes'] );
18
-		remove_action( 'save_post_post', [$this, 'save_post'] );
17
+		remove_action( 'add_meta_boxes', [ $this, 'add_meta_boxes' ] );
18
+		remove_action( 'save_post_post', [ $this, 'save_post' ] );
19 19
 
20
-		add_filter( 'rwmb_field_meta',      [$this, '_get_field_meta'], 10, 3 );
21
-		add_action( 'pollux/settings/init', [$this, 'add_meta_boxes'] );
20
+		add_filter( 'rwmb_field_meta', [ $this, '_get_field_meta' ], 10, 3 );
21
+		add_action( 'pollux/settings/init', [ $this, 'add_meta_boxes' ] );
22 22
 	}
23 23
 
24 24
 	/**
@@ -28,13 +28,13 @@  discard block
 block discarded – undo
28 28
 	 */
29 29
 	public function _get_field_meta( $meta, array $field, $saved )
30 30
 	{
31
-		if( !$this->is_edit_screen() || !empty( $meta ) || empty( $field['slug'] )) {
31
+		if( !$this->is_edit_screen() || !empty( $meta ) || empty( $field[ 'slug' ] ) ) {
32 32
 			return $meta;
33 33
 		}
34
-		$meta = call_user_func( [RWMB_Field::get_class_name( $field ), 'esc_meta'], ( $saved
35
-			? (new SiteMeta)->get( $this->meta_box['slug'], $field['slug'], $meta )
36
-			: $field['std']
37
-		));
34
+		$meta = call_user_func( [ RWMB_Field::get_class_name( $field ), 'esc_meta' ], ( $saved
35
+			? ( new SiteMeta )->get( $this->meta_box[ 'slug' ], $field[ 'slug' ], $meta )
36
+			: $field[ 'std' ]
37
+		) );
38 38
 		return $this->_normalize_field_meta( $meta, $field );
39 39
 	}
40 40
 
@@ -44,14 +44,14 @@  discard block
 block discarded – undo
44 44
 	 */
45 45
 	public function _normalize_field_meta( $meta, array $field )
46 46
 	{
47
-		if( !empty( $meta ) && is_array( $meta )) {
47
+		if( !empty( $meta ) && is_array( $meta ) ) {
48 48
 			return $meta;
49 49
 		}
50
-		if( $field['clone'] ) {
51
-			return [''];
50
+		if( $field[ 'clone' ] ) {
51
+			return [ '' ];
52 52
 		}
53
-		if( $field['multiple'] ) {
54
-			return [];
53
+		if( $field[ 'multiple' ] ) {
54
+			return [ ];
55 55
 		}
56 56
 		return $meta;
57 57
 	}
@@ -62,12 +62,12 @@  discard block
 block discarded – undo
62 62
 	public function add_meta_boxes()
63 63
 	{
64 64
 		add_meta_box(
65
-			$this->meta_box['id'],
66
-			$this->meta_box['title'],
67
-			[$this, 'show'],
65
+			$this->meta_box[ 'id' ],
66
+			$this->meta_box[ 'title' ],
67
+			[ $this, 'show' ],
68 68
 			null,
69
-			$this->meta_box['context'],
70
-			$this->meta_box['priority']
69
+			$this->meta_box[ 'context' ],
70
+			$this->meta_box[ 'priority' ]
71 71
 		);
72 72
 	}
73 73
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	public function is_saved()
86 86
 	{
87 87
 		foreach( array_column( $this->fields, 'slug' ) as $field ) {
88
-			if( !is_null( (new SiteMeta)->get( $this->meta_box['slug'], $field, null ))) {
88
+			if( !is_null( ( new SiteMeta )->get( $this->meta_box[ 'slug' ], $field, null ) ) ) {
89 89
 				return true;
90 90
 			}
91 91
 		}
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 */
99 99
 	public static function normalize( $metabox )
100 100
 	{
101
-		unset( $metabox['post_types'] );
102
-		return wp_parse_args( $metabox, ['slug' => ''] );
101
+		unset( $metabox[ 'post_types' ] );
102
+		return wp_parse_args( $metabox, [ 'slug' => '' ] );
103 103
 	}
104 104
 }
Please login to merge, or discard this patch.
src/MetaBox.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -26,16 +26,16 @@  discard block
 block discarded – undo
26 26
 	{
27 27
 		$this->normalize();
28 28
 
29
-		add_filter( 'rwmb_show',       [$this, 'isVisible'], 10, 2 );
30
-		add_action( 'rwmb_meta_boxes', [$this, 'register'] );
29
+		add_filter( 'rwmb_show', [ $this, 'isVisible' ], 10, 2 );
30
+		add_action( 'rwmb_meta_boxes', [ $this, 'register' ] );
31 31
 	}
32 32
 
33 33
 	/**
34 34
 	 * @return array
35 35
 	 */
36
-	public function register( $metaboxes = [] )
36
+	public function register( $metaboxes = [ ] )
37 37
 	{
38
-		if( current_user_can( 'switch_themes' )) {
38
+		if( current_user_can( 'switch_themes' ) ) {
39 39
 			$this->addInstructions();
40 40
 		}
41 41
 		return array_merge( $metaboxes, $this->metaboxes );
@@ -47,11 +47,11 @@  discard block
 block discarded – undo
47 47
 	public function isVisible( $bool, array $metabox )
48 48
 	{
49 49
 		if( defined( 'DOING_AJAX' )
50
-			|| !isset( $metabox['condition'] )
51
-			|| !$this->hasPostType( $metabox )) {
50
+			|| !isset( $metabox[ 'condition' ] )
51
+			|| !$this->hasPostType( $metabox ) ) {
52 52
 			return $bool;
53 53
 		}
54
-		return $this->verifyMetaBoxCondition( $metabox['condition'] );
54
+		return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] );
55 55
 	}
56 56
 
57 57
 	/**
@@ -72,18 +72,18 @@  discard block
 block discarded – undo
72 72
 	{
73 73
 		if( !count( array_filter( $this->metaboxes, function( $metabox ) {
74 74
 			return $this->isVisible( false, $metabox );
75
-		})))return;
76
-		$this->metaboxes[] = [
75
+		}) ) )return;
76
+		$this->metaboxes[ ] = [
77 77
 			'id' => 'infodiv',
78 78
 			'post_types' => $this->getPostTypes(),
79 79
 			'title' => __( 'How to use in your theme', 'pollux' ),
80 80
 			'context' => 'side',
81 81
 			'priority' => 'low',
82
-			'fields' => [[
82
+			'fields' => [ [
83 83
 				'slug' => '',
84 84
 				'std' => $this->generateInstructions(),
85 85
 				'type' => 'custom_html',
86
-			]],
86
+			] ],
87 87
 		];
88 88
 	}
89 89
 
@@ -93,12 +93,12 @@  discard block
 block discarded – undo
93 93
 	protected function generateInstructions()
94 94
 	{
95 95
 		return array_reduce( $this->getInstructions(), function( $html, $metabox ) {
96
-			$fields = array_reduce( array_column( $metabox['fields'], 'slug' ), function( $html, $slug ) use( $metabox ) {
96
+			$fields = array_reduce( array_column( $metabox[ 'fields' ], 'slug' ), function( $html, $slug ) use( $metabox ) {
97 97
 				$hook = sprintf( 'pollux/%s/instruction', $this->getClassname() );
98
-				return $html . apply_filters( $hook, "PostMeta::get('{$slug}');", $slug, $metabox['slug'] ) . PHP_EOL;
98
+				return $html . apply_filters( $hook, "PostMeta::get('{$slug}');", $slug, $metabox[ 'slug' ] ) . PHP_EOL;
99 99
 			});
100 100
 			return $html . sprintf( '<p><strong>%s</strong></p><pre class="my-sites nav-tab-active misc-pub-section">%s</pre>',
101
-				$metabox['title'],
101
+				$metabox[ 'title' ],
102 102
 				$fields
103 103
 			);
104 104
 		});
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 	protected function getInstructions()
111 111
 	{
112 112
 		return array_filter( $this->metaboxes, function( $metabox ) {
113
-			return $this->verifyMetaBoxCondition( $metabox['condition'] )
113
+			return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] )
114 114
 				&& $this->hasPostType( $metabox );
115 115
 		});
116 116
 	}
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	 */
121 121
 	protected function getPostId()
122 122
 	{
123
-		if( !( $postId = filter_input( INPUT_GET, 'post' ))) {
123
+		if( !( $postId = filter_input( INPUT_GET, 'post' ) ) ) {
124 124
 			$postId = filter_input( INPUT_POST, 'post_ID' );
125 125
 		}
126 126
 		return intval( $postId );
@@ -133,10 +133,10 @@  discard block
 block discarded – undo
133 133
 	{
134 134
 		return array_unique( iterator_to_array(
135 135
 			new RecursiveIteratorIterator(
136
-				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ))
136
+				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ) )
137 137
 			),
138 138
 			false
139
-		));
139
+		) );
140 140
 	}
141 141
 
142 142
 	/**
@@ -144,10 +144,10 @@  discard block
 block discarded – undo
144 144
 	 */
145 145
 	protected function hasPostType( array $metabox )
146 146
 	{
147
-		if( !isset( $metabox['post_types'] )) {
147
+		if( !isset( $metabox[ 'post_types' ] ) ) {
148 148
 			return true;
149 149
 		}
150
-		return in_array( get_post_type( $this->getPostId() ), $metabox['post_types'] );
150
+		return in_array( get_post_type( $this->getPostId() ), $metabox[ 'post_types' ] );
151 151
 	}
152 152
 
153 153
 	/**
@@ -155,16 +155,16 @@  discard block
 block discarded – undo
155 155
 	 */
156 156
 	protected function normalize()
157 157
 	{
158
-		$this->metaboxes = [];
159
-		foreach( $this->app->config['meta_boxes'] as $id => $metabox ) {
158
+		$this->metaboxes = [ ];
159
+		foreach( $this->app->config[ 'meta_boxes' ] as $id => $metabox ) {
160 160
 			$defaults = [
161
-				'condition' => [],
162
-				'fields' => [],
161
+				'condition' => [ ],
162
+				'fields' => [ ],
163 163
 				'id' => $id,
164
-				'post_types' => [],
164
+				'post_types' => [ ],
165 165
 				'slug' => $id,
166 166
 			];
167
-			$this->metaboxes[] = $this->normalizeThis( $metabox, $defaults, $id );
167
+			$this->metaboxes[ ] = $this->normalizeThis( $metabox, $defaults, $id );
168 168
 		}
169 169
 	}
170 170
 
@@ -175,9 +175,9 @@  discard block
 block discarded – undo
175 175
 	protected function normalizeCondition( $conditions )
176 176
 	{
177 177
 		$conditions = $this->toArray( $conditions );
178
-		if( count( array_filter( array_keys( $conditions ), 'is_string' )) == 0 ) {
178
+		if( count( array_filter( array_keys( $conditions ), 'is_string' ) ) == 0 ) {
179 179
 			foreach( $conditions as $key ) {
180
-				$conditions[str_replace( '!', '', $key )] = substr( $key, 0, 1 ) == '!' ? 0 : 1;
180
+				$conditions[ str_replace( '!', '', $key ) ] = substr( $key, 0, 1 ) == '!' ? 0 : 1;
181 181
 			}
182 182
 			$conditions = array_filter( $conditions, function( $key ) {
183 183
 				return !is_numeric( $key );
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 		$hook = sprintf( 'pollux/%s/conditions', $this->getClassname() );
187 187
 		return array_intersect_key(
188 188
 			$conditions,
189
-			array_flip( apply_filters( $hook, static::CONDITIONS ))
189
+			array_flip( apply_filters( $hook, static::CONDITIONS ) )
190 190
 		);
191 191
 	}
192 192
 
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 	protected function normalizeFields( array $fields, array $data, $parentId )
197 197
 	{
198 198
 		return array_map( function( $id, $field ) use( $parentId ) {
199
-			$defaults =  [
199
+			$defaults = [
200 200
 				'id' => $id,
201 201
 				'field_name' => '',
202 202
 				'slug' => $id,
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 	 */
242 242
 	protected function validateIsFrontPage( $value )
243 243
 	{
244
-		return $value == ( $this->getPostId() == get_option( 'page_on_front' ));
244
+		return $value == ( $this->getPostId() == get_option( 'page_on_front' ) );
245 245
 	}
246 246
 
247 247
 	/**
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 	 */
251 251
 	protected function validateIsHome( $value )
252 252
 	{
253
-		return $value == ( $this->getPostId() == get_option( 'page_for_posts' ));
253
+		return $value == ( $this->getPostId() == get_option( 'page_for_posts' ) );
254 254
 	}
255 255
 
256 256
 	/**
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 	 */
260 260
 	protected function validateIsPageTemplate( $value )
261 261
 	{
262
-		return basename( get_page_template_slug( $this->getPostId() )) == $value;
262
+		return basename( get_page_template_slug( $this->getPostId() ) ) == $value;
263 263
 	}
264 264
 
265 265
 	/**
Please login to merge, or discard this patch.
src/Taxonomy.php 2 patches
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -13,10 +13,10 @@  discard block
 block discarded – undo
13 13
 
14 14
 	const TAXONOMY_DEFAULTS = [
15 15
 		'hierarchical'      => true,
16
-		'labels'            => [],
16
+		'labels'            => [ ],
17 17
 		'menu_name'         => '',
18 18
 		'plural'            => '',
19
-		'post_types'        => [],
19
+		'post_types'        => [ ],
20 20
 		'public'            => true,
21 21
 		'rewrite'           => true,
22 22
 		'show_admin_column' => true,
@@ -36,9 +36,9 @@  discard block
 block discarded – undo
36 36
 	{
37 37
 		$this->normalize();
38 38
 
39
-		add_filter( 'parse_query',           [ $this, 'filterBy'] );
40
-		add_action( 'restrict_manage_posts', [ $this, 'printFilters'] );
41
-		add_action( 'init',                  [ $this, 'register'] );
39
+		add_filter( 'parse_query', [ $this, 'filterBy' ] );
40
+		add_action( 'restrict_manage_posts', [ $this, 'printFilters' ] );
41
+		add_action( 'init', [ $this, 'register' ] );
42 42
 	}
43 43
 
44 44
 	/**
@@ -49,9 +49,9 @@  discard block
 block discarded – undo
49 49
 		if( !is_admin() || get_current_screen()->base != 'edit' )return;
50 50
 		$vars = &$query->query_vars;
51 51
 		foreach( array_keys( $this->taxonomies ) as $taxonomy ) {
52
-			if( !isset( $vars[$taxonomy] ))return;
53
-			if( $term = get_term_by( 'id', $vars[$taxonomy], $taxonomy )) {
54
-				$vars[$taxonomy] = $term->slug;
52
+			if( !isset( $vars[ $taxonomy ] ) )return;
53
+			if( $term = get_term_by( 'id', $vars[ $taxonomy ], $taxonomy ) ) {
54
+				$vars[ $taxonomy ] = $term->slug;
55 55
 			}
56 56
 		}
57 57
 		return $query;
@@ -64,18 +64,18 @@  discard block
 block discarded – undo
64 64
 	{
65 65
 		global $wp_query;
66 66
 		foreach( $this->taxonomies as $taxonomy => $args ) {
67
-			if( !in_array( get_current_screen()->post_type, $args['post_types'] ))continue;
68
-			$selected = isset( $wp_query->query[$taxonomy] )
69
-				? $wp_query->query[$taxonomy]
67
+			if( !in_array( get_current_screen()->post_type, $args[ 'post_types' ] ) )continue;
68
+			$selected = isset( $wp_query->query[ $taxonomy ] )
69
+				? $wp_query->query[ $taxonomy ]
70 70
 				: false;
71
-			wp_dropdown_categories([
71
+			wp_dropdown_categories( [
72 72
 				'hide_if_empty' => true,
73 73
 				'name' => $taxonomy,
74 74
 				'orderby' => 'name',
75 75
 				'selected' => $selected,
76
-				'show_option_all' => $args['labels']['all_items'],
76
+				'show_option_all' => $args[ 'labels' ][ 'all_items' ],
77 77
 				'taxonomy' => $taxonomy,
78
-			]);
78
+			] );
79 79
 		}
80 80
 	}
81 81
 
@@ -85,8 +85,8 @@  discard block
 block discarded – undo
85 85
 	public function register()
86 86
 	{
87 87
 		array_walk( $this->taxonomies, function( $args, $taxonomy ) {
88
-			register_taxonomy( $taxonomy, $args['post_types'], array_diff_key( $args, array_flip( static::CUSTOM_KEYS )));
89
-			foreach( $args['post_types'] as $type ) {
88
+			register_taxonomy( $taxonomy, $args[ 'post_types' ], array_diff_key( $args, array_flip( static::CUSTOM_KEYS ) ) );
89
+			foreach( $args[ 'post_types' ] as $type ) {
90 90
 				register_taxonomy_for_object_type( $taxonomy, $type );
91 91
 			}
92 92
 		});
@@ -97,14 +97,14 @@  discard block
 block discarded – undo
97 97
 	 */
98 98
 	protected function normalize()
99 99
 	{
100
-		foreach( $this->app->config['taxonomies'] as $taxonomy => $args ) {
101
-			$this->taxonomies[$taxonomy] = apply_filters( 'pollux/taxonomy/args',
100
+		foreach( $this->app->config[ 'taxonomies' ] as $taxonomy => $args ) {
101
+			$this->taxonomies[ $taxonomy ] = apply_filters( 'pollux/taxonomy/args',
102 102
 				$this->normalizeThis( $args, static::TAXONOMY_DEFAULTS, $taxonomy )
103 103
 			);
104 104
 		}
105 105
 		$this->taxonomies = array_diff_key(
106 106
 			$this->taxonomies,
107
-			get_taxonomies( ['_builtin' => true] )
107
+			get_taxonomies( [ '_builtin' => true ] )
108 108
 		);
109 109
 	}
110 110
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 	 */
115 115
 	protected function normalizeLabels( $labels, array $args )
116 116
 	{
117
-		return wp_parse_args( $labels, $this->setLabels( $args ));
117
+		return wp_parse_args( $labels, $this->setLabels( $args ) );
118 118
 	}
119 119
 
120 120
 	/**
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 	protected function normalizeMenuName( $menuname, array $args )
125 125
 	{
126 126
 		return empty( $menuname )
127
-			? $args['plural']
127
+			? $args[ 'plural' ]
128 128
 			: $menuname;
129 129
 	}
130 130
 
@@ -143,17 +143,17 @@  discard block
 block discarded – undo
143 143
 	protected function setLabels( array $args )
144 144
 	{
145 145
 		return apply_filters( 'pollux/taxonomy/labels', [
146
-			'add_new_item' => sprintf( _x( 'Add New %s', 'Add new taxonomy', 'pollux' ), $args['single'] ),
147
-			'all_items' => sprintf( _x( 'All %s', 'All taxonomies', 'pollux' ), $args['plural'] ),
148
-			'edit_item' => sprintf( _x( 'Edit %s', 'Edit taxonomy', 'pollux' ), $args['single'] ),
149
-			'menu_name' => $this->normalizeMenuName( $args['menu_name'], $args ),
150
-			'name' => $args['plural'],
151
-			'new_item_name' => sprintf( _x( 'New %s Name', 'New taxonomy name', 'pollux' ), $args['single'] ),
152
-			'not_found' => sprintf( _x( 'No %s found', 'No taxonomies found', 'pollux' ), $args['plural'] ),
153
-			'search_items' => sprintf( _x( 'Search %s', 'Search taxonomies', 'pollux' ), $args['plural'] ),
154
-			'singular_name' => $args['single'],
155
-			'update_item' => sprintf( _x( 'Update %s', 'Update taxonomy', 'pollux' ), $args['single'] ),
156
-			'view_item' => sprintf( _x( 'View %s', 'View taxonomy', 'pollux' ), $args['single'] ),
146
+			'add_new_item' => sprintf( _x( 'Add New %s', 'Add new taxonomy', 'pollux' ), $args[ 'single' ] ),
147
+			'all_items' => sprintf( _x( 'All %s', 'All taxonomies', 'pollux' ), $args[ 'plural' ] ),
148
+			'edit_item' => sprintf( _x( 'Edit %s', 'Edit taxonomy', 'pollux' ), $args[ 'single' ] ),
149
+			'menu_name' => $this->normalizeMenuName( $args[ 'menu_name' ], $args ),
150
+			'name' => $args[ 'plural' ],
151
+			'new_item_name' => sprintf( _x( 'New %s Name', 'New taxonomy name', 'pollux' ), $args[ 'single' ] ),
152
+			'not_found' => sprintf( _x( 'No %s found', 'No taxonomies found', 'pollux' ), $args[ 'plural' ] ),
153
+			'search_items' => sprintf( _x( 'Search %s', 'Search taxonomies', 'pollux' ), $args[ 'plural' ] ),
154
+			'singular_name' => $args[ 'single' ],
155
+			'update_item' => sprintf( _x( 'Update %s', 'Update taxonomy', 'pollux' ), $args[ 'single' ] ),
156
+			'view_item' => sprintf( _x( 'View %s', 'View taxonomy', 'pollux' ), $args[ 'single' ] ),
157 157
 		], $args );
158 158
 	}
159 159
 }
Please login to merge, or discard this patch.
Braces   +11 added lines, -4 removed lines patch added patch discarded remove patch
@@ -46,10 +46,14 @@  discard block
 block discarded – undo
46 46
 	 */
47 47
 	public function filterBy( WP_Query $query )
48 48
 	{
49
-		if( !is_admin() || get_current_screen()->base != 'edit' )return;
49
+		if( !is_admin() || get_current_screen()->base != 'edit' ) {
50
+			return;
51
+		}
50 52
 		$vars = &$query->query_vars;
51 53
 		foreach( array_keys( $this->taxonomies ) as $taxonomy ) {
52
-			if( !isset( $vars[$taxonomy] ))return;
54
+			if( !isset( $vars[$taxonomy] )) {
55
+				return;
56
+			}
53 57
 			if( $term = get_term_by( 'id', $vars[$taxonomy], $taxonomy )) {
54 58
 				$vars[$taxonomy] = $term->slug;
55 59
 			}
@@ -64,7 +68,9 @@  discard block
 block discarded – undo
64 68
 	{
65 69
 		global $wp_query;
66 70
 		foreach( $this->taxonomies as $taxonomy => $args ) {
67
-			if( !in_array( get_current_screen()->post_type, $args['post_types'] ))continue;
71
+			if( !in_array( get_current_screen()->post_type, $args['post_types'] )) {
72
+				continue;
73
+			}
68 74
 			$selected = isset( $wp_query->query[$taxonomy] )
69 75
 				? $wp_query->query[$taxonomy]
70 76
 				: false;
@@ -84,7 +90,8 @@  discard block
 block discarded – undo
84 90
 	 */
85 91
 	public function register()
86 92
 	{
87
-		array_walk( $this->taxonomies, function( $args, $taxonomy ) {
93
+		array_walk( $this->taxonomies, function( $args, $taxonomy )
94
+		{
88 95
 			register_taxonomy( $taxonomy, $args['post_types'], array_diff_key( $args, array_flip( static::CUSTOM_KEYS )));
89 96
 			foreach( $args['post_types'] as $type ) {
90 97
 				register_taxonomy_for_object_type( $taxonomy, $type );
Please login to merge, or discard this patch.
src/Settings.php 2 patches
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -28,18 +28,18 @@  discard block
 block discarded – undo
28 28
 	public function init()
29 29
 	{
30 30
 		// @todo: run GateKeeper here instead to check dependencies and capability
31
-		if( !is_plugin_active( 'meta-box/meta-box.php' ))return;
31
+		if( !is_plugin_active( 'meta-box/meta-box.php' ) )return;
32 32
 
33 33
 		$this->normalize();
34 34
 
35
-		add_action( 'admin_menu',                             [$this, 'addPage'] );
36
-		add_action( 'pollux/settings/init',                   [$this, 'addSubmitMetaBox'] );
37
-		add_filter( 'pollux/settings/instruction',            [$this, 'filterInstruction'], 10, 3 );
38
-		add_filter( 'wp_redirect',                            [$this, 'filterRedirectOnSave'] );
39
-		add_action( 'current_screen',                         [$this, 'register'] );
40
-		add_action( 'admin_menu',                             [$this, 'registerSetting'] );
41
-		add_action( 'pollux/settings/init',                   [$this, 'reset'] );
42
-		add_action( 'admin_footer-toplevel_page_' . static::ID, [$this, 'renderFooterScript'] );
35
+		add_action( 'admin_menu', [ $this, 'addPage' ] );
36
+		add_action( 'pollux/settings/init', [ $this, 'addSubmitMetaBox' ] );
37
+		add_filter( 'pollux/settings/instruction', [ $this, 'filterInstruction' ], 10, 3 );
38
+		add_filter( 'wp_redirect', [ $this, 'filterRedirectOnSave' ] );
39
+		add_action( 'current_screen', [ $this, 'register' ] );
40
+		add_action( 'admin_menu', [ $this, 'registerSetting' ] );
41
+		add_action( 'pollux/settings/init', [ $this, 'reset' ] );
42
+		add_action( 'admin_footer-toplevel_page_' . static::ID, [ $this, 'renderFooterScript' ] );
43 43
 	}
44 44
 
45 45
 	/**
@@ -52,10 +52,10 @@  discard block
 block discarded – undo
52 52
 			__( 'Site Settings', 'pollux' ),
53 53
 			'edit_theme_options',
54 54
 			static::ID,
55
-			[$this, 'renderPage'],
55
+			[ $this, 'renderPage' ],
56 56
 			'dashicons-screenoptions',
57 57
 			1313
58
-		]));
58
+		] ) );
59 59
 	}
60 60
 
61 61
 	/**
@@ -66,11 +66,11 @@  discard block
 block discarded – undo
66 66
 		call_user_func_array( 'add_meta_box', apply_filters( 'pollux/settings/metabox/submit', [
67 67
 			'submitdiv',
68 68
 			__( 'Save Settings', 'pollux' ),
69
-			[ $this, 'renderSubmitMetaBox'],
69
+			[ $this, 'renderSubmitMetaBox' ],
70 70
 			$this->hook,
71 71
 			'side',
72 72
 			'high',
73
-		]));
73
+		] ) );
74 74
 	}
75 75
 
76 76
 	/**
@@ -91,19 +91,19 @@  discard block
 block discarded – undo
91 91
 	public function filterRedirectOnSave( $location )
92 92
 	{
93 93
 		if( strpos( $location, 'settings-updated=true' ) === false
94
-			|| strpos( $location, sprintf( 'page=%s', static::ID )) === false ) {
94
+			|| strpos( $location, sprintf( 'page=%s', static::ID ) ) === false ) {
95 95
 			return $location;
96 96
 		}
97
-		return add_query_arg([
97
+		return add_query_arg( [
98 98
 			'page' => static::ID,
99 99
 			'settings-updated' => 'true',
100
-		], admin_url( 'admin.php' ));
100
+		], admin_url( 'admin.php' ) );
101 101
 	}
102 102
 
103 103
 	/**
104 104
 	 * @return void
105 105
 	 */
106
-	public function register( $metaboxes = [] )
106
+	public function register( $metaboxes = [ ] )
107 107
 	{
108 108
 		if( get_current_screen()->id != $this->hook )return;
109 109
 		foreach( parent::register() as $metabox ) {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 		add_screen_option( 'layout_columns', [
113 113
 			'max' => 2,
114 114
 			'default' => 2,
115
-		]);
115
+		] );
116 116
 		do_action( 'pollux/settings/init' );
117 117
 	}
118 118
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 */
122 122
 	public function registerSetting()
123 123
 	{
124
-		register_setting( static::ID, static::ID, [$this, 'onSave'] );
124
+		register_setting( static::ID, static::ID, [ $this, 'onSave' ] );
125 125
 	}
126 126
 
127 127
 	public function onSave( $settings )
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 			'confirm' => __( 'Are you sure want to do this?', 'pollux' ),
140 140
 			'hook' => $this->hook,
141 141
 			'id' => static::ID,
142
-		]);
142
+		] );
143 143
 	}
144 144
 
145 145
 	/**
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 			'columns' => get_current_screen()->get_columns(),
152 152
 			'id' => static::ID,
153 153
 			'title' => __( 'Site Settings', 'pollux' ),
154
-		]);
154
+		] );
155 155
 	}
156 156
 
157 157
 	/**
@@ -166,9 +166,9 @@  discard block
 block discarded – undo
166 166
 		];
167 167
 		$this->render( 'settings/submit', [
168 168
 			'reset' => __( 'Reset Settings', 'pollux' ),
169
-			'reset_url' => esc_url( add_query_arg( $query, admin_url( 'admin.php' ))),
169
+			'reset_url' => esc_url( add_query_arg( $query, admin_url( 'admin.php' ) ) ),
170 170
 			'submit' => get_submit_button( __( 'Save', 'pollux' ), 'primary', 'submit', false ),
171
-		]);
171
+		] );
172 172
 	}
173 173
 
174 174
 	/**
@@ -179,12 +179,12 @@  discard block
 block discarded – undo
179 179
 		if( filter_input( INPUT_GET, 'page' ) !== static::ID
180 180
 			|| filter_input( INPUT_GET, 'action' ) !== 'reset'
181 181
 		)return;
182
-		if( wp_verify_nonce( filter_input( INPUT_GET, '_wpnonce' ), $this->hook )) {
182
+		if( wp_verify_nonce( filter_input( INPUT_GET, '_wpnonce' ), $this->hook ) ) {
183 183
 			delete_option( static::ID );
184 184
 			// @todo: now trigger save to restore defaults
185 185
 			return add_settings_error( static::ID, 'reset', __( 'Settings reset to defaults.', 'pollux' ), 'updated' );
186 186
 		}
187
-		add_settings_error( static::ID, 'reset', __( 'Failed to reset settings. Please refresh the page and try again.', 'pollux' ));
187
+		add_settings_error( static::ID, 'reset', __( 'Failed to reset settings. Please refresh the page and try again.', 'pollux' ) );
188 188
 	}
189 189
 
190 190
 	/**
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 	protected function getInstructions()
194 194
 	{
195 195
 		return array_filter( $this->metaboxes, function( $metabox ) {
196
-			return $this->verifyMetaBoxCondition( $metabox['condition'] );
196
+			return $this->verifyMetaBoxCondition( $metabox[ 'condition' ] );
197 197
 		});
198 198
 	}
199 199
 
@@ -202,15 +202,15 @@  discard block
 block discarded – undo
202 202
 	 */
203 203
 	protected function normalize()
204 204
 	{
205
-		$this->metaboxes = [];
206
-		foreach( $this->app->config['settings'] as $id => $metabox ) {
205
+		$this->metaboxes = [ ];
206
+		foreach( $this->app->config[ 'settings' ] as $id => $metabox ) {
207 207
 			$defaults = [
208
-				'condition' => [],
209
-				'fields' => [],
208
+				'condition' => [ ],
209
+				'fields' => [ ],
210 210
 				'id' => $id,
211 211
 				'slug' => $id,
212 212
 			];
213
-			$this->metaboxes[] = $this->normalizeThis( $metabox, $defaults, $id );
213
+			$this->metaboxes[ ] = $this->normalizeThis( $metabox, $defaults, $id );
214 214
 		}
215 215
 	}
216 216
 
@@ -221,10 +221,10 @@  discard block
 block discarded – undo
221 221
 	 */
222 222
 	protected function normalizeFieldName( $name, array $data, $parentId )
223 223
 	{
224
-		if( !empty( $name )) {
224
+		if( !empty( $name ) ) {
225 225
 			return $name;
226 226
 		}
227
-		$name = str_replace( sprintf( '%s-%s-', static::ID, $parentId ), '', $data['id'] );
227
+		$name = str_replace( sprintf( '%s-%s-', static::ID, $parentId ), '', $data[ 'id' ] );
228 228
 		return sprintf( '%s[%s][%s]', static::ID, $parentId, $name );
229 229
 	}
230 230
 
Please login to merge, or discard this patch.
Braces   +11 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,7 +28,9 @@  discard block
 block discarded – undo
28 28
 	public function init()
29 29
 	{
30 30
 		// @todo: run GateKeeper here instead to check dependencies and capability
31
-		if( !is_plugin_active( 'meta-box/meta-box.php' ))return;
31
+		if( !is_plugin_active( 'meta-box/meta-box.php' )) {
32
+			return;
33
+		}
32 34
 
33 35
 		$this->normalize();
34 36
 
@@ -105,7 +107,9 @@  discard block
 block discarded – undo
105 107
 	 */
106 108
 	public function register( $metaboxes = [] )
107 109
 	{
108
-		if( get_current_screen()->id != $this->hook )return;
110
+		if( get_current_screen()->id != $this->hook ) {
111
+			return;
112
+		}
109 113
 		foreach( parent::register() as $metabox ) {
110 114
 			new SettingsMetaBox( $metabox );
111 115
 		}
@@ -178,7 +182,9 @@  discard block
 block discarded – undo
178 182
 	{
179 183
 		if( filter_input( INPUT_GET, 'page' ) !== static::ID
180 184
 			|| filter_input( INPUT_GET, 'action' ) !== 'reset'
181
-		)return;
185
+		) {
186
+			return;
187
+		}
182 188
 		if( wp_verify_nonce( filter_input( INPUT_GET, '_wpnonce' ), $this->hook )) {
183 189
 			delete_option( static::ID );
184 190
 			// @todo: now trigger save to restore defaults
@@ -192,7 +198,8 @@  discard block
 block discarded – undo
192 198
 	 */
193 199
 	protected function getInstructions()
194 200
 	{
195
-		return array_filter( $this->metaboxes, function( $metabox ) {
201
+		return array_filter( $this->metaboxes, function( $metabox )
202
+		{
196 203
 			return $this->verifyMetaBoxCondition( $metabox['condition'] );
197 204
 		});
198 205
 	}
Please login to merge, or discard this patch.