ppi / framework

src/Http/Stream.php

Doc Comments +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
      *
      * After the stream has been detached, the stream is in an unusable state.
      *
-     * @return resource|null
+     * @return resource
      */
     public function detach()
     {

Spacing +16 added lines, -16 removed lines

@@ -67,7 +67,7 @@ 
      */
     public function __toString()
     {
-        if (! $this->isReadable()) {
+        if (!$this->isReadable()) {
             return '';
         }
 
@@ -79,7 +79,7 @@ 
      */
     public function close()
     {
-        if (! $this->resource) {
+        if (!$this->resource) {
             return;
         }
 
@@ -116,8 +116,8 @@ 
     public function attach($resource, $mode = 'r')
     {
         $error = null;
-        if (! is_resource($resource) && is_string($resource)) {
-            set_error_handler(function ($e) use (&$error) {
+        if (!is_resource($resource) && is_string($resource)) {
+            set_error_handler(function($e) use (&$error) {
                 $error = $e;
             }, E_WARNING);
             $resource = fopen($resource, $mode);
@@ -128,7 +128,7 @@ 
             throw new InvalidArgumentException('Invalid stream reference provided');
         }
 
-        if (! is_resource($resource)) {
+        if (!is_resource($resource)) {
             throw new InvalidArgumentException(
                 'Invalid stream provided; must be a string stream identifier or resource'
             );
@@ -160,7 +160,7 @@ 
      */
     public function tell()
     {
-        if (! $this->resource) {
+        if (!$this->resource) {
             return false;
         }
 
@@ -174,7 +174,7 @@ 
      */
     public function eof()
     {
-        if (! $this->resource) {
+        if (!$this->resource) {
             return true;
         }
 
@@ -188,7 +188,7 @@ 
      */
     public function isSeekable()
     {
-        if (! $this->resource) {
+        if (!$this->resource) {
             return false;
         }
 
@@ -214,7 +214,7 @@ 
      */
     public function seek($offset, $whence = SEEK_SET)
     {
-        if (! $this->resource || ! $this->isSeekable()) {
+        if (!$this->resource || !$this->isSeekable()) {
             return false;
         }
 
@@ -230,7 +230,7 @@ 
      */
     public function rewind()
     {
-        if (! $this->isSeekable()) {
+        if (!$this->isSeekable()) {
             return false;
         }
 
@@ -246,7 +246,7 @@ 
      */
     public function isWritable()
     {
-        if (! $this->resource) {
+        if (!$this->resource) {
             return false;
         }
 
@@ -265,7 +265,7 @@ 
      */
     public function write($string)
     {
-        if (! $this->resource) {
+        if (!$this->resource) {
             return false;
         }
 
@@ -279,7 +279,7 @@ 
      */
     public function isReadable()
     {
-        if (! $this->resource) {
+        if (!$this->resource) {
             return false;
         }
 
@@ -302,7 +302,7 @@ 
      */
     public function read($length)
     {
-        if (! $this->resource || ! $this->isReadable()) {
+        if (!$this->resource || !$this->isReadable()) {
             return false;
         }
 
@@ -320,7 +320,7 @@ 
      */
     public function getContents()
     {
-        if (! $this->isReadable()) {
+        if (!$this->isReadable()) {
             return '';
         }
 
@@ -341,7 +341,7 @@ 
         }
 
         $metadata = stream_get_meta_data($this->resource);
-        if (! array_key_exists($key, $metadata)) {
+        if (!array_key_exists($key, $metadata)) {
             return;
         }
 

src/MicroApp.php

Doc Comments +3 added lines

@@ -40,6 +40,9 @@
         $this->add($uri, 'post', $callback);
     }
 
+    /**
+     * @param string $method
+     */
     public function add($uri, $method, $callback)
     {
         $this->routes[md5($uri . $method)] = array(

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Symfony\Component\Routing\Matcher\UrlMatcher as UrlMatcher;
 use Symfony\Component\Routing\Route as Route;
 use Symfony\Component\Routing\RouteCollection;
-use Symfony\Component\Routing\Router;
 
 /**
  * The PPI MicroApp bootstrap class.

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 
     public function add($uri, $method, $callback)
     {
-        $this->routes[md5($uri . $method)] = array(
+        $this->routes[md5($uri.$method)] = array(
             'method'   => $method,
             'uri'      => $uri,
             'callback' => $callback,

src/Module/Controller.php

Doc Comments +1 added lines, -1 removed lines

@@ -458,7 +458,7 @@
      * Get an option from the controller.
      *
      * @param string $option  The option name
-     * @param null   $default The default value if the option does not exist
+     * @param string   $default The default value if the option does not exist
      *
      * @return mixed
      */

Switch Indentation +28 added lines, -28 removed lines

@@ -254,34 +254,34 @@
     {
         switch ($key = strtolower($key)) {
 
-            case 'ajax':
-                if (!isset($this->isCache['ajax'])) {
-                    return $this->isCache['ajax'] = $this->getService('Request')->isXmlHttpRequest();
-                }
-
-                return $this->isCache['ajax'];
-
-            case 'put':
-            case 'delete':
-            case 'post':
-            case 'patch':
-                if (!isset($this->isCache['requestMethod'][$key])) {
-                    $this->isCache['requestMethod'][$key] = $this->getService('Request')->getMethod() === strtoupper($key);
-                }
-
-                return $this->isCache['requestMethod'][$key];
-
-            case 'ssl':
-            case 'https':
-            case 'secure':
-                if (!isset($this->isCache['secure'])) {
-                    $this->isCache['secure'] = $this->getService('Request')->isSecure();
-                }
-
-                return $this->isCache['secure'];
-
-            default:
-                throw new \InvalidArgumentException("Invalid 'is' key supplied: {$key}");
+        case 'ajax':
+            if (!isset($this->isCache['ajax'])) {
+                return $this->isCache['ajax'] = $this->getService('Request')->isXmlHttpRequest();
+            }
+
+            return $this->isCache['ajax'];
+
+        case 'put':
+        case 'delete':
+        case 'post':
+        case 'patch':
+            if (!isset($this->isCache['requestMethod'][$key])) {
+                $this->isCache['requestMethod'][$key] = $this->getService('Request')->getMethod() === strtoupper($key);
+            }
+
+            return $this->isCache['requestMethod'][$key];
+
+        case 'ssl':
+        case 'https':
+        case 'secure':
+            if (!isset($this->isCache['secure'])) {
+                $this->isCache['secure'] = $this->getService('Request')->isSecure();
+            }
+
+            return $this->isCache['secure'];
+
+        default:
+            throw new \InvalidArgumentException("Invalid 'is' key supplied: {$key}");
 
         }
     }

Spacing +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
     protected function helper($helperName)
     {
         if (!isset($this->helpers[$helperName])) {
-            throw new \InvalidArgumentException('Unable to locate controller helper: ' . $helperName);
+            throw new \InvalidArgumentException('Unable to locate controller helper: '.$helperName);
         }
 
         return $this->helpers[$helperName];

src/Router/LaravelRouter.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
     /**
      * Given a request object, find the matching route
      *
-     * @param Request $request
+     * @param SymfonyRequest $request
      * @return \Illuminate\Routing\Route
      */
     public function matchRequest(SymfonyRequest $request)

src/ServiceManager/Config/TemplatingConfig.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 use PPI\Framework\View\TemplateLocator;
 use PPI\Framework\View\TemplateNameParser;
 // Mustache
-use Symfony\Bundle\FrameworkBundle\Templating\Loader\FilesystemLoader;
 use Symfony\Component\Templating\Helper\AssetsHelper;
 // Twig
 

Indentation +1 added lines, -1 removed lines

@@ -113,7 +113,7 @@
                     $serviceManager->get('templating.helper.assets'),
                     new RouterHelper($serviceManager->get('router')),
                     new SessionHelper($serviceManager->get('session'))
-                 )
+                    )
             );
         });
 

Spacing +15 added lines, -15 removed lines

@@ -76,7 +76,7 @@ 
         /*
          * Templating Locator.
          */
-        $serviceManager->setFactory('templating.locator', function ($serviceManager) use ($appCacheDir) {
+        $serviceManager->setFactory('templating.locator', function($serviceManager) use ($appCacheDir) {
             return new TemplateLocator(
                 $serviceManager->get('file_locator'),
                 $appCacheDir
@@ -86,28 +86,28 @@ 
         /*
          * Templating Name Parser.
          */
-        $serviceManager->setFactory('templating.name_parser', function ($serviceManager) {
+        $serviceManager->setFactory('templating.name_parser', function($serviceManager) {
             return new TemplateNameParser($serviceManager->get('modulemanager'));
         });
 
         /*
          * Filesystem Loader.
          */
-        $serviceManager->setFactory('templating.loader.filesystem', function ($serviceManager) {
+        $serviceManager->setFactory('templating.loader.filesystem', function($serviceManager) {
             return new FileSystemLoader($serviceManager->get('templating.locator'));
         });
 
         /*
          * Templating assets helper.
          */
-        $serviceManager->setFactory('templating.helper.assets', function ($serviceManager) {
+        $serviceManager->setFactory('templating.helper.assets', function($serviceManager) {
             return new AssetsHelper($serviceManager->get('request')->getBasePath());
         });
 
         /*
          * Templating globals.
          */
-        $serviceManager->setFactory('templating.globals', function ($serviceManager) {
+        $serviceManager->setFactory('templating.globals', function($serviceManager) {
             return new GlobalVariables($serviceManager->get('servicemanager'));
         });
 
@@ -116,7 +116,7 @@ 
          *
          * TODO: Migrate to Symfony\Bundle\FrameworkBundle\Templating\PhpEngine
          */
-        $serviceManager->setFactory('templating.engine.php', function ($serviceManager) use ($appCharset) {
+        $serviceManager->setFactory('templating.engine.php', function($serviceManager) use ($appCharset) {
             $engine = new PhpEngine(
                 $serviceManager->get('templating.name_parser'),
                 $serviceManager->get('templating.loader'),
@@ -137,7 +137,7 @@ 
         /*
          * Twig Engine
          */
-        $serviceManager->setFactory('templating.engine.twig', function ($serviceManager) {
+        $serviceManager->setFactory('templating.engine.twig', function($serviceManager) {
 
             if (!class_exists('Twig_Environment')) {
                 throw new \Exception('PPI\Framework\TwigModule not found. Composer require: ppi/twig-module');
@@ -160,13 +160,13 @@ 
         /*
          * Smarty Engine.
          */
-        $serviceManager->setFactory('templating.engine.smarty', function ($serviceManager) use ($appCacheDir) {
+        $serviceManager->setFactory('templating.engine.smarty', function($serviceManager) use ($appCacheDir) {
 
             if (!class_exists('NoiseLabs\Bundle\SmartyBundle\SmartyEngine')) {
                 throw new \Exception('PPI\Framework\SmartyModule not found. Composer require: ppi/smarty-module');
             }
 
-            $cacheDir = $appCacheDir . DIRECTORY_SEPARATOR . 'smarty';
+            $cacheDir = $appCacheDir.DIRECTORY_SEPARATOR.'smarty';
 
             $smartyEngine = new \PPI\Framework\View\Smarty\SmartyEngine(
                 new \Smarty(),
@@ -174,8 +174,8 @@ 
                 $serviceManager->get('templating.name_parser'),
                 $serviceManager->get('templating.loader'),
                 array(
-                    'cache_dir'     => $cacheDir . DIRECTORY_SEPARATOR . 'cache',
-                    'compile_dir'   => $cacheDir . DIRECTORY_SEPARATOR . 'templates_c',
+                    'cache_dir'     => $cacheDir.DIRECTORY_SEPARATOR.'cache',
+                    'compile_dir'   => $cacheDir.DIRECTORY_SEPARATOR.'templates_c',
                 ),
                 $serviceManager->get('templating.globals'),
                 $serviceManager->get('logger')
@@ -189,7 +189,7 @@ 
         });
 
         // Mustache Engine
-        $serviceManager->setFactory('templating.engine.mustache', function ($serviceManager, $appCacheDir) {
+        $serviceManager->setFactory('templating.engine.mustache', function($serviceManager, $appCacheDir) {
 
             if (!class_exists('Mustache_Engine')) {
                 throw new \Exception('PPI\Framework\MustacheModule not found. Composer require: ppi/mustache-module');
@@ -198,7 +198,7 @@ 
             $rawMustacheEngine = new \Mustache_Engine(array(
                 'loader' => new MustacheFileSystemLoader($serviceManager->get('templating.locator'),
                     $serviceManager->get('templating.name_parser')),
-                'cache'  => $appCacheDir . DIRECTORY_SEPARATOR . 'mustache',
+                'cache'  => $appCacheDir.DIRECTORY_SEPARATOR.'mustache',
             ));
 
             return new MustacheEngine($rawMustacheEngine, $serviceManager->get('templating.name_parser'));
@@ -207,11 +207,11 @@ 
         /*
          * Delegating Engine.
          */
-        $serviceManager->setFactory('templating.engine.delegating', function ($serviceManager) use ($engineIds) {
+        $serviceManager->setFactory('templating.engine.delegating', function($serviceManager) use ($engineIds) {
             $delegatingEngine = new DelegatingEngine();
             // @todo - lazy load this
             foreach ($engineIds as $id) {
-                $delegatingEngine->addEngine($serviceManager->get('templating.engine.' . $id));
+                $delegatingEngine->addEngine($serviceManager->get('templating.engine.'.$id));
             }
 
             return $delegatingEngine;

src/ServiceManager/Factory/RouterRequestContextFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      *
      * @param ServiceLocatorInterface $serviceLocator
      *
-     * @return \PPI\Framework\Router\RouterListener
+     * @return RequestContext
      */
     public function createService(ServiceLocatorInterface $serviceLocator)
     {

Spacing +1 added lines, -2 removed lines

@@ -61,7 +61,6 @@
         $defaults = $defaults['framework']['router'];
 
         return isset($config['framework']['router']) ?
-            $this->mergeConfiguration($defaults, $config['framework']['router']) :
-            $defaults;
+            $this->mergeConfiguration($defaults, $config['framework']['router']) : $defaults;
     }
 }

src/View/Twig/TwigEngine.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     /**
      * Renders a template.
      *
-     * @param mixed $name       A template name
+     * @param string $name       A template name
      * @param array $parameters An array of parameters to pass to the template
      *
      * @throws \InvalidArgumentException if the template does not exist

src/Debug/ExceptionHandler.php

Switch Indentation +5 added lines, -5 removed lines

@@ -180,11 +180,11 @@
     public function getContent(FlattenException $exception, $showAll = true)
     {
         switch ($exception->getStatusCode()) {
-            case 404:
-                $title = "The page you are looking for could not be found";
-                break;
-            default:
-                $title = "Oh noes, something's broken";
+        case 404:
+            $title = "The page you are looking for could not be found";
+            break;
+        default:
+            $title = "Oh noes, something's broken";
         }
 
         $content = '';

Spacing +4 added lines, -4 removed lines

@@ -138,7 +138,7 @@ 
 
         header(sprintf('HTTP/1.0 %s', $exception->getStatusCode()));
         foreach ($exception->getHeaders() as $name => $value) {
-            header($name . ': ' . $value, false);
+            header($name.': '.$value, false);
         }
 
         echo $this->decorate($this->getContent($exception, $this->showAllExceptions), $this->getStylesheet($exception));
@@ -229,7 +229,7 @@ 
 
                     foreach ($e['trace'] as $trace) {
                         $i++;
-                        $content .= '       <tr><td>' . $i . '</td><td>';
+                        $content .= '       <tr><td>'.$i.'</td><td>';
                         if ($trace['function']) {
                             $content .= sprintf('at %s%s%s(%s)', $this->abbrClass($trace['class']), $trace['type'], $trace['function'], $this->formatArgs($trace['args']));
                         }
@@ -367,12 +367,12 @@ 
                 $formattedValue = sprintf("<em>object</em>(%s)", $this->abbrClass($item[1]));
             } elseif ('array' === $item[0]) {
                 $formattedValue = sprintf("<em>array</em>(%s)", is_array($item[1]) ? $this->formatArgs($item[1]) : $item[1]);
-            } elseif ('string'  === $item[0]) {
+            } elseif ('string' === $item[0]) {
                 $formattedValue = sprintf("'%s'", htmlspecialchars($item[1], ENT_QUOTES | ENT_SUBSTITUTE, $this->charset));
             } elseif ('null' === $item[0]) {
                 $formattedValue = '<em>null</em>';
             } elseif ('boolean' === $item[0]) {
-                $formattedValue = '<em>' . strtolower(var_export($item[1], true)) . '</em>';
+                $formattedValue = '<em>'.strtolower(var_export($item[1], true)).'</em>';
             } elseif ('resource' === $item[0]) {
                 $formattedValue = '<em>resource</em>';
             } else {

Doc Comments +8 added lines, -2 removed lines

@@ -82,6 +82,8 @@ 
      * Registers the exception handler.
      *
      * @param bool $debug
+     * @param string $charset
+     * @param string $fileLinkFormat
      *
      * @return ExceptionHandler The registered exception handler
      */
@@ -128,7 +130,7 @@ 
      * This method uses plain PHP functions like header() and echo to output
      * the response.
      *
-     * @param \Exception|FlattenException $exception An \Exception instance
+     * @param \Exception $exception An \Exception instance
      */
     public function sendPhpResponse($exception)
     {
@@ -147,7 +149,7 @@ 
     /**
      * Creates the error Response associated with the given Exception.
      *
-     * @param \Exception|FlattenException $exception An \Exception instance
+     * @param \Exception $exception An \Exception instance
      *
      * @return Response A Response instance
      */
@@ -299,6 +301,10 @@ 
 EOT;
     }
 
+    /**
+     * @param string $content
+     * @param string $css
+     */
     private function decorate($content, $css)
     {
         $baseStylesheet = $this->getBaseStylesheet();

src/ServiceManager/Config/ServiceManagerConfig.php

Spacing +3 added lines, -3 removed lines

@@ -133,7 +133,7 @@ 
             $serviceManager->setShared($name, $value);
         }
 
-        $serviceManager->addInitializer(function ($instance) use ($serviceManager) {
+        $serviceManager->addInitializer(function($instance) use ($serviceManager) {
             if ($instance instanceof EventManagerAwareInterface) {
                 if ($instance->getEventManager() instanceof EventManagerInterface) {
                     $instance->getEventManager()->setSharedManager(
@@ -145,13 +145,13 @@ 
             }
         });
 
-        $serviceManager->addInitializer(function ($instance) use ($serviceManager) {
+        $serviceManager->addInitializer(function($instance) use ($serviceManager) {
             if ($instance instanceof ServiceManagerAwareInterface) {
                 $instance->setServiceManager($serviceManager);
             }
         });
 
-        $serviceManager->addInitializer(function ($instance) use ($serviceManager) {
+        $serviceManager->addInitializer(function($instance) use ($serviceManager) {
             if ($instance instanceof ServiceLocatorAwareInterface) {
                 $instance->setServiceLocator($serviceManager);
             }