Completed
Pull Request — master (#152)
by Paul
03:25
created
src/ServiceManager/Factory/RouterFactory.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,6 @@
 block discarded – undo
11 11
 namespace PPI\Framework\ServiceManager\Factory;
12 12
 
13 13
 
14
-use Symfony\Component\Routing\RouteCollection as SymfonyRouteCollection;
15 14
 use Zend\ServiceManager\FactoryInterface;
16 15
 use Zend\ServiceManager\ServiceLocatorInterface;
17 16
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
     public function createService(ServiceLocatorInterface $serviceLocator)
36 36
     {
37 37
 
38
-        $routerOptions   = array();
38
+        $routerOptions = array();
39 39
         $logger = $serviceLocator->has('Logger') ? $serviceLocator->get('Logger') : null;
40 40
         $chainRouter = new ChainRouter($logger);
41 41
 
Please login to merge, or discard this patch.
src/App.php 1 patch
Switch Indentation   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -60,37 +60,37 @@
 block discarded – undo
60 60
 
61 61
             switch(true) {
62 62
                 // @todo - move this to a separate method()
63
-                case $moduleRoutingResponse instanceof SymfonyRouteCollection:
64
-                    $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
65
-                    $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
66
-                    $chainRouter->add($sfRouterWrapper);
67
-                    break;
68
-
69
-                // @todo - move this to a separate method()
70
-                case $moduleRoutingResponse instanceof AuraRouter:
71
-                    $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
72
-                    $chainRouter->add($auraRouterWrapper);
73
-                    break;
74
-
75
-                // @todo - move this to a separate method()
76
-                case $moduleRoutingResponse instanceof LaravelRouter:
77
-                    $laravelRequest = new LaravelRequest();
78
-                    $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
79
-                    $laravelRouterWrapper = new LaravelRouterWrapper(
80
-                        $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
81
-                    );
82
-                    // @todo - solve this problem
63
+            case $moduleRoutingResponse instanceof SymfonyRouteCollection:
64
+                $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
65
+                $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
66
+                $chainRouter->add($sfRouterWrapper);
67
+                break;
68
+
69
+            // @todo - move this to a separate method()
70
+            case $moduleRoutingResponse instanceof AuraRouter:
71
+                $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
72
+                $chainRouter->add($auraRouterWrapper);
73
+                break;
74
+
75
+            // @todo - move this to a separate method()
76
+            case $moduleRoutingResponse instanceof LaravelRouter:
77
+                $laravelRequest = new LaravelRequest();
78
+                $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
79
+                $laravelRouterWrapper = new LaravelRouterWrapper(
80
+                    $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
81
+                );
82
+                // @todo - solve this problem
83 83
 //                    $laravelRouterWrapper->setModuleName($this->getName());
84
-                    $chainRouter->add($laravelRouterWrapper);
85
-                    break;
84
+                $chainRouter->add($laravelRouterWrapper);
85
+                break;
86 86
 
87
-                case $moduleRoutingResponse instanceof FastRouteWrapper:
88
-                    $chainRouter->add($moduleRoutingResponse);
89
-                    break;
87
+            case $moduleRoutingResponse instanceof FastRouteWrapper:
88
+                $chainRouter->add($moduleRoutingResponse);
89
+                break;
90 90
 
91
-                default:
92
-                    throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
93
-                        '. found value of type: ' . gettype($moduleRoutingResponse));
91
+            default:
92
+                throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
93
+                    '. found value of type: ' . gettype($moduleRoutingResponse));
94 94
             }
95 95
         }
96 96
 
Please login to merge, or discard this patch.