for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* This file is part of the PPI Framework.
*
* @copyright Copyright (c) 2011-2015 Paul Dragoonis <[email protected]>
* @license http://opensource.org/licenses/mit-license.php MIT
* @link http://www.ppi.io
*/
namespace PPI\Framework\ServiceManager\Factory;
use Symfony\Component\Routing\RouteCollection as SymfonyRouteCollection;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
* Router Factory.
* @author Paul Dragoonis <[email protected]>
* @author Vítor Brandão <[email protected]>
class RouterFactory implements FactoryInterface
{
* @todo - move this to a separate method() - consider how to inject custom-defined arbitrary chain router entries
* @param ServiceLocatorInterface $serviceLocator
* @throws \Exception
* @return ChainRouter
public function createService(ServiceLocatorInterface $serviceLocator)
$routerOptions = array();
$routerOptions
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$logger = $serviceLocator->has('Logger') ? $serviceLocator->get('Logger') : null;
$chainRouter = new ChainRouter($logger);
return $chainRouter;
}
ppi /
framework
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.