Issues in ConverterClient.php (master) - Issues in master - pomm-project/Foundation - Measure and Improve Code Quality continuously with Scrutinizer

Issues (40)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

sources/lib/Converter/ConverterClient.php (3 issues)

Labels

Duplication 3

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of Pomm's Foundation package.
 *
 * (c) 2014 - 2017 Grégoire HUBERT <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace PommProject\Foundation\Converter;

use PommProject\Foundation\Client\Client;

/**
 * ConverterClient
 *
 * Converter wrapper as Session's client.
 *
 * @package   Foundation
 * @copyright 2014 - 2017 Grégoire HUBERT
 * @author    Grégoire HUBERT
 * @license   X11 {@link http://opensource.org/licenses/mit-license.php}
 * @see       Client
 */
class ConverterClient extends Client
{
    protected $converter;
    protected $name;

    /**
     * __construct
     *
     * Wrap the given converter.
     *
     * @param  string    $name
     * @param  ConverterInterface $converter
     */
    public function __construct($name, ConverterInterface $converter)
    {
        $this->name      = $name;
        $this->converter = $converter;
    }

    /**
     * getClientType
     *
     * @see ClientInterface
     */
    public function getClientType()
    {
        return 'converter';
    }

    /**
     * getClientIdentifier
     *
     * @see ClientInterface
     */
    public function getClientIdentifier()
    {
        return $this->name;
    }

    /**
     * toPg
     *
     * Trigger converter's toPg conversion method.
     *
     * @param  mixed  $value
     * @param  string $type
     * @return string
     * @see ConverterInterface
     */
    public function toPg($value, $type = null)

    {
        return $this->converter->toPg(
            $value,
            $type === null ? $this->getClientIdentifier() : $type,
            $this->getSession()
        );
    }

    /**
     * fromPg
     *
     * Trigger converter's fromPg conversion method.
     *
     * @param  mixed  $value
     * @param  string $type
     * @return mixed
     * @see ConverterInterface
     */
    public function fromPg($value, $type = null)

    {
        return $this->converter->fromPg(
            $value,
            $type === null ? $this->getClientIdentifier() : $type,
            $this->getSession()
        );
    }

    /**
     * toPgStandardFormat
     *
     * Export data as CSV representation
     *
     * @param  mixed    $value
     * @param  string   $type
     * @return string
     * @see ConverterInterface
     */
    public function toPgStandardFormat($value, $type = null)

    {
        return $this->converter->toPgStandardFormat(
            $value,
            $type === null ? $this->getClientIdentifier() : $type,
            $this->getSession()
        );
    }

    /**
     * getConverter
     *
     * Return the embedded converter.
     *
     * @return ConverterInterface
     */
    public function getConverter()
    {
        return $this->converter;
    }
}


1		<?php
2		/*
3		* This file is part of Pomm's Foundation package.
4		*
5		* (c) 2014 - 2017 Grégoire HUBERT <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10		namespace PommProject\Foundation\Converter;
11
12		use PommProject\Foundation\Client\Client;
13
14		/**
15		* ConverterClient
16		*
17		* Converter wrapper as Session's client.
18		*
19		* @package Foundation
20		* @copyright 2014 - 2017 Grégoire HUBERT
21		* @author Grégoire HUBERT
22		* @license X11 {@link http://opensource.org/licenses/mit-license.php}
23		* @see Client
24		*/
25		class ConverterClient extends Client
26		{
27		protected $converter;
28		protected $name;
29
30		/**
31		* __construct
32		*
33		* Wrap the given converter.
34		*
35		* @param string $name
36		* @param ConverterInterface $converter
37		*/
38		public function __construct($name, ConverterInterface $converter)
39		{
40		$this->name = $name;
41		$this->converter = $converter;
42		}
43
44		/**
45		* getClientType
46		*
47		* @see ClientInterface
48		*/
49		public function getClientType()
50		{
51		return 'converter';
52		}
53
54		/**
55		* getClientIdentifier
56		*
57		* @see ClientInterface
58		*/
59		public function getClientIdentifier()
60		{
61		return $this->name;
62		}
63
64		/**
65		* toPg
66		*
67		* Trigger converter's toPg conversion method.
68		*
69		* @param mixed $value
70		* @param string $type
71		* @return string
72		* @see ConverterInterface
73		*/
74	View Code Duplication	public function toPg($value, $type = null)
		0 ignored issues – show Duplication introduced 2017-11-19 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		return $this->converter->toPg(
77		$value,
78		$type === null ? $this->getClientIdentifier() : $type,
79		$this->getSession()
80		);
81		}
82
83		/**
84		* fromPg
85		*
86		* Trigger converter's fromPg conversion method.
87		*
88		* @param mixed $value
89		* @param string $type
90		* @return mixed
91		* @see ConverterInterface
92		*/
93	View Code Duplication	public function fromPg($value, $type = null)
		0 ignored issues – show Duplication introduced 2017-11-19 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		{
95		return $this->converter->fromPg(
96		$value,
97		$type === null ? $this->getClientIdentifier() : $type,
98		$this->getSession()
99		);
100		}
101
102		/**
103		* toPgStandardFormat
104		*
105		* Export data as CSV representation
106		*
107		* @param mixed $value
108		* @param string $type
109		* @return string
110		* @see ConverterInterface
111		*/
112	View Code Duplication	public function toPgStandardFormat($value, $type = null)
		0 ignored issues – show Duplication introduced 2017-11-19 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		{
114		return $this->converter->toPgStandardFormat(
115		$value,
116		$type === null ? $this->getClientIdentifier() : $type,
117		$this->getSession()
118		);
119		}
120
121		/**
122		* getConverter
123		*
124		* Return the embedded converter.
125		*
126		* @return ConverterInterface
127		*/
128		public function getConverter()
129		{
130		return $this->converter;
131		}
132		}
133

pomm-project / Foundation

Issues (40)

Security Analysis no request data

sources/lib/Converter/ConverterClient.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like