Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
25 | class ConverterClient extends Client |
||
26 | { |
||
27 | protected $converter; |
||
28 | protected $name; |
||
29 | |||
30 | /** |
||
31 | * __construct |
||
32 | * |
||
33 | * Wrap the given converter. |
||
34 | * |
||
35 | * @param string $name |
||
36 | * @param ConverterInterface $converter |
||
37 | */ |
||
38 | public function __construct($name, ConverterInterface $converter) |
||
43 | |||
44 | /** |
||
45 | * getClientType |
||
46 | * |
||
47 | * @see ClientInterface |
||
48 | */ |
||
49 | public function getClientType() |
||
53 | |||
54 | /** |
||
55 | * getClientIdentifier |
||
56 | * |
||
57 | * @see ClientInterface |
||
58 | */ |
||
59 | public function getClientIdentifier() |
||
63 | |||
64 | /** |
||
65 | * toPg |
||
66 | * |
||
67 | * Trigger converter's toPg conversion method. |
||
68 | * |
||
69 | * @param mixed $value |
||
70 | * @param string $type |
||
71 | * @return string |
||
72 | * @see ConverterInterface |
||
73 | */ |
||
74 | View Code Duplication | public function toPg($value, $type = null) |
|
82 | |||
83 | /** |
||
84 | * fromPg |
||
85 | * |
||
86 | * Trigger converter's fromPg conversion method. |
||
87 | * |
||
88 | * @param mixed $value |
||
89 | * @param string $type |
||
90 | * @return mixed |
||
91 | * @see ConverterInterface |
||
92 | */ |
||
93 | View Code Duplication | public function fromPg($value, $type = null) |
|
101 | |||
102 | /** |
||
103 | * toPgStandardFormat |
||
104 | * |
||
105 | * Export data as CSV representation |
||
106 | * |
||
107 | * @param mixed $value |
||
108 | * @param string $type |
||
109 | * @return string |
||
110 | * @see ConverterInterface |
||
111 | */ |
||
112 | View Code Duplication | public function toPgStandardFormat($value, $type = null) |
|
120 | |||
121 | /** |
||
122 | * getConverter |
||
123 | * |
||
124 | * Return the embedded converter. |
||
125 | * |
||
126 | * @return ConverterInterface |
||
127 | */ |
||
128 | public function getConverter() |
||
132 | } |
||
133 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.