podlove / podlove-subscribe-button-wp-plugin

inc/Model/Base.php

Braces +18 added lines, -12 removed lines

@@ -45,11 +45,13 @@ 
 	}
 
 	private static function unserialize_property( $property ) {
-		if ( ! isset( $property ) )
-			return;
+		if ( ! isset( $property ) ) {
+					return;
+		}
 
-		if ( $unserialized_string = is_serialized( $property ) )
-			return unserialize( $property );
+		if ( $unserialized_string = is_serialized( $property ) ) {
+					return unserialize( $property );
+		}
 
 		return $property;
 	}
@@ -319,8 +321,9 @@ 
 	 */
 	public function update_attributes( $attributes ) {
 
-		if ( ! is_array( $attributes ) )
-			return false;
+		if ( ! is_array( $attributes ) ) {
+					return false;
+		}
 
 		$request = filter_input_array( INPUT_POST ); // Do this for security reasons
 			
@@ -429,12 +432,14 @@ 
 		
 		$defaults = $this->default_values();
 
-		if ( ! is_array( $defaults ) || empty( $defaults ) )
-			return;
+		if ( ! is_array( $defaults ) || empty( $defaults ) ) {
+					return;
+		}
 
 		foreach ( $defaults as $property => $value ) {
-			if ( $this->$property === null )
-				$this->$property = $value;
+			if ( $this->$property === null ) {
+							$this->$property = $value;
+			}
 		}
 
 	}
@@ -495,8 +500,9 @@ 
 		global $wpdb;
 		
 		$property_sql = array();
-		foreach ( static::properties() as $property )
-			$property_sql[ ] = "`{$property[ 'name' ]}` {$property[ 'type' ]}";
+		foreach ( static::properties() as $property ) {
+					$property_sql[ ] = "`{$property[ 'name' ]}` {$property[ 'type' ]}";
+		}
 		
 		$sql = 'CREATE TABLE IF NOT EXISTS '
 		     . static::table_name()

Indentation +19 added lines, -19 removed lines

@@ -396,14 +396,14 @@ 
 			$this->set_defaults();
 
 			$sql = 'INSERT INTO '
-			     . static::table_name()
-			     . ' ( '
-			     . implode( ',', static::property_names() )
-			     . ' ) '
-			     . 'VALUES'
-			     . ' ( '
-			     . implode( ',', array_map( array( $this, 'property_name_to_sql_value' ), static::property_names() ) )
-			     . ' );'
+				 . static::table_name()
+				 . ' ( '
+				 . implode( ',', static::property_names() )
+				 . ' ) '
+				 . 'VALUES'
+				 . ' ( '
+				 . implode( ',', array_map( array( $this, 'property_name_to_sql_value' ), static::property_names() ) )
+				 . ' );'
 			;
 			$success = $wpdb->query( $sql );
 			if ( $success ) {
@@ -411,9 +411,9 @@ 
 			}
 		} else {
 			$sql = 'UPDATE ' . static::table_name()
-			     . ' SET '
-			     . implode( ',', array_map( array( $this, 'property_name_to_sql_update_statement' ), static::property_names() ) )
-			     . ' WHERE id = ' . $this->id
+				 . ' SET '
+				 . implode( ',', array_map( array( $this, 'property_name_to_sql_update_statement' ), static::property_names() ) )
+				 . ' WHERE id = ' . $this->id
 			;
 
 			$success = $wpdb->query( $sql );
@@ -461,13 +461,13 @@ 
 		global $wpdb;
 
 		$sql = 'DELETE FROM '
-		     . static::table_name()
-		     . ' WHERE id = ' . $this->id;
+			 . static::table_name()
+			 . ' WHERE id = ' . $this->id;
 
 		$rows_affected = $wpdb->query( $sql );
 
-	    do_action( 'podlove_psb_model_delete', $this );
-	    do_action( 'podlove_psb_model_change', $this );
+		do_action( 'podlove_psb_model_delete', $this );
+		do_action( 'podlove_psb_model_change', $this );
 
 		return $rows_affected !== false;
 	}
@@ -506,10 +506,10 @@ 
 			$property_sql[ ] = "`{$property[ 'name' ]}` {$property[ 'type' ]}";
 
 		$sql = 'CREATE TABLE IF NOT EXISTS '
-		     . static::table_name()
-		     . ' ('
-		     . implode( ',', $property_sql )
-		     . ' ) CHARACTER SET utf8;'
+			 . static::table_name()
+			 . ' ('
+			 . implode( ',', $property_sql )
+			 . ' ) CHARACTER SET utf8;'
 		;
 
 		$wpdb->query( $sql );

inc/Settings/Buttons.php

Braces +9 added lines, -6 removed lines

@@ -45,8 +45,9 @@ 
 	 * Process form: save/update a format
 	 */
 	public static function save() {
-		if ( null == filter_input( INPUT_GET, 'button' ) )
-			return;
+		if ( null == filter_input( INPUT_GET, 'button' ) ) {
+					return;
+		}
 
 		$post = filter_input_array( INPUT_POST );
 
@@ -81,8 +82,9 @@ 
 	 * Process form: delete a format
 	 */
 	public static function delete() {
-		if ( null == filter_input( INPUT_GET, 'button' ) )
-			return;
+		if ( null == filter_input( INPUT_GET, 'button' ) ) {
+					return;
+		}
 
 		$button = ( filter_input( INPUT_GET, 'network' ) === '1' ? \PodloveSubscribeButton\Model\NetworkButton::find_by_id( filter_input( INPUT_GET, 'button' ) ) : \PodloveSubscribeButton\Model\Button::find_by_id( filter_input( INPUT_GET, 'button' ) ) );
 		$button->delete();
@@ -104,8 +106,9 @@ 
 	}
 
 	public static function process_form() {
-		if ( null === filter_input( INPUT_GET, 'button' ) )
-			return;
+		if ( null === filter_input( INPUT_GET, 'button' ) ) {
+					return;
+		}
 
 		$action = ( null !== filter_input( INPUT_GET, 'action' ) ? filter_input( INPUT_GET, 'action' ) : null );
 

Indentation +9 added lines, -9 removed lines

@@ -40,13 +40,13 @@ 
                 <div id="post-body" class="columns-2">
                     <div id="post-body-content">
 	                    <?php
-	                    switch ( $action ) {
-		                    case 'new':   self::new_template(); break;
-		                    case 'edit':  self::edit_template(); break;
-		                    case 'index': self::view_template(); break;
-		                    default:      self::view_template(); break;
-	                    }
-	                    ?>
+						switch ( $action ) {
+							case 'new':   self::new_template(); break;
+							case 'edit':  self::edit_template(); break;
+							case 'index': self::view_template(); break;
+							default:      self::view_template(); break;
+						}
+						?>
                     </div>
                     <div id="postbox-container-1" class="postbox-container">
                         <?php self::sidebar(); ?>
@@ -92,7 +92,7 @@ 
         </div>
         <?php
 
-    }
+	}
 
 	/**
 	 * Process form: save/update a format
@@ -202,7 +202,7 @@ 
 		$table->display();
 
 		if ( $is_network ) {
-		    // https://vedovini.net/2015/10/using-the-wordpress-settings-api-with-network-admin-pages/
+			// https://vedovini.net/2015/10/using-the-wordpress-settings-api-with-network-admin-pages/
 			?>
             <form method="post" action="edit.php?action=podlove_psb_update_network_options">
 				<?php

Spacing +1 added lines, -1 removed lines

@@ -352,7 +352,7 @@
 
 		//Verify Post Referring Page
 		check_admin_referer( 'podlove-psb-options' );
-		update_site_option( 'podlove_psb_defaults', $_POST['podlove_psb_defaults'] );
+		update_site_option( 'podlove_psb_defaults', $_POST[ 'podlove_psb_defaults' ] );
 
 		//Redirect to Network Settings Page
 		wp_redirect( add_query_arg( array( 'page' => 'podlove-subscribe-button', 'updated' => 'true' ), network_admin_url( 'settings.php' ) ) );

inc/Widget.php

Braces +3 added lines, -1 removed lines

@@ -104,9 +104,11 @@
 							echo "<option value='" . $subscribebutton->name . "' " . selected( $subscribebutton->name, $button ) . " >" . $subscribebutton->title . " (" . $subscribebutton->name . ")</option>";
 						} ?>
                     </optgroup>
-				<?php else :
+				<?php else {
+	:
 					foreach ( $buttons as $subscribebutton ) {
 						echo "<option value='" . $subscribebutton->name . "' " . selected( $subscribebutton->name, $button ) . " >" . $subscribebutton->title . " (" . $subscribebutton->name . ")</option>";
+}
 					}
 				endif; ?>
             </select>

Indentation +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
 		'autowidth',
 		'button',
 		'color',
-        'language'
+		'language'
 	);
 
 	public function __construct() {
@@ -49,7 +49,7 @@ 
 			\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'format' ),
 			\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'color' ),
 			false,
-            false,
+			false,
 			\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'language' )
 		);
 

Spacing +10 added lines, -10 removed lines

@@ -28,7 +28,7 @@ 
 		parent::__construct(
 			'podlove_subscribe_button_wp_plugin_widget',
 			( Helpers::is_podlove_publisher_active() ? 'Podlove Subscribe Button (WordPress plugin)' : 'Podlove Subscribe Button' ),
-			array( 'description' => __( 'Adds a Podlove Subscribe Button to your Sidebar', 'podlove-subscribe-button' ), )
+			array( 'description' => __( 'Adds a Podlove Subscribe Button to your Sidebar', 'podlove-subscribe-button' ),)
 		);
 
 	}
@@ -36,7 +36,7 @@ 
 	public function widget( $args, $instance ) {
 		// Fetch the (network)button by it's name
 		if ( ! $button = Model\Button::get_button_by_name( $instance[ 'button' ] ) ) {
-			return sprintf( __( 'Oops. There is no button with the ID "%s".', 'podlove-subscribe-button' ), $args['button'] );
+			return sprintf( __( 'Oops. There is no button with the ID "%s".', 'podlove-subscribe-button' ), $args[ 'button' ] );
 		}
 
 		echo $args[ 'before_widget' ];
@@ -64,15 +64,15 @@ 
 	public function form( $instance ) {
 		$options = get_option( 'podlove_psb_defaults' );
 
-		$title     = isset( $instance[ 'title' ] )     ? $instance[ 'title' ]     : '';
-		$button    = isset( $instance[ 'button' ] )    ? $instance[ 'button' ]    : '';
-		$size      = isset( $instance[ 'size' ] )      ? $instance[ 'size' ]      : $options['size'];
-		$style     = isset( $instance[ 'style' ] )     ? $instance[ 'style' ]     : $options['style'];
-		$format    = isset( $instance[ 'format' ] )    ? $instance[ 'format' ]    : $options['format'];
+		$title     = isset( $instance[ 'title' ] ) ? $instance[ 'title' ] : '';
+		$button    = isset( $instance[ 'button' ] ) ? $instance[ 'button' ] : '';
+		$size      = isset( $instance[ 'size' ] ) ? $instance[ 'size' ] : $options[ 'size' ];
+		$style     = isset( $instance[ 'style' ] ) ? $instance[ 'style' ] : $options[ 'style' ];
+		$format    = isset( $instance[ 'format' ] ) ? $instance[ 'format' ] : $options[ 'format' ];
 		$autowidth = isset( $instance[ 'autowidth' ] ) ? $instance[ 'autowidth' ] : true;
-		$infotext  = isset( $instance[ 'infotext' ] )  ? $instance[ 'infotext' ]  : '';
-		$color     = isset( $instance[ 'color' ] )     ? $instance[ 'color' ]     : $options['color'];
-		$language  = isset( $instance[ 'language' ] )  ? $instance[ 'language' ]  : $options['language'];
+		$infotext  = isset( $instance[ 'infotext' ] ) ? $instance[ 'infotext' ] : '';
+		$color     = isset( $instance[ 'color' ] ) ? $instance[ 'color' ] : $options[ 'color' ];
+		$language  = isset( $instance[ 'language' ] ) ? $instance[ 'language' ] : $options[ 'language' ];
 
 		$buttons = Model\Button::all();
 		if ( is_multisite() ) {

inc/Defaults.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 			'big'    => __( 'Big', 'podlove-subscribe-button' ),
 		);
 
-		$language = array( 'de', 'en', 'eo', 'fi', 'fr', 'nl', 'zh', 'ja', );
+		$language = array( 'de', 'en', 'eo', 'fi', 'fr', 'nl', 'zh', 'ja',);
 
 		return $$property;
 

inc/Helpers.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 
 namespace PodloveSubscribeButton;
 
-Class Helpers {
+class Helpers {
 
 	public static function get_path( $folder = '' ) {
 

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 			$language = get_option( 'WPLANG' );
 		}
 
-		$lang_code = strtolower( explode( '_', $language )[0] );
+		$lang_code = strtolower( explode( '_', $language )[ 0 ] );
 
 		if ( in_array( $lang_code, \PodloveSubscribeButton\Defaults::button( 'language' ) ) ) {
 			return $lang_code;

inc/Model/Button.php

Spacing +11 added lines, -11 removed lines

@@ -97,19 +97,19 @@ 
 	 */
 	private function get_feeds_as_array( $feeds = array() ) {
 		foreach ( $feeds as $feed ) {
-			if ( isset( Defaults::media_types()[ $feed['format'] ]['extension'] ) ) {
+			if ( isset( Defaults::media_types()[ $feed[ 'format' ] ][ 'extension' ] ) ) {
 				$new_feed = array(
 					'type'    => 'audio',
-					'format'  => Defaults::media_types()[ $feed['format'] ]['extension'],
-					'url'     => $feed['url'],
+					'format'  => Defaults::media_types()[ $feed[ 'format' ] ][ 'extension' ],
+					'url'     => $feed[ 'url' ],
 					'variant' => 'high',
 				);
 
-				if ( isset( $feed['itunesfeedid'] ) && $feed['itunesfeedid'] > 0 ) {
-					$new_feed['directory-url-itunes'] = "https://itunes.apple.com/podcast/id" . $feed['itunesfeedid'];
+				if ( isset( $feed[ 'itunesfeedid' ] ) && $feed[ 'itunesfeedid' ] > 0 ) {
+					$new_feed[ 'directory-url-itunes' ] = "https://itunes.apple.com/podcast/id" . $feed[ 'itunesfeedid' ];
 				}
 
-				$feeds[] = $new_feed;
+				$feeds[ ] = $new_feed;
 
 			}
 		}
@@ -158,10 +158,10 @@ 
 
 		return array(
 			// $attribute => $value
-			'size'      => ( $size == 'default' ? $options['size'] : $size ) . self::interpret_autowidth_attribute( $autowidth ),
-			'style'     => ( $style == 'default' ? $options['style'] : $style ),
-			'format'    => ( $format == 'default' ? $options['format'] : $format ),
-			'color'     => ( isset( $color ) ? $color : $options['color'] ),
+			'size'      => ( $size == 'default' ? $options[ 'size' ] : $size ) . self::interpret_autowidth_attribute( $autowidth ),
+			'style'     => ( $style == 'default' ? $options[ 'style' ] : $style ),
+			'format'    => ( $format == 'default' ? $options[ 'format' ] : $format ),
+			'color'     => ( isset( $color ) ? $color : $options[ 'color' ] ),
 			'json-data' => 'podcastData' . $this->id
 		);
 
@@ -173,7 +173,7 @@ 
 	 * @return string
 	 */
 	private static function interpret_autowidth_attribute( $autowidth ) {
-		if ( $autowidth == 'default' && get_option( 'podlove_psb_defaults' )['autowidth'] !== 'on' )
+		if ( $autowidth == 'default' && get_option( 'podlove_psb_defaults' )[ 'autowidth' ] !== 'on' )
 			return '';
 
 		if ( $autowidth !== 'default' && $autowidth !== 'on' )

Braces +6 added lines, -4 removed lines

@@ -173,11 +173,13 @@
 	 * @return string
 	 */
 	private static function interpret_autowidth_attribute( $autowidth ) {
-		if ( $autowidth == 'default' && get_option( 'podlove_psb_defaults' )['autowidth'] !== 'on' )
-			return '';
+		if ( $autowidth == 'default' && get_option( 'podlove_psb_defaults' )['autowidth'] !== 'on' ) {
+					return '';
+		}
 
-		if ( $autowidth !== 'default' && $autowidth !== 'on' )
-			return '';
+		if ( $autowidth !== 'default' && $autowidth !== 'on' ) {
+					return '';
+		}
 
 		return ' auto';
 

inc/Options.php

Indentation +4 added lines, -4 removed lines

@@ -152,11 +152,11 @@
 
 	public static function sanitize_settings( $input = null ) {
 
-	    $output = $input;
+		$output = $input;
 
-	    if ( ! array_key_exists('autowidth', $input ) ) {
-		    $output['autowidth'] = 'off';
-        }
+		if ( ! array_key_exists('autowidth', $input ) ) {
+			$output['autowidth'] = 'off';
+		}
 
 		return $output;
 	}

Spacing +10 added lines, -10 removed lines

@@ -112,18 +112,18 @@ 
 			$option = get_option( 'podlove_psb_defaults' );
 		}
 
-		switch ( $args['type'] ) {
+		switch ( $args[ 'type' ] ) {
 			case 'checkbox':
 				?>
-                <input type="checkbox" name="<?php echo "podlove_psb_defaults[{$args['label_for']}]"; ?>"
-                       id="<?php echo "podlove_psb_defaults[{$args['label_for']}]"; ?>" <?php checked( $option[ $args['label_for'] ], 'on' ); ?> />
+                <input type="checkbox" name="<?php echo "podlove_psb_defaults[{$args[ 'label_for' ]}]"; ?>"
+                       id="<?php echo "podlove_psb_defaults[{$args[ 'label_for' ]}]"; ?>" <?php checked( $option[ $args[ 'label_for' ] ], 'on' ); ?> />
 				<?php
 				break;
 
 			case 'color':
 				?>
                 <input id="podlove_psb_defaults[color]" name="podlove_psb_defaults[color]" class="podlove_subscribe_button_color"
-                       value="<?php echo $option['color'] ?>"/>
+                       value="<?php echo $option[ 'color' ] ?>"/>
 				<?php
 				break;
 
@@ -131,7 +131,7 @@ 
 				?>
                 <select name="podlove_psb_defaults[language]" id="podlove_psb_defaults[language]">
 					<?php foreach ( Defaults::button( 'language' ) as $value ) : ?>
-                        <option value="<?php echo $value; ?>" <?php selected( $option['language'], $value ); ?>><?php echo $value; ?></option>
+                        <option value="<?php echo $value; ?>" <?php selected( $option[ 'language' ], $value ); ?>><?php echo $value; ?></option>
 					<?php endforeach; ?>
                 </select>
 				<?php
@@ -140,9 +140,9 @@ 
 
 			case 'select':
 				?>
-                <select name="podlove_psb_defaults[<?php echo $args['label_for']; ?>]" id="podlove_psb_defaults[<?php echo $args['label_for']; ?>]">
-					<?php foreach ( Defaults::button( $args['label_for'] ) as $value => $description ) { ?>
-                        <option value="<?php echo $value; ?>" <?php selected( $option[ $args['label_for'] ], $value ); ?>><?php echo $description; ?></option>
+                <select name="podlove_psb_defaults[<?php echo $args[ 'label_for' ]; ?>]" id="podlove_psb_defaults[<?php echo $args[ 'label_for' ]; ?>]">
+					<?php foreach ( Defaults::button( $args[ 'label_for' ] ) as $value => $description ) { ?>
+                        <option value="<?php echo $value; ?>" <?php selected( $option[ $args[ 'label_for' ] ], $value ); ?>><?php echo $description; ?></option>
 					<?php } ?>
                 </select>
 				<?php break;
@@ -154,8 +154,8 @@ 
 
 	    $output = $input;
 
-	    if ( ! array_key_exists('autowidth', $input ) ) {
-		    $output['autowidth'] = 'off';
+	    if ( ! array_key_exists( 'autowidth', $input ) ) {
+		    $output[ 'autowidth' ] = 'off';
         }
 
 		return $output;

inc/Migration.php

Spacing +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
 				'podlove_subscribe_button_default_format',
 				'podlove_subscribe_button_default_language',
 			);
-			$options     = array();
+			$options = array();
 
 			foreach ( $old_options as $option ) {
 

podlove.php

Indentation +1 added lines, -1 removed lines

@@ -137,7 +137,7 @@
 	}
 
 	public static function admin_inline_js() {
-	    echo "<script type=\"text/javascript\">var clipboard = new ClipboardJS('.copy-btn');</script>";
+		echo "<script type=\"text/javascript\">var clipboard = new ClipboardJS('.copy-btn');</script>";
 	}
 
 	public static function admin_menu() {

Spacing +9 added lines, -9 removed lines

@@ -199,15 +199,15 @@ 
 	 * @return string|void
 	 */
 	public static function shortcode( $args ) {
-		if ( ! $args || ! isset( $args['button'] ) ) {
+		if ( ! $args || ! isset( $args[ 'button' ] ) ) {
 			return __( 'You need to create a Button first and provide its ID.', 'podlove-subscribe-button' );
 		} else {
-			$buttonid = $args['button'];
+			$buttonid = $args[ 'button' ];
 		}
 
 		// Fetch the (network)button by it's name
-		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name( $args['button'] ) ) {
-			return sprintf( __( 'Oops. There is no button with the ID "%s".', 'podlove-subscribe-button' ), $args['button'] );
+		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name( $args[ 'button' ] ) ) {
+			return sprintf( __( 'Oops. There is no button with the ID "%s".', 'podlove-subscribe-button' ), $args[ 'button' ] );
 		}
 
 		// Get button styling and options
@@ -216,19 +216,19 @@ 
 		$style     = self::get_attribute( 'style', self::get_array_value_with_fallback( $args, 'style' ) );
 		$format    = self::get_attribute( 'format', self::get_array_value_with_fallback( $args, 'format' ) );
 
-		if ( isset( $args['language'] ) ) {
-			$language = $args['language'];
+		if ( isset( $args[ 'language' ] ) ) {
+			$language = $args[ 'language' ];
 		} else {
 			$language = self::get_attribute( 'language', self::get_array_value_with_fallback( $args, 'language' ) );
 		}
 
-		if ( isset( $args['color'] ) ) {
-			$color = $args['color'];
+		if ( isset( $args[ 'color' ] ) ) {
+			$color = $args[ 'color' ];
 		} else {
 			$color = self::get_attribute( 'color', self::get_array_value_with_fallback( $args, 'color' ) );
 		}
 
-		if ( isset( $args['hide'] ) && $args['hide'] == 'true' ) {
+		if ( isset( $args[ 'hide' ] ) && $args[ 'hide' ] == 'true' ) {
 			$hide = true;
 		} else {
 			$hide = false;