Customer::_get() - Code Metrics - Inspection of "Make more clear interface and remove code duplicat..." - plesk/api-php-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff29e2...548de8 )

by Alexei

created 2016-11-12 03:10 UTC

Customer::_get() A

↳ Parent: Customer

Complexity

Conditions	4
Paths	8

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	21
rs	9.0534
cc	4
eloc	12
nc	8
nop	2

<?php
// Copyright 1999-2016. Parallels IP Holdings GmbH.

namespace PleskX\Api\Operator;
use PleskX\Api\Struct\Customer as Struct;

class Customer extends \PleskX\Api\Operator
{

    /**
     * @param array $properties
     * @return Struct\Info
     */
    public function create($properties)
    {
        $packet = $this->_client->getPacket();
        $info = $packet->addChild('customer')->addChild('add')->addChild('gen_info');

        foreach ($properties as $name => $value) {
            $info->addChild($name, $value);
        }

        $response = $this->_client->request($packet);
        return new Struct\Info($response);
    }

    /**
     * @param string $field
     * @param integer|string $value
     * @return bool
     */
    public function delete($field, $value)
    {
        $packet = $this->_client->getPacket();
        $packet->addChild('customer')->addChild('del')->addChild('filter')->addChild($field, $value);
        $response = $this->_client->request($packet);
        return 'ok' === (string)$response->status;
    }

    /**
     * @param string $field
     * @param integer|string $value
     * @return Struct\GeneralInfo
     */
    public function get($field, $value)
    {
        return $this->_get($field, $value);

    }

    /**
     * @return Struct\GeneralInfo[]
     */
    public function getAll()
    {
        return $this->_get();
    }

    /**
     * @param string|null $field
     * @param integer|string|null $value
     * @return Struct\GeneralInfo|Struct\GeneralInfo[]
     */
    private function _get($field = null, $value = null)
    {
        $packet = $this->_client->getPacket();
        $getTag = $packet->addChild('customer')->addChild('get');

        $filterTag = $getTag->addChild('filter');
        if ($field) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $filterTag->addChild($field, $value);
        }

        $getTag->addChild('dataset')->addChild('gen_info');

        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);

        $customers = [];
        foreach ($response->xpath('//result') as $xmlResult) {
            $customers[] = new Struct\GeneralInfo($xmlResult->data->gen_info);
        }

        return $field ? reset($customers) : $customers;
    }

}


1			<?php
2			// Copyright 1999-2016. Parallels IP Holdings GmbH.
3
4			namespace PleskX\Api\Operator;
5			use PleskX\Api\Struct\Customer as Struct;
6
7			class Customer extends \PleskX\Api\Operator
8			{
9
10			/**
11			* @param array $properties
12			* @return Struct\Info
13			*/
14			public function create($properties)
15			{
16			$packet = $this->_client->getPacket();
17			$info = $packet->addChild('customer')->addChild('add')->addChild('gen_info');
18
19			foreach ($properties as $name => $value) {
20			$info->addChild($name, $value);
21			}
22
23			$response = $this->_client->request($packet);
24			return new Struct\Info($response);
25			}
26
27			/**
28			* @param string $field
29			* @param integer\|string $value
30			* @return bool
31			*/
32			public function delete($field, $value)
33			{
34			$packet = $this->_client->getPacket();
35			$packet->addChild('customer')->addChild('del')->addChild('filter')->addChild($field, $value);
36			$response = $this->_client->request($packet);
37			return 'ok' === (string)$response->status;
38			}
39
40			/**
41			* @param string $field
42			* @param integer\|string $value
43			* @return Struct\GeneralInfo
44			*/
45			public function get($field, $value)
46			{
47			return $this->_get($field, $value);
			0 ignored issues – show Bug Compatibility introduced 2016-11-12 03:12 UTC by Report Bug Copy Issue Report The expression `$this->_get($field, $value);` of type `PleskX\Api\Struct\Custom...\Customer\GeneralInfo[]` adds the type `PleskX\Api\Struct\Customer\GeneralInfo[]` to the return on line 47 which is incompatible with the return type documented by `PleskX\Api\Operator\Customer::get` of type `PleskX\Api\Struct\Customer\GeneralInfo`. Loading history...
48			}
49
50			/**
51			* @return Struct\GeneralInfo[]
52			*/
53			public function getAll()
54			{
55			return $this->_get();
56			}
57
58			/**
59			* @param string\|null $field
60			* @param integer\|string\|null $value
61			* @return Struct\GeneralInfo\|Struct\GeneralInfo[]
62			*/
63			private function _get($field = null, $value = null)
64			{
65			$packet = $this->_client->getPacket();
66			$getTag = $packet->addChild('customer')->addChild('get');
67
68			$filterTag = $getTag->addChild('filter');
69			if ($field) {
			0 ignored issues – show Bug Best Practice introduced 2016-11-12 03:12 UTC by Report Bug Copy Issue Report The expression `$field` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
70			$filterTag->addChild($field, $value);
71			}
72
73			$getTag->addChild('dataset')->addChild('gen_info');
74
75			$response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
76
77			$customers = [];
78			foreach ($response->xpath('//result') as $xmlResult) {
79			$customers[] = new Struct\GeneralInfo($xmlResult->data->gen_info);
80			}
81
82			return $field ? reset($customers) : $customers;
83			}
84
85			}
86

plesk / api-php-lib

Push — master ( ff29e2...548de8 )

Customer::_get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like