PleskX\Api\Operator\Customer

Complexity

Total Complexity

9

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	12	2
A	delete()	0	7	1
A	get()	0	4	1
A	getAll()	0	4	1
A	_get()	0	21	4

<?php
// Copyright 1999-2016. Parallels IP Holdings GmbH.

namespace PleskX\Api\Operator;
use PleskX\Api\Struct\Customer as Struct;

class Customer extends \PleskX\Api\Operator
{

    /**
     * @param array $properties
     * @return Struct\Info
     */
    public function create($properties)
    {
        $packet = $this->_client->getPacket();
        $info = $packet->addChild('customer')->addChild('add')->addChild('gen_info');

        foreach ($properties as $name => $value) {
            $info->addChild($name, $value);
        }

        $response = $this->_client->request($packet);
        return new Struct\Info($response);
    }

    /**
     * @param string $field
     * @param integer|string $value
     * @return bool
     */
    public function delete($field, $value)
    {
        $packet = $this->_client->getPacket();
        $packet->addChild('customer')->addChild('del')->addChild('filter')->addChild($field, $value);
        $response = $this->_client->request($packet);
        return 'ok' === (string)$response->status;
    }

    /**
     * @param string $field
     * @param integer|string $value
     * @return Struct\GeneralInfo
     */
    public function get($field, $value)
    {
        return $this->_get($field, $value);

The expression $this->_get($field, $value); of type PleskX\Api\Struct\Customer\GeneralInfo|PleskX\Api\Struct\Customer\GeneralInfo[] adds the type PleskX\Api\Struct\Customer\GeneralInfo[] to the return on line 47 which is incompatible with the return type documented by PleskX\Api\Operator\Customer::get of type PleskX\Api\Struct\Customer\GeneralInfo.

    }

    /**
     * @return Struct\GeneralInfo[]
     */
    public function getAll()
    {
        return $this->_get();
    }

    /**
     * @param string|null $field
     * @param integer|string|null $value
     * @return Struct\GeneralInfo|Struct\GeneralInfo[]
     */
    private function _get($field = null, $value = null)
    {
        $packet = $this->_client->getPacket();
        $getTag = $packet->addChild('customer')->addChild('get');

        $filterTag = $getTag->addChild('filter');
        if ($field) {

The expression $field of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $filterTag->addChild($field, $value);
        }

        $getTag->addChild('dataset')->addChild('gen_info');

        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);

        $customers = [];
        foreach ($response->xpath('//result') as $xmlResult) {
            $customers[] = new Struct\GeneralInfo($xmlResult->data->gen_info);
        }

        return $field ? reset($customers) : $customers;
    }

}