View GitHub Repository under-query

Schedule Inspection
Subscribe
Completed
Push — master ( 3e535a...8096b4 )
by Beniamin
03:04
created
Status
Category
Toggle Patches
src/Phuria/SQLBuilder/QueryCompiler/CompilerPayload.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -65,7 +65,7 @@
 
 block discarded – undo
65 65 
     }
66 66
67 67 
     /**
68 
-     * @param $newSQL
68 
+     * @param string $newSQL
69 69 
      *
70 70 
      * @return CompilerPayload
71 71 
      */
Please login to merge, or discard this patch.
src/Phuria/SQLBuilder/QueryCompiler/ConcreteCompiler/DeleteCompiler.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -33,12 +33,12 @@
 
 block discarded – undo
33 33 
         $clauseCompiler = new ClausesCompiler();
34 34
35 35 
         parent::__construct([
36 
-            [$this,              'compileDelete'],
37 
-            [$tableCompiler,     'compileRootTables'],
38 
-            [$tableCompiler,     'compileJoinTables'],
39 
-            [$clauseCompiler,    'compileWhere'],
40 
-            [$clauseCompiler,    'compileOrderBy'],
41 
-            [$clauseCompiler,    'compileLimit'],
36 
+            [$this, 'compileDelete'],
37 
+            [$tableCompiler, 'compileRootTables'],
38 
+            [$tableCompiler, 'compileJoinTables'],
39 
+            [$clauseCompiler, 'compileWhere'],
40 
+            [$clauseCompiler, 'compileOrderBy'],
41 
+            [$clauseCompiler, 'compileLimit'],
42 42 
             [$referenceCompiler, 'compileReference']
43 43 
         ]);
44 44 
     }
Please login to merge, or discard this patch.
src/Phuria/SQLBuilder/QueryCompiler/ConcreteCompiler/SelectCompiler.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -33,14 +33,14 @@
 
 block discarded – undo
33 33 
         $clauseCompiler = new ClausesCompiler();
34 34
35 35 
         parent::__construct([
36 
-            [$this,              'compileSelect'],
37 
-            [$tableCompiler,     'compileRootTables'],
38 
-            [$tableCompiler,     'compileJoinTables'],
39 
-            [$clauseCompiler,    'compileWhere'],
40 
-            [$clauseCompiler,    'compileGroupBy'],
41 
-            [$clauseCompiler,    'compileHaving'],
42 
-            [$clauseCompiler,    'compileOrderBy'],
43 
-            [$clauseCompiler,    'compileLimit'],
36 
+            [$this, 'compileSelect'],
37 
+            [$tableCompiler, 'compileRootTables'],
38 
+            [$tableCompiler, 'compileJoinTables'],
39 
+            [$clauseCompiler, 'compileWhere'],
40 
+            [$clauseCompiler, 'compileGroupBy'],
41 
+            [$clauseCompiler, 'compileHaving'],
42 
+            [$clauseCompiler, 'compileOrderBy'],
43 
+            [$clauseCompiler, 'compileLimit'],
44 44 
             [$referenceCompiler, 'compileReference']
45 45 
         ]);
46 46 
     }
Please login to merge, or discard this patch.
src/Phuria/SQLBuilder/QueryCompiler/ConcreteCompiler/UpdateCompiler.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -33,13 +33,13 @@
 
 block discarded – undo
33 33 
         $clauseCompiler = new ClausesCompiler();
34 34
35 35 
         parent::__construct([
36 
-            [$this,              'compileUpdate'],
37 
-            [$tableCompiler,     'compileRootTables'],
38 
-            [$tableCompiler,     'compileJoinTables'],
39 
-            [$clauseCompiler,    'compileSet'],
40 
-            [$clauseCompiler,    'compileWhere'],
41 
-            [$clauseCompiler,    'compileOrderBy'],
42 
-            [$clauseCompiler,    'compileLimit'],
36 
+            [$this, 'compileUpdate'],
37 
+            [$tableCompiler, 'compileRootTables'],
38 
+            [$tableCompiler, 'compileJoinTables'],
39 
+            [$clauseCompiler, 'compileSet'],
40 
+            [$clauseCompiler, 'compileWhere'],
41 
+            [$clauseCompiler, 'compileOrderBy'],
42 
+            [$clauseCompiler, 'compileLimit'],
43 43 
             [$referenceCompiler, 'compileReference']
44 44 
         ]);
45 45 
     }
Please login to merge, or discard this patch.
src/Phuria/SQLBuilder/QueryCompiler/ConcreteCompiler/InsertCompiler.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -34,12 +34,12 @@  discard block
 
 block discarded – undo
34 34 
         $referenceCompiler = new ReferenceCompiler();
35 35
36 36 
         parent::__construct([
37 
-            [$this,              'compileInsert'],
38 
-            [$tableCompiler,     'compileRootTables'],
39 
-            [$tableCompiler,     'compileJoinTables'],
40 
-            [$this,              'compileInsertColumns'],
41 
-            [$this,              'compileSelectForInsert'],
42 
-            [$this,              'compileInsertValues'],
37 
+            [$this, 'compileInsert'],
38 
+            [$tableCompiler, 'compileRootTables'],
39 
+            [$tableCompiler, 'compileJoinTables'],
40 
+            [$this, 'compileInsertColumns'],
41 
+            [$this, 'compileSelectForInsert'],
42 
+            [$this, 'compileInsertValues'],
43 43 
             [$referenceCompiler, 'compileReference']
44 44 
         ]);
45 45 
     }
 
@@ -98,8 +98,8 @@  discard block
 
 block discarded – undo
98 98 
         $builder = $payload->getBuilder();
99 99
100 100 
         if ($builder instanceof Component\InsertValuesComponentInterface) {
101 
-            $newSQL = 'VALUES ' . implode(', ', array_map(function (array $values) {
102 
-                return '('. implode(', ', $values) . ')';
101 
+            $newSQL = 'VALUES ' . implode(', ', array_map(function(array $values) {
102 
+                return '(' . implode(', ', $values) . ')';
103 103 
             }, $builder->getValues()));
104 104 
             $payload = $payload->appendSQL($newSQL);
105 105 
         }
Please login to merge, or discard this patch.