Inspection of "Merge pull request #103 from djavolak/tests" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d92200...afdec2 )

by Aleksandar

created 2017-06-14 08:07 UTC

Status

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Article\Controller;
 
@@ -57,12 +57,12 @@  discard block
 block discarded – undo
     public function index(): \Psr\Http\Message\ResponseInterface
     {
         $params = $this->request->getQueryParams();
-        $page   = isset($params['page']) ? $params['page'] : 1;
-        $limit  = isset($params['limit']) ? $params['limit'] : 15;
+        $page   = isset($params[ 'page' ]) ? $params[ 'page' ] : 1;
+        $limit  = isset($params[ 'limit' ]) ? $params[ 'limit' ] : 15;
 
         $discussions = $this->discussionService->fetchAllArticles($page, $limit);
 
-        return new HtmlResponse($this->template->render('article::discussion/index', ['list' => $discussions, 'layout' => 'layout/admin']));
+        return new HtmlResponse($this->template->render('article::discussion/index', [ 'list' => $discussions, 'layout' => 'layout/admin' ]));
     }
 
     /**
@@ -72,14 +72,14 @@  discard block
 block discarded – undo
      *
      * @return \Psr\Http\Message\ResponseInterface
      */
-    public function edit($errors = []): \Psr\Http\Message\ResponseInterface
+    public function edit($errors = [ ]): \Psr\Http\Message\ResponseInterface
     {
         $id         = $this->request->getAttribute('id');
         $discussion = $this->discussionService->fetchSingleArticle($id);
         $categories = $this->categoryService->getAll();
 
-        if($this->request->getParsedBody()) {
-            $discussion             = (object)($this->request->getParsedBody() + (array)$discussion);
+        if ($this->request->getParsedBody()) {
+            $discussion             = (object) ($this->request->getParsedBody() + (array) $discussion);
             $discussion->article_id = $id;
         }
 
@@ -98,16 +98,16 @@  discard block
 block discarded – undo
             $data = $this->request->getParsedBody();
             $user = $this->session->getStorage()->user;
 
-            if($id) {
+            if ($id) {
                 $this->discussionService->updateArticle($data, $id);
             } else {
                 $this->discussionService->createArticle($user, $data);
             }
         }
-        catch(FilterException $fe) {
+        catch (FilterException $fe) {
             return $this->edit($fe->getArrayMessages());
         }
-        catch(\Exception $e) {
+        catch (\Exception $e) {
             throw $e;
         }
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
         try {
             $this->discussionService->deleteArticle($this->request->getAttribute('id'));
         }
-        catch(\Exception $e) {
+        catch (\Exception $e) {
             throw $e;
         }
 

Please login to merge, or discard this patch.

packages/Article/tests/Controller/DiscussionControllerTest.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['discussion' => 'test']);
+        $request = $request->withParsedBody([ 'discussion' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
             ->getMock();
         $discussionService->expects(static::once())
             ->method('updateArticle')
-            ->willThrowException(new \Core\Exception\FilterException(['test error']));
+            ->willThrowException(new \Core\Exception\FilterException([ 'test error' ]));
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,

Please login to merge, or discard this patch.

packages/Article/tests/Controller/EventControllerTest.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['event' => 'test']);
+        $request = $request->withParsedBody([ 'event' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $eventController = new \Article\Controller\EventController(
             $template,
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['event' => 'test']);
+        $request = $request->withParsedBody([ 'event' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $eventController = new \Article\Controller\EventController(
             $template,
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['event' => 'test']);
+        $request = $request->withParsedBody([ 'event' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $eventController = new \Article\Controller\EventController(
             $template,
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
             ->getMock();
         $eventService->expects(static::once())
             ->method('updateArticle')
-            ->willThrowException(new \Core\Exception\FilterException(['test error']));
+            ->willThrowException(new \Core\Exception\FilterException([ 'test error' ]));
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['event' => 'test']);
+        $request = $request->withParsedBody([ 'event' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $eventController = new \Article\Controller\EventController(
             $template,
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['event' => 'test']);
+        $request = $request->withParsedBody([ 'event' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $eventController = new \Article\Controller\EventController(
             $template,

Please login to merge, or discard this patch.

packages/Article/tests/Controller/PostControllerTest.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['post' => 'test']);
+        $request = $request->withParsedBody([ 'post' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $postController = new \Article\Controller\PostController(
             $template,
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['post' => 'test']);
+        $request = $request->withParsedBody([ 'post' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $postController = new \Article\Controller\PostController(
             $template,
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['post' => 'test']);
+        $request = $request->withParsedBody([ 'post' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $postController = new \Article\Controller\PostController(
             $template,
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
             ->getMock();
         $postService->expects(static::once())
             ->method('updateArticle')
-            ->willThrowException(new \Core\Exception\FilterException(['test error']));
+            ->willThrowException(new \Core\Exception\FilterException([ 'test error' ]));
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['post' => 'test']);
+        $request = $request->withParsedBody([ 'post' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $postController = new \Article\Controller\PostController(
             $template,
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['post' => 'test']);
+        $request = $request->withParsedBody([ 'post' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $postController = new \Article\Controller\PostController(
             $template,

Please login to merge, or discard this patch.

packages/Article/tests/Controller/VideoControllerTest.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['video' => 'test']);
+        $request = $request->withParsedBody([ 'video' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $videoController = new \Article\Controller\VideoController(
             $template,
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['video' => 'test']);
+        $request = $request->withParsedBody([ 'video' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $videoController = new \Article\Controller\VideoController(
             $template,
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['video' => 'test']);
+        $request = $request->withParsedBody([ 'video' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $videoController = new \Article\Controller\VideoController(
             $template,
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
             ->getMock();
         $videoService->expects(static::once())
             ->method('updateArticle')
-            ->willThrowException(new \Core\Exception\FilterException(['test error']));
+            ->willThrowException(new \Core\Exception\FilterException([ 'test error' ]));
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['video' => 'test']);
+        $request = $request->withParsedBody([ 'video' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $videoController = new \Article\Controller\VideoController(
             $template,
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['video' => 'test']);
+        $request = $request->withParsedBody([ 'video' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $videoController = new \Article\Controller\VideoController(
             $template,

Please login to merge, or discard this patch.

packages/Article/tests/View/Helper/PostHelperTest.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -16,26 +16,26 @@
 block discarded – undo
     public function testForSelectShouldReturnArray()
     {
         $postService = $this->getMockBuilder('Article\Service\PostService')
-            ->setMethods(['getForSelect'])
+            ->setMethods([ 'getForSelect' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $postService->expects(static::once())
             ->method('getForSelect')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $postHelper = new \Article\View\Helper\PostHelper($postService);
-        static::assertSame([], $postHelper->forSelect());
+        static::assertSame([ ], $postHelper->forSelect());
     }
 
     public function testForWebShouldReturnArray()
     {
         $postService = $this->getMockBuilder('Article\Service\PostService')
-            ->setMethods(['getLatestWeb'])
+            ->setMethods([ 'getLatestWeb' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $postService->expects(static::once())
             ->method('getLatestWeb')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $postHelper = new \Article\View\Helper\PostHelper($postService);
-        static::assertSame([], $postHelper->forWeb());
+        static::assertSame([ ], $postHelper->forWeb());
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

packages/Article/tests/View/Helper/VideoHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
     public function testGetLatestShouldReturnArray()
     {
         $videoService = $this->getMockBuilder('Article\Service\VideoService')
-            ->setMethods(['fetchLatest'])
+            ->setMethods([ 'fetchLatest' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $videoService->expects(static::once())
             ->method('fetchLatest')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $videoHelper = new \Article\View\Helper\VideoHelper($videoService);
-        static::assertSame([], $videoHelper->getLatest());
+        static::assertSame([ ], $videoHelper->getLatest());
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

packages/Article/tests/View/Helper/EventHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
     public function testAllShouldReturnArray()
     {
         $eventService = $this->getMockBuilder('Article\Service\EventService')
-            ->setMethods(['fetchLatest'])
+            ->setMethods([ 'fetchLatest' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $eventService->expects(static::once())
             ->method('fetchLatest')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $eventHelper = new \Article\View\Helper\EventHelper($eventService);
-        static::assertSame([], $eventHelper->getLatest());
+        static::assertSame([ ], $eventHelper->getLatest());
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

packages/Article/tests/Factory/Controller/DiscussionFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@
 block discarded – undo
             ->getMockForAbstractClass();
         $session = new \Zend\Session\SessionManager();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

		@@ -1,6 +1,6 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-declare(strict_types=1);
	3	+declare(strict_types = 1);
4	4
5	5	namespace Article\Controller;
6	6
		@@ -57,12 +57,12 @@ discard block
		block discarded – undo
57	57	public function index(): \Psr\Http\Message\ResponseInterface
58	58	{
59	59	$params = $this->request->getQueryParams();
60		- $page = isset($params['page']) ? $params['page'] : 1;
61		- $limit = isset($params['limit']) ? $params['limit'] : 15;
	60	+ $page = isset($params[ 'page' ]) ? $params[ 'page' ] : 1;
	61	+ $limit = isset($params[ 'limit' ]) ? $params[ 'limit' ] : 15;
62	62
63	63	$discussions = $this->discussionService->fetchAllArticles($page, $limit);
64	64
65		- return new HtmlResponse($this->template->render('article::discussion/index', ['list' => $discussions, 'layout' => 'layout/admin']));
	65	+ return new HtmlResponse($this->template->render('article::discussion/index', [ 'list' => $discussions, 'layout' => 'layout/admin' ]));
66	66	}
67	67
68	68	/**
		@@ -72,14 +72,14 @@ discard block
		block discarded – undo
72	72	*
73	73	* @return \Psr\Http\Message\ResponseInterface
74	74	*/
75		- public function edit($errors = []): \Psr\Http\Message\ResponseInterface
	75	+ public function edit($errors = [ ]): \Psr\Http\Message\ResponseInterface
76	76	{
77	77	$id = $this->request->getAttribute('id');
78	78	$discussion = $this->discussionService->fetchSingleArticle($id);
79	79	$categories = $this->categoryService->getAll();
80	80
81		- if($this->request->getParsedBody()) {
82		- $discussion = (object)($this->request->getParsedBody() + (array)$discussion);
	81	+ if ($this->request->getParsedBody()) {
	82	+ $discussion = (object) ($this->request->getParsedBody() + (array) $discussion);
83	83	$discussion->article_id = $id;
84	84	}
85	85
		@@ -98,16 +98,16 @@ discard block
		block discarded – undo
98	98	$data = $this->request->getParsedBody();
99	99	$user = $this->session->getStorage()->user;
100	100
101		- if($id) {
	101	+ if ($id) {
102	102	$this->discussionService->updateArticle($data, $id);
103	103	} else {
104	104	$this->discussionService->createArticle($user, $data);
105	105	}
106	106	}
107		- catch(FilterException $fe) {
	107	+ catch (FilterException $fe) {
108	108	return $this->edit($fe->getArrayMessages());
109	109	}
110		- catch(\Exception $e) {
	110	+ catch (\Exception $e) {
111	111	throw $e;
112	112	}
113	113
		@@ -119,7 +119,7 @@ discard block
		block discarded – undo
119	119	try {
120	120	$this->discussionService->deleteArticle($this->request->getAttribute('id'));
121	121	}
122		- catch(\Exception $e) {
	122	+ catch (\Exception $e) {
123	123	throw $e;
124	124	}
125	125

		@@ -7,7 +7,7 @@ discard block
		block discarded – undo
7	7	public function testIndexMethodShouldReturnHtmlResponse()
8	8	{
9	9	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
10		- ->setMethods(['render'])
	10	+ ->setMethods([ 'render' ])
11	11	->getMockForAbstractClass();
12	12	$template->expects(static::once())
13	13	->method('render')
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	$sessionStorage = new \Zend\Session\Storage\ArrayStorage();
44	44	$sessionStorage->user = $user;
45	45	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
46		- ->setMethods(['render'])
	46	+ ->setMethods([ 'render' ])
47	47	->getMockForAbstractClass();
48	48	$template->expects(static::once())
49	49	->method('render')
		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	$sessionStorage = new \Zend\Session\Storage\ArrayStorage();
81	81	$sessionStorage->user = $user;
82	82	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
83		- ->setMethods(['render'])
	83	+ ->setMethods([ 'render' ])
84	84	->getMockForAbstractClass();
85	85	$template->expects(static::once())
86	86	->method('render')
		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99	$request = new \Zend\Diactoros\ServerRequest();
100	100	$request = $request->withAttribute('action', 'edit');
101	101	$request = $request->withAttribute('id', 1);
102		- $request = $request->withParsedBody(['discussion' => 'test']);
	102	+ $request = $request->withParsedBody([ 'discussion' => 'test' ]);
103	103	$response = new \Zend\Diactoros\Response();
104	104	$discussionController = new \Article\Controller\DiscussionController(
105	105	$template,
		@@ -135,7 +135,7 @@ discard block
		block discarded – undo
135	135	->will(static::returnValue('http://unfinished.dev/admin'));
136	136	$request = new \Zend\Diactoros\ServerRequest();
137	137	$request = $request->withAttribute('action', 'save');
138		- $request = $request->withParsedBody(['user' => 'test']);
	138	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
139	139	$response = new \Zend\Diactoros\Response();
140	140	$discussionController = new \Article\Controller\DiscussionController(
141	141	$template,
		@@ -174,7 +174,7 @@ discard block
		block discarded – undo
174	174	$request = new \Zend\Diactoros\ServerRequest();
175	175	$request = $request->withAttribute('action', 'save');
176	176	$request = $request->withAttribute('id', 2);
177		- $request = $request->withParsedBody(['user' => 'test']);
	177	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
178	178	$response = new \Zend\Diactoros\Response();
179	179	$discussionController = new \Article\Controller\DiscussionController(
180	180	$template,
		@@ -207,7 +207,7 @@ discard block
		block discarded – undo
207	207	->getMock();
208	208	$discussionService->expects(static::once())
209	209	->method('updateArticle')
210		- ->willThrowException(new \Core\Exception\FilterException(['test error']));
	210	+ ->willThrowException(new \Core\Exception\FilterException([ 'test error' ]));
211	211	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
212	212	->disableOriginalConstructor()
213	213	->getMock();
		@@ -216,7 +216,7 @@ discard block
		block discarded – undo
216	216	$request = new \Zend\Diactoros\ServerRequest();
217	217	$request = $request->withAttribute('action', 'save');
218	218	$request = $request->withAttribute('id', 2);
219		- $request = $request->withParsedBody(['user' => 'test']);
	219	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
220	220	$response = new \Zend\Diactoros\Response();
221	221	$discussionController = new \Article\Controller\DiscussionController(
222	222	$template,
		@@ -260,7 +260,7 @@ discard block
		block discarded – undo
260	260	$request = new \Zend\Diactoros\ServerRequest();
261	261	$request = $request->withAttribute('action', 'save');
262	262	$request = $request->withAttribute('id', 2);
263		- $request = $request->withParsedBody(['user' => 'test']);
	263	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
264	264	$response = new \Zend\Diactoros\Response();
265	265	$discussionController = new \Article\Controller\DiscussionController(
266	266	$template,

		@@ -16,26 +16,26 @@
		block discarded – undo
16	16	public function testForSelectShouldReturnArray()
17	17	{
18	18	$postService = $this->getMockBuilder('Article\Service\PostService')
19		- ->setMethods(['getForSelect'])
	19	+ ->setMethods([ 'getForSelect' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$postService->expects(static::once())
23	23	->method('getForSelect')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$postHelper = new \Article\View\Helper\PostHelper($postService);
26		- static::assertSame([], $postHelper->forSelect());
	26	+ static::assertSame([ ], $postHelper->forSelect());
27	27	}
28	28
29	29	public function testForWebShouldReturnArray()
30	30	{
31	31	$postService = $this->getMockBuilder('Article\Service\PostService')
32		- ->setMethods(['getLatestWeb'])
	32	+ ->setMethods([ 'getLatestWeb' ])
33	33	->disableOriginalConstructor()
34	34	->getMockForAbstractClass();
35	35	$postService->expects(static::once())
36	36	->method('getLatestWeb')
37		- ->willReturn([]);
	37	+ ->willReturn([ ]);
38	38	$postHelper = new \Article\View\Helper\PostHelper($postService);
39		- static::assertSame([], $postHelper->forWeb());
	39	+ static::assertSame([ ], $postHelper->forWeb());
40	40	}
41	41	}
42	42	\ No newline at end of file

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	public function testGetLatestShouldReturnArray()
17	17	{
18	18	$videoService = $this->getMockBuilder('Article\Service\VideoService')
19		- ->setMethods(['fetchLatest'])
	19	+ ->setMethods([ 'fetchLatest' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$videoService->expects(static::once())
23	23	->method('fetchLatest')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$videoHelper = new \Article\View\Helper\VideoHelper($videoService);
26		- static::assertSame([], $videoHelper->getLatest());
	26	+ static::assertSame([ ], $videoHelper->getLatest());
27	27	}
28	28	}
29	29	\ No newline at end of file

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	public function testAllShouldReturnArray()
17	17	{
18	18	$eventService = $this->getMockBuilder('Article\Service\EventService')
19		- ->setMethods(['fetchLatest'])
	19	+ ->setMethods([ 'fetchLatest' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$eventService->expects(static::once())
23	23	->method('fetchLatest')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$eventHelper = new \Article\View\Helper\EventHelper($eventService);
26		- static::assertSame([], $eventHelper->getLatest());
	26	+ static::assertSame([ ], $eventHelper->getLatest());
27	27	}
28	28	}
29	29	\ No newline at end of file

		@@ -18,7 +18,7 @@
		block discarded – undo
18	18	->getMockForAbstractClass();
19	19	$session = new \Zend\Session\SessionManager();
20	20	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
21		- ->setMethods(['get'])
	21	+ ->setMethods([ 'get' ])
22	22	->getMockForAbstractClass();
23	23	$container->expects(static::at(0))
24	24	->method('get')

phpsrbija / unfinished

Push — master ( d92200...afdec2 )

Status

Category

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch