phpmetrics / PhpMetrics

src/Hal/Metric/Package/PackageCollectingVisitor.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\Interface_;
 use PhpParser\Node\Stmt\Namespace_;
-use PhpParser\Node\Stmt\Trait_;
 use PhpParser\NodeVisitorAbstract;
 
 class PackageCollectingVisitor extends NodeVisitorAbstract

Spacing +3 added lines, -3 removed lines

@@ -42,11 +42,11 @@
                 $package = $matches[1];
             }
             if (preg_match('/^\s*\* @subpackage (.*)/m', $docBlockText, $matches)) {
-                $package = $package . '\\' . $matches[1];
+                $package = $package.'\\'.$matches[1];
             }
 
-            $packageName = $package . '\\';
-            if (! $packageMetric = $this->metrics->get($packageName)) {
+            $packageName = $package.'\\';
+            if (!$packageMetric = $this->metrics->get($packageName)) {
                 $packageMetric = new PackageMetric($packageName);
                 $this->metrics->attach($packageMetric);
             }

src/Hal/Metric/PackageMetric.php

Doc Comments +9 added lines

@@ -13,6 +13,9 @@ 
         return $this->has('classes') ? $this->get('classes') : [];
     }
 
+    /**
+     * @param string $name
+     */
     public function addClass($name)
     {
         $elements = $this->get('classes');
@@ -20,6 +23,9 @@ 
         $this->set('classes', $elements);
     }
 
+    /**
+     * @param integer $abstraction
+     */
     public function setAbstraction($abstraction)
     {
         $this->set('abstraction', $abstraction);
@@ -30,6 +36,9 @@ 
         return $this->get('abstraction');
     }
 
+    /**
+     * @param integer $abstraction
+     */
     public function setInstability($abstraction)
     {
         $this->set('instability', $abstraction);

Spacing +4 added lines, -4 removed lines

@@ -47,11 +47,11 @@ 
         }
         $classDependencies = $this->getOutgoingClassDependencies();
         $packageDependencies = $this->getOutgoingPackageDependencies();
-        if (! in_array($className, $classDependencies)) {
+        if (!in_array($className, $classDependencies)) {
             $classDependencies[] = $className;
             $this->set('outgoing_class_dependencies', $classDependencies);
         }
-        if (! in_array($packageName, $packageDependencies)) {
+        if (!in_array($packageName, $packageDependencies)) {
             $packageDependencies[] = $packageName;
             $this->set('outgoing_package_dependencies', $packageDependencies);
         }
@@ -75,11 +75,11 @@ 
         }
         $classDependencies = $this->getIncomingClassDependencies();
         $packageDependencies = $this->getIncomingPackageDependencies();
-        if (! in_array($className, $classDependencies)) {
+        if (!in_array($className, $classDependencies)) {
             $classDependencies[] = $className;
             $this->set('incoming_class_dependencies', $classDependencies);
         }
-        if (! in_array($packageName, $packageDependencies)) {
+        if (!in_array($packageName, $packageDependencies)) {
             $packageDependencies[] = $packageName;
             $this->set('incoming_package_dependencies', $packageDependencies);
         }

src/Hal/Violation/Package/StableDependenciesPrinciple.php

Spacing +3 added lines, -3 removed lines

@@ -21,13 +21,13 @@ 
 
     public function apply(Metric $metric)
     {
-        if (! $metric instanceof PackageMetric) {
+        if (!$metric instanceof PackageMetric) {
             return;
         }
         $instability = $metric->getInstability();
         $violatingInstabilities = array_filter(
             $metric->getDependentInstabilities(),
-            function ($otherInstability) use ($instability) {
+            function($otherInstability) use ($instability) {
                 return $otherInstability >= $instability;
             }
         );
@@ -47,7 +47,7 @@ 
     {
         $count = count($this->violatingInstabilities);
         $thisInstability = round($this->metric->getInstability(), 3);
-        $packages = implode("\n* ", array_map(function ($name, $instability) {
+        $packages = implode("\n* ", array_map(function($name, $instability) {
             $name = $name === '\\' ? 'global' : substr($name, 0, -1);
             $instability = round($instability, 3);
             return "$name ($instability)";

src/Hal/Report/Html/template/_footer.php

Spacing +4 added lines, -4 removed lines

@@ -1,7 +1,7 @@ 
 </div>
 
 <!-- Sidebar -->
-<?php if(!isset($fullwidth) || $fullwidth === false) {?>
+<?php if (!isset($fullwidth) || $fullwidth === false) {?>
 <div id="sidebar">
     <div class="content">
         <div class="logo">
@@ -28,10 +28,10 @@ 
                             <path d="M0 0h24v24H0z" fill="none"/>
                             <path d="M20 8h-2.81c-.45-.78-1.07-1.45-1.82-1.96L17 4.41 15.59 3l-2.17 2.17C12.96 5.06 12.49 5 12 5c-.49 0-.96.06-1.41.17L8.41 3 7 4.41l1.62 1.63C7.88 6.55 7.26 7.22 6.81 8H4v2h2.09c-.05.33-.09.66-.09 1v1H4v2h2v1c0 .34.04.67.09 1H4v2h2.81c1.04 1.79 2.97 3 5.19 3s4.15-1.21 5.19-3H20v-2h-2.09c.05-.33.09-.66.09-1v-1h2v-2h-2v-1c0-.34-.04-.67-.09-1H20V8zm-6 8h-4v-2h4v2zm0-4h-4v-2h4v2z"/>
                         </svg>
-                        Violations (<?php echo $sum->violations->total;?>)
+                        Violations (<?php echo $sum->violations->total; ?>)
                     </a>
                 </li>
-                <?php if($config->has('junit')) { ?>
+                <?php if ($config->has('junit')) { ?>
                     <li>
                         <a href="junit.html">
                             <svg fill="#FFFFFF" height="24" viewBox="0 0 24 24" width="24" xmlns="http://www.w3.org/2000/svg">
@@ -125,7 +125,7 @@ 
                         Package relations
                     </a>
                 </li>
-                <?php if($config->has('git')) { ?>
+                <?php if ($config->has('git')) { ?>
                 <li>
                     <a href="git.html">
                         <img src="images/logo-git.png" alt="">

src/Hal/Report/Html/template/packages.php

Spacing +2 added lines, -2 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-require __DIR__ . '/_header.php'; ?>
+require __DIR__.'/_header.php'; ?>
 
     <div class="row">
         <div class="column">
@@ -40,7 +40,7 @@ 
             </div>
         </div>
     </div>
-<?php require __DIR__ . '/_footer.php'; ?>
+<?php require __DIR__.'/_footer.php'; ?>
 <?php
 $spots = [];
 foreach ($packages as $each) {

src/Hal/Report/Html/template/package_relations.php

Spacing +3 added lines, -3 removed lines

@@ -1,8 +1,8 @@ 
-<?php require __DIR__ . '/_header.php'; ?>
+<?php require __DIR__.'/_header.php'; ?>
 
 <?php
 $relations = [];
-$getPackageName = function ($name) {
+$getPackageName = function($name) {
     return $name === '\\' ? 'global' : substr($name, 0, -1);
 };
 foreach ($packages as $package) {
@@ -41,7 +41,7 @@ 
     </div>
 </div>
 
-<?php require __DIR__ . '/_footer.php'; ?>
+<?php require __DIR__.'/_footer.php'; ?>
 
 
 <script type="text/javascript">

src/Hal/Report/Html/template/violations.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php require __DIR__ . '/_header.php'; ?>
+<?php require __DIR__.'/_header.php'; ?>
 
 <?php
 $map = [
@@ -57,7 +57,7 @@ 
                     <tbody>
                     <?php foreach ($classes as $class) {
                         if (sizeof($class['violations']) > 0) {
-                            $currentId = 'bloc-' . uniqid();
+                            $currentId = 'bloc-'.uniqid();
                             ?>
 
                             <tr>
@@ -108,7 +108,7 @@ 
                     <tbody>
                     <?php foreach ($packages as $package) {
                         if (sizeof($package['violations']) > 0) {
-                            $currentId = 'bloc-' . uniqid();
+                            $currentId = 'bloc-'.uniqid();
                             ?>
 
                             <tr>
@@ -158,4 +158,4 @@ 
             }
         }
     </script>
-<?php require __DIR__ . '/_footer.php'; ?>
\ No newline at end of file
+<?php require __DIR__.'/_footer.php'; ?>
\ No newline at end of file

src/Hal/Report/Html/Reporter.php

Spacing +24 added lines, -24 removed lines

@@ -44,11 +44,11 @@ 
         $consolidated = new Consolidated($metrics);
 
         // history of builds
-        $today = (object)[
+        $today = (object) [
             'avg' => $consolidated->getAvg(),
             'sum' => $consolidated->getSum()
         ];
-        $files = glob($logDir . '/js/history-*.json');
+        $files = glob($logDir.'/js/history-*.json');
         $next = sizeof($files) + 1;
         $history = [];
         natsort($files);
@@ -57,35 +57,35 @@ 
         }
 
         // copy sources
-        if(!file_exists($logDir . '/js')) {
+        if (!file_exists($logDir.'/js')) {
             mkdir($logDir.'/js', 0755, true);
         }
-        if(!file_exists($logDir . '/css')) {
+        if (!file_exists($logDir.'/css')) {
             mkdir($logDir.'/css', 0755, true);
         }
-        if(!file_exists($logDir . '/images')) {
+        if (!file_exists($logDir.'/images')) {
             mkdir($logDir.'/images', 0755, true);
         }
-        recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
-        recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
-        recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
+        recurse_copy(__DIR__.'/template/js', $logDir.'/js');
+        recurse_copy(__DIR__.'/template/css', $logDir.'/css');
+        recurse_copy(__DIR__.'/template/images', $logDir.'/images');
 
         // render dynamic pages
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/packages.php', $logDir . '/packages.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/package_relations.php', $logDir . '/package_relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/packages.php', $logDir.'/packages.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/package_relations.php', $logDir.'/package_relations.html', $consolidated, $history);
         if ($this->config->has('git')) {
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
         }
-        $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
 
         // js data
         file_put_contents(
@@ -99,8 +99,8 @@ 
 
         // json data
         file_put_contents(
-            $logDir . '/js/classes.js',
-            'var classes = ' . json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
+            $logDir.'/js/classes.js',
+            'var classes = '.json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
         );
 
         $this->output->writeln(sprintf('HTML report generated in "%s" directory', $logDir));
@@ -169,7 +169,7 @@ 
 
         $diff = $newValue - $oldValue;
         if ($diff > 0) {
-            $diff = '+' . $diff;
+            $diff = '+'.$diff;
         }
 
         $goodOrBad = 'neutral';

src/Hal/Metric/Class_/ClassEnumVisitor.php

Spacing +3 added lines, -3 removed lines

@@ -39,9 +39,9 @@ 
                 $class->set('abstract', true);
             } else {
 
-                if(null === $node->name) {
+                if (null === $node->name) {
                     // anonymous class
-                    $name = 'anonymous@' . spl_object_hash($node);
+                    $name = 'anonymous@'.spl_object_hash($node);
                 } else {
                     $name = $node->namespacedName->toString();
                 }
@@ -90,7 +90,7 @@ 
             }
 
             $class->set('methods', $methods);
-            $class->set('nbMethodsIncludingGettersSetters', sizeof($methods) );
+            $class->set('nbMethodsIncludingGettersSetters', sizeof($methods));
             $class->set('nbMethods', sizeof($methods) - ($nbGetters + $nbSetters));
             $class->set('nbMethodsPrivate', $methodsPrivate);
             $class->set('nbMethodsPublic', $methodsPublic);