Hal\Metric\Package\PackageInstability::calculate()

Complexity

Conditions	5
Paths	6

Size

Total Lines	34
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function calculate(Metrics $metrics)
    {
        /* @var $packages PackageMetric[] */
        $packages = array_filter($metrics->all(), function ($metric) {
            return $metric instanceof PackageMetric;
        });

        // Calculate instability
        $instabilitiesByPackage = [];
        foreach ($packages as $eachPackage) {
            $afferentCoupling = count($eachPackage->getIncomingClassDependencies());
            $efferentCoupling = count($eachPackage->getOutgoingClassDependencies());
            if ($afferentCoupling + $efferentCoupling !== 0) {
                $eachPackage->setInstability(
                    $efferentCoupling / ($afferentCoupling + $efferentCoupling)
                );
                $instabilitiesByPackage[$eachPackage->getName()] = $eachPackage->getInstability();

Are you sure the assignment to $instabilitiesByPackage[$eachPackage->getName()] is correct as $eachPackage->getInstability() (which targets Hal\Metric\PackageMetric::getInstability()) seems to always return null.

            }
        }

        // Set depending instabilities
        foreach ($packages as $eachPackage) {
            $dependentInstabilities = array_map(function ($packageName) use ($instabilitiesByPackage) {
                return isset($instabilitiesByPackage[$packageName]) ? $instabilitiesByPackage[$packageName] : null;
            }, $eachPackage->getOutgoingPackageDependencies());
            $dependentInstabilities = array_combine(
                $eachPackage->getOutgoingPackageDependencies(),
                $dependentInstabilities
            );
            $dependentInstabilities = array_filter($dependentInstabilities);
            $eachPackage->setDependentInstabilities($dependentInstabilities);
        }

    }
}