Reporter::generate() - Code Metrics - Inspection of "Feature/reports" - phpmetrics/PhpMetrics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#301)

by personal

created 2017-09-13 16:16 UTC

Reporter::generate() B

↳ Parent: Reporter

Complexity

Conditions	5
Paths	4

Size

Total Lines	17
Code Lines	9

Duplication

Lines	3
Ratio	17.65 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	5
eloc	9
c	1
b	0
f	1
nc	4
nop	1
dl	3
loc	17
rs	8.8571

<?php
namespace Hal\Report\Json;

use Hal\Application\Config\Config;
use Hal\Component\Output\Output;
use Hal\Metric\Metrics;

class Reporter
{

    /**
     * @var Config
     */
    private $config;

    /**
     * @var OutputInterface
     */
    private $output;

    /**
     * Reporter constructor.
     * @param Config $config
     * @param Output $output
     */
    public function __construct(Config $config, Output $output)
    {
        $this->config = $config;
        $this->output = $output;

    }


    public function generate(Metrics $metrics)
    {
        if ($this->config->has('quiet')) {
            return;
        }


        $logFile = $this->config->get('report-json');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if (!$logFile) {
            return;
        }
        if (!file_exists(dirname($logFile)) || !is_writable(dirname($logFile))) {

            throw new \RuntimeException('You don\'t have permissions to write JSON report in ' . $logFile);
        }

        file_put_contents($logFile, json_encode($metrics, JSON_PRETTY_PRINT));
    }
}


1		<?php
2		namespace Hal\Report\Json;
3
4		use Hal\Application\Config\Config;
5		use Hal\Component\Output\Output;
6		use Hal\Metric\Metrics;
7
8		class Reporter
9		{
10
11		/**
12		* @var Config
13		*/
14		private $config;
15
16		/**
17		* @var OutputInterface
18		*/
19		private $output;
20
21		/**
22		* Reporter constructor.
23		* @param Config $config
24		* @param Output $output
25		*/
26		public function __construct(Config $config, Output $output)
27		{
28		$this->config = $config;
29		$this->output = $output;
		0 ignored issues – show Documentation Bug introduced 2017-09-13 16:18 UTC by Report Bug Copy Issue Report It seems like `$output` of type `object<Hal\Component\Output\Output>` is incompatible with the declared type `object<Hal\Report\Json\OutputInterface>` of property `$output`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
30		}
31
32
33		public function generate(Metrics $metrics)
34		{
35		if ($this->config->has('quiet')) {
36		return;
37		}
38
39
40		$logFile = $this->config->get('report-json');
		0 ignored issues – show Bug introduced 2017-09-13 16:18 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$logFile` is correct as `$this->config->get('report-json')` (which targets `Hal\Application\Config\Config::get()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
41		if (!$logFile) {
42		return;
43		}
44	View Code Duplication	if (!file_exists(dirname($logFile)) \|\| !is_writable(dirname($logFile))) {
		0 ignored issues – show Duplication introduced 2017-09-13 16:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		throw new \RuntimeException('You don\'t have permissions to write JSON report in ' . $logFile);
46		}
47
48		file_put_contents($logFile, json_encode($metrics, JSON_PRETTY_PRINT));
49		}
50		}
51

phpmetrics / PhpMetrics

Pull Request — master (#301)

Reporter::generate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like