Hal\Report\Json\Reporter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	6.98 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	generate()	3	17	5

<?php
namespace Hal\Report\Json;

use Hal\Application\Config\Config;
use Hal\Component\Output\Output;
use Hal\Metric\Metrics;

class Reporter
{

    /**
     * @var Config
     */
    private $config;

    /**
     * @var OutputInterface
     */
    private $output;

    /**
     * Reporter constructor.
     * @param Config $config
     * @param Output $output
     */
    public function __construct(Config $config, Output $output)
    {
        $this->config = $config;
        $this->output = $output;

It seems like $output of type object<Hal\Component\Output\Output> is incompatible with the declared type object<Hal\Report\Json\OutputInterface> of property $output.

    }


    public function generate(Metrics $metrics)
    {
        if ($this->config->has('quiet')) {
            return;
        }


        $logFile = $this->config->get('report-json');

Are you sure the assignment to $logFile is correct as $this->config->get('report-json') (which targets Hal\Application\Config\Config::get()) seems to always return null.

        if (!$logFile) {
            return;
        }
        if (!file_exists(dirname($logFile)) || !is_writable(dirname($logFile))) {

This code seems to be duplicated across your project.

            throw new \RuntimeException('You don\'t have permissions to write JSON report in ' . $logFile);
        }

        file_put_contents($logFile, json_encode($metrics, JSON_PRETTY_PRINT));
    }
}