phpmetrics / PhpMetrics

src/Hal/Component/Issue/Issuer.php

Doc Comments +4 added lines, -3 removed lines

@@ -130,7 +130,7 @@ 
     }
 
     /**
-     * @param $status
+     * @param integer $status
      */
     protected function terminate($status)
     {
@@ -139,6 +139,7 @@ 
 
     /**
      * @param $log
+     * @param string $logfile
      * @return $this
      */
     protected function log($logfile, $log)
@@ -152,7 +153,7 @@ 
     }
 
     /**
-     * @param $debugKey
+     * @param string $debugKey
      * @param $value
      * @return $this
      */
@@ -163,7 +164,7 @@ 
     }
 
     /**
-     * @param $debugKey
+     * @param string $debugKey
      * @return $this
      */
     public function clear($debugKey)

src/Hal/Metric/BagTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return null
      */
     public function get($key)

src/Hal/Metric/Class_/ClassEnumVisitor.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Hal\Metric\Class_;
 
-use Hal\Component\Reflected\Method;
 use Hal\Metric\ClassMetric;
 use Hal\Metric\FunctionMetric;
 use Hal\Metric\Helper\RoleOfMethodDetector;

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
             }
 
             $class->set('methods', $methods);
-            $class->set('nbMethodsIncludingGettersSetters', sizeof($methods) );
+            $class->set('nbMethodsIncludingGettersSetters', sizeof($methods));
             $class->set('nbMethods', sizeof($methods) - ($nbGetters + $nbSetters));
             $class->set('nbMethodsPrivate', $methodsPrivate);
             $class->set('nbMethodsPublic', $methodsPublic);

src/Hal/Metric/Class_/Complexity/CyclomaticComplexityVisitor.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Hal\Metric\Class_\Complexity;
 
-use Hal\Component\Reflected\Method;
 use Hal\Metric\Metrics;
 use PhpParser\Node;
 use PhpParser\Node\Stmt;

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
                 if ($stmt instanceof Stmt\ClassMethod) {
 
                     // iterate over childs, recursively
-                    $cb = function ($node) use (&$cb) {
+                    $cb = function($node) use (&$cb) {
                         $ccn = 0;
                         if (isset($node->stmts) && $node->stmts) {
                             foreach ($node->stmts as $child) {

src/Hal/Metric/Class_/Component/MaintainabilityIndexVisitor.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Hal\Metric\FunctionMetric;
 use Hal\Metric\Metrics;
-use Hoa\Ruler\Model\Bag\Scalar;
 use PhpParser\Node;
 use PhpParser\Node\Stmt;
 use PhpParser\NodeVisitorAbstract;

src/Hal/Report/Html/Reporter.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
     }
 
     /**
-     * @param $source
-     * @param $destination
+     * @param string $source
+     * @param string $destination
      * @return $this
      */
     public function renderPage($source, $destination, Consolidated $consolidated, $history)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Hal\Application\Config\Config;
 use Hal\Metric\Consolidated;
-use Hal\Metric\Consolided;
 use Hal\Metric\Metrics;
 use Symfony\Component\Console\Output\OutputInterface;
 

Indentation +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
             sprintf('%s/js/history-%d.json', $logDir, $next),
             json_encode($today, JSON_PRETTY_PRINT)
         );
-	file_put_contents(
+    file_put_contents(
             sprintf('%s/js/latest.json', $logDir, $next),
             json_encode($today, JSON_PRETTY_PRINT)
         );

Spacing +22 added lines, -22 removed lines

@@ -44,11 +44,11 @@ 
         $consolidated = new Consolidated($metrics);
 
         // history of builds
-        $today = (object)[
+        $today = (object) [
             'avg' => $consolidated->getAvg(),
             'sum' => $consolidated->getSum()
         ];
-        $files = glob($logDir . '/js/history-*.json');
+        $files = glob($logDir.'/js/history-*.json');
         $next = sizeof($files) + 1;
         $history = [];
         natsort($files);
@@ -57,34 +57,34 @@ 
         }
 
         // copy sources
-        if(!file_exists($logDir . '/js')) {
+        if (!file_exists($logDir.'/js')) {
             mkdir($logDir.'/js', 0755, true);
         }
-        if(!file_exists($logDir . '/css')) {
+        if (!file_exists($logDir.'/css')) {
             mkdir($logDir.'/css', 0755, true);
         }
-        if(!file_exists($logDir . '/images')) {
+        if (!file_exists($logDir.'/images')) {
             mkdir($logDir.'/images', 0755, true);
         }
-        recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
-        recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
-        recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
+        recurse_copy(__DIR__.'/template/js', $logDir.'/js');
+        recurse_copy(__DIR__.'/template/css', $logDir.'/css');
+        recurse_copy(__DIR__.'/template/images', $logDir.'/images');
 
         // render dynamic pages
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
         if ($this->config->has('git')) {
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
         }
         if ($this->config->has('junit')) {
-            $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
         }
 
         // js data
@@ -99,8 +99,8 @@ 
 
         // json data
         file_put_contents(
-            $logDir . '/js/classes.js',
-            'var classes = ' . json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
+            $logDir.'/js/classes.js',
+            'var classes = '.json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
         );
 
         $this->output->writeln(sprintf('HTML report generated in "%s" directory', $logDir),
@@ -169,7 +169,7 @@ 
 
         $diff = $newValue - $oldValue;
         if ($diff > 0) {
-            $diff = '+' . $diff;
+            $diff = '+'.$diff;
         }
 
         $goodOrBad = 'neutral';

src/Hal/Report/Violations/Xml/Reporter.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Hal\Report\Violations\Xml;
 
 use Hal\Application\Config\Config;
-use Hal\Metric\Consolided;
 use Hal\Metric\Metrics;
 use Hal\Violation\Violation;
 use Symfony\Component\Console\Output\OutputInterface;

src/functions.php

Spacing +6 added lines, -6 removed lines

@@ -90,7 +90,7 @@ 
     }
 
     if ($node instanceof \PhpParser\Node\Name\FullyQualified) {
-        return (string)$node;
+        return (string) $node;
     }
     if ($node instanceof \PhpParser\Node\Expr\New_) {
         return getNameOfNode($node->class);
@@ -101,7 +101,7 @@ 
     }
 
     if ($node instanceof \PhpParser\Node\Name) {
-        return (string)implode($node->parts);
+        return (string) implode($node->parts);
     }
 
     if (isset($node->name) && $node->name instanceof \PhpParser\Node\Expr\Variable) {
@@ -129,7 +129,7 @@ 
     }
 
     if (isset($node->name)) {
-        return (string)$node->name;
+        return (string) $node->name;
     }
 
     return null;
@@ -147,10 +147,10 @@ 
     }
     while (false !== ($file = readdir($dir))) {
         if (($file != '.') && ($file != '..')) {
-            if (is_dir($src . '/' . $file)) {
-                recurse_copy($src . '/' . $file, $dst . '/' . $file);
+            if (is_dir($src.'/'.$file)) {
+                recurse_copy($src.'/'.$file, $dst.'/'.$file);
             } else {
-                copy($src . '/' . $file, $dst . '/' . $file);
+                copy($src.'/'.$file, $dst.'/'.$file);
             }
         }
     }

src/Hal/Violation/Violations.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
     {
         $string = '';
         foreach ($this->data as $violation) {
-            $string .= $violation->getName() . ',';
+            $string .= $violation->getName().',';
         }
         return $string;
     }