phpmetrics / PhpMetrics

src/Hal/Application/Application.php

Doc Comments +1 added lines, -1 removed lines

@@ -120,7 +120,7 @@
 
     /**
      * Standardize the output error when an exception occurs.
-     * @param Throwable $e Throwable object we will get its message to output.
+     * @param ConfigException $e Throwable object we will get its message to output.
      * @return CliOutput
      */
     private function outputException(Throwable $e)

Spacing +4 added lines, -4 removed lines

@@ -69,8 +69,8 @@ 
             }
 
             if ($this->config->has('version')) {
-                $outputFormat = 'PhpMetrics %s <http://phpmetrics.org>' . \PHP_EOL .
-                    'by Jean-François Lépine <https://twitter.com/Halleck45>' . \PHP_EOL;
+                $outputFormat = 'PhpMetrics %s <http://phpmetrics.org>'.\PHP_EOL.
+                    'by Jean-François Lépine <https://twitter.com/Halleck45>'.\PHP_EOL;
                 $this->output->writeln(\sprintf($outputFormat, \getVersion()));
                 exit(0);
             }
@@ -115,7 +115,7 @@ 
         (new Report\Violations\Xml\Reporter($this->config, $this->output))->generate($metrics);
 
         // 5. Enjoy the end.
-        $this->output->writeln(\PHP_EOL . 'Done' . \PHP_EOL);
+        $this->output->writeln(\PHP_EOL.'Done'.\PHP_EOL);
     }
 
     /**
@@ -125,6 +125,6 @@ 
      */
     private function outputException(Throwable $e)
     {
-        return $this->output->err(\sprintf(\PHP_EOL .'<error>%s</error>' . \PHP_EOL, $e->getMessage()));
+        return $this->output->err(\sprintf(\PHP_EOL.'<error>%s</error>'.\PHP_EOL, $e->getMessage()));
     }
 }

src/Hal/Report/Csv/Reporter.php

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
      * Reporter constructor.
      *
      * @param Config $config
-     * @param Output|OutputInterface $output
+     * @param Output $output
      */
     public function __construct(Config $config, Output $output)
     {

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
             return;
         }
         if (!\file_exists(\dirname($logFile)) || !\is_writable(\dirname($logFile))) {
-            throw new \RuntimeException('You don\'t have permissions to write CSV report in ' . $logFile);
+            throw new \RuntimeException('You don\'t have permissions to write CSV report in '.$logFile);
         }
 
         $availables = (new Registry())->allForStructures();

src/Hal/Report/Html/Reporter.php

Doc Comments +2 added lines, -2 removed lines

@@ -116,8 +116,8 @@
     }
 
     /**
-     * @param $source
-     * @param $destination
+     * @param string $source
+     * @param string $destination
      * @param Consolidated $consolidated
      * @param $history
      * @return $this

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use Hal\Application\Config\Config;
 use Hal\Component\Output\Output;
 use Hal\Metric\Consolidated;
-use Hal\Metric\Consolided;
 use Hal\Metric\Metrics;
 
 /**

Spacing +24 added lines, -24 removed lines

@@ -51,11 +51,11 @@ 
         $consolidated = new Consolidated($metrics);
 
         // history of builds
-        $today = (object)[
+        $today = (object) [
             'avg' => $consolidated->getAvg(),
             'sum' => $consolidated->getSum()
         ];
-        $files = \glob($logDir . '/js/history-*.json');
+        $files = \glob($logDir.'/js/history-*.json');
         $next = \count($files) + 1;
         $history = [];
         \natsort($files);
@@ -64,37 +64,37 @@ 
         }
 
         // copy sources
-        if (!\file_exists($logDir . '/js')) {
+        if (!\file_exists($logDir.'/js')) {
             \mkdir($logDir.'/js', 0755, true);
         }
-        if (!\file_exists($logDir . '/css')) {
+        if (!\file_exists($logDir.'/css')) {
             \mkdir($logDir.'/css', 0755, true);
         }
-        if (!\file_exists($logDir . '/images')) {
+        if (!\file_exists($logDir.'/images')) {
             \mkdir($logDir.'/images', 0755, true);
         }
-        if (!\file_exists($logDir . '/fonts')) {
+        if (!\file_exists($logDir.'/fonts')) {
             \mkdir($logDir.'/fonts', 0755, true);
         }
-        \recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
-        \recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
-        \recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
-        \recurse_copy(__DIR__ . '/template/fonts', $logDir . '/fonts');
+        \recurse_copy(__DIR__.'/template/js', $logDir.'/js');
+        \recurse_copy(__DIR__.'/template/css', $logDir.'/css');
+        \recurse_copy(__DIR__.'/template/images', $logDir.'/images');
+        \recurse_copy(__DIR__.'/template/fonts', $logDir.'/fonts');
 
         // render dynamic pages
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
         if ($this->config->has('git')) {
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
         }
-        $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
 
         // js data
         \file_put_contents(
@@ -108,8 +108,8 @@ 
 
         // json data
         \file_put_contents(
-            $logDir . '/js/classes.js',
-            'var classes = ' . \json_encode($consolidated->getClasses(), \JSON_PRETTY_PRINT)
+            $logDir.'/js/classes.js',
+            'var classes = '.\json_encode($consolidated->getClasses(), \JSON_PRETTY_PRINT)
         );
 
         $this->output->writeln(\sprintf('HTML report generated in "%s" directory', $logDir));
@@ -179,7 +179,7 @@ 
 
         $diff = $newValue - $oldValue;
         if ($diff > 0) {
-            $diff = '+' . $diff;
+            $diff = '+'.$diff;
         }
 
         $goodOrBad = 'neutral';

src/Hal/Metric/Consolidated.php

Spacing +3 added lines, -3 removed lines

@@ -66,13 +66,13 @@ 
         }
 
         // sums
-        $sum = (object)[
+        $sum = (object) [
             'loc' => 0,
             'cloc' => 0,
             'lloc' => 0,
             'nbMethods' => 0,
         ];
-        $avg = (object)[
+        $avg = (object) [
             'ccn' => [],
             'bugs' => [],
             'kanDefect' => [],
@@ -132,7 +132,7 @@ 
                 $violations[$name]++;
             }
         }
-        $sum->violations = (object)$violations;
+        $sum->violations = (object) $violations;
 
         $this->avg = $avg;
         $this->sum = $sum;

src/Hal/Metric/System/UnitTesting/UnitTesting.php

Spacing +5 added lines, -5 removed lines

@@ -80,7 +80,7 @@ 
 
         // JUNIT format
         foreach ($xpath->query('//testsuite[@file]') as $suite) {
-            $testsuites[] = (object)[
+            $testsuites[] = (object) [
                 'file' => $suite->getAttribute('file'),
                 'name' => $suite->getAttribute('name'),
                 'assertions' => $suite->getAttribute('assertions'),
@@ -110,7 +110,7 @@ 
             }
 
             $attributeClass = $case->getAttribute('class');
-            $testsuites[$attributeClass] = (object)[
+            $testsuites[$attributeClass] = (object) [
                 'file' => $case->getAttribute('file'),
                 'name' => $attributeClass,
                 'assertions' => $assertions,
@@ -129,7 +129,7 @@ 
             $traverser->addVisitor(new ExternalsVisitor($metricsOfUnitTest));
 
             if (!\file_exists($suite->file) || !\is_readable($suite->file)) {
-                throw new \LogicException('Cannot find source file referenced in testsuite: ' . $suite->file);
+                throw new \LogicException('Cannot find source file referenced in testsuite: '.$suite->file);
             }
 
             $code = \file_get_contents($suite->file);
@@ -142,10 +142,10 @@ 
 
             // list of externals sources of unit test
             $metric = $metricsOfUnitTest->get($suite->name);
-            $externals = (array)$metric->get('externals');
+            $externals = (array) $metric->get('externals');
 
             // global stats for each test
-            $infoAboutTests[$suite->name] = (object)[
+            $infoAboutTests[$suite->name] = (object) [
                 'nbExternals' => \count(\array_unique($externals)),
                 'externals' => \array_unique($externals),
                 'filename' => $suite->file,

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
      * GitChanges constructor.
      *
      * @param Config $config
-     * @param array $files
+     * @param string[] $files
      */
     public function __construct(Config $config, array $files)
     {

src/Hal/Metric/System/Packages/Composer/Composer.php

Spacing +4 added lines, -4 removed lines

@@ -46,7 +46,7 @@ 
         foreach ($rawRequirements as $requirement => $version) {
             $package = $packagist->get($requirement);
 
-            $packages[$requirement] = (object)[
+            $packages[$requirement] = (object) [
                 'name' => $requirement,
                 'required' => $version,
                 'installed' => isset($rawInstalled[$requirement]) ? $rawInstalled[$requirement] : null,
@@ -77,13 +77,13 @@ 
             if (!\preg_match('/composer(-dist)?\.json/', $filename)) {
                 continue;
             }
-            $composerJson = (object)\json_decode(\file_get_contents($filename));
+            $composerJson = (object) \json_decode(\file_get_contents($filename));
 
             if (!isset($composerJson->require)) {
                 continue;
             }
 
-            $rawRequirements[] = (array)$composerJson->require;
+            $rawRequirements[] = (array) $composerJson->require;
         }
 
         return \call_user_func_array('\array_merge', $rawRequirements);
@@ -107,7 +107,7 @@ 
             if (false === \strpos($filename, 'composer.lock')) {
                 continue;
             }
-            $composerLockJson = (object)\json_decode(\file_get_contents($filename));
+            $composerLockJson = (object) \json_decode(\file_get_contents($filename));
 
             if (!isset($composerLockJson->packages)) {
                 continue;

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
      * GitChanges constructor.
      *
      * @param Config $config
-     * @param array $files
+     * @param string[] $files
      */
     public function __construct(Config $config, array $files)
     {

src/Hal/Metric/System/Packages/Composer/Packagist.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 
         // get latest version
         $latest = '0.0.0';
-        foreach ((array)$json->package->versions as $version => $datas) {
+        foreach ((array) $json->package->versions as $version => $datas) {
             $version = \preg_replace('([^\.\d])', '', $version);
             if (!\preg_match('!\d+\.\d+\.\d+!', $version)) {
                 continue;

src/Hal/Metric/Helper/RoleOfMethodDetector.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
         // build a fingerprint of the given method
         $fingerprintOfMethod = [];
-        \iterate_over_node($node, function ($node) use (&$fingerprintOfMethod) {
+        \iterate_over_node($node, function($node) use (&$fingerprintOfMethod) {
 
             // avoid cast
             if ($node instanceof Cast) {

src/Hal/Metric/Helper/MetricClassNameGenerator.php

Spacing +1 added lines, -2 removed lines

@@ -17,7 +17,6 @@
     public static function getName(Node $node)
     {
         return ($node instanceof Node\Stmt\Class_ && $node->isAnonymous()) ?
-            'anonymous@' . \spl_object_hash($node) :
-            $node->namespacedName->toString();
+            'anonymous@'.\spl_object_hash($node) : $node->namespacedName->toString();
     }
 }