phpmetrics / PhpMetrics

src/Hal/Metric/BagTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return null
      */
     public function get($key)

src/Hal/Metric/Class_/ClassEnumVisitor.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Hal\Metric\Class_;
 
-use Hal\Component\Reflected\Method;
 use Hal\Metric\ClassMetric;
 use Hal\Metric\FunctionMetric;
 use Hal\Metric\Helper\RoleOfMethodDetector;

Spacing +3 added lines, -3 removed lines

@@ -40,9 +40,9 @@ 
                 $class->set('interface', true);
             } else {
 
-                if(null === $node->name) {
+                if (null === $node->name) {
                     // anonymous class
-                    $name = 'anonymous@' . spl_object_hash($node);
+                    $name = 'anonymous@'.spl_object_hash($node);
                 } else {
                     $name = $node->namespacedName->toString();
                 }
@@ -90,7 +90,7 @@ 
             }
 
             $class->set('methods', $methods);
-            $class->set('nbMethodsIncludingGettersSetters', sizeof($methods) );
+            $class->set('nbMethodsIncludingGettersSetters', sizeof($methods));
             $class->set('nbMethods', sizeof($methods) - ($nbGetters + $nbSetters));
             $class->set('nbMethodsPrivate', $methodsPrivate);
             $class->set('nbMethodsPublic', $methodsPublic);

src/Hal/Metric/Class_/Component/MaintainabilityIndexVisitor.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Hal\Metric\FunctionMetric;
 use Hal\Metric\Metrics;
-use Hoa\Ruler\Model\Bag\Scalar;
 use PhpParser\Node;
 use PhpParser\Node\Stmt;
 use PhpParser\NodeVisitorAbstract;

src/Hal/Report/Html/Reporter.php

Doc Comments +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
     }
 
     /**
-     * @param $source
-     * @param $destination
+     * @param string $source
+     * @param string $destination
      * @return $this
      */
     public function renderPage($source, $destination, Consolidated $consolidated, $history)

Indentation +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
             sprintf('%s/js/history-%d.json', $logDir, $next),
             json_encode($today, JSON_PRETTY_PRINT)
         );
-	file_put_contents(
+    file_put_contents(
             sprintf('%s/js/latest.json', $logDir, $next),
             json_encode($today, JSON_PRETTY_PRINT)
         );

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use Hal\Application\Config\Config;
 use Hal\Component\Output\Output;
 use Hal\Metric\Consolidated;
-use Hal\Metric\Consolided;
 use Hal\Metric\Metrics;
 
 class Reporter

Spacing +22 added lines, -22 removed lines

@@ -44,11 +44,11 @@ 
         $consolidated = new Consolidated($metrics);
 
         // history of builds
-        $today = (object)[
+        $today = (object) [
             'avg' => $consolidated->getAvg(),
             'sum' => $consolidated->getSum()
         ];
-        $files = glob($logDir . '/js/history-*.json');
+        $files = glob($logDir.'/js/history-*.json');
         $next = sizeof($files) + 1;
         $history = [];
         natsort($files);
@@ -57,33 +57,33 @@ 
         }
 
         // copy sources
-        if(!file_exists($logDir . '/js')) {
+        if (!file_exists($logDir.'/js')) {
             mkdir($logDir.'/js', 0755, true);
         }
-        if(!file_exists($logDir . '/css')) {
+        if (!file_exists($logDir.'/css')) {
             mkdir($logDir.'/css', 0755, true);
         }
-        if(!file_exists($logDir . '/images')) {
+        if (!file_exists($logDir.'/images')) {
             mkdir($logDir.'/images', 0755, true);
         }
-        recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
-        recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
-        recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
+        recurse_copy(__DIR__.'/template/js', $logDir.'/js');
+        recurse_copy(__DIR__.'/template/css', $logDir.'/css');
+        recurse_copy(__DIR__.'/template/images', $logDir.'/images');
 
         // render dynamic pages
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
         if ($this->config->has('git')) {
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
         }
-        $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
 
         // js data
         file_put_contents(
@@ -97,8 +97,8 @@ 
 
         // json data
         file_put_contents(
-            $logDir . '/js/classes.js',
-            'var classes = ' . json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
+            $logDir.'/js/classes.js',
+            'var classes = '.json_encode($consolidated->getClasses(), JSON_PRETTY_PRINT)
         );
 
         $this->output->writeln(sprintf('HTML report generated in "%s" directory', $logDir));
@@ -166,7 +166,7 @@ 
 
         $diff = $newValue - $oldValue;
         if ($diff > 0) {
-            $diff = '+' . $diff;
+            $diff = '+'.$diff;
         }
 
         $goodOrBad = 'neutral';

src/Hal/Violation/Violations.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
     {
         $string = '';
         foreach ($this->data as $violation) {
-            $string .= $violation->getName() . ',';
+            $string .= $violation->getName().',';
         }
         return $string;
     }

src/Hal/Application/Application.php

Braces +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         // analyze
         try {
             $metrics = (new Analyze($config, $output, $issuer))->run($files);
-        }catch(ConfigException $e) {
+        } catch(ConfigException $e) {
             $output->writeln(sprintf('<error>%s</error>', $e->getMessage()));
             exit(1);
         }

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
         $output = new CliOutput();
 
         // issues and debug
-        $issuer = (new Issuer($output));//->enable();
+        $issuer = (new Issuer($output)); //->enable();
 
         // config
         $config = (new Parser())->parse($argv);
@@ -57,7 +57,7 @@ 
         // analyze
         try {
             $metrics = (new Analyze($config, $output, $issuer))->run($files);
-        }catch(ConfigException $e) {
+        } catch (ConfigException $e) {
             $output->writeln(sprintf('<error>%s</error>', $e->getMessage()));
             exit(1);
         }

src/Hal/Component/Ast/NodeTraverser.php

Spacing +2 added lines, -2 removed lines

@@ -25,9 +25,9 @@
     {
         parent::__construct($cloneNodes);
 
-        if(null === $stopCondition) {
+        if (null === $stopCondition) {
             $stopCondition = function($node) {
-                if($node instanceof Node\Stmt\Class_ || $node instanceof Node\Stmt\Interface_) {
+                if ($node instanceof Node\Stmt\Class_ || $node instanceof Node\Stmt\Interface_) {
                     return false;
                 }
 

Doc Comments +3 added lines

@@ -21,6 +21,9 @@
 {
     protected $stopCondition;
 
+    /**
+     * @param \Closure $stopCondition
+     */
     public function __construct($cloneNodes = false, $stopCondition = null)
     {
         parent::__construct($cloneNodes);

src/Hal/Component/File/Finder.php

Spacing +3 added lines, -3 removed lines

@@ -71,14 +71,14 @@
         $files = array();
         foreach ($paths as $path) {
             if (is_dir($path)) {
-                $path = rtrim($path, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
+                $path = rtrim($path, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR;
                 $directory = new RecursiveDirectoryIterator($path, $this->flags);
                 $iterator = new RecursiveIteratorIterator($directory);
 
                 $filterRegex = sprintf(
                     '`^%s%s$`',
-                    !empty($this->excludedDirs) ? '((?!' . implode('|', $this->excludedDirs) . ').)+' : '.+',
-                    '\.(' . implode('|', $this->extensions) . ')'
+                    !empty($this->excludedDirs) ? '((?!'.implode('|', $this->excludedDirs).').)+' : '.+',
+                    '\.('.implode('|', $this->extensions).')'
                 );
 
                 $filteredIterator = new RegexIterator(

src/Hal/Report/Html/template/relations.php

Spacing +6 added lines, -6 removed lines

@@ -1,17 +1,17 @@ 
-<?php require __DIR__ . '/_header.php'; ?>
+<?php require __DIR__.'/_header.php'; ?>
 
 <?php
 $relations = [];
 $classesCp = [];
 foreach ($classes as $class) {
 
-    $class['name'] = '\\' . $class['name'];
+    $class['name'] = '\\'.$class['name'];
     $classesCp[$class['name']] = $class;
     $classesCp[$class['name']]['externals'] = [];
 
 
     foreach ($class['externals'] as &$ext) {
-        $ext = '\\' . $ext;
+        $ext = '\\'.$ext;
         if (!isset($classes[$ext])) {
             $classesCp[$ext] = [
                 'name' => $ext,
@@ -22,10 +22,10 @@ 
     }
 }
 foreach ($classesCp as $class) {
-    array_push($relations, (object)[
+    array_push($relations, (object) [
         'name' => $class['name'],
         'size' => 3000,
-        'relations' => (array)array_values(array_unique($class['externals'])),
+        'relations' => (array) array_values(array_unique($class['externals'])),
     ]);
 }
 ?>
@@ -40,7 +40,7 @@ 
     </div>
 </div>
 
-<?php require __DIR__ . '/_footer.php'; ?>
+<?php require __DIR__.'/_footer.php'; ?>
 
 
 <script type="text/javascript">