phpmetrics / PhpMetrics

src/Hal/Component/OOP/Extractor/MethodExtractor.php

Doc Comments +3 added lines, -2 removed lines

@@ -133,7 +133,7 @@ 
      * Extracts visibility
      *
      * @param ReflectedMethod $method
-     * @param $n
+     * @param integer $n
      * @param TokenCollection $tokens
      * @return $this
      */
@@ -158,7 +158,7 @@ 
      * Extracts state
      *
      * @param ReflectedMethod $method
-     * @param $n
+     * @param integer $n
      * @param TokenCollection $tokens
      * @return $this
      */
@@ -262,6 +262,7 @@ 
      * Extract the list of returned values
      *
      * @param ReflectedMethod $method
+     * @param integer $n
      * @return $this
      */
     private function extractReturns(ReflectedMethod $method, $n, TokenCollection $tokens) {

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use Hal\Component\OOP\Reflected\MethodUsage;
 use Hal\Component\OOP\Reflected\ReflectedArgument;
 use Hal\Component\OOP\Reflected\ReflectedClass;
-use Hal\Component\OOP\Reflected\ReflectedClass\ReflectedAnonymousClass;
 use Hal\Component\OOP\Reflected\ReflectedMethod;
 use Hal\Component\OOP\Reflected\ReflectedReturn;
 use Hal\Component\OOP\Resolver\TypeResolver;

Switch Indentation +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
             case $this->searcher->isPrecededBy(T_PROTECTED, $n, $tokens, 4):
                 $visibility = ReflectedMethod::VISIBILITY_PROTECTED;
                 break;
-        case $this->searcher->isPrecededBy(T_PUBLIC, $n, $tokens, 4):
+            case $this->searcher->isPrecededBy(T_PUBLIC, $n, $tokens, 4):
                 default:
                 $visibility = ReflectedMethod::VISIBILITY_PUBLIC;
                 break;

Spacing +32 added lines, -32 removed lines

@@ -55,7 +55,7 @@ 
         $start = $n;
 
         $declaration = $this->searcher->getUnder(array(')'), $n, $tokens);
-        if(!preg_match('!function\s+(.*)\(\s*(.*)!is', $declaration, $matches)) {
+        if (!preg_match('!function\s+(.*)\(\s*(.*)!is', $declaration, $matches)) {
             throw new \Exception(sprintf("Closure detected instead of method\nDetails:\n%s", $declaration));
         }
         list(, $name, $args) = $matches;
@@ -68,21 +68,21 @@ 
         $this->extractState($method, $p = $start, $tokens); // please keep "p = start"
 
         $arguments = preg_split('!\s*,\s*!m', $args);
-        foreach($arguments as $argDecl) {
+        foreach ($arguments as $argDecl) {
 
-            if(0 == strlen($argDecl)) {
+            if (0 == strlen($argDecl)) {
                 continue;
             }
 
             $elems = preg_split('!([\s=]+)!', $argDecl);
             $isRequired = 2 == sizeof($elems, COUNT_NORMAL);
 
-            if(sizeof($elems, COUNT_NORMAL) == 1) {
+            if (sizeof($elems, COUNT_NORMAL) == 1) {
                 list($name, $type) = array_pad($elems, 2, null);
             } else {
-                if('$' == $elems[0][0]) {
+                if ('$' == $elems[0][0]) {
                     $name = $elems[0];
-                    $type  = null;
+                    $type = null;
                     $isRequired = false;
                 } else {
                     list($type, $name) = array_pad($elems, 2, null);
@@ -96,9 +96,9 @@ 
 
 
         // does method has body ? (example: interface ; abstract classes)
-        $p = $n  + 1;
+        $p = $n + 1;
         $underComma = trim($this->searcher->getUnder(array(';'), $p, $tokens));
-        if(strlen($underComma) > 0) {
+        if (strlen($underComma) > 0) {
             //
             // Body
             $this->extractContent($method, $n, $tokens);
@@ -108,7 +108,7 @@ 
 
             // Tokens
             $end = $this->searcher->getPositionOfClosingBrace($n, $tokens);
-            if($end > 0) {
+            if ($end > 0) {
                 $method->setTokens($tokens->extract($n, $end));
             }
         } else {
@@ -138,7 +138,7 @@ 
      * @return $this
      */
     public function extractVisibility(ReflectedMethod $method, $n, TokenCollection $tokens) {
-        switch(true) {
+        switch (true) {
             case $this->searcher->isPrecededBy(T_PRIVATE, $n, $tokens, 4):
                 $visibility = ReflectedMethod::VISIBILITY_PRIVATE;
                 break;
@@ -163,7 +163,7 @@ 
      * @return $this
      */
     public function extractState(ReflectedMethod $method, $n, TokenCollection $tokens) {
-        if($this->searcher->isPrecededBy(T_STATIC, $n, $tokens, 4)) {
+        if ($this->searcher->isPrecededBy(T_STATIC, $n, $tokens, 4)) {
             $method->setState(ReflectedMethod::STATE_STATIC);
         }
         return $this;
@@ -179,7 +179,7 @@ 
      */
     private function extractContent(ReflectedMethod $method, $n, TokenCollection $tokens) {
         $end = $this->searcher->getPositionOfClosingBrace($n, $tokens);
-        if($end > 0) {
+        if ($end > 0) {
             $collection = $tokens->extract($n, $end);
             $method->setContent($collection->asString());
         }
@@ -202,13 +202,13 @@ 
         $extractor = new CallExtractor($this->searcher, $currentClass);
         $start = $n;
         $len = sizeof($tokens, COUNT_NORMAL);
-        for($i = $start; $i < $len; $i++) {
+        for ($i = $start; $i < $len; $i++) {
             $token = $tokens[$i];
-            switch($token->getType()) {
+            switch ($token->getType()) {
                 case T_PAAMAYIM_NEKUDOTAYIM:
                 case T_NEW:
                     $call = $extractor->extract($i, $tokens, $currentClass);
-                    if($call !== 'class') { // anonymous class
+                    if ($call !== 'class') { // anonymous class
                         $method->pushDependency($call);
                         $method->pushInstanciedClass($call);
                     }
@@ -219,9 +219,9 @@ 
         //
         // Parameters in Method API
         $resolver = new TypeResolver();
-        foreach($method->getArguments() as $argument) {
+        foreach ($method->getArguments() as $argument) {
             $name = $argument->getType();
-            if(strlen($name) > 0 && !$resolver->isNative($name)) {
+            if (strlen($name) > 0 && !$resolver->isNative($name)) {
                 $method->pushDependency($name);
             }
         }
@@ -240,10 +240,10 @@ 
     private function extractCalls(ReflectedMethod $method, $n, TokenCollection $tokens) {
 
         // $this->foo(), $c->foo()
-        if(preg_match_all('!(\$[\w]*)\-\>(\w*?)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
-            foreach($matches as $m) {
+        if (preg_match_all('!(\$[\w]*)\-\>(\w*?)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
+            foreach ($matches as $m) {
                 $function = $m[2];
-                if('$this' == $m[1]) {
+                if ('$this' == $m[1]) {
                     $method->pushInternalCall($function);
                 } else {
                     $method->pushExternalCall($m[1], $function);
@@ -251,8 +251,8 @@ 
             }
         }
         // (new X)->foo()
-        if(preg_match_all('!\(new (\w+?).*?\)\->(\w+)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
-            foreach($matches as $m) {
+        if (preg_match_all('!\(new (\w+?).*?\)\->(\w+)\(!', $method->getContent(), $matches, PREG_SET_ORDER)) {
+            foreach ($matches as $m) {
                 $method->pushExternalCall($m[1], $m[2]);
             }
         }
@@ -272,9 +272,9 @@ 
         // we cannot use specific token. The ":" delimiter is a T_STRING token
         // in regex we match ":" followed by any character except another ":"
         $following = $this->searcher->getUnder(array('{', ';'), $n, $tokens);
-        if(preg_match('@(?<!:):\s*(\w+)@', $following, $matches)) {
+        if (preg_match('@(?<!:):\s*(\w+)@', $following, $matches)) {
             $type = trim($matches[1]);
-            if(empty($type)) {
+            if (empty($type)) {
                 return $this;
             }
             $return = new ReflectedReturn($type, ReflectedReturn::VALUE_UNKNOW, ReflectedReturn::STRICT_TYPE_HINT);
@@ -283,8 +283,8 @@ 
         }
 
         // array of available values based on code
-        if(preg_match_all('!([\s;]return\s|^return\s+)(.*?);!', $method->getContent(), $matches)) {
-            foreach($matches[2] as $m) {
+        if (preg_match_all('!([\s;]return\s|^return\s+)(.*?);!', $method->getContent(), $matches)) {
+            foreach ($matches[2] as $m) {
                 $value = trim($m, ";\t\n\r\0\x0B");
                 $return = new ReflectedReturn($resolver->resolve($m), $value, ReflectedReturn::ESTIMATED_TYPE_HINT);
                 $method->pushReturn($return);
@@ -302,21 +302,21 @@ 
     private function extractUsage(ReflectedMethod $method) {
         $tokens = $method->getTokens();
         $codes = $values = array();
-        foreach($tokens as $token) {
-            if(in_array($token->getType(), array(T_WHITESPACE, T_BOOL_CAST, T_INT_CAST, T_STRING_CAST, T_DOUBLE_CAST, T_OBJECT_CAST))) {
+        foreach ($tokens as $token) {
+            if (in_array($token->getType(), array(T_WHITESPACE, T_BOOL_CAST, T_INT_CAST, T_STRING_CAST, T_DOUBLE_CAST, T_OBJECT_CAST))) {
                 continue;
             }
             array_push($codes, $token->getType());
             array_push($values, $token->getValue());
         }
-        switch(true) {
-            case preg_match('!^(get)|(is)|(has).*!',$method->getName()) && $codes == array(T_RETURN, T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING):
+        switch (true) {
+            case preg_match('!^(get)|(is)|(has).*!', $method->getName()) && $codes == array(T_RETURN, T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING):
                 $method->setUsage(MethodUsage::USAGE_GETTER);
                 break;
             // basic setter
-            case preg_match('!^set.*!',$method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR,T_STRING,T_STRING, T_VARIABLE, T_STRING) && $values[3] == '=':
+            case preg_match('!^set.*!', $method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING, T_VARIABLE, T_STRING) && $values[3] == '=':
             // fluent setter
-            case preg_match('!^set.*!',$method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR,T_STRING,T_STRING, T_VARIABLE, T_STRING, T_RETURN, T_VARIABLE, T_STRING)
+            case preg_match('!^set.*!', $method->getName()) && $codes == array(T_VARIABLE, T_OBJECT_OPERATOR, T_STRING, T_STRING, T_VARIABLE, T_STRING, T_RETURN, T_VARIABLE, T_STRING)
                 && $values[3] == '=' && $values[7] == '$this':
                 $method->setUsage(MethodUsage::USAGE_SETTER);
                 break;

src/Hal/Component/OOP/Reflected/ReflectedMethod.php

Doc Comments +4 added lines, -4 removed lines

@@ -163,7 +163,7 @@ 
     }
 
     /**
-     * @return array
+     * @return \Hal\Component\Token\TokenCollection
      */
     public function getTokens()
     {
@@ -365,7 +365,7 @@ 
     }
 
     /**
-     * @param $class
+     * @param string|null $class
      * @return $this
      */
     public function pushInstanciedClass($class) {
@@ -386,7 +386,7 @@ 
     }
 
     /**
-     * @param $call
+     * @param string $call
      * @return $this
      */
     public function pushInternalCall($call)
@@ -404,7 +404,7 @@ 
     }
 
     /**
-     * @param $call
+     * @param string $call
      * @return $this
      */
     public function pushExternalCall($call)

Spacing +7 added lines, -7 removed lines

@@ -189,10 +189,10 @@ 
         // on read : compare with aliases. We cannot make it in pushDependency() => aliases aren't yet known
         $result = array();
         $resolver = new TypeResolver();
-        foreach($this->returns as $return) {
+        foreach ($this->returns as $return) {
             $type = $this->nameResolver->resolve($return->getType(), null);
 
-            if("\\" !== $type[0] &&!$resolver->isNative($type)) {
+            if ("\\" !== $type[0] && !$resolver->isNative($type)) {
                 $type = $this->namespace.'\\'.$type;
             }
 
@@ -233,21 +233,21 @@ 
     {
         // on read : compare with aliases. We cannot make it in pushDependency() => aliases aren't yet known
         $dependencies = array();
-        foreach($this->dependencies as $name) {
+        foreach ($this->dependencies as $name) {
             array_push($dependencies, $this->nameResolver->resolve($name, null));
         }
 
         // returned values
         $resolver = new TypeResolver();
-        foreach($this->returns as $return) {
+        foreach ($this->returns as $return) {
             $name = $return->getType();
-            if(!$resolver->isNative($name)) {
+            if (!$resolver->isNative($name)) {
                 array_push($dependencies, $this->nameResolver->resolve($name, null));
             }
         }
 
         // anonymous classes in method (inner class)
-        foreach($this->anonymousClasses as $c) {
+        foreach ($this->anonymousClasses as $c) {
             array_push($dependencies, $c->getParent());
             $dependencies = array_merge($dependencies, $c->getDependencies());
         }
@@ -379,7 +379,7 @@ 
     public function getInstanciedClasses()
     {
         $classes = array();
-        foreach($this->instanciedClasses as $name) {
+        foreach ($this->instanciedClasses as $name) {
             array_push($classes, $this->nameResolver->resolve($name, null));
         }
         return $classes;

src/Hal/Component/Token/Tokenizer.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
     /**
      * Clean php source
      *
-     * @param $content
+     * @param string $content
      * @return string
      */
     private function cleanup($content) {

Spacing +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
      */
     public function __construct(Cache $cache = null)
     {
-        if(null == $cache) {
+        if (null == $cache) {
             $cache = new CacheNull();
         }
         $this->cache = $cache;
@@ -41,13 +41,13 @@ 
      */
     public function tokenize($filename) {
 
-        if($this->cache->has($filename)) {
+        if ($this->cache->has($filename)) {
             return new TokenCollection($this->cache->get($filename));
         }
 
         $size = filesize($filename);
         $limit = 102400; // around 100 Ko
-        if($size > $limit) {
+        if ($size > $limit) {
             $tokens = $this->tokenizeLargeFile($filename);
         } else {
             $tokens = token_get_all($this->cleanup(file_get_contents($filename)));
@@ -74,7 +74,7 @@ 
 EOT;
         $output = shell_exec('php -r \''.$code.'\'');
         $tokens = unserialize($output);
-        if(false === $tokens) {
+        if (false === $tokens) {
             throw new NoTokenizableException(sprintf('Cannot tokenize "%s". This file is probably too big. Please try to increase memory_limit', $filename));
         }
         return $tokens;

build.php

Indentation +2 added lines, -2 removed lines

@@ -2,8 +2,8 @@
 chdir(__DIR__);
 
 if (!file_exists('vendor/autoload.php')) {
-  echo '[ERROR] It\'s required to run "composer install" before building PhpMetrics!' . PHP_EOL;
-  exit(1);
+    echo '[ERROR] It\'s required to run "composer install" before building PhpMetrics!' . PHP_EOL;
+    exit(1);
 }
 
 $filename = 'build/phpmetrics.phar';

Spacing +7 added lines, -7 removed lines

@@ -2,7 +2,7 @@ 
 chdir(__DIR__);
 
 if (!file_exists('vendor/autoload.php')) {
-  echo '[ERROR] It\'s required to run "composer install" before building PhpMetrics!' . PHP_EOL;
+  echo '[ERROR] It\'s required to run "composer install" before building PhpMetrics!'.PHP_EOL;
   exit(1);
 }
 
@@ -18,8 +18,8 @@ 
 
 $files = array_merge(rglob('*.php'), rglob('*.twig'), rglob('*.json'), rglob('*.pp'));
 $exclude = '!(.git)|(.svn)|(bin)|(tests)|(Tests)|(phpmetrics)!';
-foreach($files as $file) {
-    if(preg_match($exclude, $file)) continue;
+foreach ($files as $file) {
+    if (preg_match($exclude, $file)) continue;
     $path = str_replace(__DIR__.'/', '', $file);
     $phar->addFromString($path, file_get_contents($file));
 }
@@ -50,10 +50,10 @@ 
 
 chmod($filename, 0755);
 
-function rglob($pattern='*', $flags = 0, $path='')
+function rglob($pattern = '*', $flags = 0, $path = '')
 {
-    $paths=glob($path.'*', GLOB_MARK|GLOB_ONLYDIR|GLOB_NOSORT);
-    $files=glob($path.$pattern, $flags);
-    foreach ($paths as $path) { $files=array_merge($files,rglob($pattern, $flags, $path)); }
+    $paths = glob($path.'*', GLOB_MARK|GLOB_ONLYDIR|GLOB_NOSORT);
+    $files = glob($path.$pattern, $flags);
+    foreach ($paths as $path) { $files = array_merge($files, rglob($pattern, $flags, $path)); }
     return $files;
 }
\ No newline at end of file

Braces +3 added lines, -1 removed lines

@@ -19,7 +19,9 @@
 $files = array_merge(rglob('*.php'), rglob('*.twig'), rglob('*.json'), rglob('*.pp'));
 $exclude = '!(.git)|(.svn)|(bin)|(tests)|(Tests)|(phpmetrics)!';
 foreach($files as $file) {
-    if(preg_match($exclude, $file)) continue;
+    if(preg_match($exclude, $file)) {
+        continue;
+    }
     $path = str_replace(__DIR__.'/', '', $file);
     $phar->addFromString($path, file_get_contents($file));
 }

compatibility.php

Spacing +2 added lines, -2 removed lines

@@ -1,4 +1,4 @@
 <?php
 // PHP 7
-defined('T_SPACESHIP') ||define('T_SPACESHIP', '<=>'); // 289
-defined('T_COALESCE') ||define('T_COALESCE', '??'); // 282
\ No newline at end of file
+defined('T_SPACESHIP') || define('T_SPACESHIP', '<=>'); // 289
+defined('T_COALESCE') || define('T_COALESCE', '??'); // 282
\ No newline at end of file

src/Hal/Application/Command/Job/Analyze/FileAnalyzer.php

Spacing +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
             ->setHalstead($rHalstead)
             ->setMaintainabilityIndex($rMaintainability);
 
-        if($this->withOOP) {
+        if ($this->withOOP) {
             $rOOP = $this->extractor->extract($filename);
             $this->classMap->push($filename, $rOOP);
             $resultSet->setOOP($rOOP);

src/Hal/Application/Command/Job/Analyze/LcomAnalyzer.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
 
     public function execute(array $files) {
         $fileCoupling = new FileLackOfCohesionOfMethods($this->classMap);
-        foreach($files as $filename) {
+        foreach ($files as $filename) {
             $result = $fileCoupling->calculate($filename);
             $this->collection->get($filename)->setLcom($result);
         }

src/Hal/Application/Command/Job/DoAggregatedAnalyze.php

Indentation +2 added lines, -2 removed lines

@@ -52,8 +52,8 @@
 
 
     /**
-    * @inheritdoc
-    */
+     * @inheritdoc
+     */
     public function execute(ResultCollection $collection, ResultCollection $aggregatedResults) {
 
         $this->output->write(str_pad("\x0DGrouping results by package/directory. This will take few minutes...", 80, "\x20"));

Spacing +4 added lines, -4 removed lines

@@ -46,7 +46,7 @@ 
      */
     public function __construct(OutputInterface $output, Aggregator $aggregator)
     {
-        $this->aggregator= $aggregator;
+        $this->aggregator = $aggregator;
         $this->output = $output;
     }
 
@@ -66,12 +66,12 @@ 
         $bounds = new Bounds();
         $instability = new Instability();
 
-        foreach($groupedResults as $namespace => $results) {
+        foreach ($groupedResults as $namespace => $results) {
 
             // we filter aggregates to conserve only direct results
             $childs = new ResultCollection();
-            foreach($results as $r) {
-                if($namespace === dirname($r->getName())) {
+            foreach ($results as $r) {
+                if ($namespace === dirname($r->getName())) {
                     $childs->push($r);
                 }
             }

src/Hal/Application/Command/Job/DoAnalyze.php

Spacing +5 added lines, -5 removed lines

@@ -92,7 +92,7 @@ 
 
         $files = $this->finder->find($this->path);
 
-        if(0 == sizeof($files, COUNT_NORMAL)) {
+        if (0 == sizeof($files, COUNT_NORMAL)) {
             throw new \LogicException('No file found');
         }
 
@@ -116,12 +116,12 @@ 
             , $classMap
         );
 
-        foreach($files as $k => $filename) {
+        foreach ($files as $k => $filename) {
 
             $progress->advance();
 
             // Integrity
-            if(!$this->ignoreErrors && !$syntaxChecker->isCorrect($filename)) {
+            if (!$this->ignoreErrors && !$syntaxChecker->isCorrect($filename)) {
                 $this->output->writeln(sprintf('<error>file %s is not valid and has been skipped</error>', $filename));
                 unset($files[$k]);
                 continue;
@@ -130,7 +130,7 @@ 
             // Analyze
             try {
                 $resultSet = $fileAnalyzer->execute($filename);
-            } catch(NoTokenizableException $e) {
+            } catch (NoTokenizableException $e) {
                 $this->output->writeln(sprintf("<error>file %s has been skipped: \n%s</error>", $filename, $e->getMessage()));
                 unset($files[$k]);
                 continue;
@@ -151,7 +151,7 @@ 
         $progress->finish();
 
 
-        if($this->withOOP) {
+        if ($this->withOOP) {
             // COUPLING (should be done after parsing files)
             $this->output->write(str_pad("\x0DAnalyzing coupling. This will take few minutes...", 80, "\x20"));
             $couplingAnalyzer = new CouplingAnalyzer($classMap, $collection);