phpmetrics / PhpMetrics

src/Hal/Application/Application.php

Doc Comments +1 added lines, -1 removed lines

@@ -120,7 +120,7 @@
 
     /**
      * Standardize the output error when an exception occurs.
-     * @param Throwable $e Throwable object we will get its message to output.
+     * @param ConfigException $e Throwable object we will get its message to output.
      * @return CliOutput
      */
     private function outputException(Throwable $e)

Spacing +4 added lines, -4 removed lines

@@ -69,8 +69,8 @@ 
             }
 
             if ($this->config->has('version')) {
-                $outputFormat = 'PhpMetrics %s <http://phpmetrics.org>' . \PHP_EOL .
-                    'by Jean-François Lépine <https://twitter.com/Halleck45>' . \PHP_EOL;
+                $outputFormat = 'PhpMetrics %s <http://phpmetrics.org>'.\PHP_EOL.
+                    'by Jean-François Lépine <https://twitter.com/Halleck45>'.\PHP_EOL;
                 $this->output->writeln(\sprintf($outputFormat, \getVersion()));
                 exit(0);
             }
@@ -115,7 +115,7 @@ 
         (new Report\Violations\Xml\Reporter($this->config, $this->output))->generate($metrics);
 
         // 5. Enjoy the end.
-        $this->output->writeln(\PHP_EOL . 'Done' . \PHP_EOL);
+        $this->output->writeln(\PHP_EOL.'Done'.\PHP_EOL);
     }
 
     /**
@@ -125,6 +125,6 @@ 
      */
     private function outputException(Throwable $e)
     {
-        return $this->output->err(\sprintf(\PHP_EOL .'<error>%s</error>' . \PHP_EOL, $e->getMessage()));
+        return $this->output->err(\sprintf(\PHP_EOL.'<error>%s</error>'.\PHP_EOL, $e->getMessage()));
     }
 }

src/Hal/Component/Issue/Issuer.php

Doc Comments +4 added lines, -4 removed lines

@@ -138,7 +138,7 @@ 
     }
 
     /**
-     * @param $status
+     * @param integer $status
      */
     protected function terminate($status)
     {
@@ -146,7 +146,7 @@ 
     }
 
     /**
-     * @param $logfile
+     * @param string $logfile
      * @param $log
      * @return $this
      */
@@ -161,7 +161,7 @@ 
     }
 
     /**
-     * @param $debugKey
+     * @param string $debugKey
      * @param $value
      * @return $this
      */
@@ -172,7 +172,7 @@ 
     }
 
     /**
-     * @param $debugKey
+     * @param string $debugKey
      * @return $this
      */
     public function clear($debugKey)

src/Hal/Metric/Class_/Component/MaintainabilityIndexVisitor.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 
 use Hal\Metric\Metrics;
-use Hoa\Ruler\Model\Bag\Scalar;
 use PhpParser\Node;
 use PhpParser\Node\Stmt;
 use PhpParser\NodeVisitorAbstract;

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     public function leaveNode(Node $node)
     {
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
-            $name = (string)(isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'. \spl_object_hash($node));
+            $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.\spl_object_hash($node));
             $classOrFunction = $this->metrics->get($name);
 
             if (null === $lloc = $classOrFunction->get('lloc')) {

src/Hal/Report/Csv/Reporter.php

Doc Comments +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
      * Reporter constructor.
      *
      * @param Config $config
-     * @param Output|OutputInterface $output
+     * @param Output $output
      */
     public function __construct(Config $config, Output $output)
     {

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
             return;
         }
         if (!\file_exists(\dirname($logFile)) || !\is_writable(\dirname($logFile))) {
-            throw new \RuntimeException('You don\'t have permissions to write CSV report in ' . $logFile);
+            throw new \RuntimeException('You don\'t have permissions to write CSV report in '.$logFile);
         }
 
         $availables = (new Registry())->allForStructures();

src/Hal/Report/Html/Reporter.php

Doc Comments +2 added lines, -2 removed lines

@@ -116,8 +116,8 @@
     }
 
     /**
-     * @param $source
-     * @param $destination
+     * @param string $source
+     * @param string $destination
      * @param Consolidated $consolidated
      * @param $history
      * @return $this

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use Hal\Application\Config\Config;
 use Hal\Component\Output\Output;
 use Hal\Metric\Consolidated;
-use Hal\Metric\Consolided;
 use Hal\Metric\Metrics;
 
 /**

Spacing +24 added lines, -24 removed lines

@@ -51,11 +51,11 @@ 
         $consolidated = new Consolidated($metrics);
 
         // history of builds
-        $today = (object)[
+        $today = (object) [
             'avg' => $consolidated->getAvg(),
             'sum' => $consolidated->getSum()
         ];
-        $files = \glob($logDir . '/js/history-*.json');
+        $files = \glob($logDir.'/js/history-*.json');
         $next = \count($files) + 1;
         $history = [];
         \natsort($files);
@@ -64,37 +64,37 @@ 
         }
 
         // copy sources
-        if (!\file_exists($logDir . '/js')) {
+        if (!\file_exists($logDir.'/js')) {
             \mkdir($logDir.'/js', 0755, true);
         }
-        if (!\file_exists($logDir . '/css')) {
+        if (!\file_exists($logDir.'/css')) {
             \mkdir($logDir.'/css', 0755, true);
         }
-        if (!\file_exists($logDir . '/images')) {
+        if (!\file_exists($logDir.'/images')) {
             \mkdir($logDir.'/images', 0755, true);
         }
-        if (!\file_exists($logDir . '/fonts')) {
+        if (!\file_exists($logDir.'/fonts')) {
             \mkdir($logDir.'/fonts', 0755, true);
         }
-        \recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
-        \recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
-        \recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
-        \recurse_copy(__DIR__ . '/template/fonts', $logDir . '/fonts');
+        \recurse_copy(__DIR__.'/template/js', $logDir.'/js');
+        \recurse_copy(__DIR__.'/template/css', $logDir.'/css');
+        \recurse_copy(__DIR__.'/template/images', $logDir.'/images');
+        \recurse_copy(__DIR__.'/template/fonts', $logDir.'/fonts');
 
         // render dynamic pages
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
         if ($this->config->has('git')) {
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
         }
-        $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
+        $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
 
         // js data
         \file_put_contents(
@@ -108,8 +108,8 @@ 
 
         // json data
         \file_put_contents(
-            $logDir . '/js/classes.js',
-            'var classes = ' . \json_encode($consolidated->getClasses(), \JSON_PRETTY_PRINT)
+            $logDir.'/js/classes.js',
+            'var classes = '.\json_encode($consolidated->getClasses(), \JSON_PRETTY_PRINT)
         );
 
         $this->output->writeln(\sprintf('HTML report generated in "%s" directory', $logDir));
@@ -179,7 +179,7 @@ 
 
         $diff = $newValue - $oldValue;
         if ($diff > 0) {
-            $diff = '+' . $diff;
+            $diff = '+'.$diff;
         }
 
         $goodOrBad = 'neutral';

src/functions.php

Spacing +7 added lines, -7 removed lines

@@ -89,7 +89,7 @@ 
     }
 
     if ($node instanceof \PhpParser\Node\Name\FullyQualified) {
-        return (string)$node;
+        return (string) $node;
     }
     if ($node instanceof \PhpParser\Node\Expr\New_) {
         return getNameOfNode($node->class);
@@ -100,7 +100,7 @@ 
     }
 
     if ($node instanceof \PhpParser\Node\Name) {
-        return (string)implode($node->parts);
+        return (string) implode($node->parts);
     }
 
     if (isset($node->name) && $node->name instanceof \PhpParser\Node\Expr\Variable) {
@@ -128,11 +128,11 @@ 
     }
 
     if (isset($node->name) && null === $node->name) {
-        return 'anonymous@' . spl_object_hash($node);
+        return 'anonymous@'.spl_object_hash($node);
     }
 
     if (isset($node->name)) {
-        return (string)$node->name;
+        return (string) $node->name;
     }
 
     return null;
@@ -150,10 +150,10 @@ 
     }
     while (false !== ($file = readdir($dir))) {
         if (('.' != $file) && ('..' != $file)) {
-            if (is_dir($src . '/' . $file)) {
-                recurse_copy($src . '/' . $file, $dst . '/' . $file);
+            if (is_dir($src.'/'.$file)) {
+                recurse_copy($src.'/'.$file, $dst.'/'.$file);
             } else {
-                copy($src . '/' . $file, $dst . '/' . $file);
+                copy($src.'/'.$file, $dst.'/'.$file);
             }
         }
     }

src/Hal/Metric/Consolidated.php

Spacing +3 added lines, -3 removed lines

@@ -66,13 +66,13 @@ 
         }
 
         // sums
-        $sum = (object)[
+        $sum = (object) [
             'loc' => 0,
             'cloc' => 0,
             'lloc' => 0,
             'nbMethods' => 0,
         ];
-        $avg = (object)[
+        $avg = (object) [
             'ccn' => [],
             'bugs' => [],
             'kanDefect' => [],
@@ -132,7 +132,7 @@ 
                 $violations[$name]++;
             }
         }
-        $sum->violations = (object)$violations;
+        $sum->violations = (object) $violations;
 
         $this->avg = $avg;
         $this->sum = $sum;

src/Hal/Metric/Class_/Structural/SystemComplexityVisitor.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
                     $output = 0;
                     $fanout = [];
 
-                    \iterate_over_node($node, function ($node) use (&$output, &$fanout) {
+                    \iterate_over_node($node, function($node) use (&$output, &$fanout) {
                         switch (true) {
                             case $node instanceof Stmt\Return_:
                                 $output++;

src/Hal/Metric/Class_/Structural/LcomVisitor.php

Spacing +5 added lines, -5 removed lines

@@ -44,12 +44,12 @@ 
 
             foreach ($node->stmts as $stmt) {
                 if ($stmt instanceof Stmt\ClassMethod) {
-                    if (!$graph->has($stmt->name . '()')) {
-                        $graph->insert(new TreeNode($stmt->name . '()'));
+                    if (!$graph->has($stmt->name.'()')) {
+                        $graph->insert(new TreeNode($stmt->name.'()'));
                     }
-                    $from = $graph->get($stmt->name . '()');
+                    $from = $graph->get($stmt->name.'()');
 
-                    \iterate_over_node($stmt, function ($node) use ($from, &$graph) {
+                    \iterate_over_node($stmt, function($node) use ($from, &$graph) {
 
                         if ($node instanceof Node\Expr\PropertyFetch && isset($node->var->name) && 'this' == $node->var->name) {
                             $name = \getNameOfNode($node);
@@ -67,7 +67,7 @@ 
                             if (!$node->var instanceof Node\Expr\New_ && isset($node->var->name) && 'this' === \getNameOfNode($node->var)) {
                                 // use of method call $this->xxx();
                                 // use of attribute $this->xxx;
-                                $name = \getNameOfNode($node->name) . '()';
+                                $name = \getNameOfNode($node->name).'()';
                                 if (!$graph->has($name)) {
                                     $graph->insert(new TreeNode($name));
                                 }