Completed
Pull Request — master (#314)
by
unknown
01:54
created
src/Hal/Metric/Class_/Component/MaintainabilityIndexVisitor.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 
4 4
 
5 5
 use Hal\Metric\Metrics;
6
-use Hoa\Ruler\Model\Bag\Scalar;
7 6
 use PhpParser\Node;
8 7
 use PhpParser\Node\Stmt;
9 8
 use PhpParser\NodeVisitorAbstract;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
     public function leaveNode(Node $node)
49 49
     {
50 50
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
51
-            $name = (string)(isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'. \spl_object_hash($node));
51
+            $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.\spl_object_hash($node));
52 52
             $classOrFunction = $this->metrics->get($name);
53 53
 
54 54
             if (null === $lloc = $classOrFunction->get('lloc')) {
Please login to merge, or discard this patch.
src/Hal/Report/Html/Reporter.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 use Hal\Application\Config\Config;
5 5
 use Hal\Component\Output\Output;
6 6
 use Hal\Metric\Consolidated;
7
-use Hal\Metric\Consolided;
8 7
 use Hal\Metric\Metrics;
9 8
 
10 9
 /**
Please login to merge, or discard this patch.
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -51,11 +51,11 @@  discard block
 block discarded – undo
51 51
         $consolidated = new Consolidated($metrics);
52 52
 
53 53
         // history of builds
54
-        $today = (object)[
54
+        $today = (object) [
55 55
             'avg' => $consolidated->getAvg(),
56 56
             'sum' => $consolidated->getSum()
57 57
         ];
58
-        $files = \glob($logDir . '/js/history-*.json');
58
+        $files = \glob($logDir.'/js/history-*.json');
59 59
         $next = \count($files) + 1;
60 60
         $history = [];
61 61
         \natsort($files);
@@ -64,37 +64,37 @@  discard block
 block discarded – undo
64 64
         }
65 65
 
66 66
         // copy sources
67
-        if (!\file_exists($logDir . '/js')) {
67
+        if (!\file_exists($logDir.'/js')) {
68 68
             \mkdir($logDir.'/js', 0755, true);
69 69
         }
70
-        if (!\file_exists($logDir . '/css')) {
70
+        if (!\file_exists($logDir.'/css')) {
71 71
             \mkdir($logDir.'/css', 0755, true);
72 72
         }
73
-        if (!\file_exists($logDir . '/images')) {
73
+        if (!\file_exists($logDir.'/images')) {
74 74
             \mkdir($logDir.'/images', 0755, true);
75 75
         }
76
-        if (!\file_exists($logDir . '/fonts')) {
76
+        if (!\file_exists($logDir.'/fonts')) {
77 77
             \mkdir($logDir.'/fonts', 0755, true);
78 78
         }
79
-        \recurse_copy(__DIR__ . '/template/js', $logDir . '/js');
80
-        \recurse_copy(__DIR__ . '/template/css', $logDir . '/css');
81
-        \recurse_copy(__DIR__ . '/template/images', $logDir . '/images');
82
-        \recurse_copy(__DIR__ . '/template/fonts', $logDir . '/fonts');
79
+        \recurse_copy(__DIR__.'/template/js', $logDir.'/js');
80
+        \recurse_copy(__DIR__.'/template/css', $logDir.'/css');
81
+        \recurse_copy(__DIR__.'/template/images', $logDir.'/images');
82
+        \recurse_copy(__DIR__.'/template/fonts', $logDir.'/fonts');
83 83
 
84 84
         // render dynamic pages
85
-        $this->renderPage(__DIR__ . '/template/index.php', $logDir . '/index.html', $consolidated, $history);
86
-        $this->renderPage(__DIR__ . '/template/loc.php', $logDir . '/loc.html', $consolidated, $history);
87
-        $this->renderPage(__DIR__ . '/template/relations.php', $logDir . '/relations.html', $consolidated, $history);
88
-        $this->renderPage(__DIR__ . '/template/coupling.php', $logDir . '/coupling.html', $consolidated, $history);
89
-        $this->renderPage(__DIR__ . '/template/all.php', $logDir . '/all.html', $consolidated, $history);
90
-        $this->renderPage(__DIR__ . '/template/oop.php', $logDir . '/oop.html', $consolidated, $history);
91
-        $this->renderPage(__DIR__ . '/template/complexity.php', $logDir . '/complexity.html', $consolidated, $history);
92
-        $this->renderPage(__DIR__ . '/template/panel.php', $logDir . '/panel.html', $consolidated, $history);
93
-        $this->renderPage(__DIR__ . '/template/violations.php', $logDir . '/violations.html', $consolidated, $history);
85
+        $this->renderPage(__DIR__.'/template/index.php', $logDir.'/index.html', $consolidated, $history);
86
+        $this->renderPage(__DIR__.'/template/loc.php', $logDir.'/loc.html', $consolidated, $history);
87
+        $this->renderPage(__DIR__.'/template/relations.php', $logDir.'/relations.html', $consolidated, $history);
88
+        $this->renderPage(__DIR__.'/template/coupling.php', $logDir.'/coupling.html', $consolidated, $history);
89
+        $this->renderPage(__DIR__.'/template/all.php', $logDir.'/all.html', $consolidated, $history);
90
+        $this->renderPage(__DIR__.'/template/oop.php', $logDir.'/oop.html', $consolidated, $history);
91
+        $this->renderPage(__DIR__.'/template/complexity.php', $logDir.'/complexity.html', $consolidated, $history);
92
+        $this->renderPage(__DIR__.'/template/panel.php', $logDir.'/panel.html', $consolidated, $history);
93
+        $this->renderPage(__DIR__.'/template/violations.php', $logDir.'/violations.html', $consolidated, $history);
94 94
         if ($this->config->has('git')) {
95
-            $this->renderPage(__DIR__ . '/template/git.php', $logDir . '/git.html', $consolidated, $history);
95
+            $this->renderPage(__DIR__.'/template/git.php', $logDir.'/git.html', $consolidated, $history);
96 96
         }
97
-        $this->renderPage(__DIR__ . '/template/junit.php', $logDir . '/junit.html', $consolidated, $history);
97
+        $this->renderPage(__DIR__.'/template/junit.php', $logDir.'/junit.html', $consolidated, $history);
98 98
 
99 99
         // js data
100 100
         \file_put_contents(
@@ -108,8 +108,8 @@  discard block
 block discarded – undo
108 108
 
109 109
         // json data
110 110
         \file_put_contents(
111
-            $logDir . '/js/classes.js',
112
-            'var classes = ' . \json_encode($consolidated->getClasses(), \JSON_PRETTY_PRINT)
111
+            $logDir.'/js/classes.js',
112
+            'var classes = '.\json_encode($consolidated->getClasses(), \JSON_PRETTY_PRINT)
113 113
         );
114 114
 
115 115
         $this->output->writeln(\sprintf('HTML report generated in "%s" directory', $logDir));
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
         $diff = $newValue - $oldValue;
181 181
         if ($diff > 0) {
182
-            $diff = '+' . $diff;
182
+            $diff = '+'.$diff;
183 183
         }
184 184
 
185 185
         $goodOrBad = 'neutral';
Please login to merge, or discard this patch.
src/functions.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
     }
90 90
 
91 91
     if ($node instanceof \PhpParser\Node\Name\FullyQualified) {
92
-        return (string)$node;
92
+        return (string) $node;
93 93
     }
94 94
     if ($node instanceof \PhpParser\Node\Expr\New_) {
95 95
         return getNameOfNode($node->class);
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     }
101 101
 
102 102
     if ($node instanceof \PhpParser\Node\Name) {
103
-        return (string)implode($node->parts);
103
+        return (string) implode($node->parts);
104 104
     }
105 105
 
106 106
     if (isset($node->name) && $node->name instanceof \PhpParser\Node\Expr\Variable) {
@@ -128,11 +128,11 @@  discard block
 block discarded – undo
128 128
     }
129 129
 
130 130
     if (isset($node->name) && null === $node->name) {
131
-        return 'anonymous@' . spl_object_hash($node);
131
+        return 'anonymous@'.spl_object_hash($node);
132 132
     }
133 133
 
134 134
     if (isset($node->name)) {
135
-        return (string)$node->name;
135
+        return (string) $node->name;
136 136
     }
137 137
 
138 138
     return null;
@@ -150,10 +150,10 @@  discard block
 block discarded – undo
150 150
     }
151 151
     while (false !== ($file = readdir($dir))) {
152 152
         if (('.' != $file) && ('..' != $file)) {
153
-            if (is_dir($src . '/' . $file)) {
154
-                recurse_copy($src . '/' . $file, $dst . '/' . $file);
153
+            if (is_dir($src.'/'.$file)) {
154
+                recurse_copy($src.'/'.$file, $dst.'/'.$file);
155 155
             } else {
156
-                copy($src . '/' . $file, $dst . '/' . $file);
156
+                copy($src.'/'.$file, $dst.'/'.$file);
157 157
             }
158 158
         }
159 159
     }
Please login to merge, or discard this patch.
src/Hal/Metric/Consolidated.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,13 +66,13 @@  discard block
 block discarded – undo
66 66
         }
67 67
 
68 68
         // sums
69
-        $sum = (object)[
69
+        $sum = (object) [
70 70
             'loc' => 0,
71 71
             'cloc' => 0,
72 72
             'lloc' => 0,
73 73
             'nbMethods' => 0,
74 74
         ];
75
-        $avg = (object)[
75
+        $avg = (object) [
76 76
             'ccn' => [],
77 77
             'bugs' => [],
78 78
             'kanDefect' => [],
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
                 $violations[$name]++;
133 133
             }
134 134
         }
135
-        $sum->violations = (object)$violations;
135
+        $sum->violations = (object) $violations;
136 136
 
137 137
         $this->avg = $avg;
138 138
         $this->sum = $sum;
Please login to merge, or discard this patch.
src/Hal/Metric/Class_/Structural/SystemComplexityVisitor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
                     $output = 0;
51 51
                     $fanout = [];
52 52
 
53
-                    \iterate_over_node($node, function ($node) use (&$output, &$fanout) {
53
+                    \iterate_over_node($node, function($node) use (&$output, &$fanout) {
54 54
                         switch (true) {
55 55
                             case $node instanceof Stmt\Return_:
56 56
                                 $output++;
Please login to merge, or discard this patch.
src/Hal/Metric/Class_/Structural/LcomVisitor.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -44,12 +44,12 @@  discard block
 block discarded – undo
44 44
 
45 45
             foreach ($node->stmts as $stmt) {
46 46
                 if ($stmt instanceof Stmt\ClassMethod) {
47
-                    if (!$graph->has($stmt->name . '()')) {
48
-                        $graph->insert(new TreeNode($stmt->name . '()'));
47
+                    if (!$graph->has($stmt->name.'()')) {
48
+                        $graph->insert(new TreeNode($stmt->name.'()'));
49 49
                     }
50
-                    $from = $graph->get($stmt->name . '()');
50
+                    $from = $graph->get($stmt->name.'()');
51 51
 
52
-                    \iterate_over_node($stmt, function ($node) use ($from, &$graph) {
52
+                    \iterate_over_node($stmt, function($node) use ($from, &$graph) {
53 53
 
54 54
                         if ($node instanceof Node\Expr\PropertyFetch && isset($node->var->name) && 'this' == $node->var->name) {
55 55
                             $name = \getNameOfNode($node);
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
                             if (!$node->var instanceof Node\Expr\New_ && isset($node->var->name) && 'this' === \getNameOfNode($node->var)) {
68 68
                                 // use of method call $this->xxx();
69 69
                                 // use of attribute $this->xxx;
70
-                                $name = \getNameOfNode($node->name) . '()';
70
+                                $name = \getNameOfNode($node->name).'()';
71 71
                                 if (!$graph->has($name)) {
72 72
                                     $graph->insert(new TreeNode($name));
73 73
                                 }
Please login to merge, or discard this patch.
src/Hal/Metric/Class_/Text/HalsteadVisitor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     {
46 46
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Function_ || $node instanceof Stmt\Trait_) {
47 47
             if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
48
-                $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'. \spl_object_hash($node));
48
+                $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.\spl_object_hash($node));
49 49
                 $classOrFunction = $this->metrics->get($name);
50 50
             } else {
51 51
                 $classOrFunction = new FunctionMetric($node->name);
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
             $operands = [];
57 57
             $operators = [];
58 58
 
59
-            \iterate_over_node($node, function ($node) use (&$operators, &$operands) {
59
+            \iterate_over_node($node, function($node) use (&$operators, &$operands) {
60 60
 
61 61
                 if ($node instanceof Node\Expr\BinaryOp
62 62
                     || $node instanceof Node\Expr\AssignOp
Please login to merge, or discard this patch.
src/Hal/Metric/Class_/Text/LengthVisitor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     {
37 37
         if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Function_ || $node instanceof Stmt\Trait_) {
38 38
             if ($node instanceof Stmt\Class_ || $node instanceof Stmt\Trait_) {
39
-                $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'. \spl_object_hash($node));
39
+                $name = (string) (isset($node->namespacedName) ? $node->namespacedName : 'anonymous@'.\spl_object_hash($node));
40 40
                 $classOrFunction = $this->metrics->get($name);
41 41
             } else {
42 42
                 $classOrFunction = new FunctionMetric($node->name);
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
             $code = \preg_replace('!/\*.*?\*/!s', '', $code);
61 61
 
62 62
             // count and remove single line comments
63
-            $code = \preg_replace_callback('!(\'[^\']*\'|"[^"]*")|((?:#|\/\/).*$)!m', function (array $matches) use (&$cloc) {
63
+            $code = \preg_replace_callback('!(\'[^\']*\'|"[^"]*")|((?:#|\/\/).*$)!m', function(array $matches) use (&$cloc) {
64 64
                 if (isset($matches[2])) {
65 65
                     ++$cloc;
66 66
                 }
Please login to merge, or discard this patch.
src/Hal/Metric/Class_/Complexity/KanDefectVisitor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
             $select = $while = $if = 0;
45 45
 
46
-            \iterate_over_node($node, function ($node) use (&$while, &$select, &$if) {
46
+            \iterate_over_node($node, function($node) use (&$while, &$select, &$if) {
47 47
                 switch (true) {
48 48
                     case $node instanceof Stmt\Do_:
49 49
                     case $node instanceof Stmt\Foreach_:
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
                 }
60 60
             });
61 61
 
62
-            $defect = 0.15 + 0.23 *  $while + 0.22 *  $select + 0.07 * $if;
62
+            $defect = 0.15 + 0.23 * $while + 0.22 * $select + 0.07 * $if;
63 63
             $class->set('kanDefect', \round($defect, 2));
64 64
         }
65 65
     }
Please login to merge, or discard this patch.