phpipam / phpipam

functions/classes/class.Radius.php

Doc Comments +34 added lines

@@ -355,30 +355,45 @@ 
     }

 

 

+    /**
+     * @param integer $packet_code
+     */
     function SetPacketCodeToSend($packet_code)

     {

         $this->_radius_packet_to_send = $packet_code;

     }

 

 

+    /**
+     * @param boolean $debug_mode
+     */
     function SetDebugMode($debug_mode)

     {

         $this->_debug_mode = (TRUE === $debug_mode);

     }

 

 

+    /**
+     * @param string $ip_radius_server
+     */
     function SetIpRadiusServer($ip_radius_server)

     {

         $this->_ip_radius_server = gethostbyname($ip_radius_server);

     }

 

 

+    /**
+     * @param string $shared_secret
+     */
     function SetSharedSecret($shared_secret)

     {

         $this->_shared_secret = $shared_secret;

     }

 

 

+    /**
+     * @param string $radius_suffix
+     */
     function SetRadiusSuffix($radius_suffix)

     {

         $this->_radius_suffix = $radius_suffix;

@@ -468,6 +483,9 @@ 
     }

 

 

+    /**
+     * @param integer $authentication_port
+     */
     function SetAuthenticationPort($authentication_port)

     {

         if ((intval($authentication_port) > 0) && (intval($authentication_port) < 65536))

@@ -477,6 +495,9 @@ 
     }

 

 

+    /**
+     * @param integer $accounting_port
+     */
     function SetAccountingPort($accounting_port)

     {

         if ((intval($accounting_port) > 0) && (intval($accounting_port) < 65536))

@@ -541,6 +562,9 @@ 
     }

 

 

+    /**
+     * @param integer $info_index
+     */
     function GetRadiusPacketInfo($info_index)

     {

         if (isset($this->_radius_packet_info[intval($info_index)]))

@@ -567,6 +591,9 @@ 
     }

 

 

+    /**
+     * @param string $debug_info
+     */
     function DebugInfo($debug_info)

     {

         if ($this->_debug_mode)

@@ -577,6 +604,9 @@ 
     }

 

 

+    /**
+     * @param integer $type
+     */
     function SetAttribute($type, $value)

     {

         $attribute_index = -1;

@@ -631,6 +661,10 @@ 
     }

 

 

+    /**
+     * @param string $attribute_raw_value
+     * @param integer $attribute_format
+     */
     function DecodeAttribute($attribute_raw_value, $attribute_format)

     {

         $attribute_value = NULL;

Indentation +2 added lines, -2 removed lines

@@ -571,8 +571,8 @@
     {
         if ($this->_debug_mode)
         {
-	        //save debugging
-	        $this->debug_text[] = date('Y-m-d H:i:s').' DEBUG: '.$debug_info;
+            //save debugging
+            $this->debug_text[] = date('Y-m-d H:i:s').' DEBUG: '.$debug_info;
         }
     }
 

Braces +55 added lines, -84 removed lines

@@ -330,11 +330,10 @@ 
 
     function GetLastError()
     {
-        if (0 < $this->_last_error_code)
-        {
+        if (0 < $this->_last_error_code) {
             return $this->_last_error_message.' ('.$this->_last_error_code.')';
-        } else
-        {
+        }
+        else {
             return '';
         }
     }
@@ -387,8 +386,7 @@ 
     function SetUsername($username = '')
     {
         $temp_username = $username;
-        if (false === strpos($temp_username, '@'))
-        {
+        if (false === strpos($temp_username, '@')) {
             $temp_username .= $this->_radius_suffix;
         }
 
@@ -403,8 +401,7 @@ 
         $encrypted_password = '';
         $padded_password = $password;
 
-        if (0 != (strlen($password) % 16))
-        {
+        if (0 != (strlen($password) % 16)) {
             $padded_password .= str_repeat(chr(0), (16 - strlen($password) % 16));
         }
 
@@ -432,11 +429,10 @@ 
 
     function SetNasIPAddress($nas_ip_address = '')
     {
-        if (0 < strlen($nas_ip_address))
-        {
+        if (0 < strlen($nas_ip_address)) {
             $this->_nas_ip_address = gethostbyname($nas_ip_address);
-        } else
-        {
+        }
+        else {
             $this->_nas_ip_address = gethostbyname(isset($_SERVER['SERVER_ADDR']) ? $_SERVER['SERVER_ADDR'] : '0.0.0.0');
         }
         $this->SetAttribute(4, $this->_nas_ip_address);
@@ -452,8 +448,7 @@ 
 
     function SetUdpTimeout($udp_timeout = 5)
     {
-        if (intval($udp_timeout) > 0)
-        {
+        if (intval($udp_timeout) > 0) {
             $this->_udp_timeout = intval($udp_timeout);
         }
     }
@@ -468,8 +463,7 @@ 
 
     function SetAuthenticationPort($authentication_port)
     {
-        if ((intval($authentication_port) > 0) && (intval($authentication_port) < 65536))
-        {
+        if ((intval($authentication_port) > 0) && (intval($authentication_port) < 65536)) {
             $this->_authentication_port = intval($authentication_port);
         }
     }
@@ -477,8 +471,7 @@ 
 
     function SetAccountingPort($accounting_port)
     {
-        if ((intval($accounting_port) > 0) && (intval($accounting_port) < 65536))
-        {
+        if ((intval($accounting_port) > 0) && (intval($accounting_port) < 65536)) {
             $this->_accounting_port = intval($accounting_port);
         }
     }
@@ -499,21 +492,19 @@ 
     function GetReadableReceivedAttributes()
     {
         $readable_attributes = '';
-        if (isset($this->_attributes_received))
-        {
+        if (isset($this->_attributes_received)) {
             foreach ($this->_attributes_received as $one_received_attribute)
             {
                 $attributes_info = $this->GetAttributesInfo($one_received_attribute[0]);
                 $readable_attributes .= $attributes_info[0].": ";
-                if (26 == $one_received_attribute[0])
-                {
+                if (26 == $one_received_attribute[0]) {
                     $vendor_array = $this->DecodeVendorSpecificContent($one_received_attribute[1]);
                     foreach ($vendor_array as $vendor_one)
                     {
                         $readable_attributes .= 'Vendor-Id: '.$vendor_one[0].", Vendor-type: ".$vendor_one[1].",  Attribute-specific: ".$vendor_one[2];
                     }
-                } else
-                {
+                }
+                else {
                     $readable_attributes .= $one_received_attribute[1];
                 }
                 $readable_attributes .= "<br />\n";
@@ -528,8 +519,7 @@ 
         $attribute_value = NULL;
         foreach ($this->_attributes_received as $one_received_attribute)
         {
-            if (intval($attribute_type) == $one_received_attribute[0])
-            {
+            if (intval($attribute_type) == $one_received_attribute[0]) {
                 $attribute_value = $one_received_attribute[1];
                 break;
             }
@@ -540,11 +530,10 @@ 
 
     function GetRadiusPacketInfo($info_index)
     {
-        if (isset($this->_radius_packet_info[intval($info_index)]))
-        {
+        if (isset($this->_radius_packet_info[intval($info_index)])) {
             return $this->_radius_packet_info[intval($info_index)];
-        } else
-        {
+        }
+        else {
             return '';
         }
     }
@@ -552,11 +541,10 @@ 
 
     function GetAttributesInfo($info_index)
     {
-        if (isset($this->_attributes_info[intval($info_index)]))
-        {
+        if (isset($this->_attributes_info[intval($info_index)])) {
             return $this->_attributes_info[intval($info_index)];
-        } else
-        {
+        }
+        else {
             return array('', '');
         }
     }
@@ -564,8 +552,7 @@ 
 
     function DebugInfo($debug_info)
     {
-        if ($this->_debug_mode)
-        {
+        if ($this->_debug_mode) {
 	        //save debugging
 	        $this->debug_text[] = date('Y-m-d H:i:s').' DEBUG: '.$debug_info;
         }
@@ -577,8 +564,7 @@ 
         $attribute_index = -1;
         for ($attributes_loop = 0; $attributes_loop < count($this->_attributes_to_send); $attributes_loop++)
         {
-            if ($type == ord(substr($this->_attributes_to_send[$attributes_loop], 0, 1)))
-            {
+            if ($type == ord(substr($this->_attributes_to_send[$attributes_loop], 0, 1))) {
                 $attribute_index = $attributes_loop;
                 break;
             }
@@ -586,10 +572,8 @@ 
 
         $temp_attribute = NULL;
 
-        if (isset($this->_attributes_info[$type]))
-        {
-            switch ($this->_attributes_info[$type][1])
-            {
+        if (isset($this->_attributes_info[$type])) {
+            switch ($this->_attributes_info[$type][1]) {
                 case 'T': // Text, 1-253 octets containing UTF-8 encoded ISO 10646 characters (RFC 2279).
                     $temp_attribute = chr($type).chr(2 + strlen($value)).$value;
                     break;
@@ -611,12 +595,11 @@ 
             }
         }
 
-        if ($attribute_index > -1)
-        {
+        if ($attribute_index > -1) {
             $this->_attributes_to_send[$attribute_index] = $temp_attribute;
             $additional_debug = 'Modified';
-        } else
-        {
+        }
+        else {
             $this->_attributes_to_send[] = $temp_attribute;
             $additional_debug = 'Added';
         }
@@ -629,10 +612,8 @@ 
     {
         $attribute_value = NULL;
 
-        if (isset($this->_attributes_info[$attribute_format]))
-        {
-            switch ($this->_attributes_info[$attribute_format][1])
-            {
+        if (isset($this->_attributes_info[$attribute_format])) {
+            switch ($this->_attributes_info[$attribute_format][1]) {
                 case 'T': // Text, 1-253 octets containing UTF-8 encoded ISO 10646 characters (RFC 2279).
                     $attribute_value = $attribute_raw_value;
                     break;
@@ -690,26 +671,22 @@ 
 
         $this->SetPacketCodeToSend(1); // Access-Request
 
-        if (0 < strlen($username))
-        {
+        if (0 < strlen($username)) {
             $this->SetUsername($username);
         }
 
-        if (0 < strlen($password))
-        {
+        if (0 < strlen($password)) {
             $this->SetPassword($password);
         }
 
-        if ($state !== NULL)
-        {
+        if ($state !== NULL) {
             $this->SetAttribute(24, $state);
-        } else
-        {
+        }
+        else {
             $this->SetAttribute(6, 1); // 1=Login
         }
 
-        if (intval($udp_timeout) > 0)
-        {
+        if (intval($udp_timeout) > 0) {
             $this->SetUdpTimeout($udp_timeout);
         }
 
@@ -732,23 +709,21 @@ 
 
         $_socket_to_server = socket_create(AF_INET, SOCK_DGRAM, 17); // UDP packet = 17
 
-        if ($_socket_to_server === FALSE)
-        {
+        if ($_socket_to_server === FALSE) {
             $this->_last_error_code    = socket_last_error();
             $this->_last_error_message = socket_strerror($this->_last_error_code);
-        } elseif (FALSE === socket_connect($_socket_to_server, $this->_ip_radius_server, $this->_authentication_port))
-        {
+        }
+        elseif (FALSE === socket_connect($_socket_to_server, $this->_ip_radius_server, $this->_authentication_port)) {
             $this->_last_error_code    = socket_last_error();
             $this->_last_error_message = socket_strerror($this->_last_error_code);
-        } elseif (FALSE === socket_write($_socket_to_server, $packet_data, $packet_length))
-        {
+        }
+        elseif (FALSE === socket_write($_socket_to_server, $packet_data, $packet_length)) {
             $this->_last_error_code    = socket_last_error();
             $this->_last_error_message = socket_strerror($this->_last_error_code);
-        } else
-        {
+        }
+        else {
             $this->DebugInfo('<b>Packet type '.$this->_radius_packet_to_send.' ('.$this->GetRadiusPacketInfo($this->_radius_packet_to_send).')'.' sent</b>');
-            if ($this->_debug_mode)
-            {
+            if ($this->_debug_mode) {
                 $readable_attributes = '';
                 foreach ($this->_attributes_to_send as $one_attribute_to_send)
                 {
@@ -762,10 +737,8 @@ 
 
             $received_packet = chr(0);
 
-            if (!(FALSE === socket_select($read_socket_array, $write_socket_array, $except_socket_array, $this->_udp_timeout)))
-            {
-                if (in_array($_socket_to_server, $read_socket_array))
-                {
+            if (!(FALSE === socket_select($read_socket_array, $write_socket_array, $except_socket_array, $this->_udp_timeout))) {
+                if (in_array($_socket_to_server, $read_socket_array)) {
                     if (FALSE === ($received_packet = @socket_read($_socket_to_server, 1024))) {
                         // @ used, than no error is displayed if the connection is closed by the remote host
                     {
@@ -773,13 +746,13 @@ 
                     }
                         $this->_last_error_code    = socket_last_error();
                         $this->_last_error_message = socket_strerror($this->_last_error_code);
-                    } else
-                    {
+                    }
+                    else {
                         socket_close($_socket_to_server);
                     }
                 }
-            } else
-            {
+            }
+            else {
                 socket_close($_socket_to_server);
             }
         }
@@ -788,8 +761,7 @@ 
 
         $this->DebugInfo('<b>Packet type '.$this->_radius_packet_received.' ('.$this->GetRadiusPacketInfo($this->_radius_packet_received).')'.' received</b>');
 
-        if ($this->_radius_packet_received > 0)
-        {
+        if ($this->_radius_packet_received > 0) {
             $this->_identifier_received = intval(ord(substr($received_packet, 1, 1)));
             $packet_length = (intval(ord(substr($received_packet, 2, 1))) * 256) + (intval(ord(substr($received_packet, 3, 1))));
             $this->_response_authenticator = substr($received_packet, 4, 16);
@@ -804,15 +776,14 @@ 
                 $attribute_value = $this->DecodeAttribute($attribute_raw_value, $attribute_type);
 
                 $attribute_info = $this->GetAttributesInfo($attribute_type);
-                if (26 == $attribute_type)
-                {
+                if (26 == $attribute_type) {
                     $vendor_array = $this->DecodeVendorSpecificContent($attribute_value);
                     foreach ($vendor_array as $vendor_one)
                     {
                         $this->DebugInfo('Attribute '.$attribute_type.' ('.$attribute_info[0].'), length '.($attribute_length - 2).', format '.$attribute_info[1].', Vendor-Id: '.$vendor_one[0].", Vendor-type: ".$vendor_one[1].",  Attribute-specific: ".$vendor_one[2]);
                     }
-                } else
-                {
+                }
+                else {
                     $this->DebugInfo('Attribute '.$attribute_type.' ('.$attribute_info[0].'), length '.($attribute_length - 2).', format '.$attribute_info[1].', value <em>'.$attribute_value.'</em>');
                 }
 

Spacing +223 added lines, -223 removed lines

@@ -182,32 +182,32 @@ 
  *********************************************************************/
 class Radius
 {
-    var $_ip_radius_server;       // Radius server IP address
-    var $_shared_secret;          // Shared secret with the radius server
-    var $_radius_suffix;          // Radius suffix (default is '');
-    var $_udp_timeout;            // Timeout of the UDP connection in seconds (default value is 5)
-    var $_authentication_port;    // Authentication port (default value is 1812)
-    var $_accounting_port;        // Accouting port (default value is 1813)
-    var $_nas_ip_address;         // NAS IP address
-    var $_nas_port;               // NAS port
-    var $_encrypted_password;     // Encrypted password, as described in the RFC 2865
-    var $_user_ip_address;        // Remote IP address of the user
-    var $_request_authenticator;  // Request-Authenticator, 16 octets random number
+    var $_ip_radius_server; // Radius server IP address
+    var $_shared_secret; // Shared secret with the radius server
+    var $_radius_suffix; // Radius suffix (default is '');
+    var $_udp_timeout; // Timeout of the UDP connection in seconds (default value is 5)
+    var $_authentication_port; // Authentication port (default value is 1812)
+    var $_accounting_port; // Accouting port (default value is 1813)
+    var $_nas_ip_address; // NAS IP address
+    var $_nas_port; // NAS port
+    var $_encrypted_password; // Encrypted password, as described in the RFC 2865
+    var $_user_ip_address; // Remote IP address of the user
+    var $_request_authenticator; // Request-Authenticator, 16 octets random number
     var $_response_authenticator; // Request-Authenticator, 16 octets random number
-    var $_username;               // Username to sent to the Radius server
-    var $_password;               // Password to sent to the Radius server (clear password, must be encrypted)
-    var $_identifier_to_send;     // Identifier field for the packet to be sent
-    var $_identifier_received;    // Identifier field for the received packet
-    var $_radius_packet_to_send;  // Radius packet code (1=Access-Request, 2=Access-Accept, 3=Access-Reject, 4=Accounting-Request, 5=Accounting-Response, 11=Access-Challenge, 12=Status-Server (experimental), 13=Status-Client (experimental), 255=Reserved
+    var $_username; // Username to sent to the Radius server
+    var $_password; // Password to sent to the Radius server (clear password, must be encrypted)
+    var $_identifier_to_send; // Identifier field for the packet to be sent
+    var $_identifier_received; // Identifier field for the received packet
+    var $_radius_packet_to_send; // Radius packet code (1=Access-Request, 2=Access-Accept, 3=Access-Reject, 4=Accounting-Request, 5=Accounting-Response, 11=Access-Challenge, 12=Status-Server (experimental), 13=Status-Client (experimental), 255=Reserved
     var $_radius_packet_received; // Radius packet code (1=Access-Request, 2=Access-Accept, 3=Access-Reject, 4=Accounting-Request, 5=Accounting-Response, 11=Access-Challenge, 12=Status-Server (experimental), 13=Status-Client (experimental), 255=Reserved
-    var $_attributes_to_send;     // Radius attributes to send
-    var $_attributes_received;    // Radius attributes received
-    var $_socket_to_server;       // Socket connection
-    var $_debug_mode;             // Debug mode flag
-    var $_attributes_info;        // Attributes info array
-    var $_radius_packet_info;     // Radius packet codes info array
-    var $_last_error_code;        // Last error code
-    var $_last_error_message;     // Last error message
+    var $_attributes_to_send; // Radius attributes to send
+    var $_attributes_received; // Radius attributes received
+    var $_socket_to_server; // Socket connection
+    var $_debug_mode; // Debug mode flag
+    var $_attributes_info; // Attributes info array
+    var $_radius_packet_info; // Radius packet codes info array
+    var $_last_error_code; // Last error code
+    var $_last_error_message; // Last error message
 
 
     /*********************************************************************
@@ -227,7 +227,7 @@ 
      * @param integer accounting port
      * @return NULL
      *********************************************************************/
-    public function Radius($ip_radius_server = '127.0.0.1', $shared_secret = '', $radius_suffix = '', $udp_timeout = 5, $authentication_port = 1812, $accounting_port = 1813)
+    public function Radius ($ip_radius_server = '127.0.0.1', $shared_secret = '', $radius_suffix = '', $udp_timeout = 5, $authentication_port = 1812, $accounting_port = 1813)
     {
         $this->_radius_packet_info[1] = 'Access-Request';
         $this->_radius_packet_info[2] = 'Access-Accept';
@@ -239,96 +239,96 @@ 
         $this->_radius_packet_info[13] = 'Status-Client (experimental)';
         $this->_radius_packet_info[255] = 'Reserved';
 
-        $this->_attributes_info[1] = array('User-Name', 'S');
-        $this->_attributes_info[2] = array('User-Password', 'S');
-        $this->_attributes_info[3] = array('CHAP-Password', 'S'); // Type (1) / Length (1) / CHAP Ident (1) / String
-        $this->_attributes_info[4] = array('NAS-IP-Address', 'A');
-        $this->_attributes_info[5] = array('NAS-Port', 'I');
-        $this->_attributes_info[6] = array('Service-Type', 'I');
-        $this->_attributes_info[7] = array('Framed-Protocol', 'I');
-        $this->_attributes_info[8] = array('Framed-IP-Address', 'A');
-        $this->_attributes_info[9] = array('Framed-IP-Netmask', 'A');
-        $this->_attributes_info[10] = array('Framed-Routing', 'I');
-        $this->_attributes_info[11] = array('Filter-Id', 'T');
-        $this->_attributes_info[12] = array('Framed-MTU', 'I');
-        $this->_attributes_info[13] = array('Framed-Compression', 'I');
-        $this->_attributes_info[14] = array('Login-IP-Host', 'A');
-        $this->_attributes_info[15] = array('Login-service', 'I');
-        $this->_attributes_info[16] = array('Login-TCP-Port', 'I');
-        $this->_attributes_info[17] = array('(unassigned)', '');
-        $this->_attributes_info[18] = array('Reply-Message', 'T');
-        $this->_attributes_info[19] = array('Callback-Number', 'S');
-        $this->_attributes_info[20] = array('Callback-Id', 'S');
-        $this->_attributes_info[21] = array('(unassigned)', '');
-        $this->_attributes_info[22] = array('Framed-Route', 'T');
-        $this->_attributes_info[23] = array('Framed-IPX-Network', 'I');
-        $this->_attributes_info[24] = array('State', 'S');
-        $this->_attributes_info[25] = array('Class', 'S');
-        $this->_attributes_info[26] = array('Vendor-Specific', 'S'); // Type (1) / Length (1) / Vendor-Id (4) / Vendor type (1) / Vendor length (1) / Attribute-Specific...
-        $this->_attributes_info[27] = array('Session-Timeout', 'I');
-        $this->_attributes_info[28] = array('Idle-Timeout', 'I');
-        $this->_attributes_info[29] = array('Termination-Action', 'I');
-        $this->_attributes_info[30] = array('Called-Station-Id', 'S');
-        $this->_attributes_info[31] = array('Calling-Station-Id', 'S');
-        $this->_attributes_info[32] = array('NAS-Identifier', 'S');
-        $this->_attributes_info[33] = array('Proxy-State', 'S');
-        $this->_attributes_info[34] = array('Login-LAT-Service', 'S');
-        $this->_attributes_info[35] = array('Login-LAT-Node', 'S');
-        $this->_attributes_info[36] = array('Login-LAT-Group', 'S');
-        $this->_attributes_info[37] = array('Framed-AppleTalk-Link', 'I');
-        $this->_attributes_info[38] = array('Framed-AppleTalk-Network', 'I');
-        $this->_attributes_info[39] = array('Framed-AppleTalk-Zone', 'S');
-        $this->_attributes_info[60] = array('CHAP-Challenge', 'S');
-        $this->_attributes_info[61] = array('NAS-Port-Type', 'I');
-        $this->_attributes_info[62] = array('Port-Limit', 'I');
-        $this->_attributes_info[63] = array('Login-LAT-Port', 'S');
-        $this->_attributes_info[76] = array('Prompt', 'I');
+        $this->_attributes_info[1] = array ('User-Name', 'S');
+        $this->_attributes_info[2] = array ('User-Password', 'S');
+        $this->_attributes_info[3] = array ('CHAP-Password', 'S'); // Type (1) / Length (1) / CHAP Ident (1) / String
+        $this->_attributes_info[4] = array ('NAS-IP-Address', 'A');
+        $this->_attributes_info[5] = array ('NAS-Port', 'I');
+        $this->_attributes_info[6] = array ('Service-Type', 'I');
+        $this->_attributes_info[7] = array ('Framed-Protocol', 'I');
+        $this->_attributes_info[8] = array ('Framed-IP-Address', 'A');
+        $this->_attributes_info[9] = array ('Framed-IP-Netmask', 'A');
+        $this->_attributes_info[10] = array ('Framed-Routing', 'I');
+        $this->_attributes_info[11] = array ('Filter-Id', 'T');
+        $this->_attributes_info[12] = array ('Framed-MTU', 'I');
+        $this->_attributes_info[13] = array ('Framed-Compression', 'I');
+        $this->_attributes_info[14] = array ('Login-IP-Host', 'A');
+        $this->_attributes_info[15] = array ('Login-service', 'I');
+        $this->_attributes_info[16] = array ('Login-TCP-Port', 'I');
+        $this->_attributes_info[17] = array ('(unassigned)', '');
+        $this->_attributes_info[18] = array ('Reply-Message', 'T');
+        $this->_attributes_info[19] = array ('Callback-Number', 'S');
+        $this->_attributes_info[20] = array ('Callback-Id', 'S');
+        $this->_attributes_info[21] = array ('(unassigned)', '');
+        $this->_attributes_info[22] = array ('Framed-Route', 'T');
+        $this->_attributes_info[23] = array ('Framed-IPX-Network', 'I');
+        $this->_attributes_info[24] = array ('State', 'S');
+        $this->_attributes_info[25] = array ('Class', 'S');
+        $this->_attributes_info[26] = array ('Vendor-Specific', 'S'); // Type (1) / Length (1) / Vendor-Id (4) / Vendor type (1) / Vendor length (1) / Attribute-Specific...
+        $this->_attributes_info[27] = array ('Session-Timeout', 'I');
+        $this->_attributes_info[28] = array ('Idle-Timeout', 'I');
+        $this->_attributes_info[29] = array ('Termination-Action', 'I');
+        $this->_attributes_info[30] = array ('Called-Station-Id', 'S');
+        $this->_attributes_info[31] = array ('Calling-Station-Id', 'S');
+        $this->_attributes_info[32] = array ('NAS-Identifier', 'S');
+        $this->_attributes_info[33] = array ('Proxy-State', 'S');
+        $this->_attributes_info[34] = array ('Login-LAT-Service', 'S');
+        $this->_attributes_info[35] = array ('Login-LAT-Node', 'S');
+        $this->_attributes_info[36] = array ('Login-LAT-Group', 'S');
+        $this->_attributes_info[37] = array ('Framed-AppleTalk-Link', 'I');
+        $this->_attributes_info[38] = array ('Framed-AppleTalk-Network', 'I');
+        $this->_attributes_info[39] = array ('Framed-AppleTalk-Zone', 'S');
+        $this->_attributes_info[60] = array ('CHAP-Challenge', 'S');
+        $this->_attributes_info[61] = array ('NAS-Port-Type', 'I');
+        $this->_attributes_info[62] = array ('Port-Limit', 'I');
+        $this->_attributes_info[63] = array ('Login-LAT-Port', 'S');
+        $this->_attributes_info[76] = array ('Prompt', 'I');
 
         $this->_identifier_to_send = 0;
         $this->_user_ip_address = (isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : '0.0.0.0');
 
-        $this->GenerateRequestAuthenticator();
-        $this->SetIpRadiusServer($ip_radius_server);
-        $this->SetSharedSecret($shared_secret);
-        $this->SetAuthenticationPort($authentication_port);
-        $this->SetAccountingPort($accounting_port);
-        $this->SetRadiusSuffix($radius_suffix);
-        $this->SetUdpTimeout($udp_timeout);
-        $this->SetUsername();
-        $this->SetPassword();
-        $this->SetNasIpAddress();
-        $this->SetNasPort();
-
-        $this->ClearLastError();
-        $this->ClearDataToSend();
-        $this->ClearDataReceived();
+        $this->GenerateRequestAuthenticator ();
+        $this->SetIpRadiusServer ($ip_radius_server);
+        $this->SetSharedSecret ($shared_secret);
+        $this->SetAuthenticationPort ($authentication_port);
+        $this->SetAccountingPort ($accounting_port);
+        $this->SetRadiusSuffix ($radius_suffix);
+        $this->SetUdpTimeout ($udp_timeout);
+        $this->SetUsername ();
+        $this->SetPassword ();
+        $this->SetNasIpAddress ();
+        $this->SetNasPort ();
+
+        $this->ClearLastError ();
+        $this->ClearDataToSend ();
+        $this->ClearDataReceived ();
     }
 
 
-    function GetNextIdentifier()
+    function GetNextIdentifier ()
     {
         $this->_identifier_to_send = (($this->_identifier_to_send + 1) % 256);
         return $this->_identifier_to_send;
     }
 
 
-    function GenerateRequestAuthenticator()
+    function GenerateRequestAuthenticator ()
     {
         $this->_request_authenticator = '';
         for ($ra_loop = 0; $ra_loop <= 15; $ra_loop++)
         {
-            $this->_request_authenticator .= chr(rand(1, 255));
+            $this->_request_authenticator .= chr (rand (1, 255));
         }
     }
 
 
-    function GetRequestAuthenticator()
+    function GetRequestAuthenticator ()
     {
         return $this->_request_authenticator;
     }
 
 
-    function GetLastError()
+    function GetLastError ()
     {
         if (0 < $this->_last_error_code)
         {
@@ -340,174 +340,174 @@ 
     }
 
 
-    function ClearDataToSend()
+    function ClearDataToSend ()
     {
         $this->_radius_packet_to_send = 0;
         $this->_attributes_to_send = NULL;
     }
 
 
-    function ClearDataReceived()
+    function ClearDataReceived ()
     {
         $this->_radius_packet_received = 0;
         $this->_attributes_received = NULL;
     }
 
 
-    function SetPacketCodeToSend($packet_code)
+    function SetPacketCodeToSend ($packet_code)
     {
         $this->_radius_packet_to_send = $packet_code;
     }
 
 
-    function SetDebugMode($debug_mode)
+    function SetDebugMode ($debug_mode)
     {
         $this->_debug_mode = (TRUE === $debug_mode);
     }
 
 
-    function SetIpRadiusServer($ip_radius_server)
+    function SetIpRadiusServer ($ip_radius_server)
     {
-        $this->_ip_radius_server = gethostbyname($ip_radius_server);
+        $this->_ip_radius_server = gethostbyname ($ip_radius_server);
     }
 
 
-    function SetSharedSecret($shared_secret)
+    function SetSharedSecret ($shared_secret)
     {
         $this->_shared_secret = $shared_secret;
     }
 
 
-    function SetRadiusSuffix($radius_suffix)
+    function SetRadiusSuffix ($radius_suffix)
     {
         $this->_radius_suffix = $radius_suffix;
     }
 
 
-    function SetUsername($username = '')
+    function SetUsername ($username = '')
     {
         $temp_username = $username;
-        if (false === strpos($temp_username, '@'))
+        if (false === strpos ($temp_username, '@'))
         {
             $temp_username .= $this->_radius_suffix;
         }
 
         $this->_username = $temp_username;
-        $this->SetAttribute(1, $this->_username);
+        $this->SetAttribute (1, $this->_username);
     }
 
 
-    function SetPassword($password = '')
+    function SetPassword ($password = '')
     {
         $this->_password = $password;
         $encrypted_password = '';
         $padded_password = $password;
 
-        if (0 != (strlen($password) % 16))
+        if (0 != (strlen ($password) % 16))
         {
-            $padded_password .= str_repeat(chr(0), (16 - strlen($password) % 16));
+            $padded_password .= str_repeat (chr (0), (16 - strlen ($password) % 16));
         }
 
         $previous_result = $this->_request_authenticator;
 
-        for ($full_loop = 0; $full_loop < (strlen($padded_password) / 16); $full_loop++)
+        for ($full_loop = 0; $full_loop < (strlen ($padded_password) / 16); $full_loop++)
         {
-            $xor_value = md5($this->_shared_secret.$previous_result);
+            $xor_value = md5 ($this->_shared_secret.$previous_result);
 
             $previous_result = '';
             for ($xor_loop = 0; $xor_loop <= 15; $xor_loop++)
             {
-                $value1 = ord(substr($padded_password, ($full_loop * 16) + $xor_loop, 1));
-                $value2 = hexdec(substr($xor_value, 2 * $xor_loop, 2));
-                $xor_result = $value1^$value2;
-                $previous_result .= chr($xor_result);
+                $value1 = ord (substr ($padded_password, ($full_loop * 16) + $xor_loop, 1));
+                $value2 = hexdec (substr ($xor_value, 2 * $xor_loop, 2));
+                $xor_result = $value1 ^ $value2;
+                $previous_result .= chr ($xor_result);
             }
             $encrypted_password .= $previous_result;
         }
 
         $this->_encrypted_password = $encrypted_password;
-        $this->SetAttribute(2, $this->_encrypted_password);
+        $this->SetAttribute (2, $this->_encrypted_password);
     }
 
 
-    function SetNasIPAddress($nas_ip_address = '')
+    function SetNasIPAddress ($nas_ip_address = '')
     {
-        if (0 < strlen($nas_ip_address))
+        if (0 < strlen ($nas_ip_address))
         {
-            $this->_nas_ip_address = gethostbyname($nas_ip_address);
+            $this->_nas_ip_address = gethostbyname ($nas_ip_address);
         } else
         {
-            $this->_nas_ip_address = gethostbyname(isset($_SERVER['SERVER_ADDR']) ? $_SERVER['SERVER_ADDR'] : '0.0.0.0');
+            $this->_nas_ip_address = gethostbyname (isset($_SERVER['SERVER_ADDR']) ? $_SERVER['SERVER_ADDR'] : '0.0.0.0');
         }
-        $this->SetAttribute(4, $this->_nas_ip_address);
+        $this->SetAttribute (4, $this->_nas_ip_address);
     }
 
 
-    function SetNasPort($nas_port = 0)
+    function SetNasPort ($nas_port = 0)
     {
-        $this->_nas_port = intval($nas_port);
-        $this->SetAttribute(5, $this->_nas_port);
+        $this->_nas_port = intval ($nas_port);
+        $this->SetAttribute (5, $this->_nas_port);
     }
 
 
-    function SetUdpTimeout($udp_timeout = 5)
+    function SetUdpTimeout ($udp_timeout = 5)
     {
-        if (intval($udp_timeout) > 0)
+        if (intval ($udp_timeout) > 0)
         {
-            $this->_udp_timeout = intval($udp_timeout);
+            $this->_udp_timeout = intval ($udp_timeout);
         }
     }
 
 
-    function ClearLastError()
+    function ClearLastError ()
     {
         $this->_last_error_code    = 0;
         $this->_last_error_message = '';
     }
 
 
-    function SetAuthenticationPort($authentication_port)
+    function SetAuthenticationPort ($authentication_port)
     {
-        if ((intval($authentication_port) > 0) && (intval($authentication_port) < 65536))
+        if ((intval ($authentication_port) > 0) && (intval ($authentication_port) < 65536))
         {
-            $this->_authentication_port = intval($authentication_port);
+            $this->_authentication_port = intval ($authentication_port);
         }
     }
 
 
-    function SetAccountingPort($accounting_port)
+    function SetAccountingPort ($accounting_port)
     {
-        if ((intval($accounting_port) > 0) && (intval($accounting_port) < 65536))
+        if ((intval ($accounting_port) > 0) && (intval ($accounting_port) < 65536))
         {
-            $this->_accounting_port = intval($accounting_port);
+            $this->_accounting_port = intval ($accounting_port);
         }
     }
 
 
-    function GetReceivedPacket()
+    function GetReceivedPacket ()
     {
         return $this->_radius_packet_received;
     }
 
 
-    function GetReceivedAttributes()
+    function GetReceivedAttributes ()
     {
         return $this->_attributes_received;
     }
 
 
-    function GetReadableReceivedAttributes()
+    function GetReadableReceivedAttributes ()
     {
         $readable_attributes = '';
         if (isset($this->_attributes_received))
         {
             foreach ($this->_attributes_received as $one_received_attribute)
             {
-                $attributes_info = $this->GetAttributesInfo($one_received_attribute[0]);
+                $attributes_info = $this->GetAttributesInfo ($one_received_attribute[0]);
                 $readable_attributes .= $attributes_info[0].": ";
                 if (26 == $one_received_attribute[0])
                 {
-                    $vendor_array = $this->DecodeVendorSpecificContent($one_received_attribute[1]);
+                    $vendor_array = $this->DecodeVendorSpecificContent ($one_received_attribute[1]);
                     foreach ($vendor_array as $vendor_one)
                     {
                         $readable_attributes .= 'Vendor-Id: '.$vendor_one[0].", Vendor-type: ".$vendor_one[1].",  Attribute-specific: ".$vendor_one[2];
@@ -523,12 +523,12 @@ 
     }
 
 
-    function GetAttribute($attribute_type)
+    function GetAttribute ($attribute_type)
     {
         $attribute_value = NULL;
         foreach ($this->_attributes_received as $one_received_attribute)
         {
-            if (intval($attribute_type) == $one_received_attribute[0])
+            if (intval ($attribute_type) == $one_received_attribute[0])
             {
                 $attribute_value = $one_received_attribute[1];
                 break;
@@ -538,11 +538,11 @@ 
     }
 
 
-    function GetRadiusPacketInfo($info_index)
+    function GetRadiusPacketInfo ($info_index)
     {
-        if (isset($this->_radius_packet_info[intval($info_index)]))
+        if (isset($this->_radius_packet_info[intval ($info_index)]))
         {
-            return $this->_radius_packet_info[intval($info_index)];
+            return $this->_radius_packet_info[intval ($info_index)];
         } else
         {
             return '';
@@ -550,34 +550,34 @@ 
     }
 
 
-    function GetAttributesInfo($info_index)
+    function GetAttributesInfo ($info_index)
     {
-        if (isset($this->_attributes_info[intval($info_index)]))
+        if (isset($this->_attributes_info[intval ($info_index)]))
         {
-            return $this->_attributes_info[intval($info_index)];
+            return $this->_attributes_info[intval ($info_index)];
         } else
         {
-            return array('', '');
+            return array ('', '');
         }
     }
 
 
-    function DebugInfo($debug_info)
+    function DebugInfo ($debug_info)
     {
         if ($this->_debug_mode)
         {
 	        //save debugging
-	        $this->debug_text[] = date('Y-m-d H:i:s').' DEBUG: '.$debug_info;
+	        $this->debug_text[] = date ('Y-m-d H:i:s').' DEBUG: '.$debug_info;
         }
     }
 
 
-    function SetAttribute($type, $value)
+    function SetAttribute ($type, $value)
     {
         $attribute_index = -1;
-        for ($attributes_loop = 0; $attributes_loop < count($this->_attributes_to_send); $attributes_loop++)
+        for ($attributes_loop = 0; $attributes_loop < count ($this->_attributes_to_send); $attributes_loop++)
         {
-            if ($type == ord(substr($this->_attributes_to_send[$attributes_loop], 0, 1)))
+            if ($type == ord (substr ($this->_attributes_to_send[$attributes_loop], 0, 1)))
             {
                 $attribute_index = $attributes_loop;
                 break;
@@ -591,17 +591,17 @@ 
             switch ($this->_attributes_info[$type][1])
             {
                 case 'T': // Text, 1-253 octets containing UTF-8 encoded ISO 10646 characters (RFC 2279).
-                    $temp_attribute = chr($type).chr(2 + strlen($value)).$value;
+                    $temp_attribute = chr ($type).chr (2 + strlen ($value)).$value;
                     break;
                 case 'S': // String, 1-253 octets containing binary data (values 0 through 255 decimal, inclusive).
-                    $temp_attribute = chr($type).chr(2 + strlen($value)).$value;
+                    $temp_attribute = chr ($type).chr (2 + strlen ($value)).$value;
                     break;
                 case 'A': // Address, 32 bit value, most significant octet first.
-                    $ip_array = explode(".", $value);
-                    $temp_attribute = chr($type).chr(6).chr($ip_array[0]).chr($ip_array[1]).chr($ip_array[2]).chr($ip_array[3]);
+                    $ip_array = explode (".", $value);
+                    $temp_attribute = chr ($type).chr (6).chr ($ip_array[0]).chr ($ip_array[1]).chr ($ip_array[2]).chr ($ip_array[3]);
                     break;
                 case 'I': // Integer, 32 bit unsigned value, most significant octet first.
-                    $temp_attribute = chr($type).chr(6).chr(($value / (256 * 256 * 256)) % 256).chr(($value / (256 * 256)) % 256).chr(($value / (256)) % 256).chr($value % 256);
+                    $temp_attribute = chr ($type).chr (6).chr (($value / (256 * 256 * 256)) % 256).chr (($value / (256 * 256)) % 256).chr (($value / (256)) % 256).chr ($value % 256);
                     break;
                 case 'D': // Time, 32 bit unsigned value, most significant octet first -- seconds since 00:00:00 UTC, January 1, 1970. (not used in this RFC)
                     $temp_attribute = NULL;
@@ -620,12 +620,12 @@ 
             $this->_attributes_to_send[] = $temp_attribute;
             $additional_debug = 'Added';
         }
-        $attribute_info = $this->GetAttributesInfo($type);
-        $this->DebugInfo($additional_debug.' Attribute '.$type.' ('.$attribute_info[0].'), format '.$attribute_info[1].', value <em>'.$value.'</em>');
+        $attribute_info = $this->GetAttributesInfo ($type);
+        $this->DebugInfo ($additional_debug.' Attribute '.$type.' ('.$attribute_info[0].'), format '.$attribute_info[1].', value <em>'.$value.'</em>');
     }
 
 
-    function DecodeAttribute($attribute_raw_value, $attribute_format)
+    function DecodeAttribute ($attribute_raw_value, $attribute_format)
     {
         $attribute_value = NULL;
 
@@ -640,10 +640,10 @@ 
                     $attribute_value = $attribute_raw_value;
                     break;
                 case 'A': // Address, 32 bit value, most significant octet first.
-                    $attribute_value = ord(substr($attribute_raw_value, 0, 1)).'.'.ord(substr($attribute_raw_value, 1, 1)).'.'.ord(substr($attribute_raw_value, 2, 1)).'.'.ord(substr($attribute_raw_value, 3, 1));
+                    $attribute_value = ord (substr ($attribute_raw_value, 0, 1)).'.'.ord (substr ($attribute_raw_value, 1, 1)).'.'.ord (substr ($attribute_raw_value, 2, 1)).'.'.ord (substr ($attribute_raw_value, 3, 1));
                     break;
                 case 'I': // Integer, 32 bit unsigned value, most significant octet first.
-                    $attribute_value = (ord(substr($attribute_raw_value, 0, 1)) * 256 * 256 * 256) + (ord(substr($attribute_raw_value, 1, 1)) * 256 * 256) + (ord(substr($attribute_raw_value, 2, 1)) * 256) + ord(substr($attribute_raw_value, 3, 1));
+                    $attribute_value = (ord (substr ($attribute_raw_value, 0, 1)) * 256 * 256 * 256) + (ord (substr ($attribute_raw_value, 1, 1)) * 256 * 256) + (ord (substr ($attribute_raw_value, 2, 1)) * 256) + ord (substr ($attribute_raw_value, 3, 1));
                     break;
                 case 'D': // Time, 32 bit unsigned value, most significant octet first -- seconds since 00:00:00 UTC, January 1, 1970. (not used in this RFC)
                     $attribute_value = NULL;
@@ -659,18 +659,18 @@ 
     /*********************************************************************
      * Array returned: array(array(Vendor-Id1, Vendor type1, Attribute-Specific1), ..., array(Vendor-IdN, Vendor typeN, Attribute-SpecificN)
      *********************************************************************/
-    function DecodeVendorSpecificContent($vendor_specific_raw_value)
+    function DecodeVendorSpecificContent ($vendor_specific_raw_value)
     {
-        $result = array();
+        $result = array ();
         $offset_in_raw = 0;
-        $vendor_id = (ord(substr($vendor_specific_raw_value, 0, 1)) * 256 * 256 * 256) + (ord(substr($vendor_specific_raw_value, 1, 1)) * 256 * 256) + (ord(substr($vendor_specific_raw_value, 2, 1)) * 256) + ord(substr($vendor_specific_raw_value, 3, 1));
+        $vendor_id = (ord (substr ($vendor_specific_raw_value, 0, 1)) * 256 * 256 * 256) + (ord (substr ($vendor_specific_raw_value, 1, 1)) * 256 * 256) + (ord (substr ($vendor_specific_raw_value, 2, 1)) * 256) + ord (substr ($vendor_specific_raw_value, 3, 1));
         $offset_in_raw += 4;
-        while ($offset_in_raw < strlen($vendor_specific_raw_value))
+        while ($offset_in_raw < strlen ($vendor_specific_raw_value))
         {
-            $vendor_type = (ord(substr($vendor_specific_raw_value, 0 + $offset_in_raw, 1)));
-            $vendor_length = (ord(substr($vendor_specific_raw_value, 1 + $offset_in_raw, 1)));
-            $attribute_specific = substr($vendor_specific_raw_value, 2 + $offset_in_raw, $vendor_length);
-            $result[] = array($vendor_id, $vendor_type, $attribute_specific);
+            $vendor_type = (ord (substr ($vendor_specific_raw_value, 0 + $offset_in_raw, 1)));
+            $vendor_length = (ord (substr ($vendor_specific_raw_value, 1 + $offset_in_raw, 1)));
+            $attribute_specific = substr ($vendor_specific_raw_value, 2 + $offset_in_raw, $vendor_length);
+            $result[] = array ($vendor_id, $vendor_type, $attribute_specific);
             $offset_in_raw += ($vendor_length);
         }
 
@@ -683,140 +683,140 @@ 
      *
      * Return TRUE if Access-Request is accepted, FALSE otherwise
      */
-    function AccessRequest($username = '', $password = '', $udp_timeout = 0, $state = NULL)
+    function AccessRequest ($username = '', $password = '', $udp_timeout = 0, $state = NULL)
     {
-        $this->ClearDataReceived();
-        $this->ClearLastError();
+        $this->ClearDataReceived ();
+        $this->ClearLastError ();
 
-        $this->SetPacketCodeToSend(1); // Access-Request
+        $this->SetPacketCodeToSend (1); // Access-Request
 
-        if (0 < strlen($username))
+        if (0 < strlen ($username))
         {
-            $this->SetUsername($username);
+            $this->SetUsername ($username);
         }
 
-        if (0 < strlen($password))
+        if (0 < strlen ($password))
         {
-            $this->SetPassword($password);
+            $this->SetPassword ($password);
         }
 
         if ($state !== NULL)
         {
-            $this->SetAttribute(24, $state);
+            $this->SetAttribute (24, $state);
         } else
         {
-            $this->SetAttribute(6, 1); // 1=Login
+            $this->SetAttribute (6, 1); // 1=Login
         }
 
-        if (intval($udp_timeout) > 0)
+        if (intval ($udp_timeout) > 0)
         {
-            $this->SetUdpTimeout($udp_timeout);
+            $this->SetUdpTimeout ($udp_timeout);
         }
 
         $attributes_content = '';
-        for ($attributes_loop = 0; $attributes_loop < count($this->_attributes_to_send); $attributes_loop++)
+        for ($attributes_loop = 0; $attributes_loop < count ($this->_attributes_to_send); $attributes_loop++)
         {
             $attributes_content .= $this->_attributes_to_send[$attributes_loop];
         }
 
         $packet_length  = 4; // Radius packet code + Identifier + Length high + Length low
-        $packet_length += strlen($this->_request_authenticator); // Request-Authenticator
-        $packet_length += strlen($attributes_content); // Attributes
+        $packet_length += strlen ($this->_request_authenticator); // Request-Authenticator
+        $packet_length += strlen ($attributes_content); // Attributes
 
-        $packet_data  = chr($this->_radius_packet_to_send);
-        $packet_data .= chr($this->GetNextIdentifier());
-        $packet_data .= chr(intval($packet_length / 256));
-        $packet_data .= chr(intval($packet_length % 256));
+        $packet_data  = chr ($this->_radius_packet_to_send);
+        $packet_data .= chr ($this->GetNextIdentifier ());
+        $packet_data .= chr (intval ($packet_length / 256));
+        $packet_data .= chr (intval ($packet_length % 256));
         $packet_data .= $this->_request_authenticator;
         $packet_data .= $attributes_content;
 
-        $_socket_to_server = socket_create(AF_INET, SOCK_DGRAM, 17); // UDP packet = 17
+        $_socket_to_server = socket_create (AF_INET, SOCK_DGRAM, 17); // UDP packet = 17
 
         if ($_socket_to_server === FALSE)
         {
-            $this->_last_error_code    = socket_last_error();
-            $this->_last_error_message = socket_strerror($this->_last_error_code);
-        } elseif (FALSE === socket_connect($_socket_to_server, $this->_ip_radius_server, $this->_authentication_port))
+            $this->_last_error_code    = socket_last_error ();
+            $this->_last_error_message = socket_strerror ($this->_last_error_code);
+        } elseif (FALSE === socket_connect ($_socket_to_server, $this->_ip_radius_server, $this->_authentication_port))
         {
-            $this->_last_error_code    = socket_last_error();
-            $this->_last_error_message = socket_strerror($this->_last_error_code);
-        } elseif (FALSE === socket_write($_socket_to_server, $packet_data, $packet_length))
+            $this->_last_error_code    = socket_last_error ();
+            $this->_last_error_message = socket_strerror ($this->_last_error_code);
+        } elseif (FALSE === socket_write ($_socket_to_server, $packet_data, $packet_length))
         {
-            $this->_last_error_code    = socket_last_error();
-            $this->_last_error_message = socket_strerror($this->_last_error_code);
+            $this->_last_error_code    = socket_last_error ();
+            $this->_last_error_message = socket_strerror ($this->_last_error_code);
         } else
         {
-            $this->DebugInfo('<b>Packet type '.$this->_radius_packet_to_send.' ('.$this->GetRadiusPacketInfo($this->_radius_packet_to_send).')'.' sent</b>');
+            $this->DebugInfo ('<b>Packet type '.$this->_radius_packet_to_send.' ('.$this->GetRadiusPacketInfo ($this->_radius_packet_to_send).')'.' sent</b>');
             if ($this->_debug_mode)
             {
                 $readable_attributes = '';
                 foreach ($this->_attributes_to_send as $one_attribute_to_send)
                 {
-                    $attribute_info = $this->GetAttributesInfo(ord(substr($one_attribute_to_send, 0, 1)));
-                    $this->DebugInfo('Attribute '.ord(substr($one_attribute_to_send, 0, 1)).' ('.$attribute_info[0].'), length '.(ord(substr($one_attribute_to_send, 1, 1)) - 2).', format '.$attribute_info[1].', value <em>'.$this->DecodeAttribute(substr($one_attribute_to_send, 2), ord(substr($one_attribute_to_send, 0, 1))).'</em>');
+                    $attribute_info = $this->GetAttributesInfo (ord (substr ($one_attribute_to_send, 0, 1)));
+                    $this->DebugInfo ('Attribute '.ord (substr ($one_attribute_to_send, 0, 1)).' ('.$attribute_info[0].'), length '.(ord (substr ($one_attribute_to_send, 1, 1)) - 2).', format '.$attribute_info[1].', value <em>'.$this->DecodeAttribute (substr ($one_attribute_to_send, 2), ord (substr ($one_attribute_to_send, 0, 1))).'</em>');
                 }
             }
-            $read_socket_array   = array($_socket_to_server);
+            $read_socket_array   = array ($_socket_to_server);
             $write_socket_array  = NULL;
             $except_socket_array = NULL;
 
-            $received_packet = chr(0);
+            $received_packet = chr (0);
 
-            if (!(FALSE === socket_select($read_socket_array, $write_socket_array, $except_socket_array, $this->_udp_timeout)))
+            if (!(FALSE === socket_select ($read_socket_array, $write_socket_array, $except_socket_array, $this->_udp_timeout)))
             {
-                if (in_array($_socket_to_server, $read_socket_array))
+                if (in_array ($_socket_to_server, $read_socket_array))
                 {
-                    if (FALSE === ($received_packet = @socket_read($_socket_to_server, 1024))) {
+                    if (FALSE === ($received_packet = @socket_read ($_socket_to_server, 1024))) {
                         // @ used, than no error is displayed if the connection is closed by the remote host
                     {
-                        $received_packet = chr(0);
+                        $received_packet = chr (0);
                     }
-                        $this->_last_error_code    = socket_last_error();
-                        $this->_last_error_message = socket_strerror($this->_last_error_code);
+                        $this->_last_error_code    = socket_last_error ();
+                        $this->_last_error_message = socket_strerror ($this->_last_error_code);
                     } else
                     {
-                        socket_close($_socket_to_server);
+                        socket_close ($_socket_to_server);
                     }
                 }
             } else
             {
-                socket_close($_socket_to_server);
+                socket_close ($_socket_to_server);
             }
         }
 
-        $this->_radius_packet_received = intval(ord(substr($received_packet, 0, 1)));
+        $this->_radius_packet_received = intval (ord (substr ($received_packet, 0, 1)));
 
-        $this->DebugInfo('<b>Packet type '.$this->_radius_packet_received.' ('.$this->GetRadiusPacketInfo($this->_radius_packet_received).')'.' received</b>');
+        $this->DebugInfo ('<b>Packet type '.$this->_radius_packet_received.' ('.$this->GetRadiusPacketInfo ($this->_radius_packet_received).')'.' received</b>');
 
         if ($this->_radius_packet_received > 0)
         {
-            $this->_identifier_received = intval(ord(substr($received_packet, 1, 1)));
-            $packet_length = (intval(ord(substr($received_packet, 2, 1))) * 256) + (intval(ord(substr($received_packet, 3, 1))));
-            $this->_response_authenticator = substr($received_packet, 4, 16);
-            $attributes_content = substr($received_packet, 20, ($packet_length - 4 - 16));
-            while (strlen($attributes_content) > 2)
+            $this->_identifier_received = intval (ord (substr ($received_packet, 1, 1)));
+            $packet_length = (intval (ord (substr ($received_packet, 2, 1))) * 256) + (intval (ord (substr ($received_packet, 3, 1))));
+            $this->_response_authenticator = substr ($received_packet, 4, 16);
+            $attributes_content = substr ($received_packet, 20, ($packet_length - 4 - 16));
+            while (strlen ($attributes_content) > 2)
             {
-                $attribute_type = intval(ord(substr($attributes_content, 0, 1)));
-                $attribute_length = intval(ord(substr($attributes_content, 1, 1)));
-                $attribute_raw_value = substr($attributes_content, 2, $attribute_length - 2);
-                $attributes_content = substr($attributes_content, $attribute_length);
+                $attribute_type = intval (ord (substr ($attributes_content, 0, 1)));
+                $attribute_length = intval (ord (substr ($attributes_content, 1, 1)));
+                $attribute_raw_value = substr ($attributes_content, 2, $attribute_length - 2);
+                $attributes_content = substr ($attributes_content, $attribute_length);
 
-                $attribute_value = $this->DecodeAttribute($attribute_raw_value, $attribute_type);
+                $attribute_value = $this->DecodeAttribute ($attribute_raw_value, $attribute_type);
 
-                $attribute_info = $this->GetAttributesInfo($attribute_type);
+                $attribute_info = $this->GetAttributesInfo ($attribute_type);
                 if (26 == $attribute_type)
                 {
-                    $vendor_array = $this->DecodeVendorSpecificContent($attribute_value);
+                    $vendor_array = $this->DecodeVendorSpecificContent ($attribute_value);
                     foreach ($vendor_array as $vendor_one)
                     {
-                        $this->DebugInfo('Attribute '.$attribute_type.' ('.$attribute_info[0].'), length '.($attribute_length - 2).', format '.$attribute_info[1].', Vendor-Id: '.$vendor_one[0].", Vendor-type: ".$vendor_one[1].",  Attribute-specific: ".$vendor_one[2]);
+                        $this->DebugInfo ('Attribute '.$attribute_type.' ('.$attribute_info[0].'), length '.($attribute_length - 2).', format '.$attribute_info[1].', Vendor-Id: '.$vendor_one[0].", Vendor-type: ".$vendor_one[1].",  Attribute-specific: ".$vendor_one[2]);
                     }
                 } else
                 {
-                    $this->DebugInfo('Attribute '.$attribute_type.' ('.$attribute_info[0].'), length '.($attribute_length - 2).', format '.$attribute_info[1].', value <em>'.$attribute_value.'</em>');
+                    $this->DebugInfo ('Attribute '.$attribute_type.' ('.$attribute_info[0].'), length '.($attribute_length - 2).', format '.$attribute_info[1].', value <em>'.$attribute_value.'</em>');
                 }
 
-                $this->_attributes_received[] = array($attribute_type, $attribute_value);
+                $this->_attributes_received[] = array ($attribute_type, $attribute_value);
             }
         }
 

functions/classes/class.Result.php

Doc Comments +7 added lines, -7 removed lines

@@ -71,7 +71,7 @@ 
 	 *
 	 * @access public
 	 * @param string $text (default: "No value provided")
-	 * @return void
+	 * @return string
 	 */
 	public function show_cli_message ($text="No value provided") {
 		// array - join
@@ -95,11 +95,11 @@ 
 	 * Show GUI result
 	 *
 	 * @access public
-	 * @param mixed $class
-	 * @param mixed $text
-	 * @param mixed $popup
-	 * @param mixed $popup2
-	 * @return void
+	 * @param string $class
+	 * @param string $text
+	 * @param boolean $popup
+	 * @param boolean $popup2
+	 * @return string
 	 */
 	public function show_message ($class, $text, $popup, $popup2) {
 		// format if array
@@ -144,7 +144,7 @@ 
 	 * Exists with exception for API
 	 *
 	 * @access public
-	 * @param mixed $content
+	 * @param string $content
 	 * @return void
 	 */
 	public function throw_exception ($content) {

Braces +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 		$this->die = $die;
 
 		# API - throw exception
-		if($this->exit_method == "exception")  {
+		if($this->exit_method == "exception") {
 			# ok, just return success
 			if ($class=="success") 		{ return true; }
 			else						{ return $this->throw_exception ($text); }

Indentation +170 added lines, -170 removed lines

@@ -13,176 +13,176 @@
 
 class Result extends Common_functions {
 
-	/**
-	 *  what to do when failed - result shows result, exception throws exception (for API)
-	 *
-	 * (default value: "result")
-	 *
-	 * @var string
-	 * @access public
-	 */
-	public $exit_method = "result";
-
-	/**
-	 * Die flag
-	 *
-	 * (default value: false)
-	 *
-	 * @var bool
-	 * @access public
-	 */
-	public $die = false;
-
-	/**
-	 * Show result
-	 *
-	 * @access public
-	 * @param string $class (default: "muted")				result class - danger, success, warning, info
-	 * @param string $text (default: "No value provided")	text to display
-	 * @param bool $die (default: false)					controls stop of php execution
-	 * @param bool $popup (default: false)					print result as popup
-	 * @param bool $inline (default: false)					return, not print
-	 * @param bool $popup2 (default: false)					close for JS for popup2
-	 * @return void
-	 */
-	public function show($class="muted", $text="No value provided", $die=false, $popup=false, $inline = false, $popup2 = false) {
-
-		# set die
-		$this->die = $die;
-
-		# API - throw exception
-		if($this->exit_method == "exception")  {
-			# ok, just return success
-			if ($class=="success") 		{ return true; }
-			else						{ return $this->throw_exception ($text); }
-		}
-		else {
-			# cli or GUI
-			if (php_sapi_name()=="cli") { print $this->show_cli_message ($text); }
-			else {
-				# return or print
-				if ($inline) 			{ return $this->show_message ($class, $text, $popup, $popup2); }
-				else					{ print  $this->show_message ($class, $text, $popup, $popup2); }
-			}
-
-			# die
-			if($this->die===true)	{die(); }
-		}
-	}
-
-	/**
-	 * Alias for show method for backwards compatibility
-	 *
-	 * @access public
-	 * @param string $text (default: "No value provided")
-	 * @param bool $die (default: false)
-	 * @return void
-	 */
-	public function show_cli ($text="No value provided", $die=false) {
-		$this->show(false, $text, $die, false, false, false);
-	}
-
-	/**
-	 * Shows result for cli functions
-	 *
-	 * @access public
-	 * @param string $text (default: "No value provided")
-	 * @return void
-	 */
-	public function show_cli_message ($text="No value provided") {
-		// array - join
-		if (is_array($text) && sizeof($text)>0) {
-			// 1 element
-			if(sizeof( $text )==1) {
-				$text = $text[0];
-			}
-			// multiple - format
-			else {
-				foreach( $text as $l ) { $out[] = "\t* $l"; }
-				// join
-				$text = implode("\n", $out);
-			}
-		}
-		# print
-		return $text."\n";
-	}
-
-	/**
-	 * Show GUI result
-	 *
-	 * @access public
-	 * @param mixed $class
-	 * @param mixed $text
-	 * @param mixed $popup
-	 * @param mixed $popup2
-	 * @return void
-	 */
-	public function show_message ($class, $text, $popup, $popup2) {
-    	// to array if object
-    	if (is_object($text))   { $text = (array) $text; }
-		// format if array
-		if(is_array($text)) {
-			// single value
-			if(sizeof( $text )==1) {
-				$out = $text;
-			}
-			// multiple values
-			else {
-				$out[] = "<ul>";
-				foreach( $text as $l ) { $out[] = "<li>$l</li>"; }
-				$out[] = "</ul>";
-			}
-			// join
-			$text = implode("\n", $out);
-		}
-
-		# print popup or normal
-		if($popup===false) {
-			return "<div class='alert alert-".$class."'>".$text."</div>";
-		}
-		else {
-			// set close class for JS
-			$pclass = $popup2===false ? "hidePopups" : "hidePopup2";
-			// change danger to error for popup
-			$htext = $class==="danger" ? "error" : $class;
-
-			$out[] = '<div class="pHeader">'._(ucwords($htext)).'</div>';
-			$out[] = '<div class="pContent">';
-			$out[] = '<div class="alert alert-'.$class.'">'.$text.'</div>';
-			$out[] = '</div>';
-			$out[] = '<div class="pFooter"><button class="btn btn-sm btn-default '.$pclass.'">'._('Close').'</button></div>';
-
-			// return
-			return implode("\n", $out);
-		}
-	}
-
-	/**
-	 * Exists with exception for API
-	 *
-	 * @access public
-	 * @param mixed $content
-	 * @return void
-	 */
-	public function throw_exception ($content) {
-		// include Exceptions class for API
-		include_once( dirname(__FILE__) . '../../../api/controllers/Responses.php' );
-		// initialize exceptions
-		$Exceptions = new Responses ();
-		// throw error
-		$Exceptions->throw_exception(500, $content);
-	}
-
-	/**
-	 * __destruct function
-	 *
-	 * @access public
-	 * @return void
-	 */
-	public function __destruct() {
-		// exit if required
-		if ($this->die === true)	{ die(); }
-	}
+    /**
+     *  what to do when failed - result shows result, exception throws exception (for API)
+     *
+     * (default value: "result")
+     *
+     * @var string
+     * @access public
+     */
+    public $exit_method = "result";
+
+    /**
+     * Die flag
+     *
+     * (default value: false)
+     *
+     * @var bool
+     * @access public
+     */
+    public $die = false;
+
+    /**
+     * Show result
+     *
+     * @access public
+     * @param string $class (default: "muted")				result class - danger, success, warning, info
+     * @param string $text (default: "No value provided")	text to display
+     * @param bool $die (default: false)					controls stop of php execution
+     * @param bool $popup (default: false)					print result as popup
+     * @param bool $inline (default: false)					return, not print
+     * @param bool $popup2 (default: false)					close for JS for popup2
+     * @return void
+     */
+    public function show($class="muted", $text="No value provided", $die=false, $popup=false, $inline = false, $popup2 = false) {
+
+        # set die
+        $this->die = $die;
+
+        # API - throw exception
+        if($this->exit_method == "exception")  {
+            # ok, just return success
+            if ($class=="success") 		{ return true; }
+            else						{ return $this->throw_exception ($text); }
+        }
+        else {
+            # cli or GUI
+            if (php_sapi_name()=="cli") { print $this->show_cli_message ($text); }
+            else {
+                # return or print
+                if ($inline) 			{ return $this->show_message ($class, $text, $popup, $popup2); }
+                else					{ print  $this->show_message ($class, $text, $popup, $popup2); }
+            }
+
+            # die
+            if($this->die===true)	{die(); }
+        }
+    }
+
+    /**
+     * Alias for show method for backwards compatibility
+     *
+     * @access public
+     * @param string $text (default: "No value provided")
+     * @param bool $die (default: false)
+     * @return void
+     */
+    public function show_cli ($text="No value provided", $die=false) {
+        $this->show(false, $text, $die, false, false, false);
+    }
+
+    /**
+     * Shows result for cli functions
+     *
+     * @access public
+     * @param string $text (default: "No value provided")
+     * @return void
+     */
+    public function show_cli_message ($text="No value provided") {
+        // array - join
+        if (is_array($text) && sizeof($text)>0) {
+            // 1 element
+            if(sizeof( $text )==1) {
+                $text = $text[0];
+            }
+            // multiple - format
+            else {
+                foreach( $text as $l ) { $out[] = "\t* $l"; }
+                // join
+                $text = implode("\n", $out);
+            }
+        }
+        # print
+        return $text."\n";
+    }
+
+    /**
+     * Show GUI result
+     *
+     * @access public
+     * @param mixed $class
+     * @param mixed $text
+     * @param mixed $popup
+     * @param mixed $popup2
+     * @return void
+     */
+    public function show_message ($class, $text, $popup, $popup2) {
+        // to array if object
+        if (is_object($text))   { $text = (array) $text; }
+        // format if array
+        if(is_array($text)) {
+            // single value
+            if(sizeof( $text )==1) {
+                $out = $text;
+            }
+            // multiple values
+            else {
+                $out[] = "<ul>";
+                foreach( $text as $l ) { $out[] = "<li>$l</li>"; }
+                $out[] = "</ul>";
+            }
+            // join
+            $text = implode("\n", $out);
+        }
+
+        # print popup or normal
+        if($popup===false) {
+            return "<div class='alert alert-".$class."'>".$text."</div>";
+        }
+        else {
+            // set close class for JS
+            $pclass = $popup2===false ? "hidePopups" : "hidePopup2";
+            // change danger to error for popup
+            $htext = $class==="danger" ? "error" : $class;
+
+            $out[] = '<div class="pHeader">'._(ucwords($htext)).'</div>';
+            $out[] = '<div class="pContent">';
+            $out[] = '<div class="alert alert-'.$class.'">'.$text.'</div>';
+            $out[] = '</div>';
+            $out[] = '<div class="pFooter"><button class="btn btn-sm btn-default '.$pclass.'">'._('Close').'</button></div>';
+
+            // return
+            return implode("\n", $out);
+        }
+    }
+
+    /**
+     * Exists with exception for API
+     *
+     * @access public
+     * @param mixed $content
+     * @return void
+     */
+    public function throw_exception ($content) {
+        // include Exceptions class for API
+        include_once( dirname(__FILE__) . '../../../api/controllers/Responses.php' );
+        // initialize exceptions
+        $Exceptions = new Responses ();
+        // throw error
+        $Exceptions->throw_exception(500, $content);
+    }
+
+    /**
+     * __destruct function
+     *
+     * @access public
+     * @return void
+     */
+    public function __destruct() {
+        // exit if required
+        if ($this->die === true)	{ die(); }
+    }
 }
 
 ?>
\ No newline at end of file

Spacing +30 added lines, -30 removed lines

@@ -45,28 +45,28 @@ 
 	 * @param bool $popup2 (default: false)					close for JS for popup2
 	 * @return void
 	 */
-	public function show($class="muted", $text="No value provided", $die=false, $popup=false, $inline = false, $popup2 = false) {
+	public function show ($class = "muted", $text = "No value provided", $die = false, $popup = false, $inline = false, $popup2 = false) {
 
 		# set die
 		$this->die = $die;
 
 		# API - throw exception
-		if($this->exit_method == "exception")  {
+		if ($this->exit_method == "exception") {
 			# ok, just return success
-			if ($class=="success") 		{ return true; }
-			else						{ return $this->throw_exception ($text); }
+			if ($class == "success") { return true; }
+			else { return $this->throw_exception ($text); }
 		}
 		else {
 			# cli or GUI
-			if (php_sapi_name()=="cli") { print $this->show_cli_message ($text); }
+			if (php_sapi_name () == "cli") { print $this->show_cli_message ($text); }
 			else {
 				# return or print
-				if ($inline) 			{ return $this->show_message ($class, $text, $popup, $popup2); }
-				else					{ print  $this->show_message ($class, $text, $popup, $popup2); }
+				if ($inline) { return $this->show_message ($class, $text, $popup, $popup2); }
+				else { print  $this->show_message ($class, $text, $popup, $popup2); }
 			}
 
 			# die
-			if($this->die===true)	{die(); }
+			if ($this->die === true) {die(); }
 		}
 	}
 
@@ -78,8 +78,8 @@ 
 	 * @param bool $die (default: false)
 	 * @return void
 	 */
-	public function show_cli ($text="No value provided", $die=false) {
-		$this->show(false, $text, $die, false, false, false);
+	public function show_cli ($text = "No value provided", $die = false) {
+		$this->show (false, $text, $die, false, false, false);
 	}
 
 	/**
@@ -89,18 +89,18 @@ 
 	 * @param string $text (default: "No value provided")
 	 * @return void
 	 */
-	public function show_cli_message ($text="No value provided") {
+	public function show_cli_message ($text = "No value provided") {
 		// array - join
-		if (is_array($text) && sizeof($text)>0) {
+		if (is_array ($text) && sizeof ($text) > 0) {
 			// 1 element
-			if(sizeof( $text )==1) {
+			if (sizeof ($text) == 1) {
 				$text = $text[0];
 			}
 			// multiple - format
 			else {
-				foreach( $text as $l ) { $out[] = "\t* $l"; }
+				foreach ($text as $l) { $out[] = "\t* $l"; }
 				// join
-				$text = implode("\n", $out);
+				$text = implode ("\n", $out);
 			}
 		}
 		# print
@@ -119,41 +119,41 @@ 
 	 */
 	public function show_message ($class, $text, $popup, $popup2) {
     	// to array if object
-    	if (is_object($text))   { $text = (array) $text; }
+    	if (is_object ($text)) { $text = (array) $text; }
 		// format if array
-		if(is_array($text)) {
+		if (is_array ($text)) {
 			// single value
-			if(sizeof( $text )==1) {
+			if (sizeof ($text) == 1) {
 				$out = $text;
 			}
 			// multiple values
 			else {
 				$out[] = "<ul>";
-				foreach( $text as $l ) { $out[] = "<li>$l</li>"; }
+				foreach ($text as $l) { $out[] = "<li>$l</li>"; }
 				$out[] = "</ul>";
 			}
 			// join
-			$text = implode("\n", $out);
+			$text = implode ("\n", $out);
 		}
 
 		# print popup or normal
-		if($popup===false) {
+		if ($popup === false) {
 			return "<div class='alert alert-".$class."'>".$text."</div>";
 		}
 		else {
 			// set close class for JS
-			$pclass = $popup2===false ? "hidePopups" : "hidePopup2";
+			$pclass = $popup2 === false ? "hidePopups" : "hidePopup2";
 			// change danger to error for popup
-			$htext = $class==="danger" ? "error" : $class;
+			$htext = $class === "danger" ? "error" : $class;
 
-			$out[] = '<div class="pHeader">'._(ucwords($htext)).'</div>';
+			$out[] = '<div class="pHeader">'._ (ucwords ($htext)).'</div>';
 			$out[] = '<div class="pContent">';
 			$out[] = '<div class="alert alert-'.$class.'">'.$text.'</div>';
 			$out[] = '</div>';
-			$out[] = '<div class="pFooter"><button class="btn btn-sm btn-default '.$pclass.'">'._('Close').'</button></div>';
+			$out[] = '<div class="pFooter"><button class="btn btn-sm btn-default '.$pclass.'">'._ ('Close').'</button></div>';
 
 			// return
-			return implode("\n", $out);
+			return implode ("\n", $out);
 		}
 	}
 
@@ -166,11 +166,11 @@ 
 	 */
 	public function throw_exception ($content) {
 		// include Exceptions class for API
-		include_once( dirname(__FILE__) . '../../../api/controllers/Responses.php' );
+		include_once(dirname (__FILE__).'../../../api/controllers/Responses.php');
 		// initialize exceptions
 		$Exceptions = new Responses ();
 		// throw error
-		$Exceptions->throw_exception(500, $content);
+		$Exceptions->throw_exception (500, $content);
 	}
 
 	/**
@@ -179,9 +179,9 @@ 
 	 * @access public
 	 * @return void
 	 */
-	public function __destruct() {
+	public function __destruct () {
 		// exit if required
-		if ($this->die === true)	{ die(); }
+		if ($this->die === true) { die(); }
 	}
 }
 

functions/classes/class.Scan.php

Doc Comments +8 added lines, -9 removed lines

@@ -62,7 +62,7 @@ 
 	 * Returns all possible ping types / apps
 	 *
 	 * @access public
-	 * @return array
+	 * @return string[]
 	 */
 	public function ping_fetch_types () {
 		return array("ping", "pear", "fping");
@@ -152,7 +152,6 @@ 
 	 * @param mixed $address
 	 * @param int $count (default: 1)
 	 * @param int $timeout (default: 1)
-	 * @param bool $exit (default: false)
 	 * @return void
 	 */
 	public function ping_address ($address, $count=1, $timeout = 1) {
@@ -178,7 +177,7 @@ 
 	 *
 	 * @access protected
 	 * @param ip $address
-	 * @return void
+	 * @return null|integer
 	 */
 	protected function ping_address_method_ping ($address) {
 		# verify ping path
@@ -276,8 +275,7 @@ 
 	 *	fping cannot be run from web, it needs root privileges to be able to open raw socket :/
 	 *
 	 * @access public
-	 * @param mixed $subnet 	//CIDR
-	 * @return void
+	 * @return null|integer
 	 */
 	public function ping_address_method_fping ($address) {
 		# verify ping path
@@ -329,7 +327,7 @@ 
 	 *	fping cannot be run from web, it needs root privileges to be able to open raw socket :/
 	 *
 	 * @access public
-	 * @param mixed $subnet 	//CIDR
+	 * @param mixed $subnet_cidr 	//CIDR
 	 * @return void
 	 */
 	public function ping_address_method_fping_subnet ($subnet_cidr, $return_result = false) {
@@ -377,8 +375,8 @@ 
 	 * Explains invalid error codes
 	 *
 	 * @access public
-	 * @param mixed $code
-	 * @return void
+	 * @param null|integer $code
+	 * @return string|false
 	 */
 	public function ping_exit_explain ($code) {
 		# fetch explain codes
@@ -396,7 +394,7 @@ 
 	 *	extend if needed for future scripts
 	 *
 	 * @access public
-	 * @return void
+	 * @return string[]
 	 */
 	public function ping_set_exit_code_explains () {
 		$explain_codes[0]  = "SUCCESS";
@@ -523,6 +521,7 @@ 
 	 *
 	 * @access public
 	 * @param mixed $subnetId
+	 * @param boolean $die
 	 * @return void
 	 */
 	public function prepare_addresses_to_discover_subnetId ($subnetId, $die) {

Braces +9 added lines, -9 removed lines

@@ -431,8 +431,7 @@ 
     	# set datetime
     	$datetime = is_null($datetime) ? date("Y-m-d H:i:s") : $datetime;
 		# execute
-		try { $this->Database->updateObject("ipaddresses", array("id"=>$id, "lastSeen"=>$datetime), "id"); }
-		catch (Exception $e) {
+		try { $this->Database->updateObject("ipaddresses", array("id"=>$id, "lastSeen"=>$datetime), "id"); } catch (Exception $e) {
 			!$this->debugging ? : $this->Result->show("danger", $e->getMessage(), false);
 			# log
 			!$this->debugging ? : $this->Log->write ("status_update", _('Failed to update address status'), 0 );
@@ -452,8 +451,7 @@ 
     	if ($date === false)    { $date = date("Y-m-d H:i:s"); }
     	else                    { $date = $date; }
 		# execute
-		try { $this->Database->updateObject("scanAgents", array("id"=>$id, "last_access"=>date("Y-m-d H:i:s")), "id"); }
-		catch (Exception $e) {
+		try { $this->Database->updateObject("scanAgents", array("id"=>$id, "last_access"=>date("Y-m-d H:i:s")), "id"); } catch (Exception $e) {
 		}
 	}
 
@@ -477,7 +475,7 @@ 
 			//failed
 			if (!$conn) {}
 			//success
-			else 		{
+			else {
 				$retval = 0;	//set return as port if alive
 				fclose($conn);
 				break;			//end foreach if success
@@ -531,14 +529,16 @@ 
 
 		//subnet ID is provided, fetch subnet
 		$subnet = $Subnets->fetch_subnet(null, $subnetId);
-		if($subnet===false)	{
+		if($subnet===false) {
 			 if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Invalid subnet ID provided"))); }
 			 else												{ return array(); }
 		}
 
 		// we should support only up to 4094 hosts!
-		if($Subnets->get_max_hosts ($subnet->mask, "IPv4")>4094 && php_sapi_name()!="cli")
-		if ($die)												{ die(json_encode(array("status"=>1, "error"=>"Scanning from GUI is only available for subnets up to /20 or 4094 hosts!"))); }
+		if($Subnets->get_max_hosts ($subnet->mask, "IPv4")>4094 && php_sapi_name()!="cli") {
+				if ($die)												{ die(json_encode(array("status"=>1, "error"=>"Scanning from GUI is only available for subnets up to /20 or 4094 hosts!")));
+		}
+		}
 		else													{ return array(); }
 
 		# set array of addresses to scan, exclude existing!
@@ -548,7 +548,7 @@ 
 		$ip = $this->remove_existing_subnet_addresses ($ip, $subnetId);
 
 		//none to scan?
-		if(sizeof($ip)==0)	{
+		if(sizeof($ip)==0) {
 			if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Didn't find any address to scan!"))); }
 			else												{ return array(); }
 		}

Indentation +744 added lines, -744 removed lines

@@ -6,276 +6,276 @@ 
 
 class Scan extends Common_functions {
 
-	/**
-	 * (array of objects) to store addresses, address ID is array index
-	 *
-	 * @var mixed
-	 * @access public
-	 */
-	public $addresses;
-
-	/**
-	 * php executable file
-	 *
-	 * (default value: null)
-	 *
-	 * @var mixed
-	 * @access public
-	 */
-	public $php_exec = null;
-
-	/**
-	 * debugging flag
-	 *
-	 * (default value: false)
-	 *
-	 * @var bool
-	 * @access public
-	 */
-	public $debugging = false;
-
-	/**
-	 * default icmp type
-	 *
-	 * (default value: "ping")
-	 *
-	 * @var string
-	 * @access public
-	 */
-	public $icmp_type = "ping";
-
-	/**
-	 * icmp timeout
-	 *
-	 * (default value: 1)
-	 *
-	 * @var int
-	 * @access protected
-	 */
-	protected $icmp_timeout = 1;
-
-	/**
-	 * icmp retries
-	 *
-	 * (default value: 1)
-	 *
-	 * @var int
-	 * @access protected
-	 */
-	protected $icmp_count = 1;
-
-	/**
-	 *  exit or return icmp status
-	 *
-	 * (default value: false)
-	 *
-	 * @var bool
-	 * @access protected
-	 */
-	protected $icmp_exit = false;
-
-	/**
-	 * Result
-	 *
-	 * @var mixed
-	 * @access public
-	 */
-	public $Result;
-
-	/**
-	 * Database
-	 *
-	 * @var mixed
-	 * @access protected
-	 */
-	protected $Database;
-
-	/**
-	 * Subnets
-	 *
-	 * @var mixed
-	 * @access protected
-	 */
-	protected $Subnets;
-
-	/**
-	 * Addresses
-	 *
-	 * @var mixed
-	 * @access protected
-	 */
-	protected $Addresses;
-
-	/**
-	 * Log
-	 *
-	 * @var mixed
-	 * @access public
-	 */
-	public $Log;
-
-
-
-
-
-	/**
-	 * __construct function
-	 *
-	 * @access public
-	 * @param Database_PDO $database
-	 * @param mixed $settings (default: null)
-	 */
-	public function __construct (Database_PDO $database, $settings = null) {
-		# Save database object
-		$this->Database = $database;
-		# initialize Result
-		$this->Result = new Result ();
-		# debugging
-		$this->set_debugging();
-		# fetch settings
-		is_null($this->settings) ? $this->get_settings() : (object) $this->settings;
-		# set type
-		$this->reset_scan_method ($this->settings->scanPingType);
-		# set php exec
-		$this->set_php_exec ();
-		# Log object
-		$this->Log = new Logging ($this->Database, $this->settings);
-	}
-
-	/**
-	 * Returns all possible ping types / apps
-	 *
-	 * @access public
-	 * @return array
-	 */
-	public function ping_fetch_types () {
-		return array("ping", "pear", "fping");
-	}
-
-	/**
-	 * This functin resets the scan method, for cron scripts
-	 *
-	 * @access public
-	 * @param mixed $method
-	 * @return void
-	 */
-	public function reset_scan_method ($method) {
-		// fetch possible methods
-		$possible = $this->ping_fetch_types ();
-		//check
-		if(!in_array($method, $possible)) {
-			//die or print?
-			if($this->icmp_exit)				{ die(json_encode(array("status"=>1, "error"=>"Invalid scan method"))); }
-			else								{ $this->Result->show("danger", "Invalid scan method", true); }
-		}
-		//ok
-		else {
-			$this->icmp_type = $method;
-		}
-	}
-
-	/**
-	 * Resets debugging
-	 *
-	 * @access public
-	 * @param bool $debug (default: false)
-	 * @return void
-	 */
-	public function reset_debugging ($debug = false) {
-		$this->debugging = $debug;
-	}
-
-	/**
-	 * Sets php exec
-	 *
-	 * @access private
-	 * @return void
-	 */
-	private function set_php_exec () {
-		$this->php_exec = PHP_BINDIR."/php";
-	}
-
-	/**
-	 * Set weather the code should exit or return
-	 *
-	 *	Default is return
-	 *
-	 * @access public
-	 * @param bool $exit (default: false)
-	 * @return void
-	 */
-	public function ping_set_exit ($exit = false) {
-		$this->icmp_exit = $exit;
-	}
-
-
-
-
-
-
-
-
-
-	/**
-	 *	@ping @icmp methods
-	 *	--------------------------------
-	 */
-
-	/**
-	 * Function that pings address and checks if it responds
-	 *
-	 *	any script can be used by extension, important are results
-	 *
-	 *	0 = Alive
-	 *	1 = Offline
-	 *	2 = Offline
-	 *
-	 *	all other codes can be explained in ping_exit_explain method
-	 *
-	 * @access public
-	 * @param mixed $address
-	 * @param int $count (default: 1)
-	 * @param int $timeout (default: 1)
-	 * @param bool $exit (default: false)
-	 * @return void
-	 */
-	public function ping_address ($address, $count=1, $timeout = 1) {
-		#set parameters
-		$this->icmp_timeout = $timeout;
-		$this->icmp_count = $count;
-
-		# escape address
-		$address = escapeshellarg($address);
-
-		# make sure it is in right format
-		$address = $this->transform_address ($address, "dotted");
-		# set method name variable
-		$ping_method = "ping_address_method_".$this->icmp_type;
-		# ping with selected method
-		return $this->$ping_method ($address);
-	}
-
-	/**
-	 * Ping selected address and return response
-	 *
-	 *	timeout value: for miliseconds multiplyy by 1000
-	 *
-	 * @access protected
-	 * @param ip $address
-	 * @return void
-	 */
-	protected function ping_address_method_ping ($address) {
-		# verify ping path
-		$this->ping_verify_path ($this->settings->scanPingPath);
-
-		# if ipv6 append 6
-		if ($this->identify_address ($address)=="IPv6")	{ $this->settings->scanPingPath = $this->settings->scanPingPath."6"; }
-
-		# set ping command based on OS type
-		if	(PHP_OS == "FreeBSD" || PHP_OS == "NetBSD")                         { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -W ".($this->icmp_timeout*1000)." $address 1>/dev/null 2>&1"; }
-		elseif(PHP_OS == "Linux" || PHP_OS == "OpenBSD")                        { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -w $this->icmp_timeout $address 1>/dev/null 2>&1"; }
-		elseif(PHP_OS == "WIN32" || PHP_OS == "Windows" || PHP_OS == "WINNT")	{ $cmd = $this->settings->scanPingPath." -n $this->icmp_count -I ".($this->icmp_timeout*1000)." $address 1>/dev/null 2>&1"; }
-		else																	{ $cmd = $this->settings->scanPingPath." -c $this->icmp_count -n $address 1>/dev/null 2>&1"; }
+    /**
+     * (array of objects) to store addresses, address ID is array index
+     *
+     * @var mixed
+     * @access public
+     */
+    public $addresses;
+
+    /**
+     * php executable file
+     *
+     * (default value: null)
+     *
+     * @var mixed
+     * @access public
+     */
+    public $php_exec = null;
+
+    /**
+     * debugging flag
+     *
+     * (default value: false)
+     *
+     * @var bool
+     * @access public
+     */
+    public $debugging = false;
+
+    /**
+     * default icmp type
+     *
+     * (default value: "ping")
+     *
+     * @var string
+     * @access public
+     */
+    public $icmp_type = "ping";
+
+    /**
+     * icmp timeout
+     *
+     * (default value: 1)
+     *
+     * @var int
+     * @access protected
+     */
+    protected $icmp_timeout = 1;
+
+    /**
+     * icmp retries
+     *
+     * (default value: 1)
+     *
+     * @var int
+     * @access protected
+     */
+    protected $icmp_count = 1;
+
+    /**
+     *  exit or return icmp status
+     *
+     * (default value: false)
+     *
+     * @var bool
+     * @access protected
+     */
+    protected $icmp_exit = false;
+
+    /**
+     * Result
+     *
+     * @var mixed
+     * @access public
+     */
+    public $Result;
+
+    /**
+     * Database
+     *
+     * @var mixed
+     * @access protected
+     */
+    protected $Database;
+
+    /**
+     * Subnets
+     *
+     * @var mixed
+     * @access protected
+     */
+    protected $Subnets;
+
+    /**
+     * Addresses
+     *
+     * @var mixed
+     * @access protected
+     */
+    protected $Addresses;
+
+    /**
+     * Log
+     *
+     * @var mixed
+     * @access public
+     */
+    public $Log;
+
+
+
+
+
+    /**
+     * __construct function
+     *
+     * @access public
+     * @param Database_PDO $database
+     * @param mixed $settings (default: null)
+     */
+    public function __construct (Database_PDO $database, $settings = null) {
+        # Save database object
+        $this->Database = $database;
+        # initialize Result
+        $this->Result = new Result ();
+        # debugging
+        $this->set_debugging();
+        # fetch settings
+        is_null($this->settings) ? $this->get_settings() : (object) $this->settings;
+        # set type
+        $this->reset_scan_method ($this->settings->scanPingType);
+        # set php exec
+        $this->set_php_exec ();
+        # Log object
+        $this->Log = new Logging ($this->Database, $this->settings);
+    }
+
+    /**
+     * Returns all possible ping types / apps
+     *
+     * @access public
+     * @return array
+     */
+    public function ping_fetch_types () {
+        return array("ping", "pear", "fping");
+    }
+
+    /**
+     * This functin resets the scan method, for cron scripts
+     *
+     * @access public
+     * @param mixed $method
+     * @return void
+     */
+    public function reset_scan_method ($method) {
+        // fetch possible methods
+        $possible = $this->ping_fetch_types ();
+        //check
+        if(!in_array($method, $possible)) {
+            //die or print?
+            if($this->icmp_exit)				{ die(json_encode(array("status"=>1, "error"=>"Invalid scan method"))); }
+            else								{ $this->Result->show("danger", "Invalid scan method", true); }
+        }
+        //ok
+        else {
+            $this->icmp_type = $method;
+        }
+    }
+
+    /**
+     * Resets debugging
+     *
+     * @access public
+     * @param bool $debug (default: false)
+     * @return void
+     */
+    public function reset_debugging ($debug = false) {
+        $this->debugging = $debug;
+    }
+
+    /**
+     * Sets php exec
+     *
+     * @access private
+     * @return void
+     */
+    private function set_php_exec () {
+        $this->php_exec = PHP_BINDIR."/php";
+    }
+
+    /**
+     * Set weather the code should exit or return
+     *
+     *	Default is return
+     *
+     * @access public
+     * @param bool $exit (default: false)
+     * @return void
+     */
+    public function ping_set_exit ($exit = false) {
+        $this->icmp_exit = $exit;
+    }
+
+
+
+
+
+
+
+
+
+    /**
+     *	@ping @icmp methods
+     *	--------------------------------
+     */
+
+    /**
+     * Function that pings address and checks if it responds
+     *
+     *	any script can be used by extension, important are results
+     *
+     *	0 = Alive
+     *	1 = Offline
+     *	2 = Offline
+     *
+     *	all other codes can be explained in ping_exit_explain method
+     *
+     * @access public
+     * @param mixed $address
+     * @param int $count (default: 1)
+     * @param int $timeout (default: 1)
+     * @param bool $exit (default: false)
+     * @return void
+     */
+    public function ping_address ($address, $count=1, $timeout = 1) {
+        #set parameters
+        $this->icmp_timeout = $timeout;
+        $this->icmp_count = $count;
+
+        # escape address
+        $address = escapeshellarg($address);
+
+        # make sure it is in right format
+        $address = $this->transform_address ($address, "dotted");
+        # set method name variable
+        $ping_method = "ping_address_method_".$this->icmp_type;
+        # ping with selected method
+        return $this->$ping_method ($address);
+    }
+
+    /**
+     * Ping selected address and return response
+     *
+     *	timeout value: for miliseconds multiplyy by 1000
+     *
+     * @access protected
+     * @param ip $address
+     * @return void
+     */
+    protected function ping_address_method_ping ($address) {
+        # verify ping path
+        $this->ping_verify_path ($this->settings->scanPingPath);
+
+        # if ipv6 append 6
+        if ($this->identify_address ($address)=="IPv6")	{ $this->settings->scanPingPath = $this->settings->scanPingPath."6"; }
+
+        # set ping command based on OS type
+        if	(PHP_OS == "FreeBSD" || PHP_OS == "NetBSD")                         { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -W ".($this->icmp_timeout*1000)." $address 1>/dev/null 2>&1"; }
+        elseif(PHP_OS == "Linux" || PHP_OS == "OpenBSD")                        { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -w $this->icmp_timeout $address 1>/dev/null 2>&1"; }
+        elseif(PHP_OS == "WIN32" || PHP_OS == "Windows" || PHP_OS == "WINNT")	{ $cmd = $this->settings->scanPingPath." -n $this->icmp_count -I ".($this->icmp_timeout*1000)." $address 1>/dev/null 2>&1"; }
+        else																	{ $cmd = $this->settings->scanPingPath." -c $this->icmp_count -n $address 1>/dev/null 2>&1"; }
 
         # for IPv6 remove wait
         if ($this->identify_address ($address)=="IPv6") {
@@ -284,471 +284,471 @@ 
             $cmd = implode(" ", $cmd);
         }
 
-		# execute command, return $retval
-	    exec($cmd, $output, $retval);
-
-		# return result for web or cmd
-		if($this->icmp_exit)	{ exit  ($retval); }
-		else					{ return $retval; }
-	}
-
-	/**
-	 * Ping selected address with PEAR ping package
-	 *
-	 * @access protected
-	 * @param ip $address
-	 * @return void
-	 */
-	protected function ping_address_method_pear ($address) {
-		# we need pear ping package
-		require_once(dirname(__FILE__) . '/../../functions/PEAR/Net/Ping.php');
-		$ping = Net_Ping::factory();
-
-		# ipv6 not supported
-		if ($this->identify_address ($address)=="IPv6") {
-    		//return result for web or cmd
-    		if($this->icmp_exit) 	{ exit	(255); }
-    		else	  				{ return 255; }
-		}
-
-		# check for errors
-		if($ping->pear->isError($ping)) {
-			if($this->icmp_exit)	{ exit  ($ping->getMessage()); }
-			else					{ return $ping->getMessage(); }
-		}
-		else {
-			//set count and timeout
-			$ping->setArgs(array('count' => $this->icmp_timeout, 'timeout' => $this->icmp_timeout));
-			//execute
-			$ping_response = $ping->ping($address);
-			//check response for error
-			if($ping->pear->isError($ping_response)) {
-				$result['code'] = 2;
-			}
-			else {
-				//all good
-				if($ping_response->_transmitted == $ping_response->_received) {
-					$result['code'] = 0;
-					$this->rtt = "RTT: ". strstr($ping_response->_round_trip['avg'], ".", true);
-				}
-				//ping loss
-				elseif($ping_response->_received == 0) {
-					$result['code'] = 1;
-				}
-				//failed
-				else {
-					$result['code'] = 3;
-				}
-			}
-		}
-
-		//return result for web or cmd
-		if($this->icmp_exit) 	{ exit	($result['code']); }
-		else	  				{ return $result['code']; }
-	}
-
-	/**
-	 * Ping selected address with fping function
-	 *
-	 *	Exit status is:
-	 *		0 if all the hosts are reachable,
-	 *		1 if some hosts were unreachable,
-	 *		2 if any IP addresses were not found,
-	 *		3 for invalid command line arguments,
-	 *		4 for a system call failure.
-	 *
-	 *	fping cannot be run from web, it needs root privileges to be able to open raw socket :/
-	 *
-	 * @access public
-	 * @param mixed $subnet 	//CIDR
-	 * @return void
-	 */
-	public function ping_address_method_fping ($address) {
-		# verify ping path
-		$this->ping_verify_path ($this->settings->scanFPingPath);
-
-		# if ipv6 append 6
-		if ($this->identify_address ($address)=="IPv6")	{ $this->settings->scanFPingPath = $this->settings->scanFPingPath."6"; }
-
-		# set command
-		$cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout*1000)." $address";
-		# execute command, return $retval
-	    exec($cmd, $output, $retval);
-
-	    # save result
-	    if($retval==0) {
-	    	$this->save_fping_rtt ($output[0]);
-		}
-
-		# return result for web or cmd
-		if($this->icmp_exit)	{ exit  ($retval); }
-		else					{ return $retval; }
-	}
-
-	/**
-	 * Saves RTT for fping
-	 *
-	 * @access private
-	 * @param mixed $line
-	 * @return void
-	 */
-	private function save_fping_rtt ($line) {
-		// 173.192.112.30 : xmt/rcv/%loss = 1/1/0%, min/avg/max = 160/160/160
- 		$tmp = explode(" ",$line);
-
- 		# save rtt
-		@$this->rtt	= "RTT: ".str_replace("(", "", $tmp[7]);
-	}
-
-	/**
-	 * Ping selected address with fping function
-	 *
-	 *	Exit status is:
-	 *		0 if all the hosts are reachable,
-	 *		1 if some hosts were unreachable,
-	 *		2 if any IP addresses were not found,
-	 *		3 for invalid command line arguments,
-	 *		4 for a system call failure.
-	 *
-	 *	fping cannot be run from web, it needs root privileges to be able to open raw socket :/
-	 *
-	 * @access public
-	 * @param mixed $subnet 	//CIDR
-	 * @return void
-	 */
-	public function ping_address_method_fping_subnet ($subnet_cidr, $return_result = false) {
-		# verify ping path
-		$this->ping_verify_path ($this->settings->scanFPingPath);
-		# set command
-		$cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout*1000)." -Ag $subnet_cidr";
-		# execute command, return $retval
-	    exec($cmd, $output, $retval);
-
-	    # save result
-	    if(sizeof($output)>0) {
-	    	foreach($output as $line) {
-		    	$tmp = explode(" ",$line);
-		    	$out[] = $tmp[0];
-	    	}
-	    }
-
-	    # save to var
-	    $this->fping_result = $out;
-
-	    # return result?
-	    if($return_result)		{ return $out; }
-
-		# return result for web or cmd
-		if($this->icmp_exit)	{ exit  ($retval); }
-		else					{ return $retval; }
-	}
-
-	/**
-	 * Verifies that ping file exists
-	 *
-	 * @access private
-	 * @param mixed $path
-	 * @return void
-	 */
-	private function ping_verify_path ($path) {
-		if(!file_exists($path)) {
-			if($this->icmp_exit)	{ exit  ($this->ping_exit_explain(1000)); }
-			else					{ return $this->Result->show("danger", _($this->ping_exit_explain(1000)), true);  }
-		}
-	}
-
-	/**
-	 * Explains invalid error codes
-	 *
-	 * @access public
-	 * @param mixed $code
-	 * @return void
-	 */
-	public function ping_exit_explain ($code) {
-		# fetch explain codes
-		$explain_codes = $this->ping_set_exit_code_explains ();
-
-		# return code
-		return isset($explain_codes[$code]) ? $explain_codes[$code] : false;
-	}
-
-	/**
-	 * This function sets ping exit code and message mappings
-	 *
-	 *	http://www.freebsd.org/cgi/man.cgi?query=sysexits&apropos=0&sektion=0&manpath=FreeBSD+4.3-RELEASE&arch=default&format=ascii
-	 *
-	 *	extend if needed for future scripts
-	 *
-	 * @access public
-	 * @return void
-	 */
-	public function ping_set_exit_code_explains () {
-		$explain_codes[0]  = "SUCCESS";
-		$explain_codes[1]  = "OFFLINE";
-		$explain_codes[2]  = "ERROR";
-		$explain_codes[3]  = "UNKNOWN ERROR";
-		$explain_codes[64] = "EX_USAGE";
-		$explain_codes[65] = "EX_DATAERR";
-		$explain_codes[68] = "EX_NOHOST";
-		$explain_codes[70] = "EX_SOFTWARE";
-		$explain_codes[71] = "EX_OSERR";
-		$explain_codes[72] = "EX_OSFILE";
-		$explain_codes[73] = "EX_CANTCREAT";
-		$explain_codes[74] = "EX_IOERR";
-		$explain_codes[75] = "EX_TEMPFAIL";
-		$explain_codes[77] = "EX_NOPERM";
-		$explain_codes[255] = "EX_NOT_SUPPORTED";
-		$explain_codes[1000] = "Invalid ping path";
-		# return codes
-		return $explain_codes;
-	}
-
-	/**
-	 * Update lastseen field for specific IP address
-	 *
-	 * @access public
-	 * @param int $id
-	 * @param datetime $datetime
-	 * @return void
-	 */
-	public function ping_update_lastseen ($id, $datetime = null) {
-    	# set datetime
-    	$datetime = is_null($datetime) ? date("Y-m-d H:i:s") : $datetime;
-		# execute
-		try { $this->Database->updateObject("ipaddresses", array("id"=>$id, "lastSeen"=>$datetime), "id"); }
-		catch (Exception $e) {
-			!$this->debugging ? : $this->Result->show("danger", $e->getMessage(), false);
-			# log
-			!$this->debugging ? : $this->Log->write ("status_update", _('Failed to update address status'), 0 );
-		}
-	}
-
-	/**
-	 * Update last check time for agent
-	 *
-	 * @access public
-	 * @param int $id
-	 * @param datetime $date
-	 * @return void
-	 */
-	public function ping_update_scanagent_checktime ($id, $date = false) {
-    	# set time
-    	if ($date === false)    { $date = date("Y-m-d H:i:s"); }
-    	else                    { $date = $date; }
-		# execute
-		try { $this->Database->updateObject("scanAgents", array("id"=>$id, "last_access"=>date("Y-m-d H:i:s")), "id"); }
-		catch (Exception $e) {
-		}
-	}
-
-	/**
-	 * Opens socket connection on specified TCP ports, if at least one is available host is alive
-	 *
-	 * @access public
-	 * @param mixed $address
-	 * @param mixed $port
-	 * @return void
-	 */
-	public function telnet_address ($address, $port) {
-		# set all ports
-		$ports = explode(",", str_replace(";",",",$port));
-		# default response is dead
-		$retval = 1;
-		//try each port untill one is alive
-		foreach($ports as $p) {
-			// open socket
-			$conn = @fsockopen($address, $p, $errno, $errstr, $this->icmp_timeout);
-			//failed
-			if (!$conn) {}
-			//success
-			else 		{
-				$retval = 0;	//set return as port if alive
-				fclose($conn);
-				break;			//end foreach if success
-			}
-		}
-	    # exit with result
-	    exit($retval);
-	}
-
-
-
-
-
-
-
-
-
-	/**
-	 *	@prepare addresses methods
-	 *	--------------------------------
-	 */
-
-	/**
-	 * Returns all addresses to be scanned or updated
-	 *
-	 * @access public
-	 * @param mixed $type		//discovery, update
-	 * @param mixed $subnet
-	 * @param bool $type
-	 * @return void
-	 */
-	public function prepare_addresses_to_scan ($type, $subnet, $die = true) {
-		# discover new addresses
-		if($type=="discovery") 	{ return is_numeric($subnet) ? $this->prepare_addresses_to_discover_subnetId ($subnet, $die) : $this->prepare_addresses_to_discover_subnet ($subnet, $die); }
-		# update addresses statuses
-		elseif($type=="update") { return $this->prepare_addresses_to_update ($subnet); }
-		# fail
-		else 					{ die(json_encode(array("status"=>1, "error"=>"Invalid scan type provided"))); }
-	}
-
-	/**
-	 * Returns array of all addresses to be scanned inside subnet defined with subnetId
-	 *
-	 * @access public
-	 * @param mixed $subnetId
-	 * @return void
-	 */
-	public function prepare_addresses_to_discover_subnetId ($subnetId, $die) {
-		# initialize classes
-		$Subnets   = new Subnets ($this->Database);
-
-		//subnet ID is provided, fetch subnet
-		$subnet = $Subnets->fetch_subnet(null, $subnetId);
-		if($subnet===false)	{
-			 if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Invalid subnet ID provided"))); }
-			 else												{ return array(); }
-		}
-
-		// we should support only up to 4094 hosts!
-		if($Subnets->get_max_hosts ($subnet->mask, "IPv4")>4094 && php_sapi_name()!="cli")
-		if ($die)												{ die(json_encode(array("status"=>1, "error"=>"Scanning from GUI is only available for subnets up to /20 or 4094 hosts!"))); }
-		else													{ return array(); }
-
-		# set array of addresses to scan, exclude existing!
-		$ip = $this->get_all_possible_subnet_addresses ($subnet->subnet, $subnet->mask);
-
-		# remove existing
-		$ip = $this->remove_existing_subnet_addresses ($ip, $subnetId);
-
-		//none to scan?
-		if(sizeof($ip)==0)	{
-			if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Didn't find any address to scan!"))); }
-			else												{ return array(); }
-		}
-
-		//return
-		return $ip;
-	}
-
-	/**
-	 * Fetches all possible subnet addresses
-	 *
-	 * @access private
-	 * @param $subnet		//subnet in decimal format
-	 * @param int $mask		//subnet mask
-	 * @return void			//array of ip addresses in decimal format
-	 */
-	private function get_all_possible_subnet_addresses ($subnet, $mask) {
-		# initialize classes
-		$Subnets   = new Subnets ($this->Database);
-		# make sure we have proper subnet format
-		$subnet    = $Subnets->transform_address($subnet, "decimal");
-		//fetch start and stop addresses
-		$boundaries = (object) $Subnets->get_network_boundaries ($subnet, $mask);
-		//create array
-		if($mask==32) {
-			$ip[] = $Subnets->transform_to_decimal($boundaries->network);
-		}
-		elseif($mask==31) {
-			$ip[] = $Subnets->transform_to_decimal($boundaries->network);
-			$ip[] = $Subnets->transform_to_decimal($boundaries->broadcast);
-		}
-		else {
-			//set loop limits
-			$start = gmp_strval(gmp_add($Subnets->transform_to_decimal($boundaries->network),1));
-			$stop  = gmp_strval($Subnets->transform_to_decimal($boundaries->broadcast));
-			//loop
-			for($m=$start; $m<$stop; $m++) {
-				$ip[] = $m;
-			}
-		}
-		//return
-		return $ip;
-	}
-
-	/**
-	 * Removes existing addresses from
-	 *
-	 * @access private
-	 * @param mixed $ip				//array of ip addresses in decimal format
-	 * @param mixed $subnetId		//id of subnet
-	 * @return void
-	 */
-	private function remove_existing_subnet_addresses ($ip, $subnetId) {
-		# first fetch all addresses
-		$Addresses = new Addresses ($this->Database);
-		// get all existing IP addresses in subnet
-		$addresses  = $Addresses->fetch_subnet_addresses($subnetId);
-		// if some exist remove them
-		if(sizeof($addresses)>0 && sizeof(@$ip)>0) {
-			foreach($addresses as $a) {
-				$key = array_search($a->ip_addr, $ip);
-				if($key !== false) {
-					unset($ip[$key]);
-				}
-			}
-			//reindex array for pinging
-			$ip = array_values(@$ip);
-		}
-		//return
-		return is_array(@$ip) ? $ip : array();
-	}
-
-	/**
-	 * Returns array of all addresses in subnet
-	 *
-	 * @access public
-	 * @param mixed $subnet
-	 * @return void
-	 */
-	public function prepare_addresses_to_discover_subnet ($subnet) {
-		//set subnet / mask
-		$subnet_parsed = explode("/", $subnet);
-		# result
-		$ip = $this->get_all_possible_subnet_addresses ($subnet_parsed[0], $subnet_parsed[1]);
-		//none to scan?
-		if(sizeof($ip)==0)									{ die(json_encode(array("status"=>1, "error"=>"Didn't find any address to scan!"))); }
-		//result
-		return $ip;
-	}
-
-	/**
-	 * Returns array of all addresses to be scanned
-	 *
-	 * @access public
-	 * @param mixed $subnetId
-	 * @return void
-	 */
-	public function prepare_addresses_to_update ($subnetId) {
-		# first fetch all addresses
-		$Addresses = new Addresses ($this->Database);
-		// get all existing IP addresses in subnet
-		$subnet_addresses = $Addresses->fetch_subnet_addresses($subnetId);
-		//create array
-		if(sizeof($subnet_addresses)>0) {
-			foreach($subnet_addresses as $a) {
-				$scan_addresses[$a->id] = $a->ip_addr;
-			}
-			//reindex
-			$scan_addresses = array_values(@$scan_addresses);
-			//return
-			return $scan_addresses;
-		}
-		else {
-			return array();
-		}
-	}
+        # execute command, return $retval
+        exec($cmd, $output, $retval);
+
+        # return result for web or cmd
+        if($this->icmp_exit)	{ exit  ($retval); }
+        else					{ return $retval; }
+    }
+
+    /**
+     * Ping selected address with PEAR ping package
+     *
+     * @access protected
+     * @param ip $address
+     * @return void
+     */
+    protected function ping_address_method_pear ($address) {
+        # we need pear ping package
+        require_once(dirname(__FILE__) . '/../../functions/PEAR/Net/Ping.php');
+        $ping = Net_Ping::factory();
+
+        # ipv6 not supported
+        if ($this->identify_address ($address)=="IPv6") {
+            //return result for web or cmd
+            if($this->icmp_exit) 	{ exit	(255); }
+            else	  				{ return 255; }
+        }
+
+        # check for errors
+        if($ping->pear->isError($ping)) {
+            if($this->icmp_exit)	{ exit  ($ping->getMessage()); }
+            else					{ return $ping->getMessage(); }
+        }
+        else {
+            //set count and timeout
+            $ping->setArgs(array('count' => $this->icmp_timeout, 'timeout' => $this->icmp_timeout));
+            //execute
+            $ping_response = $ping->ping($address);
+            //check response for error
+            if($ping->pear->isError($ping_response)) {
+                $result['code'] = 2;
+            }
+            else {
+                //all good
+                if($ping_response->_transmitted == $ping_response->_received) {
+                    $result['code'] = 0;
+                    $this->rtt = "RTT: ". strstr($ping_response->_round_trip['avg'], ".", true);
+                }
+                //ping loss
+                elseif($ping_response->_received == 0) {
+                    $result['code'] = 1;
+                }
+                //failed
+                else {
+                    $result['code'] = 3;
+                }
+            }
+        }
+
+        //return result for web or cmd
+        if($this->icmp_exit) 	{ exit	($result['code']); }
+        else	  				{ return $result['code']; }
+    }
+
+    /**
+     * Ping selected address with fping function
+     *
+     *	Exit status is:
+     *		0 if all the hosts are reachable,
+     *		1 if some hosts were unreachable,
+     *		2 if any IP addresses were not found,
+     *		3 for invalid command line arguments,
+     *		4 for a system call failure.
+     *
+     *	fping cannot be run from web, it needs root privileges to be able to open raw socket :/
+     *
+     * @access public
+     * @param mixed $subnet 	//CIDR
+     * @return void
+     */
+    public function ping_address_method_fping ($address) {
+        # verify ping path
+        $this->ping_verify_path ($this->settings->scanFPingPath);
+
+        # if ipv6 append 6
+        if ($this->identify_address ($address)=="IPv6")	{ $this->settings->scanFPingPath = $this->settings->scanFPingPath."6"; }
+
+        # set command
+        $cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout*1000)." $address";
+        # execute command, return $retval
+        exec($cmd, $output, $retval);
+
+        # save result
+        if($retval==0) {
+            $this->save_fping_rtt ($output[0]);
+        }
+
+        # return result for web or cmd
+        if($this->icmp_exit)	{ exit  ($retval); }
+        else					{ return $retval; }
+    }
+
+    /**
+     * Saves RTT for fping
+     *
+     * @access private
+     * @param mixed $line
+     * @return void
+     */
+    private function save_fping_rtt ($line) {
+        // 173.192.112.30 : xmt/rcv/%loss = 1/1/0%, min/avg/max = 160/160/160
+            $tmp = explode(" ",$line);
+
+            # save rtt
+        @$this->rtt	= "RTT: ".str_replace("(", "", $tmp[7]);
+    }
+
+    /**
+     * Ping selected address with fping function
+     *
+     *	Exit status is:
+     *		0 if all the hosts are reachable,
+     *		1 if some hosts were unreachable,
+     *		2 if any IP addresses were not found,
+     *		3 for invalid command line arguments,
+     *		4 for a system call failure.
+     *
+     *	fping cannot be run from web, it needs root privileges to be able to open raw socket :/
+     *
+     * @access public
+     * @param mixed $subnet 	//CIDR
+     * @return void
+     */
+    public function ping_address_method_fping_subnet ($subnet_cidr, $return_result = false) {
+        # verify ping path
+        $this->ping_verify_path ($this->settings->scanFPingPath);
+        # set command
+        $cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout*1000)." -Ag $subnet_cidr";
+        # execute command, return $retval
+        exec($cmd, $output, $retval);
+
+        # save result
+        if(sizeof($output)>0) {
+            foreach($output as $line) {
+                $tmp = explode(" ",$line);
+                $out[] = $tmp[0];
+            }
+        }
+
+        # save to var
+        $this->fping_result = $out;
+
+        # return result?
+        if($return_result)		{ return $out; }
+
+        # return result for web or cmd
+        if($this->icmp_exit)	{ exit  ($retval); }
+        else					{ return $retval; }
+    }
+
+    /**
+     * Verifies that ping file exists
+     *
+     * @access private
+     * @param mixed $path
+     * @return void
+     */
+    private function ping_verify_path ($path) {
+        if(!file_exists($path)) {
+            if($this->icmp_exit)	{ exit  ($this->ping_exit_explain(1000)); }
+            else					{ return $this->Result->show("danger", _($this->ping_exit_explain(1000)), true);  }
+        }
+    }
+
+    /**
+     * Explains invalid error codes
+     *
+     * @access public
+     * @param mixed $code
+     * @return void
+     */
+    public function ping_exit_explain ($code) {
+        # fetch explain codes
+        $explain_codes = $this->ping_set_exit_code_explains ();
+
+        # return code
+        return isset($explain_codes[$code]) ? $explain_codes[$code] : false;
+    }
+
+    /**
+     * This function sets ping exit code and message mappings
+     *
+     *	http://www.freebsd.org/cgi/man.cgi?query=sysexits&apropos=0&sektion=0&manpath=FreeBSD+4.3-RELEASE&arch=default&format=ascii
+     *
+     *	extend if needed for future scripts
+     *
+     * @access public
+     * @return void
+     */
+    public function ping_set_exit_code_explains () {
+        $explain_codes[0]  = "SUCCESS";
+        $explain_codes[1]  = "OFFLINE";
+        $explain_codes[2]  = "ERROR";
+        $explain_codes[3]  = "UNKNOWN ERROR";
+        $explain_codes[64] = "EX_USAGE";
+        $explain_codes[65] = "EX_DATAERR";
+        $explain_codes[68] = "EX_NOHOST";
+        $explain_codes[70] = "EX_SOFTWARE";
+        $explain_codes[71] = "EX_OSERR";
+        $explain_codes[72] = "EX_OSFILE";
+        $explain_codes[73] = "EX_CANTCREAT";
+        $explain_codes[74] = "EX_IOERR";
+        $explain_codes[75] = "EX_TEMPFAIL";
+        $explain_codes[77] = "EX_NOPERM";
+        $explain_codes[255] = "EX_NOT_SUPPORTED";
+        $explain_codes[1000] = "Invalid ping path";
+        # return codes
+        return $explain_codes;
+    }
+
+    /**
+     * Update lastseen field for specific IP address
+     *
+     * @access public
+     * @param int $id
+     * @param datetime $datetime
+     * @return void
+     */
+    public function ping_update_lastseen ($id, $datetime = null) {
+        # set datetime
+        $datetime = is_null($datetime) ? date("Y-m-d H:i:s") : $datetime;
+        # execute
+        try { $this->Database->updateObject("ipaddresses", array("id"=>$id, "lastSeen"=>$datetime), "id"); }
+        catch (Exception $e) {
+            !$this->debugging ? : $this->Result->show("danger", $e->getMessage(), false);
+            # log
+            !$this->debugging ? : $this->Log->write ("status_update", _('Failed to update address status'), 0 );
+        }
+    }
+
+    /**
+     * Update last check time for agent
+     *
+     * @access public
+     * @param int $id
+     * @param datetime $date
+     * @return void
+     */
+    public function ping_update_scanagent_checktime ($id, $date = false) {
+        # set time
+        if ($date === false)    { $date = date("Y-m-d H:i:s"); }
+        else                    { $date = $date; }
+        # execute
+        try { $this->Database->updateObject("scanAgents", array("id"=>$id, "last_access"=>date("Y-m-d H:i:s")), "id"); }
+        catch (Exception $e) {
+        }
+    }
+
+    /**
+     * Opens socket connection on specified TCP ports, if at least one is available host is alive
+     *
+     * @access public
+     * @param mixed $address
+     * @param mixed $port
+     * @return void
+     */
+    public function telnet_address ($address, $port) {
+        # set all ports
+        $ports = explode(",", str_replace(";",",",$port));
+        # default response is dead
+        $retval = 1;
+        //try each port untill one is alive
+        foreach($ports as $p) {
+            // open socket
+            $conn = @fsockopen($address, $p, $errno, $errstr, $this->icmp_timeout);
+            //failed
+            if (!$conn) {}
+            //success
+            else 		{
+                $retval = 0;	//set return as port if alive
+                fclose($conn);
+                break;			//end foreach if success
+            }
+        }
+        # exit with result
+        exit($retval);
+    }
+
+
+
+
+
+
+
+
+
+    /**
+     *	@prepare addresses methods
+     *	--------------------------------
+     */
+
+    /**
+     * Returns all addresses to be scanned or updated
+     *
+     * @access public
+     * @param mixed $type		//discovery, update
+     * @param mixed $subnet
+     * @param bool $type
+     * @return void
+     */
+    public function prepare_addresses_to_scan ($type, $subnet, $die = true) {
+        # discover new addresses
+        if($type=="discovery") 	{ return is_numeric($subnet) ? $this->prepare_addresses_to_discover_subnetId ($subnet, $die) : $this->prepare_addresses_to_discover_subnet ($subnet, $die); }
+        # update addresses statuses
+        elseif($type=="update") { return $this->prepare_addresses_to_update ($subnet); }
+        # fail
+        else 					{ die(json_encode(array("status"=>1, "error"=>"Invalid scan type provided"))); }
+    }
+
+    /**
+     * Returns array of all addresses to be scanned inside subnet defined with subnetId
+     *
+     * @access public
+     * @param mixed $subnetId
+     * @return void
+     */
+    public function prepare_addresses_to_discover_subnetId ($subnetId, $die) {
+        # initialize classes
+        $Subnets   = new Subnets ($this->Database);
+
+        //subnet ID is provided, fetch subnet
+        $subnet = $Subnets->fetch_subnet(null, $subnetId);
+        if($subnet===false)	{
+                if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Invalid subnet ID provided"))); }
+                else												{ return array(); }
+        }
+
+        // we should support only up to 4094 hosts!
+        if($Subnets->get_max_hosts ($subnet->mask, "IPv4")>4094 && php_sapi_name()!="cli")
+        if ($die)												{ die(json_encode(array("status"=>1, "error"=>"Scanning from GUI is only available for subnets up to /20 or 4094 hosts!"))); }
+        else													{ return array(); }
+
+        # set array of addresses to scan, exclude existing!
+        $ip = $this->get_all_possible_subnet_addresses ($subnet->subnet, $subnet->mask);
+
+        # remove existing
+        $ip = $this->remove_existing_subnet_addresses ($ip, $subnetId);
+
+        //none to scan?
+        if(sizeof($ip)==0)	{
+            if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Didn't find any address to scan!"))); }
+            else												{ return array(); }
+        }
+
+        //return
+        return $ip;
+    }
+
+    /**
+     * Fetches all possible subnet addresses
+     *
+     * @access private
+     * @param $subnet		//subnet in decimal format
+     * @param int $mask		//subnet mask
+     * @return void			//array of ip addresses in decimal format
+     */
+    private function get_all_possible_subnet_addresses ($subnet, $mask) {
+        # initialize classes
+        $Subnets   = new Subnets ($this->Database);
+        # make sure we have proper subnet format
+        $subnet    = $Subnets->transform_address($subnet, "decimal");
+        //fetch start and stop addresses
+        $boundaries = (object) $Subnets->get_network_boundaries ($subnet, $mask);
+        //create array
+        if($mask==32) {
+            $ip[] = $Subnets->transform_to_decimal($boundaries->network);
+        }
+        elseif($mask==31) {
+            $ip[] = $Subnets->transform_to_decimal($boundaries->network);
+            $ip[] = $Subnets->transform_to_decimal($boundaries->broadcast);
+        }
+        else {
+            //set loop limits
+            $start = gmp_strval(gmp_add($Subnets->transform_to_decimal($boundaries->network),1));
+            $stop  = gmp_strval($Subnets->transform_to_decimal($boundaries->broadcast));
+            //loop
+            for($m=$start; $m<$stop; $m++) {
+                $ip[] = $m;
+            }
+        }
+        //return
+        return $ip;
+    }
+
+    /**
+     * Removes existing addresses from
+     *
+     * @access private
+     * @param mixed $ip				//array of ip addresses in decimal format
+     * @param mixed $subnetId		//id of subnet
+     * @return void
+     */
+    private function remove_existing_subnet_addresses ($ip, $subnetId) {
+        # first fetch all addresses
+        $Addresses = new Addresses ($this->Database);
+        // get all existing IP addresses in subnet
+        $addresses  = $Addresses->fetch_subnet_addresses($subnetId);
+        // if some exist remove them
+        if(sizeof($addresses)>0 && sizeof(@$ip)>0) {
+            foreach($addresses as $a) {
+                $key = array_search($a->ip_addr, $ip);
+                if($key !== false) {
+                    unset($ip[$key]);
+                }
+            }
+            //reindex array for pinging
+            $ip = array_values(@$ip);
+        }
+        //return
+        return is_array(@$ip) ? $ip : array();
+    }
+
+    /**
+     * Returns array of all addresses in subnet
+     *
+     * @access public
+     * @param mixed $subnet
+     * @return void
+     */
+    public function prepare_addresses_to_discover_subnet ($subnet) {
+        //set subnet / mask
+        $subnet_parsed = explode("/", $subnet);
+        # result
+        $ip = $this->get_all_possible_subnet_addresses ($subnet_parsed[0], $subnet_parsed[1]);
+        //none to scan?
+        if(sizeof($ip)==0)									{ die(json_encode(array("status"=>1, "error"=>"Didn't find any address to scan!"))); }
+        //result
+        return $ip;
+    }
+
+    /**
+     * Returns array of all addresses to be scanned
+     *
+     * @access public
+     * @param mixed $subnetId
+     * @return void
+     */
+    public function prepare_addresses_to_update ($subnetId) {
+        # first fetch all addresses
+        $Addresses = new Addresses ($this->Database);
+        // get all existing IP addresses in subnet
+        $subnet_addresses = $Addresses->fetch_subnet_addresses($subnetId);
+        //create array
+        if(sizeof($subnet_addresses)>0) {
+            foreach($subnet_addresses as $a) {
+                $scan_addresses[$a->id] = $a->ip_addr;
+            }
+            //reindex
+            $scan_addresses = array_values(@$scan_addresses);
+            //return
+            return $scan_addresses;
+        }
+        else {
+            return array();
+        }
+    }
 }
 
 
@@ -769,25 +769,25 @@ 
 function ping_address ($address) {
 //	$Database = new Database_PDO;
 //	$Scan = new Scan ($Database);
- 	global $Scan;
-	//scan
-	return $Scan->ping_address ($address);
+        global $Scan;
+    //scan
+    return $Scan->ping_address ($address);
 }
 
 /**
  *	Telnet address helper for CLI threading
  */
 function telnet_address ($address, $port) {
-	global $Scan;
-	//scan
-	return $Scan->telnet_address ($address, $port);
+    global $Scan;
+    //scan
+    return $Scan->telnet_address ($address, $port);
 }
 
 /**
  *	fping subnet helper for fping threading, all methods
  */
 function fping_subnet ($subnet_cidr, $return = true) {
-	global $Scan;
-	//scan
-	return $Scan->ping_address_method_fping_subnet ($subnet_cidr, $return);
+    global $Scan;
+    //scan
+    return $Scan->ping_address_method_fping_subnet ($subnet_cidr, $return);
 }
\ No newline at end of file

Spacing +105 added lines, -105 removed lines

@@ -131,9 +131,9 @@ 
 		# initialize Result
 		$this->Result = new Result ();
 		# debugging
-		$this->set_debugging();
+		$this->set_debugging ();
 		# fetch settings
-		is_null($this->settings) ? $this->get_settings() : (object) $this->settings;
+		is_null ($this->settings) ? $this->get_settings () : (object) $this->settings;
 		# set type
 		$this->reset_scan_method ($this->settings->scanPingType);
 		# set php exec
@@ -149,7 +149,7 @@ 
 	 * @return array
 	 */
 	public function ping_fetch_types () {
-		return array("ping", "pear", "fping");
+		return array ("ping", "pear", "fping");
 	}
 
 	/**
@@ -163,10 +163,10 @@ 
 		// fetch possible methods
 		$possible = $this->ping_fetch_types ();
 		//check
-		if(!in_array($method, $possible)) {
+		if (!in_array ($method, $possible)) {
 			//die or print?
-			if($this->icmp_exit)				{ die(json_encode(array("status"=>1, "error"=>"Invalid scan method"))); }
-			else								{ $this->Result->show("danger", "Invalid scan method", true); }
+			if ($this->icmp_exit) { die(json_encode (array ("status"=>1, "error"=>"Invalid scan method"))); }
+			else { $this->Result->show ("danger", "Invalid scan method", true); }
 		}
 		//ok
 		else {
@@ -239,13 +239,13 @@ 
 	 * @param bool $exit (default: false)
 	 * @return void
 	 */
-	public function ping_address ($address, $count=1, $timeout = 1) {
+	public function ping_address ($address, $count = 1, $timeout = 1) {
 		#set parameters
 		$this->icmp_timeout = $timeout;
 		$this->icmp_count = $count;
 
 		# escape address
-		$address = escapeshellarg($address);
+		$address = escapeshellarg ($address);
 
 		# make sure it is in right format
 		$address = $this->transform_address ($address, "dotted");
@@ -269,27 +269,27 @@ 
 		$this->ping_verify_path ($this->settings->scanPingPath);
 
 		# if ipv6 append 6
-		if ($this->identify_address ($address)=="IPv6")	{ $this->settings->scanPingPath = $this->settings->scanPingPath."6"; }
+		if ($this->identify_address ($address) == "IPv6") { $this->settings->scanPingPath = $this->settings->scanPingPath."6"; }
 
 		# set ping command based on OS type
-		if	(PHP_OS == "FreeBSD" || PHP_OS == "NetBSD")                         { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -W ".($this->icmp_timeout*1000)." $address 1>/dev/null 2>&1"; }
-		elseif(PHP_OS == "Linux" || PHP_OS == "OpenBSD")                        { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -w $this->icmp_timeout $address 1>/dev/null 2>&1"; }
-		elseif(PHP_OS == "WIN32" || PHP_OS == "Windows" || PHP_OS == "WINNT")	{ $cmd = $this->settings->scanPingPath." -n $this->icmp_count -I ".($this->icmp_timeout*1000)." $address 1>/dev/null 2>&1"; }
-		else																	{ $cmd = $this->settings->scanPingPath." -c $this->icmp_count -n $address 1>/dev/null 2>&1"; }
+		if (PHP_OS == "FreeBSD" || PHP_OS == "NetBSD") { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -W ".($this->icmp_timeout * 1000)." $address 1>/dev/null 2>&1"; }
+		elseif (PHP_OS == "Linux" || PHP_OS == "OpenBSD") { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -w $this->icmp_timeout $address 1>/dev/null 2>&1"; }
+		elseif (PHP_OS == "WIN32" || PHP_OS == "Windows" || PHP_OS == "WINNT") { $cmd = $this->settings->scanPingPath." -n $this->icmp_count -I ".($this->icmp_timeout * 1000)." $address 1>/dev/null 2>&1"; }
+		else { $cmd = $this->settings->scanPingPath." -c $this->icmp_count -n $address 1>/dev/null 2>&1"; }
 
         # for IPv6 remove wait
-        if ($this->identify_address ($address)=="IPv6") {
-            $cmd = explode(" ", $cmd);
+        if ($this->identify_address ($address) == "IPv6") {
+            $cmd = explode (" ", $cmd);
             unset($cmd[3], $cmd[4]);
-            $cmd = implode(" ", $cmd);
+            $cmd = implode (" ", $cmd);
         }
 
 		# execute command, return $retval
-	    exec($cmd, $output, $retval);
+	    exec ($cmd, $output, $retval);
 
 		# return result for web or cmd
-		if($this->icmp_exit)	{ exit  ($retval); }
-		else					{ return $retval; }
+		if ($this->icmp_exit) { exit  ($retval); }
+		else { return $retval; }
 	}
 
 	/**
@@ -301,38 +301,38 @@ 
 	 */
 	protected function ping_address_method_pear ($address) {
 		# we need pear ping package
-		require_once(dirname(__FILE__) . '/../../functions/PEAR/Net/Ping.php');
-		$ping = Net_Ping::factory();
+		require_once(dirname (__FILE__).'/../../functions/PEAR/Net/Ping.php');
+		$ping = Net_Ping::factory ();
 
 		# ipv6 not supported
-		if ($this->identify_address ($address)=="IPv6") {
+		if ($this->identify_address ($address) == "IPv6") {
     		//return result for web or cmd
-    		if($this->icmp_exit) 	{ exit	(255); }
-    		else	  				{ return 255; }
+    		if ($this->icmp_exit) { exit	(255); }
+    		else { return 255; }
 		}
 
 		# check for errors
-		if($ping->pear->isError($ping)) {
-			if($this->icmp_exit)	{ exit  ($ping->getMessage()); }
-			else					{ return $ping->getMessage(); }
+		if ($ping->pear->isError ($ping)) {
+			if ($this->icmp_exit) { exit  ($ping->getMessage ()); }
+			else { return $ping->getMessage (); }
 		}
 		else {
 			//set count and timeout
-			$ping->setArgs(array('count' => $this->icmp_timeout, 'timeout' => $this->icmp_timeout));
+			$ping->setArgs (array ('count' => $this->icmp_timeout, 'timeout' => $this->icmp_timeout));
 			//execute
-			$ping_response = $ping->ping($address);
+			$ping_response = $ping->ping ($address);
 			//check response for error
-			if($ping->pear->isError($ping_response)) {
+			if ($ping->pear->isError ($ping_response)) {
 				$result['code'] = 2;
 			}
 			else {
 				//all good
-				if($ping_response->_transmitted == $ping_response->_received) {
+				if ($ping_response->_transmitted == $ping_response->_received) {
 					$result['code'] = 0;
-					$this->rtt = "RTT: ". strstr($ping_response->_round_trip['avg'], ".", true);
+					$this->rtt = "RTT: ".strstr ($ping_response->_round_trip['avg'], ".", true);
 				}
 				//ping loss
-				elseif($ping_response->_received == 0) {
+				elseif ($ping_response->_received == 0) {
 					$result['code'] = 1;
 				}
 				//failed
@@ -343,8 +343,8 @@ 
 		}
 
 		//return result for web or cmd
-		if($this->icmp_exit) 	{ exit	($result['code']); }
-		else	  				{ return $result['code']; }
+		if ($this->icmp_exit) { exit	($result['code']); }
+		else { return $result['code']; }
 	}
 
 	/**
@@ -368,21 +368,21 @@ 
 		$this->ping_verify_path ($this->settings->scanFPingPath);
 
 		# if ipv6 append 6
-		if ($this->identify_address ($address)=="IPv6")	{ $this->settings->scanFPingPath = $this->settings->scanFPingPath."6"; }
+		if ($this->identify_address ($address) == "IPv6") { $this->settings->scanFPingPath = $this->settings->scanFPingPath."6"; }
 
 		# set command
-		$cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout*1000)." $address";
+		$cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout * 1000)." $address";
 		# execute command, return $retval
-	    exec($cmd, $output, $retval);
+	    exec ($cmd, $output, $retval);
 
 	    # save result
-	    if($retval==0) {
+	    if ($retval == 0) {
 	    	$this->save_fping_rtt ($output[0]);
 		}
 
 		# return result for web or cmd
-		if($this->icmp_exit)	{ exit  ($retval); }
-		else					{ return $retval; }
+		if ($this->icmp_exit) { exit  ($retval); }
+		else { return $retval; }
 	}
 
 	/**
@@ -394,10 +394,10 @@ 
 	 */
 	private function save_fping_rtt ($line) {
 		// 173.192.112.30 : xmt/rcv/%loss = 1/1/0%, min/avg/max = 160/160/160
- 		$tmp = explode(" ",$line);
+ 		$tmp = explode (" ", $line);
 
  		# save rtt
-		@$this->rtt	= "RTT: ".str_replace("(", "", $tmp[7]);
+		@$this->rtt = "RTT: ".str_replace ("(", "", $tmp[7]);
 	}
 
 	/**
@@ -420,14 +420,14 @@ 
 		# verify ping path
 		$this->ping_verify_path ($this->settings->scanFPingPath);
 		# set command
-		$cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout*1000)." -Ag $subnet_cidr";
+		$cmd = $this->settings->scanFPingPath." -c $this->icmp_count -t ".($this->icmp_timeout * 1000)." -Ag $subnet_cidr";
 		# execute command, return $retval
-	    exec($cmd, $output, $retval);
+	    exec ($cmd, $output, $retval);
 
 	    # save result
-	    if(sizeof($output)>0) {
-	    	foreach($output as $line) {
-		    	$tmp = explode(" ",$line);
+	    if (sizeof ($output) > 0) {
+	    	foreach ($output as $line) {
+		    	$tmp = explode (" ", $line);
 		    	$out[] = $tmp[0];
 	    	}
 	    }
@@ -436,11 +436,11 @@ 
 	    $this->fping_result = $out;
 
 	    # return result?
-	    if($return_result)		{ return $out; }
+	    if ($return_result) { return $out; }
 
 		# return result for web or cmd
-		if($this->icmp_exit)	{ exit  ($retval); }
-		else					{ return $retval; }
+		if ($this->icmp_exit) { exit  ($retval); }
+		else { return $retval; }
 	}
 
 	/**
@@ -451,9 +451,9 @@ 
 	 * @return void
 	 */
 	private function ping_verify_path ($path) {
-		if(!file_exists($path)) {
-			if($this->icmp_exit)	{ exit  ($this->ping_exit_explain(1000)); }
-			else					{ return $this->Result->show("danger", _($this->ping_exit_explain(1000)), true);  }
+		if (!file_exists ($path)) {
+			if ($this->icmp_exit) { exit  ($this->ping_exit_explain (1000)); }
+			else { return $this->Result->show ("danger", _ ($this->ping_exit_explain (1000)), true); }
 		}
 	}
 
@@ -513,13 +513,13 @@ 
 	 */
 	public function ping_update_lastseen ($id, $datetime = null) {
     	# set datetime
-    	$datetime = is_null($datetime) ? date("Y-m-d H:i:s") : $datetime;
+    	$datetime = is_null ($datetime) ? date ("Y-m-d H:i:s") : $datetime;
 		# execute
-		try { $this->Database->updateObject("ipaddresses", array("id"=>$id, "lastSeen"=>$datetime), "id"); }
+		try { $this->Database->updateObject ("ipaddresses", array ("id"=>$id, "lastSeen"=>$datetime), "id"); }
 		catch (Exception $e) {
-			!$this->debugging ? : $this->Result->show("danger", $e->getMessage(), false);
+			!$this->debugging ? : $this->Result->show ("danger", $e->getMessage (), false);
 			# log
-			!$this->debugging ? : $this->Log->write ("status_update", _('Failed to update address status'), 0 );
+			!$this->debugging ? : $this->Log->write ("status_update", _ ('Failed to update address status'), 0);
 		}
 	}
 
@@ -533,10 +533,10 @@ 
 	 */
 	public function ping_update_scanagent_checktime ($id, $date = false) {
     	# set time
-    	if ($date === false)    { $date = date("Y-m-d H:i:s"); }
-    	else                    { $date = $date; }
+    	if ($date === false) { $date = date ("Y-m-d H:i:s"); }
+    	else { $date = $date; }
 		# execute
-		try { $this->Database->updateObject("scanAgents", array("id"=>$id, "last_access"=>date("Y-m-d H:i:s")), "id"); }
+		try { $this->Database->updateObject ("scanAgents", array ("id"=>$id, "last_access"=>date ("Y-m-d H:i:s")), "id"); }
 		catch (Exception $e) {
 		}
 	}
@@ -551,20 +551,20 @@ 
 	 */
 	public function telnet_address ($address, $port) {
 		# set all ports
-		$ports = explode(",", str_replace(";",",",$port));
+		$ports = explode (",", str_replace (";", ",", $port));
 		# default response is dead
 		$retval = 1;
 		//try each port untill one is alive
-		foreach($ports as $p) {
+		foreach ($ports as $p) {
 			// open socket
-			$conn = @fsockopen($address, $p, $errno, $errstr, $this->icmp_timeout);
+			$conn = @fsockopen ($address, $p, $errno, $errstr, $this->icmp_timeout);
 			//failed
 			if (!$conn) {}
 			//success
-			else 		{
-				$retval = 0;	//set return as port if alive
-				fclose($conn);
-				break;			//end foreach if success
+			else {
+				$retval = 0; //set return as port if alive
+				fclose ($conn);
+				break; //end foreach if success
 			}
 		}
 	    # exit with result
@@ -595,11 +595,11 @@ 
 	 */
 	public function prepare_addresses_to_scan ($type, $subnet, $die = true) {
 		# discover new addresses
-		if($type=="discovery") 	{ return is_numeric($subnet) ? $this->prepare_addresses_to_discover_subnetId ($subnet, $die) : $this->prepare_addresses_to_discover_subnet ($subnet, $die); }
+		if ($type == "discovery") { return is_numeric ($subnet) ? $this->prepare_addresses_to_discover_subnetId ($subnet, $die) : $this->prepare_addresses_to_discover_subnet ($subnet, $die); }
 		# update addresses statuses
-		elseif($type=="update") { return $this->prepare_addresses_to_update ($subnet); }
+		elseif ($type == "update") { return $this->prepare_addresses_to_update ($subnet); }
 		# fail
-		else 					{ die(json_encode(array("status"=>1, "error"=>"Invalid scan type provided"))); }
+		else { die(json_encode (array ("status"=>1, "error"=>"Invalid scan type provided"))); }
 	}
 
 	/**
@@ -611,19 +611,19 @@ 
 	 */
 	public function prepare_addresses_to_discover_subnetId ($subnetId, $die) {
 		# initialize classes
-		$Subnets   = new Subnets ($this->Database);
+		$Subnets = new Subnets ($this->Database);
 
 		//subnet ID is provided, fetch subnet
-		$subnet = $Subnets->fetch_subnet(null, $subnetId);
-		if($subnet===false)	{
-			 if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Invalid subnet ID provided"))); }
-			 else												{ return array(); }
+		$subnet = $Subnets->fetch_subnet (null, $subnetId);
+		if ($subnet === false) {
+			 if ($die) { die(json_encode (array ("status"=>1, "error"=>"Invalid subnet ID provided"))); }
+			 else { return array (); }
 		}
 
 		// we should support only up to 4094 hosts!
-		if($Subnets->get_max_hosts ($subnet->mask, "IPv4")>4094 && php_sapi_name()!="cli")
-		if ($die)												{ die(json_encode(array("status"=>1, "error"=>"Scanning from GUI is only available for subnets up to /20 or 4094 hosts!"))); }
-		else													{ return array(); }
+		if ($Subnets->get_max_hosts ($subnet->mask, "IPv4") > 4094 && php_sapi_name () != "cli")
+		if ($die) { die(json_encode (array ("status"=>1, "error"=>"Scanning from GUI is only available for subnets up to /20 or 4094 hosts!"))); }
+		else { return array (); }
 
 		# set array of addresses to scan, exclude existing!
 		$ip = $this->get_all_possible_subnet_addresses ($subnet->subnet, $subnet->mask);
@@ -632,9 +632,9 @@ 
 		$ip = $this->remove_existing_subnet_addresses ($ip, $subnetId);
 
 		//none to scan?
-		if(sizeof($ip)==0)	{
-			if ($die)											{ die(json_encode(array("status"=>1, "error"=>"Didn't find any address to scan!"))); }
-			else												{ return array(); }
+		if (sizeof ($ip) == 0) {
+			if ($die) { die(json_encode (array ("status"=>1, "error"=>"Didn't find any address to scan!"))); }
+			else { return array (); }
 		}
 
 		//return
@@ -653,23 +653,23 @@ 
 		# initialize classes
 		$Subnets   = new Subnets ($this->Database);
 		# make sure we have proper subnet format
-		$subnet    = $Subnets->transform_address($subnet, "decimal");
+		$subnet    = $Subnets->transform_address ($subnet, "decimal");
 		//fetch start and stop addresses
 		$boundaries = (object) $Subnets->get_network_boundaries ($subnet, $mask);
 		//create array
-		if($mask==32) {
-			$ip[] = $Subnets->transform_to_decimal($boundaries->network);
+		if ($mask == 32) {
+			$ip[] = $Subnets->transform_to_decimal ($boundaries->network);
 		}
-		elseif($mask==31) {
-			$ip[] = $Subnets->transform_to_decimal($boundaries->network);
-			$ip[] = $Subnets->transform_to_decimal($boundaries->broadcast);
+		elseif ($mask == 31) {
+			$ip[] = $Subnets->transform_to_decimal ($boundaries->network);
+			$ip[] = $Subnets->transform_to_decimal ($boundaries->broadcast);
 		}
 		else {
 			//set loop limits
-			$start = gmp_strval(gmp_add($Subnets->transform_to_decimal($boundaries->network),1));
-			$stop  = gmp_strval($Subnets->transform_to_decimal($boundaries->broadcast));
+			$start = gmp_strval (gmp_add ($Subnets->transform_to_decimal ($boundaries->network), 1));
+			$stop  = gmp_strval ($Subnets->transform_to_decimal ($boundaries->broadcast));
 			//loop
-			for($m=$start; $m<$stop; $m++) {
+			for ($m = $start; $m < $stop; $m++) {
 				$ip[] = $m;
 			}
 		}
@@ -689,20 +689,20 @@ 
 		# first fetch all addresses
 		$Addresses = new Addresses ($this->Database);
 		// get all existing IP addresses in subnet
-		$addresses  = $Addresses->fetch_subnet_addresses($subnetId);
+		$addresses = $Addresses->fetch_subnet_addresses ($subnetId);
 		// if some exist remove them
-		if(sizeof($addresses)>0 && sizeof(@$ip)>0) {
-			foreach($addresses as $a) {
-				$key = array_search($a->ip_addr, $ip);
-				if($key !== false) {
+		if (sizeof ($addresses) > 0 && sizeof (@$ip) > 0) {
+			foreach ($addresses as $a) {
+				$key = array_search ($a->ip_addr, $ip);
+				if ($key !== false) {
 					unset($ip[$key]);
 				}
 			}
 			//reindex array for pinging
-			$ip = array_values(@$ip);
+			$ip = array_values (@$ip);
 		}
 		//return
-		return is_array(@$ip) ? $ip : array();
+		return is_array (@$ip) ? $ip : array ();
 	}
 
 	/**
@@ -714,11 +714,11 @@ 
 	 */
 	public function prepare_addresses_to_discover_subnet ($subnet) {
 		//set subnet / mask
-		$subnet_parsed = explode("/", $subnet);
+		$subnet_parsed = explode ("/", $subnet);
 		# result
 		$ip = $this->get_all_possible_subnet_addresses ($subnet_parsed[0], $subnet_parsed[1]);
 		//none to scan?
-		if(sizeof($ip)==0)									{ die(json_encode(array("status"=>1, "error"=>"Didn't find any address to scan!"))); }
+		if (sizeof ($ip) == 0) { die(json_encode (array ("status"=>1, "error"=>"Didn't find any address to scan!"))); }
 		//result
 		return $ip;
 	}
@@ -734,19 +734,19 @@ 
 		# first fetch all addresses
 		$Addresses = new Addresses ($this->Database);
 		// get all existing IP addresses in subnet
-		$subnet_addresses = $Addresses->fetch_subnet_addresses($subnetId);
+		$subnet_addresses = $Addresses->fetch_subnet_addresses ($subnetId);
 		//create array
-		if(sizeof($subnet_addresses)>0) {
-			foreach($subnet_addresses as $a) {
+		if (sizeof ($subnet_addresses) > 0) {
+			foreach ($subnet_addresses as $a) {
 				$scan_addresses[$a->id] = $a->ip_addr;
 			}
 			//reindex
-			$scan_addresses = array_values(@$scan_addresses);
+			$scan_addresses = array_values (@$scan_addresses);
 			//return
 			return $scan_addresses;
 		}
 		else {
-			return array();
+			return array ();
 		}
 	}
 }

functions/checks/check_db_structure.php

Indentation +18 added lines, -18 removed lines

@@ -22,26 +22,26 @@
 
 # print result
 if( (!isset($errors['tableError'])) && (!isset($errors['fieldError'])) ) {
-	print 'All tables and fields are installed properly'. "\n";
+    print 'All tables and fields are installed properly'. "\n";
 }
 else {
-	# missing tables
-	if (isset($errors['tableError'])) {
-		print 'Missing tables:'. "\n";
-
-		foreach ($errors['tableError'] as $table) {
-			print " - ".$table."\n";
-		}
-	}
-
-	# missing fields
-	if (isset($errors['fieldError'])) {
-		print "\n".'Missing fields'. "\n";
-
-		foreach ($errors['fieldError'] as $table=>$field) {
-			print 'Table `'. $table .'`: missing field `'. $field .'`;'."\n";
-		}
-	}
+    # missing tables
+    if (isset($errors['tableError'])) {
+        print 'Missing tables:'. "\n";
+
+        foreach ($errors['tableError'] as $table) {
+            print " - ".$table."\n";
+        }
+    }
+
+    # missing fields
+    if (isset($errors['fieldError'])) {
+        print "\n".'Missing fields'. "\n";
+
+        foreach ($errors['fieldError'] as $table=>$field) {
+            print 'Table `'. $table .'`: missing field `'. $field .'`;'."\n";
+        }
+    }
 }
 print "\n";
 ?>
\ No newline at end of file

Spacing +8 added lines, -8 removed lines

@@ -8,26 +8,26 @@ 
  ****************************************/
 
 # functions
-require_once( dirname(__FILE__) . '/../functions.php' );
+require_once(dirname (__FILE__).'/../functions.php');
 
 # Classes
 $Database = new Database_PDO;
 $Tools = new Tools ($Database);
 
 # title
-print "\n".'Database structure verification'. "\n--------------------\n";
+print "\n".'Database structure verification'."\n--------------------\n";
 
 # check for errors
-$errors = $Tools->verify_database();
+$errors = $Tools->verify_database ();
 
 # print result
-if( (!isset($errors['tableError'])) && (!isset($errors['fieldError'])) ) {
-	print 'All tables and fields are installed properly'. "\n";
+if ((!isset($errors['tableError'])) && (!isset($errors['fieldError']))) {
+	print 'All tables and fields are installed properly'."\n";
 }
 else {
 	# missing tables
 	if (isset($errors['tableError'])) {
-		print 'Missing tables:'. "\n";
+		print 'Missing tables:'."\n";
 
 		foreach ($errors['tableError'] as $table) {
 			print " - ".$table."\n";
@@ -36,10 +36,10 @@ 
 
 	# missing fields
 	if (isset($errors['fieldError'])) {
-		print "\n".'Missing fields'. "\n";
+		print "\n".'Missing fields'."\n";
 
 		foreach ($errors['fieldError'] as $table=>$field) {
-			print 'Table `'. $table .'`: missing field `'. $field .'`;'."\n";
+			print 'Table `'.$table.'`: missing field `'.$field.'`;'."\n";
 		}
 	}
 }

functions/checks/check_db_upgrade.php

Indentation +2 added lines, -2 removed lines

@@ -8,7 +8,7 @@
 
 /* redirect */
 if($User->settings->version < VERSION) {
-	header("Location: ".create_link("upgrade"));
-	die();
+    header("Location: ".create_link("upgrade"));
+    die();
 }
 ?>
\ No newline at end of file

Spacing +2 added lines, -2 removed lines

@@ -7,8 +7,8 @@
 # use required functions
 
 /* redirect */
-if($User->settings->version < VERSION) {
-	header("Location: ".create_link("upgrade"));
+if ($User->settings->version < VERSION) {
+	header ("Location: ".create_link ("upgrade"));
 	die();
 }
 ?>
\ No newline at end of file

functions/scripts/find_untranslated_files.php

Indentation +27 added lines, -27 removed lines

@@ -14,23 +14,23 @@ 
 $untranslated = explode("\n",shell_exec("cd ".dirname(__FILE__)."/../../ && grep -r '_(' * "));
 // loop and search
 foreach ($untranslated as $u) {
-	// find string
-	$str = get_string_between($u, "_('", "')");
-	// remove "" and '
-	$str = trim($str, "',\"");
-	// search for invalud content and remove
-	if (substr($str, 0, 1)!="$") {
-		$all_translations[] = $str;
-	}
+    // find string
+    $str = get_string_between($u, "_('", "')");
+    // remove "" and '
+    $str = trim($str, "',\"");
+    // search for invalud content and remove
+    if (substr($str, 0, 1)!="$") {
+        $all_translations[] = $str;
+    }
 
-	// find string
-	$str = get_string_between($u, '_("', '")');
-	// remove "" and '
-	$str = trim($str, "',\"");
-	// search for invalud content and remove
-	if (substr($str, 0, 1)!="$") {
-		$all_translations[] = $str;
-	}
+    // find string
+    $str = get_string_between($u, '_("', '")');
+    // remove "" and '
+    $str = trim($str, "',\"");
+    // search for invalud content and remove
+    if (substr($str, 0, 1)!="$") {
+        $all_translations[] = $str;
+    }
 }
 //unique
 $all_translations = array_unique($all_translations);
@@ -40,25 +40,25 @@ 
 $untranslated = explode("\n",shell_exec("cd ".dirname(__FILE__)."/../../ && more functions/locale/en/LC_MESSAGES/phpipam.po"));
 // loop and create
 foreach ($untranslated as $u) {
-	// search for string
-	if (substr($u, 0, 7)=='msgid "') {
-		$u = str_replace("msgid ", "", $u);
-		$u = trim($u, '"');
-		$translated[] = $u;
-	}
+    // search for string
+    if (substr($u, 0, 7)=='msgid "') {
+        $u = str_replace("msgid ", "", $u);
+        $u = trim($u, '"');
+        $translated[] = $u;
+    }
 }
 
 // remove existing from unique
 foreach ($all_translations as $tr) {
-	if (!in_array($tr, $translated)) {
-		$new[] = $tr;
-	}
+    if (!in_array($tr, $translated)) {
+        $new[] = $tr;
+    }
 }
 
 // format
 foreach ($new as $tr) {
-	$text[] = "msgid \"$tr\"";
-	$text[] = "msgstr \"\"\n";
+    $text[] = "msgid \"$tr\"";
+    $text[] = "msgstr \"\"\n";
 }
 // join text
 $text = implode("\n",$text);

Braces +3 added lines, -1 removed lines

@@ -72,7 +72,9 @@
 function get_string_between($string, $start, $end){
     $string = " ".$string;
     $ini = strpos($string,$start);
-    if ($ini == 0) return "";
+    if ($ini == 0) {
+        return "";
+    }
     $ini += strlen($start);
     $len = strpos($string,$end,$ini) - $ini;
     return substr($string,$ini,$len);

Spacing +21 added lines, -21 removed lines

@@ -7,50 +7,50 @@ 
  */
 
 // only from cli
-if (php_sapi_name() != "cli")	{ die("Cli only!"); }
+if (php_sapi_name () != "cli") { die("Cli only!"); }
 
 
 // search for all translated words and put them to array
-$untranslated = explode("\n",shell_exec("cd ".dirname(__FILE__)."/../../ && grep -r '_(' * "));
+$untranslated = explode ("\n", shell_exec ("cd ".dirname (__FILE__)."/../../ && grep -r '_(' * "));
 // loop and search
 foreach ($untranslated as $u) {
 	// find string
-	$str = get_string_between($u, "_('", "')");
+	$str = get_string_between ($u, "_('", "')");
 	// remove "" and '
-	$str = trim($str, "',\"");
+	$str = trim ($str, "',\"");
 	// search for invalud content and remove
-	if (substr($str, 0, 1)!="$") {
+	if (substr ($str, 0, 1) != "$") {
 		$all_translations[] = $str;
 	}
 
 	// find string
-	$str = get_string_between($u, '_("', '")');
+	$str = get_string_between ($u, '_("', '")');
 	// remove "" and '
-	$str = trim($str, "',\"");
+	$str = trim ($str, "',\"");
 	// search for invalud content and remove
-	if (substr($str, 0, 1)!="$") {
+	if (substr ($str, 0, 1) != "$") {
 		$all_translations[] = $str;
 	}
 }
 //unique
-$all_translations = array_unique($all_translations);
+$all_translations = array_unique ($all_translations);
 
 
 // search all existing translations
-$untranslated = explode("\n",shell_exec("cd ".dirname(__FILE__)."/../../ && more functions/locale/en/LC_MESSAGES/phpipam.po"));
+$untranslated = explode ("\n", shell_exec ("cd ".dirname (__FILE__)."/../../ && more functions/locale/en/LC_MESSAGES/phpipam.po"));
 // loop and create
 foreach ($untranslated as $u) {
 	// search for string
-	if (substr($u, 0, 7)=='msgid "') {
-		$u = str_replace("msgid ", "", $u);
-		$u = trim($u, '"');
+	if (substr ($u, 0, 7) == 'msgid "') {
+		$u = str_replace ("msgid ", "", $u);
+		$u = trim ($u, '"');
 		$translated[] = $u;
 	}
 }
 
 // remove existing from unique
 foreach ($all_translations as $tr) {
-	if (!in_array($tr, $translated)) {
+	if (!in_array ($tr, $translated)) {
 		$new[] = $tr;
 	}
 }
@@ -61,20 +61,20 @@ 
 	$text[] = "msgstr \"\"\n";
 }
 // join text
-$text = implode("\n",$text);
+$text = implode ("\n", $text);
 
 
 // output changes
-print_r($text);
+print_r ($text);
 
 
 // returns string between 2 separators
-function get_string_between($string, $start, $end){
+function get_string_between ($string, $start, $end) {
     $string = " ".$string;
-    $ini = strpos($string,$start);
+    $ini = strpos ($string, $start);
     if ($ini == 0) return "";
-    $ini += strlen($start);
-    $len = strpos($string,$end,$ini) - $ini;
-    return substr($string,$ini,$len);
+    $ini += strlen ($start);
+    $len = strpos ($string, $end, $ini) - $ini;
+    return substr ($string, $ini, $len);
 }
 ?>
\ No newline at end of file

functions/scripts/resolveIPaddresses.php

Indentation +51 added lines, -51 removed lines

@@ -15,9 +15,9 @@ 
 /* settings */
 $resolve_config['emptyonly'] = true;			# if true it will only update the ones without DNS entry!
 $resolve_config['subnets']	 = array();			# which subnets to check - by id
-												# example -> array(1,3,5)	will only update subnets with id 1,3,5
-												# 	you can get id's and descriptions with following MySQL query:
-												#	select `id`,`description` from `subnets`;
+                                                # example -> array(1,3,5)	will only update subnets with id 1,3,5
+                                                # 	you can get id's and descriptions with following MySQL query:
+                                                #	select `id`,`description` from `subnets`;
 $resolve_config['verbose']  = true;				# verbose response - prints results, cron will email it to you!
 
 # include required scripts
@@ -39,13 +39,13 @@ 
 
 # set subnet
 if (isset($argv[1])) {
-	$req_subnets = explode(",", $argv[1]);
-	foreach ($req_subnets as $s) {
-		if (!is_numeric($s)) { $Result->show_cli("Invalid subnetId provided - $s\n", true); }
-		else {
-			$resolve_config['subnets'][] = $s;
-		}
-	}
+    $req_subnets = explode(",", $argv[1]);
+    foreach ($req_subnets as $s) {
+        if (!is_numeric($s)) { $Result->show_cli("Invalid subnetId provided - $s\n", true); }
+        else {
+            $resolve_config['subnets'][] = $s;
+        }
+    }
 }
 
 
@@ -56,29 +56,29 @@ 
 
 # check all subnets
 if(sizeof($resolve_config['subnets']) == 0) {
-	# get ony ip's with empty DNS
-	if($resolve_config['emptyonly'] == 1) 	{ $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` where `dns_name` = "" or `dns_name` is NULL order by `ip_addr` ASC;'; }
-	else 									{ $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` order by `ip_addr` ASC;'; }
+    # get ony ip's with empty DNS
+    if($resolve_config['emptyonly'] == 1) 	{ $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` where `dns_name` = "" or `dns_name` is NULL order by `ip_addr` ASC;'; }
+    else 									{ $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` order by `ip_addr` ASC;'; }
 }
 # check selected subnets
 else {
-	$query[] = "select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` where ";
-	//go through subnets
-	$m=1;
-	foreach($resolve_config['subnets'] as $k=>$subnetId) {
-		// last
-		if($m==sizeof($resolve_config['subnets']))	{ $query[] = '`subnetId` = "'. $subnetId .'" '; }
-		else										{ $query[] = '`subnetId` = "'. $subnetId .'" or '; }
-		$m++;
-	}
-	# get ony ip's with empty DNS
-	if($resolve_config['emptyonly'] == 1) {
-		$query[] = ' and (`dns_name` = "" or `dns_name` is NULL ) ';
-	}
-	$query[] = 'order by `ip_addr` ASC;';
-
-	//join
-	$query = implode("\n", $query);
+    $query[] = "select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` where ";
+    //go through subnets
+    $m=1;
+    foreach($resolve_config['subnets'] as $k=>$subnetId) {
+        // last
+        if($m==sizeof($resolve_config['subnets']))	{ $query[] = '`subnetId` = "'. $subnetId .'" '; }
+        else										{ $query[] = '`subnetId` = "'. $subnetId .'" or '; }
+        $m++;
+    }
+    # get ony ip's with empty DNS
+    if($resolve_config['emptyonly'] == 1) {
+        $query[] = ' and (`dns_name` = "" or `dns_name` is NULL ) ';
+    }
+    $query[] = 'order by `ip_addr` ASC;';
+
+    //join
+    $query = implode("\n", $query);
 }
 
 # fetch records
@@ -86,31 +86,31 @@ 
 
 # try to update dns records
 if (sizeof($ipaddresses)>0) {
-	foreach($ipaddresses as $ip) {
-		# fetch subnet
-		$subnet = $Subnets->fetch_subnet ("id", $ip->subnetId);
-		$nsid = $subnet===false ? false : $subnet->nameserverId;
-		# try to resolve
-		$hostname = $DNS->resolve_address ($ip->ip_addr, null, true, $nsid);
-
-		# update if change
-		if($hostname['class']=="resolved") {
-			# values
-			$values = array("dns_name"=>$hostname['name'],
-							"id"=>$ip->id
-							);
-			# execute
-			if(!$Admin->object_modify("ipaddresses", "edit", "id", $values))	{ $Result->show_cli("Failed to update address ".$Subnets->transform_to_dotted($ip->ip_addr)); }
-
-			# set text
-			$res[] = 'updated ip address '. $Subnets->transform_to_dotted($ip->ip_addr) . ' with hostname '. $hostname['name'];
-		}
-	}
+    foreach($ipaddresses as $ip) {
+        # fetch subnet
+        $subnet = $Subnets->fetch_subnet ("id", $ip->subnetId);
+        $nsid = $subnet===false ? false : $subnet->nameserverId;
+        # try to resolve
+        $hostname = $DNS->resolve_address ($ip->ip_addr, null, true, $nsid);
+
+        # update if change
+        if($hostname['class']=="resolved") {
+            # values
+            $values = array("dns_name"=>$hostname['name'],
+                            "id"=>$ip->id
+                            );
+            # execute
+            if(!$Admin->object_modify("ipaddresses", "edit", "id", $values))	{ $Result->show_cli("Failed to update address ".$Subnets->transform_to_dotted($ip->ip_addr)); }
+
+            # set text
+            $res[] = 'updated ip address '. $Subnets->transform_to_dotted($ip->ip_addr) . ' with hostname '. $hostname['name'];
+        }
+    }
 }
 
 
 # if verbose print result so it can be emailed via cron!
 if($resolve_config['verbose'] == true && isset($res)) {
-	print implode("\n", $res);
+    print implode("\n", $res);
 }
 ?>
\ No newline at end of file

Spacing +32 added lines, -32 removed lines

@@ -13,35 +13,35 @@ 
 
 
 /* settings */
-$resolve_config['emptyonly'] = true;			# if true it will only update the ones without DNS entry!
-$resolve_config['subnets']	 = array();			# which subnets to check - by id
+$resolve_config['emptyonly'] = true; # if true it will only update the ones without DNS entry!
+$resolve_config['subnets'] = array (); # which subnets to check - by id
 												# example -> array(1,3,5)	will only update subnets with id 1,3,5
 												# 	you can get id's and descriptions with following MySQL query:
 												#	select `id`,`description` from `subnets`;
-$resolve_config['verbose']  = true;				# verbose response - prints results, cron will email it to you!
+$resolve_config['verbose'] = true; # verbose response - prints results, cron will email it to you!
 
 # include required scripts
-require( dirname(__FILE__) . '/../functions.php' );
+require(dirname (__FILE__).'/../functions.php');
 
 # initialize objects
-$Database 	= new Database_PDO;
-$Admin		= new Admin ($Database, false);
+$Database = new Database_PDO;
+$Admin = new Admin ($Database, false);
 $Subnets	= new Subnets ($Database);
-$DNS		= new DNS ($Database);
-$Result		= new Result();
+$DNS = new DNS ($Database);
+$Result		= new Result ();
 
 // set to 1 in case of errors
-ini_set('display_errors', 0);
-error_reporting(E_ERROR);
+ini_set ('display_errors', 0);
+error_reporting (E_ERROR);
 
 # cli required
-if( php_sapi_name()!="cli" ) { $Result->show_cli("cli only\n", true); }
+if (php_sapi_name () != "cli") { $Result->show_cli ("cli only\n", true); }
 
 # set subnet
 if (isset($argv[1])) {
-	$req_subnets = explode(",", $argv[1]);
+	$req_subnets = explode (",", $argv[1]);
 	foreach ($req_subnets as $s) {
-		if (!is_numeric($s)) { $Result->show_cli("Invalid subnetId provided - $s\n", true); }
+		if (!is_numeric ($s)) { $Result->show_cli ("Invalid subnetId provided - $s\n", true); }
 		else {
 			$resolve_config['subnets'][] = $s;
 		}
@@ -55,62 +55,62 @@ 
 #
 
 # check all subnets
-if(sizeof($resolve_config['subnets']) == 0) {
+if (sizeof ($resolve_config['subnets']) == 0) {
 	# get ony ip's with empty DNS
-	if($resolve_config['emptyonly'] == 1) 	{ $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` where `dns_name` = "" or `dns_name` is NULL order by `ip_addr` ASC;'; }
-	else 									{ $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` order by `ip_addr` ASC;'; }
+	if ($resolve_config['emptyonly'] == 1) { $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` where `dns_name` = "" or `dns_name` is NULL order by `ip_addr` ASC;'; }
+	else { $query = 'select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` order by `ip_addr` ASC;'; }
 }
 # check selected subnets
 else {
 	$query[] = "select `id`,`ip_addr`,`dns_name`,`subnetId` from `ipaddresses` where ";
 	//go through subnets
-	$m=1;
-	foreach($resolve_config['subnets'] as $k=>$subnetId) {
+	$m = 1;
+	foreach ($resolve_config['subnets'] as $k=>$subnetId) {
 		// last
-		if($m==sizeof($resolve_config['subnets']))	{ $query[] = '`subnetId` = "'. $subnetId .'" '; }
-		else										{ $query[] = '`subnetId` = "'. $subnetId .'" or '; }
+		if ($m == sizeof ($resolve_config['subnets'])) { $query[] = '`subnetId` = "'.$subnetId.'" '; }
+		else { $query[] = '`subnetId` = "'.$subnetId.'" or '; }
 		$m++;
 	}
 	# get ony ip's with empty DNS
-	if($resolve_config['emptyonly'] == 1) {
+	if ($resolve_config['emptyonly'] == 1) {
 		$query[] = ' and (`dns_name` = "" or `dns_name` is NULL ) ';
 	}
 	$query[] = 'order by `ip_addr` ASC;';
 
 	//join
-	$query = implode("\n", $query);
+	$query = implode ("\n", $query);
 }
 
 # fetch records
-$ipaddresses = $Database->getObjectsQuery($query);
+$ipaddresses = $Database->getObjectsQuery ($query);
 
 # try to update dns records
-if (sizeof($ipaddresses)>0) {
-	foreach($ipaddresses as $ip) {
+if (sizeof ($ipaddresses) > 0) {
+	foreach ($ipaddresses as $ip) {
 		# fetch subnet
 		$subnet = $Subnets->fetch_subnet ("id", $ip->subnetId);
-		$nsid = $subnet===false ? false : $subnet->nameserverId;
+		$nsid = $subnet === false ? false : $subnet->nameserverId;
 		# try to resolve
 		$hostname = $DNS->resolve_address ($ip->ip_addr, null, true, $nsid);
 
 		# update if change
-		if($hostname['class']=="resolved") {
+		if ($hostname['class'] == "resolved") {
 			# values
-			$values = array("dns_name"=>$hostname['name'],
+			$values = array ("dns_name"=>$hostname['name'],
 							"id"=>$ip->id
 							);
 			# execute
-			if(!$Admin->object_modify("ipaddresses", "edit", "id", $values))	{ $Result->show_cli("Failed to update address ".$Subnets->transform_to_dotted($ip->ip_addr)); }
+			if (!$Admin->object_modify ("ipaddresses", "edit", "id", $values)) { $Result->show_cli ("Failed to update address ".$Subnets->transform_to_dotted ($ip->ip_addr)); }
 
 			# set text
-			$res[] = 'updated ip address '. $Subnets->transform_to_dotted($ip->ip_addr) . ' with hostname '. $hostname['name'];
+			$res[] = 'updated ip address '.$Subnets->transform_to_dotted ($ip->ip_addr).' with hostname '.$hostname['name'];
 		}
 	}
 }
 
 
 # if verbose print result so it can be emailed via cron!
-if($resolve_config['verbose'] == true && isset($res)) {
-	print implode("\n", $res);
+if ($resolve_config['verbose'] == true && isset($res)) {
+	print implode ("\n", $res);
 }
 ?>
\ No newline at end of file

functions/scripts/discoveryCheck.php

Indentation +182 added lines, -182 removed lines

@@ -78,18 +78,18 @@ 
     $addresses_tmp = array();
     // loop
     foreach($scan_subnets as $s) {
-    	// if subnet has slaves dont check it
-    	if ($Subnets->has_slaves ($s->id) === false) {
-    		$addresses_tmp[$s->id] = $Scan-> prepare_addresses_to_scan ("discovery", $s->id, false);
-    	}
+        // if subnet has slaves dont check it
+        if ($Subnets->has_slaves ($s->id) === false) {
+            $addresses_tmp[$s->id] = $Scan-> prepare_addresses_to_scan ("discovery", $s->id, false);
+        }
     }
 
     //reindex
     if(sizeof($addresses_tmp)>0) {
         foreach($addresses_tmp as $s_id=>$a) {
-        	foreach($a as $ip) {
-        		$addresses[] = array("subnetId"=>$s_id, "ip_addr"=>$ip);
-        	}
+            foreach($a as $ip) {
+                $addresses[] = array("subnetId"=>$s_id, "ip_addr"=>$ip);
+            }
         }
     }
 }
@@ -110,101 +110,101 @@ 
 
 //different scan for fping
 if($Scan->icmp_type=="fping") {
-	//run per MAX_THREADS
-	for ($m=0; $m<=$size_subnets; $m += $Scan->settings->scanMaxThreads) {
-	    // create threads
-	    $threads = array();
-	    //fork processes
-	    for ($i = 0; $i <= $Scan->settings->scanMaxThreads && $i <= $size_subnets; $i++) {
-	    	//only if index exists!
-	    	if(isset($scan_subnets[$z])) {
-				//start new thread
-	            $threads[$z] = new Thread( 'fping_subnet' );
-				$threads[$z]->start_fping( $Subnets->transform_to_dotted($scan_subnets[$z]->subnet)."/".$scan_subnets[$z]->mask );
-	            $z++;				//next index
-			}
-	    }
-	    // wait for all the threads to finish
-	    while( !empty( $threads ) ) {
-			foreach($threads as $index => $thread) {
-				$child_pipe = "/tmp/pipe_".$thread->getPid();
-
-				if (file_exists($child_pipe)) {
-					$file_descriptor = fopen( $child_pipe, "r");
-					$child_response = "";
-					while (!feof($file_descriptor)) {
-						$child_response .= fread($file_descriptor, 8192);
-					}
-					//we have the child data in the parent, but serialized:
-					$child_response = unserialize( $child_response );
-					//store
-					$scan_subnets[$index]->discovered = $child_response;
-					//now, child is dead, and parent close the pipe
-					unlink( $child_pipe );
-					unset($threads[$index]);
-				}
-			}
-	        usleep(200000);
-	    }
-	}
-
-	//fping finds all subnet addresses, we must remove existing ones !
-	foreach($scan_subnets as $sk=>$s) {
-    	if(isset($s->discovered)) {
-    		foreach($s->discovered as $rk=>$result) {
-    			if(!in_array($Subnets->transform_to_decimal($result), $addresses_tmp[$s->id])) {
-    				unset($scan_subnets[$sk]->discovered[$rk]);
-    			}
-    		}
+    //run per MAX_THREADS
+    for ($m=0; $m<=$size_subnets; $m += $Scan->settings->scanMaxThreads) {
+        // create threads
+        $threads = array();
+        //fork processes
+        for ($i = 0; $i <= $Scan->settings->scanMaxThreads && $i <= $size_subnets; $i++) {
+            //only if index exists!
+            if(isset($scan_subnets[$z])) {
+                //start new thread
+                $threads[$z] = new Thread( 'fping_subnet' );
+                $threads[$z]->start_fping( $Subnets->transform_to_dotted($scan_subnets[$z]->subnet)."/".$scan_subnets[$z]->mask );
+                $z++;				//next index
+            }
+        }
+        // wait for all the threads to finish
+        while( !empty( $threads ) ) {
+            foreach($threads as $index => $thread) {
+                $child_pipe = "/tmp/pipe_".$thread->getPid();
+
+                if (file_exists($child_pipe)) {
+                    $file_descriptor = fopen( $child_pipe, "r");
+                    $child_response = "";
+                    while (!feof($file_descriptor)) {
+                        $child_response .= fread($file_descriptor, 8192);
+                    }
+                    //we have the child data in the parent, but serialized:
+                    $child_response = unserialize( $child_response );
+                    //store
+                    $scan_subnets[$index]->discovered = $child_response;
+                    //now, child is dead, and parent close the pipe
+                    unlink( $child_pipe );
+                    unset($threads[$index]);
+                }
+            }
+            usleep(200000);
+        }
+    }
+
+    //fping finds all subnet addresses, we must remove existing ones !
+    foreach($scan_subnets as $sk=>$s) {
+        if(isset($s->discovered)) {
+            foreach($s->discovered as $rk=>$result) {
+                if(!in_array($Subnets->transform_to_decimal($result), $addresses_tmp[$s->id])) {
+                    unset($scan_subnets[$sk]->discovered[$rk]);
+                }
+            }
             //rekey
             $scan_subnets[$sk]->discovered = array_values($scan_subnets[$sk]->discovered);
-		}
-	}
+        }
+    }
 }
 //ping, pear
 else {
-	//run per MAX_THREADS
+    //run per MAX_THREADS
     for ($m=0; $m<=$size_addresses; $m += $Scan->settings->scanMaxThreads) {
         // create threads
         $threads = array();
 
         //fork processes
         for ($i = 0; $i <= $Scan->settings->scanMaxThreads && $i <= $size_addresses; $i++) {
-        	//only if index exists!
-        	if(isset($addresses[$z])) {
-				//start new thread
-	            $threads[$z] = new Thread( 'ping_address' );
-	            $threads[$z]->start( $Subnets->transform_to_dotted($addresses[$z]['ip_addr']) );
-				$z++;			//next index
-			}
+            //only if index exists!
+            if(isset($addresses[$z])) {
+                //start new thread
+                $threads[$z] = new Thread( 'ping_address' );
+                $threads[$z]->start( $Subnets->transform_to_dotted($addresses[$z]['ip_addr']) );
+                $z++;			//next index
+            }
         }
 
         // wait for all the threads to finish
         while( !empty( $threads ) ) {
             foreach( $threads as $index => $thread ) {
                 if( ! $thread->isAlive() ) {
-					//unset dead hosts
-					if($thread->getExitCode() != 0) {
-						unset($addresses[$index]);
-					}
+                    //unset dead hosts
+                    if($thread->getExitCode() != 0) {
+                        unset($addresses[$index]);
+                    }
                     //remove thread
                     unset( $threads[$index]);
                 }
             }
             usleep(200000);
         }
-	}
-
-	//ok, we have all available addresses, rekey them
-	foreach($addresses as $a) {
-		$add_tmp[$a['subnetId']][] = $Subnets->transform_to_dotted($a['ip_addr']);
-	}
-	//add to scan_subnets as result
-	foreach($scan_subnets as $sk=>$s) {
-		if(isset($add_tmp[$s->id])) {
-			$scan_subnets[$sk]->discovered = $add_tmp[$s->id];
-		}
-	}
+    }
+
+    //ok, we have all available addresses, rekey them
+    foreach($addresses as $a) {
+        $add_tmp[$a['subnetId']][] = $Subnets->transform_to_dotted($a['ip_addr']);
+    }
+    //add to scan_subnets as result
+    foreach($scan_subnets as $sk=>$s) {
+        if(isset($add_tmp[$s->id])) {
+            $scan_subnets[$sk]->discovered = $add_tmp[$s->id];
+        }
+    }
 }
 
 
@@ -226,31 +226,31 @@ 
 $discovered = 0;				//for mailing
 
 foreach($scan_subnets as $s) {
-	if(sizeof(@$s->discovered)>0) {
-		foreach($s->discovered as $ip) {
-			// fetch subnet
-			$subnet = $Subnets->fetch_subnet ("id", $s->id);
-			$nsid = $subnet===false ? false : $subnet->nameserverId;
-			// try to resolve hostname
-			$hostname = $DNS->resolve_address ($ip, false, true, $nsid);
-
-			//set update query
-			$values = array("subnetId"=>$s->id,
-							"ip_addr"=>$Subnets->transform_address($ip, "decimal"),
-							"dns_name"=>$hostname['name'],
-							"description"=>"-- autodiscovered --",
-							"note"=>"This host was autodiscovered on ".$nowdate,
-							"lastSeen"=>$nowdate,
-							"state"=>"2",
-							"action"=>"add"
-							);
-			//insert
-			$Addresses->modify_address($values);
-
-			//set discovered
-			$discovered++;
-		}
-	}
+    if(sizeof(@$s->discovered)>0) {
+        foreach($s->discovered as $ip) {
+            // fetch subnet
+            $subnet = $Subnets->fetch_subnet ("id", $s->id);
+            $nsid = $subnet===false ? false : $subnet->nameserverId;
+            // try to resolve hostname
+            $hostname = $DNS->resolve_address ($ip, false, true, $nsid);
+
+            //set update query
+            $values = array("subnetId"=>$s->id,
+                            "ip_addr"=>$Subnets->transform_address($ip, "decimal"),
+                            "dns_name"=>$hostname['name'],
+                            "description"=>"-- autodiscovered --",
+                            "note"=>"This host was autodiscovered on ".$nowdate,
+                            "lastSeen"=>$nowdate,
+                            "state"=>"2",
+                            "action"=>"add"
+                            );
+            //insert
+            $Addresses->modify_address($values);
+
+            //set discovered
+            $discovered++;
+        }
+    }
 }
 
 # update scan time
@@ -261,84 +261,84 @@ 
 # send mail
 if($discovered>0 && $send_mail) {
 
-	# check for recipients
-	foreach($Admin->fetch_multiple_objects ("users", "role", "Administrator") as $admin) {
-		if($admin->mailNotify=="Yes") {
-			$recepients[] = array("name"=>$admin->real_name, "email"=>$admin->email);
-		}
-	}
-	# none?
-	if(!isset($recepients))	{ die(); }
-
-	# fetch mailer settings
-	$mail_settings = $Admin->fetch_object("settingsMail", "id", 1);
-	# fake user object, needed for create_link
-	$User = new StdClass();
-	@$User->settings->prettyLinks = $Scan->settings->prettyLinks;
-
-	# initialize mailer
-	$phpipam_mail = new phpipam_mail($Scan->settings, $mail_settings);
-	$phpipam_mail->initialize_mailer();
-
-
-
-	// set subject
-	$subject	= "phpIPAM new addresses detected ".date("Y-m-d H:i:s");
-
-	//html
-	$content[] = "<h3>phpIPAM found $discovered new hosts</h3>";
-	$content[] = "<table style='margin-left:10px;margin-top:5px;width:auto;padding:0px;border-collapse:collapse;border:1px solid gray;'>";
-	$content[] = "<tr>";
-	$content[] = "	<th style='padding:3px 8px;border:1px solid silver;border-bottom:2px solid gray;'>IP</th>";
-	$content[] = "	<th style='padding:3px 8px;border:1px solid silver;border-bottom:2px solid gray;'>Subnet</th>";
-	$content[] = "	<th style='padding:3px 8px;border:1px solid silver;border-bottom:2px solid gray;'>Section</th>";
-	$content[] = "</tr>";
-	//plain
-	$content_plain[] = "phpIPAM found $discovered new hosts\r\n------------------------------";
-	//Changes
-	foreach($scan_subnets as $s) {
-		if(sizeof(@$s->discovered)>0) {
-			foreach($s->discovered as $ip) {
-				//set subnet
-				$subnet 	 = $Subnets->fetch_subnet(null, $s->id);
-				//set section
-				$section 	 = $Admin->fetch_object("sections", "id", $s->sectionId);
-
-				$content[] = "<tr>";
-				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'>$ip</td>";
-				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim($Scan->settings->siteURL, "/")."".create_link("subnets",$section->id,$subnet->id)."'>".$Subnets->transform_to_dotted($subnet->subnet)."/".$subnet->mask." - ".$subnet->description."</a></td>";
-				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim($Scan->settings->siteURL, "/")."".create_link("subnets",$section->id)."'>$section->name $section->description</a></td>";
-				$content[] = "</tr>";
-
-				//plain content
-				$content_plain[] = "\t * $ip (".$Subnets->transform_to_dotted($subnet->subnet)."/".$subnet->mask.")";
-			}
-		}
-	}
-	$content[] = "</table>";
-
-
-	# set content
-	$content 		= $phpipam_mail->generate_message (implode("\r\n", $content));
-	$content_plain 	= implode("\r\n",$content_plain);
-
-	# try to send
-	try {
-		$phpipam_mail->Php_mailer->setFrom($mail_settings->mAdminMail, $mail_settings->mAdminName);
-		//add all admins to CC
-		foreach($recepients as $admin) {
-			$phpipam_mail->Php_mailer->addAddress(addslashes($admin['email']), addslashes($admin['name']));
-		}
-		$phpipam_mail->Php_mailer->Subject = $subject;
-		$phpipam_mail->Php_mailer->msgHTML($content);
-		$phpipam_mail->Php_mailer->AltBody = $content_plain;
-		//send
-		$phpipam_mail->Php_mailer->send();
-	} catch (phpmailerException $e) {
-		$Result->show_cli("Mailer Error: ".$e->errorMessage(), true);
-	} catch (Exception $e) {
-		$Result->show_cli("Mailer Error: ".$e->errorMessage(), true);
-	}
+    # check for recipients
+    foreach($Admin->fetch_multiple_objects ("users", "role", "Administrator") as $admin) {
+        if($admin->mailNotify=="Yes") {
+            $recepients[] = array("name"=>$admin->real_name, "email"=>$admin->email);
+        }
+    }
+    # none?
+    if(!isset($recepients))	{ die(); }
+
+    # fetch mailer settings
+    $mail_settings = $Admin->fetch_object("settingsMail", "id", 1);
+    # fake user object, needed for create_link
+    $User = new StdClass();
+    @$User->settings->prettyLinks = $Scan->settings->prettyLinks;
+
+    # initialize mailer
+    $phpipam_mail = new phpipam_mail($Scan->settings, $mail_settings);
+    $phpipam_mail->initialize_mailer();
+
+
+
+    // set subject
+    $subject	= "phpIPAM new addresses detected ".date("Y-m-d H:i:s");
+
+    //html
+    $content[] = "<h3>phpIPAM found $discovered new hosts</h3>";
+    $content[] = "<table style='margin-left:10px;margin-top:5px;width:auto;padding:0px;border-collapse:collapse;border:1px solid gray;'>";
+    $content[] = "<tr>";
+    $content[] = "	<th style='padding:3px 8px;border:1px solid silver;border-bottom:2px solid gray;'>IP</th>";
+    $content[] = "	<th style='padding:3px 8px;border:1px solid silver;border-bottom:2px solid gray;'>Subnet</th>";
+    $content[] = "	<th style='padding:3px 8px;border:1px solid silver;border-bottom:2px solid gray;'>Section</th>";
+    $content[] = "</tr>";
+    //plain
+    $content_plain[] = "phpIPAM found $discovered new hosts\r\n------------------------------";
+    //Changes
+    foreach($scan_subnets as $s) {
+        if(sizeof(@$s->discovered)>0) {
+            foreach($s->discovered as $ip) {
+                //set subnet
+                $subnet 	 = $Subnets->fetch_subnet(null, $s->id);
+                //set section
+                $section 	 = $Admin->fetch_object("sections", "id", $s->sectionId);
+
+                $content[] = "<tr>";
+                $content[] = "	<td style='padding:3px 8px;border:1px solid silver;'>$ip</td>";
+                $content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim($Scan->settings->siteURL, "/")."".create_link("subnets",$section->id,$subnet->id)."'>".$Subnets->transform_to_dotted($subnet->subnet)."/".$subnet->mask." - ".$subnet->description."</a></td>";
+                $content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim($Scan->settings->siteURL, "/")."".create_link("subnets",$section->id)."'>$section->name $section->description</a></td>";
+                $content[] = "</tr>";
+
+                //plain content
+                $content_plain[] = "\t * $ip (".$Subnets->transform_to_dotted($subnet->subnet)."/".$subnet->mask.")";
+            }
+        }
+    }
+    $content[] = "</table>";
+
+
+    # set content
+    $content 		= $phpipam_mail->generate_message (implode("\r\n", $content));
+    $content_plain 	= implode("\r\n",$content_plain);
+
+    # try to send
+    try {
+        $phpipam_mail->Php_mailer->setFrom($mail_settings->mAdminMail, $mail_settings->mAdminName);
+        //add all admins to CC
+        foreach($recepients as $admin) {
+            $phpipam_mail->Php_mailer->addAddress(addslashes($admin['email']), addslashes($admin['name']));
+        }
+        $phpipam_mail->Php_mailer->Subject = $subject;
+        $phpipam_mail->Php_mailer->msgHTML($content);
+        $phpipam_mail->Php_mailer->AltBody = $content_plain;
+        //send
+        $phpipam_mail->Php_mailer->send();
+    } catch (phpmailerException $e) {
+        $Result->show_cli("Mailer Error: ".$e->errorMessage(), true);
+    } catch (Exception $e) {
+        $Result->show_cli("Mailer Error: ".$e->errorMessage(), true);
+    }
 }
 
 ?>

Spacing +109 added lines, -109 removed lines

@@ -24,60 +24,60 @@ 
 
 
 # include required scripts
-require( dirname(__FILE__) . '/../functions.php' );
-require( dirname(__FILE__) . '/../../functions/classes/class.Thread.php');
+require(dirname (__FILE__).'/../functions.php');
+require(dirname (__FILE__).'/../../functions/classes/class.Thread.php');
 
 # initialize objects
 $Database 	= new Database_PDO;
-$Subnets	= new Subnets ($Database);
+$Subnets = new Subnets ($Database);
 $Addresses	= new Addresses ($Database);
-$Tools		= new Tools ($Database);
-$Scan		= new Scan ($Database);
-$DNS		= new DNS ($Database);
-$Result		= new Result();
+$Tools = new Tools ($Database);
+$Scan = new Scan ($Database);
+$DNS = new DNS ($Database);
+$Result = new Result ();
 
 // set exit flag to true
-$Scan->ping_set_exit(true);
+$Scan->ping_set_exit (true);
 // set debugging
-$Scan->reset_debugging(false);
+$Scan->reset_debugging (false);
 // change scan type?
 //$Scan->reset_scan_method ("pear");
 // set ping statuses
-$statuses = explode(";", $Scan->settings->pingStatus);
+$statuses = explode (";", $Scan->settings->pingStatus);
 // set mail override flag
 $send_mail = true;
 
 // set now for whole script
-$now     = time();
+$now     = time ();
 $nowdate = date ("Y-m-d H:i:s");
 
 
 // response for mailing
-$address_change = array();			// Array with differences, can be used to email to admins
+$address_change = array (); // Array with differences, can be used to email to admins
 
 
 // script can only be run from cli
-if(php_sapi_name()!="cli") 						{ die("This script can only be run from cli!"); }
+if (php_sapi_name () != "cli") { die("This script can only be run from cli!"); }
 // test to see if threading is available
-if(!Thread::available()) 						{ die("Threading is required for scanning subnets. Please recompile PHP with pcntl extension"); }
+if (!Thread::available ()) { die("Threading is required for scanning subnets. Please recompile PHP with pcntl extension"); }
 // verify ping path
-if ($Scan->icmp_type=="ping") {
-if(!file_exists($Scan->settings->scanPingPath)) { die("Invalid ping path!"); }
+if ($Scan->icmp_type == "ping") {
+if (!file_exists ($Scan->settings->scanPingPath)) { die("Invalid ping path!"); }
 }
 // verify fping path
-if ($Scan->icmp_type=="fping") {
-if(!file_exists($Scan->settings->scanFPingPath)){ die("Invalid fping path!"); }
+if ($Scan->icmp_type == "fping") {
+if (!file_exists ($Scan->settings->scanFPingPath)) { die("Invalid fping path!"); }
 }
 
 
 //first fetch all subnets to be scanned
 $scan_subnets = $Subnets->fetch_all_subnets_for_discoveryCheck (1);
 //set addresses
-if ($scan_subnets!==false) {
+if ($scan_subnets !== false) {
     // initial array
-    $addresses_tmp = array();
+    $addresses_tmp = array ();
     // loop
-    foreach($scan_subnets as $s) {
+    foreach ($scan_subnets as $s) {
     	// if subnet has slaves dont check it
     	if ($Subnets->has_slaves ($s->id) === false) {
     		$addresses_tmp[$s->id] = $Scan-> prepare_addresses_to_scan ("discovery", $s->id, false);
@@ -85,123 +85,123 @@ 
     }
 
     //reindex
-    if(sizeof($addresses_tmp)>0) {
-        foreach($addresses_tmp as $s_id=>$a) {
-        	foreach($a as $ip) {
-        		$addresses[] = array("subnetId"=>$s_id, "ip_addr"=>$ip);
+    if (sizeof ($addresses_tmp) > 0) {
+        foreach ($addresses_tmp as $s_id=>$a) {
+        	foreach ($a as $ip) {
+        		$addresses[] = array ("subnetId"=>$s_id, "ip_addr"=>$ip);
         	}
         }
     }
 }
 
 
-if($Scan->debugging)							{ print_r($scan_subnets); }
-if($scan_subnets===false) 						{ die("No subnets are marked for new hosts checking"); }
+if ($Scan->debugging) { print_r ($scan_subnets); }
+if ($scan_subnets === false) { die("No subnets are marked for new hosts checking"); }
 
 
 //scan
-if($Scan->debugging)							{ print "Using $Scan->icmp_type\n--------------------\n\n"; }
+if ($Scan->debugging) { print "Using $Scan->icmp_type\n--------------------\n\n"; }
 
 
-$z = 0;			//addresses array index
+$z = 0; //addresses array index
 
-$size_subnets = max(array_keys($scan_subnets));
-$size_addresses = max(array_keys($addresses));
+$size_subnets = max (array_keys ($scan_subnets));
+$size_addresses = max (array_keys ($addresses));
 
 //different scan for fping
-if($Scan->icmp_type=="fping") {
+if ($Scan->icmp_type == "fping") {
 	//run per MAX_THREADS
-	for ($m=0; $m<=$size_subnets; $m += $Scan->settings->scanMaxThreads) {
+	for ($m = 0; $m <= $size_subnets; $m += $Scan->settings->scanMaxThreads) {
 	    // create threads
-	    $threads = array();
+	    $threads = array ();
 	    //fork processes
 	    for ($i = 0; $i <= $Scan->settings->scanMaxThreads && $i <= $size_subnets; $i++) {
 	    	//only if index exists!
-	    	if(isset($scan_subnets[$z])) {
+	    	if (isset($scan_subnets[$z])) {
 				//start new thread
-	            $threads[$z] = new Thread( 'fping_subnet' );
-				$threads[$z]->start_fping( $Subnets->transform_to_dotted($scan_subnets[$z]->subnet)."/".$scan_subnets[$z]->mask );
-	            $z++;				//next index
+	            $threads[$z] = new Thread ('fping_subnet');
+				$threads[$z]->start_fping ($Subnets->transform_to_dotted ($scan_subnets[$z]->subnet)."/".$scan_subnets[$z]->mask);
+	            $z++; //next index
 			}
 	    }
 	    // wait for all the threads to finish
-	    while( !empty( $threads ) ) {
-			foreach($threads as $index => $thread) {
-				$child_pipe = "/tmp/pipe_".$thread->getPid();
+	    while (!empty($threads)) {
+			foreach ($threads as $index => $thread) {
+				$child_pipe = "/tmp/pipe_".$thread->getPid ();
 
-				if (file_exists($child_pipe)) {
-					$file_descriptor = fopen( $child_pipe, "r");
+				if (file_exists ($child_pipe)) {
+					$file_descriptor = fopen ($child_pipe, "r");
 					$child_response = "";
-					while (!feof($file_descriptor)) {
-						$child_response .= fread($file_descriptor, 8192);
+					while (!feof ($file_descriptor)) {
+						$child_response .= fread ($file_descriptor, 8192);
 					}
 					//we have the child data in the parent, but serialized:
-					$child_response = unserialize( $child_response );
+					$child_response = unserialize ($child_response);
 					//store
 					$scan_subnets[$index]->discovered = $child_response;
 					//now, child is dead, and parent close the pipe
-					unlink( $child_pipe );
+					unlink ($child_pipe);
 					unset($threads[$index]);
 				}
 			}
-	        usleep(200000);
+	        usleep (200000);
 	    }
 	}
 
 	//fping finds all subnet addresses, we must remove existing ones !
-	foreach($scan_subnets as $sk=>$s) {
-    	if(isset($s->discovered)) {
-    		foreach($s->discovered as $rk=>$result) {
-    			if(!in_array($Subnets->transform_to_decimal($result), $addresses_tmp[$s->id])) {
+	foreach ($scan_subnets as $sk=>$s) {
+    	if (isset($s->discovered)) {
+    		foreach ($s->discovered as $rk=>$result) {
+    			if (!in_array ($Subnets->transform_to_decimal ($result), $addresses_tmp[$s->id])) {
     				unset($scan_subnets[$sk]->discovered[$rk]);
     			}
     		}
             //rekey
-            $scan_subnets[$sk]->discovered = array_values($scan_subnets[$sk]->discovered);
+            $scan_subnets[$sk]->discovered = array_values ($scan_subnets[$sk]->discovered);
 		}
 	}
 }
 //ping, pear
 else {
 	//run per MAX_THREADS
-    for ($m=0; $m<=$size_addresses; $m += $Scan->settings->scanMaxThreads) {
+    for ($m = 0; $m <= $size_addresses; $m += $Scan->settings->scanMaxThreads) {
         // create threads
-        $threads = array();
+        $threads = array ();
 
         //fork processes
         for ($i = 0; $i <= $Scan->settings->scanMaxThreads && $i <= $size_addresses; $i++) {
         	//only if index exists!
-        	if(isset($addresses[$z])) {
+        	if (isset($addresses[$z])) {
 				//start new thread
-	            $threads[$z] = new Thread( 'ping_address' );
-	            $threads[$z]->start( $Subnets->transform_to_dotted($addresses[$z]['ip_addr']) );
-				$z++;			//next index
+	            $threads[$z] = new Thread ('ping_address');
+	            $threads[$z]->start ($Subnets->transform_to_dotted ($addresses[$z]['ip_addr']));
+				$z++; //next index
 			}
         }
 
         // wait for all the threads to finish
-        while( !empty( $threads ) ) {
-            foreach( $threads as $index => $thread ) {
-                if( ! $thread->isAlive() ) {
+        while (!empty($threads)) {
+            foreach ($threads as $index => $thread) {
+                if (!$thread->isAlive ()) {
 					//unset dead hosts
-					if($thread->getExitCode() != 0) {
+					if ($thread->getExitCode () != 0) {
 						unset($addresses[$index]);
 					}
                     //remove thread
-                    unset( $threads[$index]);
+                    unset($threads[$index]);
                 }
             }
-            usleep(200000);
+            usleep (200000);
         }
 	}
 
 	//ok, we have all available addresses, rekey them
-	foreach($addresses as $a) {
-		$add_tmp[$a['subnetId']][] = $Subnets->transform_to_dotted($a['ip_addr']);
+	foreach ($addresses as $a) {
+		$add_tmp[$a['subnetId']][] = $Subnets->transform_to_dotted ($a['ip_addr']);
 	}
 	//add to scan_subnets as result
-	foreach($scan_subnets as $sk=>$s) {
-		if(isset($add_tmp[$s->id])) {
+	foreach ($scan_subnets as $sk=>$s) {
+		if (isset($add_tmp[$s->id])) {
 			$scan_subnets[$sk]->discovered = $add_tmp[$s->id];
 		}
 	}
@@ -209,34 +209,34 @@ 
 
 
 # print change
-if($Scan->debugging)							{ "\nDiscovered addresses:\n----------\n"; print_r($scan_subnets); }
+if ($Scan->debugging) { "\nDiscovered addresses:\n----------\n"; print_r ($scan_subnets); }
 
 
 
 # reinitialize objects
 $Database 	= new Database_PDO;
-$Admin		= new Admin ($Database, false);
+$Admin = new Admin ($Database, false);
 $Addresses	= new Addresses ($Database);
 $Subnets	= new Subnets ($Database);
-$DNS		= new DNS ($Database);
-$Scan		= new Scan ($Database);
-$Result		= new Result();
+$DNS = new DNS ($Database);
+$Scan = new Scan ($Database);
+$Result		= new Result ();
 
 # insert to database
-$discovered = 0;				//for mailing
+$discovered = 0; //for mailing
 
-foreach($scan_subnets as $s) {
-	if(sizeof(@$s->discovered)>0) {
-		foreach($s->discovered as $ip) {
+foreach ($scan_subnets as $s) {
+	if (sizeof (@$s->discovered) > 0) {
+		foreach ($s->discovered as $ip) {
 			// fetch subnet
 			$subnet = $Subnets->fetch_subnet ("id", $s->id);
-			$nsid = $subnet===false ? false : $subnet->nameserverId;
+			$nsid = $subnet === false ? false : $subnet->nameserverId;
 			// try to resolve hostname
 			$hostname = $DNS->resolve_address ($ip, false, true, $nsid);
 
 			//set update query
-			$values = array("subnetId"=>$s->id,
-							"ip_addr"=>$Subnets->transform_address($ip, "decimal"),
+			$values = array ("subnetId"=>$s->id,
+							"ip_addr"=>$Subnets->transform_address ($ip, "decimal"),
 							"dns_name"=>$hostname['name'],
 							"description"=>"-- autodiscovered --",
 							"note"=>"This host was autodiscovered on ".$nowdate,
@@ -245,7 +245,7 @@ 
 							"action"=>"add"
 							);
 			//insert
-			$Addresses->modify_address($values);
+			$Addresses->modify_address ($values);
 
 			//set discovered
 			$discovered++;
@@ -259,31 +259,31 @@ 
 
 
 # send mail
-if($discovered>0 && $send_mail) {
+if ($discovered > 0 && $send_mail) {
 
 	# check for recipients
-	foreach($Admin->fetch_multiple_objects ("users", "role", "Administrator") as $admin) {
-		if($admin->mailNotify=="Yes") {
-			$recepients[] = array("name"=>$admin->real_name, "email"=>$admin->email);
+	foreach ($Admin->fetch_multiple_objects ("users", "role", "Administrator") as $admin) {
+		if ($admin->mailNotify == "Yes") {
+			$recepients[] = array ("name"=>$admin->real_name, "email"=>$admin->email);
 		}
 	}
 	# none?
-	if(!isset($recepients))	{ die(); }
+	if (!isset($recepients)) { die(); }
 
 	# fetch mailer settings
-	$mail_settings = $Admin->fetch_object("settingsMail", "id", 1);
+	$mail_settings = $Admin->fetch_object ("settingsMail", "id", 1);
 	# fake user object, needed for create_link
-	$User = new StdClass();
+	$User = new StdClass ();
 	@$User->settings->prettyLinks = $Scan->settings->prettyLinks;
 
 	# initialize mailer
-	$phpipam_mail = new phpipam_mail($Scan->settings, $mail_settings);
-	$phpipam_mail->initialize_mailer();
+	$phpipam_mail = new phpipam_mail ($Scan->settings, $mail_settings);
+	$phpipam_mail->initialize_mailer ();
 
 
 
 	// set subject
-	$subject	= "phpIPAM new addresses detected ".date("Y-m-d H:i:s");
+	$subject = "phpIPAM new addresses detected ".date ("Y-m-d H:i:s");
 
 	//html
 	$content[] = "<h3>phpIPAM found $discovered new hosts</h3>";
@@ -296,22 +296,22 @@ 
 	//plain
 	$content_plain[] = "phpIPAM found $discovered new hosts\r\n------------------------------";
 	//Changes
-	foreach($scan_subnets as $s) {
-		if(sizeof(@$s->discovered)>0) {
-			foreach($s->discovered as $ip) {
+	foreach ($scan_subnets as $s) {
+		if (sizeof (@$s->discovered) > 0) {
+			foreach ($s->discovered as $ip) {
 				//set subnet
-				$subnet 	 = $Subnets->fetch_subnet(null, $s->id);
+				$subnet = $Subnets->fetch_subnet (null, $s->id);
 				//set section
-				$section 	 = $Admin->fetch_object("sections", "id", $s->sectionId);
+				$section 	 = $Admin->fetch_object ("sections", "id", $s->sectionId);
 
 				$content[] = "<tr>";
 				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'>$ip</td>";
-				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim($Scan->settings->siteURL, "/")."".create_link("subnets",$section->id,$subnet->id)."'>".$Subnets->transform_to_dotted($subnet->subnet)."/".$subnet->mask." - ".$subnet->description."</a></td>";
-				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim($Scan->settings->siteURL, "/")."".create_link("subnets",$section->id)."'>$section->name $section->description</a></td>";
+				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim ($Scan->settings->siteURL, "/")."".create_link ("subnets", $section->id, $subnet->id)."'>".$Subnets->transform_to_dotted ($subnet->subnet)."/".$subnet->mask." - ".$subnet->description."</a></td>";
+				$content[] = "	<td style='padding:3px 8px;border:1px solid silver;'><a href='".rtrim ($Scan->settings->siteURL, "/")."".create_link ("subnets", $section->id)."'>$section->name $section->description</a></td>";
 				$content[] = "</tr>";
 
 				//plain content
-				$content_plain[] = "\t * $ip (".$Subnets->transform_to_dotted($subnet->subnet)."/".$subnet->mask.")";
+				$content_plain[] = "\t * $ip (".$Subnets->transform_to_dotted ($subnet->subnet)."/".$subnet->mask.")";
 			}
 		}
 	}
@@ -319,25 +319,25 @@ 
 
 
 	# set content
-	$content 		= $phpipam_mail->generate_message (implode("\r\n", $content));
-	$content_plain 	= implode("\r\n",$content_plain);
+	$content = $phpipam_mail->generate_message (implode ("\r\n", $content));
+	$content_plain = implode ("\r\n", $content_plain);
 
 	# try to send
 	try {
-		$phpipam_mail->Php_mailer->setFrom($mail_settings->mAdminMail, $mail_settings->mAdminName);
+		$phpipam_mail->Php_mailer->setFrom ($mail_settings->mAdminMail, $mail_settings->mAdminName);
 		//add all admins to CC
-		foreach($recepients as $admin) {
-			$phpipam_mail->Php_mailer->addAddress(addslashes($admin['email']), addslashes($admin['name']));
+		foreach ($recepients as $admin) {
+			$phpipam_mail->Php_mailer->addAddress (addslashes ($admin['email']), addslashes ($admin['name']));
 		}
 		$phpipam_mail->Php_mailer->Subject = $subject;
-		$phpipam_mail->Php_mailer->msgHTML($content);
+		$phpipam_mail->Php_mailer->msgHTML ($content);
 		$phpipam_mail->Php_mailer->AltBody = $content_plain;
 		//send
-		$phpipam_mail->Php_mailer->send();
+		$phpipam_mail->Php_mailer->send ();
 	} catch (phpmailerException $e) {
-		$Result->show_cli("Mailer Error: ".$e->errorMessage(), true);
+		$Result->show_cli ("Mailer Error: ".$e->errorMessage (), true);
 	} catch (Exception $e) {
-		$Result->show_cli("Mailer Error: ".$e->errorMessage(), true);
+		$Result->show_cli ("Mailer Error: ".$e->errorMessage (), true);
 	}
 }
 

config.dist.php

Indentation +3 added lines, -3 removed lines

@@ -70,9 +70,9 @@
 elseif ($proxy_enabled == true && proxy_use_auth == true) {
     stream_context_set_default(
         array('http' => array(
-              'proxy' => "tcp://$proxy_server:$proxy_port",
-              'request_fulluri' => true,
-              'header' => "Proxy-Authorization: Basic $proxy_auth"
+                'proxy' => "tcp://$proxy_server:$proxy_port",
+                'request_fulluri' => true,
+                'header' => "Proxy-Authorization: Basic $proxy_auth"
         )));
 }
 

Braces +6 added lines, -4 removed lines

@@ -47,14 +47,16 @@
  *  Also change
  *	RewriteBase / in .htaccess
  ******************************/
-if(!defined('BASE'))
-define('BASE', "/");
+if(!defined('BASE')) {
+    define('BASE', "/");
+}
 
 /**
  * Multicast unique mac requirement - section or vlan
  */
-if(!defined('MCUNIQUE'))
-define('MCUNIQUE', "section");
+if(!defined('MCUNIQUE')) {
+    define('MCUNIQUE', "section");
+}
 
 
 /*  proxy connection details

Spacing +19 added lines, -19 removed lines

@@ -18,11 +18,11 @@ 
 
      php 5.3.7 required
 */
-$db['ssl']        = false;                           # true/false, enable or disable SSL as a whole
-$db['ssl_key']    = "/path/to/cert.key";             # path to an SSL key file. Only makes sense combined with ssl_cert
-$db['ssl_cert']   = "/path/to/cert.crt";             # path to an SSL certificate file. Only makes sense combined with ssl_key
-$db['ssl_ca']     = "/path/to/ca.crt";               # path to a file containing SSL CA certs
-$db['ssl_capath'] = "/path/to/ca_certs";             # path to a directory containing CA certs
+$db['ssl']        = false; # true/false, enable or disable SSL as a whole
+$db['ssl_key']    = "/path/to/cert.key"; # path to an SSL key file. Only makes sense combined with ssl_cert
+$db['ssl_cert']   = "/path/to/cert.crt"; # path to an SSL certificate file. Only makes sense combined with ssl_key
+$db['ssl_ca']     = "/path/to/ca.crt"; # path to a file containing SSL CA certs
+$db['ssl_capath'] = "/path/to/ca_certs"; # path to a directory containing CA certs
 $db['ssl_cipher'] = "DHE-RSA-AES256-SHA:AES128-SHA"; # one or more SSL Ciphers
 
 /**
@@ -47,36 +47,36 @@ 
  *  Also change
  *	RewriteBase / in .htaccess
  ******************************/
-if(!defined('BASE'))
-define('BASE', "/");
+if (!defined ('BASE'))
+define ('BASE', "/");
 
 /**
  * Multicast unique mac requirement - section or vlan
  */
-if(!defined('MCUNIQUE'))
-define('MCUNIQUE', "section");
+if (!defined ('MCUNIQUE'))
+define ('MCUNIQUE', "section");
 
 
 /*  proxy connection details
  ******************************/
-$proxy_enabled  = false;                                  # Enable/Disable usage of the Proxy server
-$proxy_server   = "myproxy.something.com";                # Proxy server FQDN or IP
-$proxy_port     = "8080";                                 # Proxy server port
-$proxy_user     = "USERNAME";                             # Proxy Username
-$proxy_pass     = "PASSWORD";                             # Proxy Password
-$proxy_use_auth = false;                                  # Enable/Disable Proxy authentication
+$proxy_enabled  = false; # Enable/Disable usage of the Proxy server
+$proxy_server   = "myproxy.something.com"; # Proxy server FQDN or IP
+$proxy_port     = "8080"; # Proxy server port
+$proxy_user     = "USERNAME"; # Proxy Username
+$proxy_pass     = "PASSWORD"; # Proxy Password
+$proxy_use_auth = false; # Enable/Disable Proxy authentication
 
 /**
  * proxy to use for every internet access like update check
  */
-$proxy_auth     = base64_encode("$proxy_user:$proxy_pass");
+$proxy_auth = base64_encode ("$proxy_user:$proxy_pass");
 
 if ($proxy_enabled == true && $proxy_use_auth == false) {
-    stream_context_set_default(array('http' => array('proxy'=>'tcp://'.$proxy_server.':'.$proxy_port)));
+    stream_context_set_default (array ('http' => array ('proxy'=>'tcp://'.$proxy_server.':'.$proxy_port)));
 }
 elseif ($proxy_enabled == true && $proxy_use_auth == true) {
-    stream_context_set_default(
-        array('http' => array(
+    stream_context_set_default (
+        array ('http' => array (
               'proxy' => "tcp://$proxy_server:$proxy_port",
               'request_fulluri' => true,
               'header' => "Proxy-Authorization: Basic $proxy_auth"