Completed
Pull Request — master (#33)
by
unknown
03:17
created
src/Phpforce/SoapClient/BulkSaver.php 2 patches
Doc Comments   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -165,8 +165,7 @@  discard block
 block discarded – undo
165 165
     /**
166 166
      * Add a record to the create queue
167 167
      *
168
-     * @param sObject $sObject
169
-     * @param type $objectType
168
+     * @param string $objectType
170 169
      */
171 170
     private function addBulkCreateRecord($record, $objectType)
172 171
     {
@@ -183,7 +182,6 @@  discard block
 block discarded – undo
183 182
      *
184 183
      * (Delete calls
185 184
      *
186
-     * @param string $id
187 185
      */
188 186
     private function addBulkDeleteRecord($record)
189 187
     {
@@ -215,6 +213,7 @@  discard block
 block discarded – undo
215 213
      *
216 214
      * @param sObject $sObject
217 215
      * @param string $objectType
216
+     * @param string $matchField
218 217
      */
219 218
     private function addBulkUpsertRecord($sObject, $objectType, $matchField)
220 219
     {
@@ -245,7 +244,7 @@  discard block
 block discarded – undo
245 244
     /**
246 245
      * Flush deletes
247 246
      *
248
-     * @return SaveResult[]
247
+     * @return Result\DeleteResult[]
249 248
      */
250 249
     private function flushDeletes()
251 250
     {
@@ -264,7 +263,7 @@  discard block
 block discarded – undo
264 263
      * Flush updates
265 264
      *
266 265
      * @param string $objectType
267
-     * @return SaveResult
266
+     * @return SaveResult[]
268 267
      */
269 268
     private function flushUpdates($objectType)
270 269
     {
@@ -278,7 +277,7 @@  discard block
 block discarded – undo
278 277
      * Flush upserts
279 278
      *
280 279
      * @param string $objectType
281
-     * @return SaveResult[]
280
+     * @return Result\UpsertResult[]
282 281
      */
283 282
     private function flushUpserts($objectType)
284 283
     {
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -194,12 +194,12 @@  discard block
 block discarded – undo
194 194
         $this->bulkDeleteRecords[] = $record;
195 195
     }
196 196
 
197
-     /**
198
-     * Add a record to the update queue
199
-     *
200
-     * @param sObject $sObject
201
-     * @param string $objectType
202
-     */
197
+        /**
198
+         * Add a record to the update queue
199
+         *
200
+         * @param sObject $sObject
201
+         * @param string $objectType
202
+         */
203 203
     private function addBulkUpdateRecord($sObject, $objectType)
204 204
     {
205 205
         if (isset($this->bulkUpdateRecords[$objectType])
@@ -228,12 +228,12 @@  discard block
 block discarded – undo
228 228
         $this->bulkUpsertRecords[$objectType][] = $sObject;
229 229
     }
230 230
 
231
-     /**
232
-     * Flush creates
233
-     *
234
-     * @param string $objectType
235
-     * @return SaveResult[]
236
-     */
231
+        /**
232
+         * Flush creates
233
+         *
234
+         * @param string $objectType
235
+         * @return SaveResult[]
236
+         */
237 237
     private function flushCreates($objectType)
238 238
     {
239 239
         $result = $this->client->create($this->bulkCreateRecords[$objectType], $objectType);
Please login to merge, or discard this patch.
src/Phpforce/SoapClient/BulkSaverInterface.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     /**
10 10
      * Save a record in bulk
11 11
      *
12
-     * @param object $record
13 12
      * @param string $objectType  The record type, e.g., Account
14 13
      * @param string $matchField  Optional match field for upserts
15 14
      * @return BulkSaver
Please login to merge, or discard this patch.
src/Phpforce/SoapClient/Client.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -204,6 +204,9 @@  discard block
 block discarded – undo
204 204
 
205 205
     /**
206 206
      * {@inheritdoc}
207
+     * @param string $username
208
+     * @param string $password
209
+     * @param string $token
207 210
      */
208 211
     public function doLogin($username, $password, $token)
209 212
     {
@@ -657,7 +660,7 @@  discard block
 block discarded – undo
657 660
      * @param object $object     Any object with public properties
658 661
      * @param string $objectType Salesforce object type
659 662
      *
660
-     * @return object
663
+     * @return \stdClass
661 664
      */
662 665
     protected function createSObject($object, $objectType)
663 666
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
             $xml = '';
468 468
             if (isset($sObject->fieldsToNull)) {
469 469
                 foreach ($sObject->fieldsToNull as $fieldToNull) {
470
-                    $xml .= '<fieldsToNull>' . $fieldToNull . '</fieldsToNull>';
470
+                    $xml .= '<fieldsToNull>'.$fieldToNull.'</fieldsToNull>';
471 471
                 }
472 472
                 $fieldsToNullVar = new \SoapVar(new \SoapVar($xml, XSD_ANYXML), SOAP_ENC_ARRAY);
473 473
                 $sObject->fieldsToNull = $fieldsToNullVar;
@@ -494,7 +494,7 @@  discard block
 block discarded – undo
494 494
         {
495 495
             $xml = '';
496 496
             foreach ($object->enc_value->fieldsToNull as $fieldToNull) {
497
-                $xml .= '<fieldsToNull>' . $fieldToNull . '</fieldsToNull>';
497
+                $xml .= '<fieldsToNull>'.$fieldToNull.'</fieldsToNull>';
498 498
             }
499 499
             return new \SoapVar(new \SoapVar($xml, XSD_ANYXML), SOAP_ENC_ARRAY);
500 500
         }
@@ -679,12 +679,12 @@  discard block
 block discarded – undo
679 679
             switch ($type) {
680 680
                 case 'date':
681 681
                     if ($value instanceof \DateTime) {
682
-                        $value  = $value->format('Y-m-d');
682
+                        $value = $value->format('Y-m-d');
683 683
                     }
684 684
                     break;
685 685
                 case 'dateTime':
686 686
                     if ($value instanceof \DateTime) {
687
-                        $value  = $value->format('Y-m-d\TH:i:sP');
687
+                        $value = $value->format('Y-m-d\TH:i:sP');
688 688
                     }
689 689
                     break;
690 690
                 case 'base64Binary':
Please login to merge, or discard this patch.
src/Phpforce/SoapClient/Result/RecordIterator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@
 block discarded – undo
45 45
     /**
46 46
      * Construct a record iterator
47 47
      *
48
-     * @param client $client
49
-     * @param string $result
48
+     * @param Client $client
49
+     * @param QueryResult $result
50 50
      */
51 51
     public function __construct(Client $client, QueryResult $result)
52 52
     {
Please login to merge, or discard this patch.
src/Phpforce/SoapClient/EventListener/LogTransactionListener.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
     {
43 43
         $error = $event->getError();
44 44
         $this->logger->err('[Salesforce] error: ' . $error->statusCode . ' - '
45
-                           . $error->message, get_object_vars($error));
45
+                            . $error->message, get_object_vars($error));
46 46
     }
47 47
 
48 48
     public function setLogging($logging)
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,13 +35,13 @@
 block discarded – undo
35 35
 
36 36
     public function onSalesforceClientSoapFault(Event\SoapFaultEvent $event)
37 37
     {
38
-        $this->logger->err('[Salesforce] fault: ' . $event->getSoapFault()->getMessage());
38
+        $this->logger->err('[Salesforce] fault: '.$event->getSoapFault()->getMessage());
39 39
     }
40 40
 
41 41
     public function onSalesforceClientError(Event\ErrorEvent $event)
42 42
     {
43 43
         $error = $event->getError();
44
-        $this->logger->err('[Salesforce] error: ' . $error->statusCode . ' - '
44
+        $this->logger->err('[Salesforce] error: '.$error->statusCode.' - '
45 45
                            . $error->message, get_object_vars($error));
46 46
     }
47 47
 
Please login to merge, or discard this patch.
src/Phpforce/SoapClient/Soap/TypeConverter/TypeConverterCollection.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      */
52 52
     public function set(TypeConverterInterface $converter)
53 53
     {
54
-        $this->converters[$converter->getTypeNamespace() . ':'
54
+        $this->converters[$converter->getTypeNamespace().':'
55 55
             . $converter->getTypeName()] = $converter;
56 56
 
57 57
         return $this;
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     public function has($namespace, $name)
70 70
     {
71
-        if (isset($this->converters[$namespace . ':' . $name])) {
71
+        if (isset($this->converters[$namespace.':'.$name])) {
72 72
             return true;
73 73
         }
74 74
 
Please login to merge, or discard this patch.