FormCommentUpdate::rules() - Code Metrics - Inspection of "Comments admin side, fixes, etc" - phpffcms/ffcms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( aaaee4...c2a29b )

by Mihail

created 2016-03-26 21:08 UTC

FormCommentUpdate::rules() A

↳ Parent: FormCommentUpdate

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	8
loc	8
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Apps\Model\Admin\Comments;

use Ffcms\Core\Arch\Model;

class FormCommentUpdate extends Model
{
    public $message;
    public $guestName;
    
    /** @var Apps\ActiveRecord\CommentPost|Apps\ActiveRecord\CommentAnswer $_record */
    private $_record;
    private $type;
    
    /**
     * FormCommentUpdate constructor. Pass record inside the model.
     * @param Apps\ActiveRecord\CommentPost|Apps\ActiveRecord\CommentAnswer $record
     */
    public function __construct($record, $type = 'comment')

    {
        $this->_record = $record;
        parent::__construct();
    }
    
    /**
    * Set default values from active record data
    */
    public function before()
    {
        $this->message = $this->_record->message;
        $this->guestName = $this->_record->guest_name;
    }

    /**
    * Labels to display in view
    */
    public function labels()
    {
        return [
            'message' => __('Message'),
            'guestName' => __('Guest name')
        ];
    }

    /**
    * Validation rules for comment body
    */
    public function rules()

    {
        return [
            ['message', 'required'],
            ['guestName', 'used'],
            ['guestName', 'length_max', 100]
        ];
    }
    
    /**
     * Save updated data to database
     */
    public function make()
    {
        $this->_record->message = $this->message;
        $this->_record->guest_name = $this->guestName;
        $this->_record->save();
    }
    
    public function getCommentId()
    {
        $id = $this->_record->id;
        if ($this->type === 'answer') {
            $id = $this->_record->getCommentPost()->id;
        }
        
        return $id;
    }
}

1		<?php
2
3		namespace Apps\Model\Admin\Comments;
4
5		use Ffcms\Core\Arch\Model;
6
7		class FormCommentUpdate extends Model
8		{
9		public $message;
10		public $guestName;
11
12		/** @var Apps\ActiveRecord\CommentPost\|Apps\ActiveRecord\CommentAnswer $_record */
13		private $_record;
14		private $type;
15
16		/**
17		* FormCommentUpdate constructor. Pass record inside the model.
18		* @param Apps\ActiveRecord\CommentPost\|Apps\ActiveRecord\CommentAnswer $record
19		*/
20		public function __construct($record, $type = 'comment')
		0 ignored issues – show Unused Code introduced 2016-03-26 21:12 UTC by Report Bug Copy Issue Report The parameter `$type` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21		{
22		$this->_record = $record;
23		parent::__construct();
24		}
25
26		/**
27		* Set default values from active record data
28		*/
29		public function before()
30		{
31		$this->message = $this->_record->message;
32		$this->guestName = $this->_record->guest_name;
33		}
34
35		/**
36		* Labels to display in view
37		*/
38		public function labels()
39		{
40		return [
41		'message' => __('Message'),
42		'guestName' => __('Guest name')
43		];
44		}
45
46		/**
47		* Validation rules for comment body
48		*/
49	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2016-03-26 21:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51		return [
52		['message', 'required'],
53		['guestName', 'used'],
54		['guestName', 'length_max', 100]
55		];
56		}
57
58		/**
59		* Save updated data to database
60		*/
61		public function make()
62		{
63		$this->_record->message = $this->message;
64		$this->_record->guest_name = $this->guestName;
65		$this->_record->save();
66		}
67
68		public function getCommentId()
69		{
70		$id = $this->_record->id;
71		if ($this->type === 'answer') {
72		$id = $this->_record->getCommentPost()->id;
73		}
74
75		return $id;
76		}
77		}

phpffcms / ffcms

Push — master ( aaaee4...c2a29b )

FormCommentUpdate::rules() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like