Apps\Model\Admin\Comments\FormCommentUpdate

Complexity

Total Complexity

7

Size/Duplication

Total Lines	71
Duplicated Lines	11.27 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	before()	0	5	1
A	labels()	0	7	1
A	rules()	8	8	1
A	make()	0	6	1
A	getCommentId()	0	9	2

<?php

namespace Apps\Model\Admin\Comments;

use Ffcms\Core\Arch\Model;

class FormCommentUpdate extends Model
{
    public $message;
    public $guestName;
    
    /** @var Apps\ActiveRecord\CommentPost|Apps\ActiveRecord\CommentAnswer $_record */
    private $_record;
    private $type;
    
    /**
     * FormCommentUpdate constructor. Pass record inside the model.
     * @param Apps\ActiveRecord\CommentPost|Apps\ActiveRecord\CommentAnswer $record
     */
    public function __construct($record, $type = 'comment')

The parameter $type is not used and could be removed.

    {
        $this->_record = $record;
        parent::__construct();
    }
    
    /**
    * Set default values from active record data
    */
    public function before()
    {
        $this->message = $this->_record->message;
        $this->guestName = $this->_record->guest_name;
    }

    /**
    * Labels to display in view
    */
    public function labels()
    {
        return [
            'message' => __('Message'),
            'guestName' => __('Guest name')
        ];
    }

    /**
    * Validation rules for comment body
    */
    public function rules()

This method seems to be duplicated in your project.

    {
        return [
            ['message', 'required'],
            ['guestName', 'used'],
            ['guestName', 'length_max', 100]
        ];
    }
    
    /**
     * Save updated data to database
     */
    public function make()
    {
        $this->_record->message = $this->message;
        $this->_record->guest_name = $this->guestName;
        $this->_record->save();
    }
    
    public function getCommentId()
    {
        $id = $this->_record->id;
        if ($this->type === 'answer') {
            $id = $this->_record->getCommentPost()->id;
        }
        
        return $id;
    }
}