phpffcms / ffcms-core

src/App.php

Unused Use Statements -4 removed lines

@@ -6,16 +6,12 @@
 use Ffcms\Core\Cache\MemoryObject;
 use Ffcms\Core\Debug\DebugMeasure;
 use Ffcms\Core\Debug\Manager as Debug;
-use Ffcms\Core\Exception\ForbiddenException;
-use Ffcms\Core\Exception\JsonException;
 use Ffcms\Core\Exception\NativeException;
 use Ffcms\Core\Exception\NotFoundException;
-use Ffcms\Core\Exception\SyntaxException;
 use Ffcms\Core\Exception\TemplateException;
 use Ffcms\Core\Helper\Mailer;
 use Ffcms\Core\Helper\Security;
 use Ffcms\Core\Helper\Type\Any;
-use Ffcms\Core\Helper\Type\Obj;
 use Ffcms\Core\Helper\Type\Str;
 use Ffcms\Core\I18n\Translate;
 use Ffcms\Core\Managers\BootManager;

Spacing +9 added lines, -9 removed lines

@@ -187,24 +187,24 @@ 
         $html = null;
         // lets try to get html full content to page render
         try {
-            $this->startMeasure(__METHOD__ . '::callback');
+            $this->startMeasure(__METHOD__.'::callback');
             /** @var \Ffcms\Core\Arch\Controller $callClass */
             $callClass = null;
-            $callMethod = 'action' . self::$Request->getAction();
+            $callMethod = 'action'.self::$Request->getAction();
 
             // define callback class namespace/name full path
-            $cName = (self::$Request->getCallbackAlias() ?? '\Apps\Controller\\' . env_name . '\\' . self::$Request->getController());
+            $cName = (self::$Request->getCallbackAlias() ?? '\Apps\Controller\\'.env_name.'\\'.self::$Request->getController());
             if (!class_exists($cName)) {
-                throw new NotFoundException('Callback class not found: ' . App::$Security->strip_tags($cName));
+                throw new NotFoundException('Callback class not found: '.App::$Security->strip_tags($cName));
             }
 
             $callClass = new $cName;
             // check if callback method (action) is exist in class object
             if (!method_exists($callClass, $callMethod)) {
-                throw new NotFoundException('Method "' . App::$Security->strip_tags($callMethod) . '()" not founded in "' . get_class($callClass) . '"');
+                throw new NotFoundException('Method "'.App::$Security->strip_tags($callMethod).'()" not founded in "'.get_class($callClass).'"');
             }
 
-            $this->stopMeasure(__METHOD__ . '::callback');
+            $this->stopMeasure(__METHOD__.'::callback');
             $params = [];
             if (!Str::likeEmpty(self::$Request->getID())) {
                 $params[] = self::$Request->getID();
@@ -231,10 +231,10 @@ 
                 ]));
             }
 
-            $this->startMeasure($cName . '::' . $callMethod);
+            $this->startMeasure($cName.'::'.$callMethod);
             // make callback call to action in controller and get response
             $actionResponse = call_user_func_array([$callClass, $callMethod], $params);
-            $this->stopMeasure($cName . '::' . $callMethod);
+            $this->stopMeasure($cName.'::'.$callMethod);
 
             // set response to controller attribute
             if (!Str::likeEmpty($actionResponse)) {
@@ -249,7 +249,7 @@ 
                 $html = $e->display();
             } else { // or hook exception to system based :)))
                 if (App::$Debug) {
-                    $msg = $e->getMessage() . $e->getTraceAsString();
+                    $msg = $e->getMessage().$e->getTraceAsString();
                     $html = (new NativeException($msg))->display();
                 } else {
                     $html = (new NativeException($e->getMessage()))->display();

src/Arch/Model.php

Doc Comments +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
     /**
      * Get label value by variable name
      * @param string $param
-     * @return mixed
+     * @return string
      */
     final public function getLabel($param)
     {
@@ -65,7 +65,7 @@ 
 
     /**
      * Set attribute labels for model variables
-     * @return array
+     * @return string
      */
     public function labels(): array
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Ffcms\Core\App;
 use Ffcms\Core\Exception\SyntaxException;
 use Ffcms\Core\Helper\Type\Any;
-use Ffcms\Core\Helper\Type\Obj;
 use Ffcms\Core\Helper\Type\Str;
 use Ffcms\Core\Interfaces\iModel;
 use Ffcms\Core\Traits\DynamicGlobal;

src/Arch/View.php

Doc Comments +1 added lines, -1 removed lines

@@ -249,7 +249,7 @@
     /**
      * Show custom code library link
      * @param string $type - js or css allowed
-     * @return array|null|string
+     * @return null|string
      */
     public function showCodeLink(string $type)
     {

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Ffcms\Core\Helper\FileSystem\File;
 use Ffcms\Core\Helper\FileSystem\Normalize;
 use Ffcms\Core\Helper\Type\Any;
-use Ffcms\Core\Helper\Type\Obj;
 use Ffcms\Core\Helper\Type\Str;
 use Ffcms\Core\Template\Variables;
 use Ffcms\Core\Traits\DynamicGlobal;

Spacing +16 added lines, -16 removed lines

@@ -55,16 +55,16 @@ 
         $this->lang = App::$Request->getLanguage();
         // get theme config and build full path
         $themeConfig = App::$Properties->get('theme');
-        $this->themePath = root . DIRECTORY_SEPARATOR . 'Apps' . DIRECTORY_SEPARATOR . 'View' . DIRECTORY_SEPARATOR . env_name;
+        $this->themePath = root.DIRECTORY_SEPARATOR.'Apps'.DIRECTORY_SEPARATOR.'View'.DIRECTORY_SEPARATOR.env_name;
         if (isset($themeConfig[env_name]) && Str::length($themeConfig[env_name]) > 0) {
-            $this->themePath .=  DIRECTORY_SEPARATOR . $themeConfig[env_name];
+            $this->themePath .= DIRECTORY_SEPARATOR.$themeConfig[env_name];
         } else {
-            $this->themePath .= DIRECTORY_SEPARATOR . 'default';
+            $this->themePath .= DIRECTORY_SEPARATOR.'default';
         }
 
         // check if theme is available
         if (!Directory::exist($this->themePath)) {
-            throw new NativeException('Apps theme is not founded: ' . Str::replace(root, null, $this->themePath));
+            throw new NativeException('Apps theme is not founded: '.Str::replace(root, null, $this->themePath));
         }
 
         // get input args and build class properties
@@ -106,7 +106,7 @@ 
         
         // path still not defined?
         if (!$path) {
-            throw new SyntaxException('View not found: ' . App::$Security->strip_tags($path));
+            throw new SyntaxException('View not found: '.App::$Security->strip_tags($path));
         }
 
         // cleanup from slashes on start/end
@@ -135,7 +135,7 @@ 
             // lets try to get full path for current theme
             $tmpPath = $path;
             if (!Str::startsWith($this->themePath, $path)) {
-                $tmpPath = Normalize::diskPath($this->themePath . '/' . $path . '.php');
+                $tmpPath = Normalize::diskPath($this->themePath.'/'.$path.'.php');
             }
         } else { // sounds like a object-depended view call from controller or etc
             // get stack trace of callbacks
@@ -151,14 +151,14 @@ 
 
             // depended controller is not founded? Let finish
             if (!$calledController) {
-                throw new SyntaxException('View render is failed: callback controller not founded! Call with relative path: ' . $path);
+                throw new SyntaxException('View render is failed: callback controller not founded! Call with relative path: '.$path);
             }
 
             // get controller name
-            $controllerName = Str::sub($calledController, Str::length('Apps\Controller\\' . env_name . '\\'));
+            $controllerName = Str::sub($calledController, Str::length('Apps\Controller\\'.env_name.'\\'));
             $controllerName = Str::lowerCase($controllerName);
             // get full path
-            $tmpPath = $this->themePath . DIRECTORY_SEPARATOR . $controllerName . DIRECTORY_SEPARATOR . $path . '.php';
+            $tmpPath = $this->themePath.DIRECTORY_SEPARATOR.$controllerName.DIRECTORY_SEPARATOR.$path.'.php';
         }
 
         // check if builded view full path is exist
@@ -168,11 +168,11 @@ 
 
         // hmm, not founded. Lets try to find in caller directory (for widgets, apps packages and other)
         if ($source !== null) {
-            $tmpPath = Normalize::diskPath($source . DIRECTORY_SEPARATOR . $path . '.php');
+            $tmpPath = Normalize::diskPath($source.DIRECTORY_SEPARATOR.$path.'.php');
             if (File::exist($tmpPath)) {
                 // add notify for native views
                 if (App::$Debug) {
-                    App::$Debug->addMessage('Render native viewer: ' . Str::replace(root, null, $tmpPath), 'info');
+                    App::$Debug->addMessage('Render native viewer: '.Str::replace(root, null, $tmpPath), 'info');
                 }
 
                 return $tmpPath;
@@ -180,7 +180,7 @@ 
         }
 
         if (App::$Debug) {
-            App::$Debug->addMessage('Viewer not founded on rendering: ' . $path, 'warning');
+            App::$Debug->addMessage('Viewer not founded on rendering: '.$path, 'warning');
         }
 
         return null;
@@ -276,7 +276,7 @@ 
         foreach ($items as $item) {
             $item = trim($item, '/');
             if (!Str::startsWith(App::$Alias->scriptUrl, $item) && !Str::startsWith('http', $item)) { // is local without proto and domain
-                $item = App::$Alias->scriptUrl . '/' . $item;
+                $item = App::$Alias->scriptUrl.'/'.$item;
             }
             $output[] = $item;
         }
@@ -285,9 +285,9 @@ 
         $output = null;
         foreach ($clear as $row) {
             if ($type === 'css') {
-                $output .= '<link rel="stylesheet" type="text/css" href="' . $row . '">' . "\n";
+                $output .= '<link rel="stylesheet" type="text/css" href="'.$row.'">'."\n";
             } elseif ($type === 'js') {
-                $output .= '<script src="' . $row . '"></script>' . "\n";
+                $output .= '<script src="'.$row.'"></script>'."\n";
             }
         }
 
@@ -310,7 +310,7 @@ 
 
         $code = null;
         foreach (App::$Alias->getPlainCode($type) as $row) {
-            $code .= $row . "\n";
+            $code .= $row."\n";
         }
 
         return $code;

src/Arch/Widget.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Apps\ActiveRecord\App as AppRecord;
 use Ffcms\Core\Helper\Type\Any;
-use Ffcms\Core\Helper\Type\Obj;
 use Ffcms\Core\Helper\Type\Str;
 use Ffcms\Core\Interfaces\iWidget;
 use Ffcms\Core\Traits\DynamicGlobal;

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 
         // check if class exist
         if (!class_exists(self::$class)) {
-            return 'Error: Widget is not founded: ' . self::$class;
+            return 'Error: Widget is not founded: '.self::$class;
         }
 
         // init class and pass properties

src/Debug/Manager.php

Unused Use Statements -2 removed lines

@@ -5,10 +5,8 @@
 use Cassandra\Exception;
 use DebugBar\DataCollector\ConfigCollector;
 use DebugBar\DebugBarException;
-use DebugBar\StandardDebugBar;
 use Ffcms\Core\App;
 use Ffcms\Core\Helper\Type\Any;
-use Ffcms\Core\Helper\Type\Obj;
 
 /**
  * Class Debug. Provide methods of display information about debug and collected data in debug bar

src/Helper/FileSystem/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
     /**
      * Get file md5 hash
      * @param string $path
-     * @return bool|string
+     * @return false|string
      */
     public static function getMd5($path)
     {

Spacing +3 added lines, -3 removed lines

@@ -192,15 +192,15 @@
             return [];
         }
 
-        $dir = opendir($path . '/.');
+        $dir = opendir($path.'/.');
         while ($item = readdir($dir)) {
-            if (is_file($sub = $path . '/' . $item)) {
+            if (is_file($sub = $path.'/'.$item)) {
                 $item_ext = Str::lastIn($item, '.');
                 if ($ext === null || Arr::in($item_ext, $ext)) {
                     if ($returnRelative) {
                         $files[] = $item;
                     } else {
-                        $files[] = $path . DIRECTORY_SEPARATOR . $item;
+                        $files[] = $path.DIRECTORY_SEPARATOR.$item;
                     }
                 }
             } else {

src/Helper/HTML/Bootstrap/Nav.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Ffcms\Core\Helper\HTML\System\NativeGenerator;
 use Ffcms\Core\Helper\Type\Any;
 use Ffcms\Core\Helper\Type\Arr;
-use Ffcms\Core\Helper\Type\Obj;
 use Ffcms\Core\Helper\Type\Str;
 
 class Nav extends NativeGenerator

Spacing +9 added lines, -9 removed lines

@@ -62,7 +62,7 @@ 
             } elseif ($item['type'] === 'tab') {
                 $activeObject = false;
                 $item['type'] = 'link'; // fix for global Listing builder
-                $item['link'] = '#' . $elements['tabAnchor'] . $tabIdx;
+                $item['link'] = '#'.$elements['tabAnchor'].$tabIdx;
 
                 $item['property']['role'] = 'presentation';
 
@@ -77,11 +77,11 @@ 
 
                 // mark active tab
                 if ($activeObject === true) {
-                    $item['property']['class'] .= (Str::length($item['property']['class']) > 0 ? ' ' : null) . 'active';
+                    $item['property']['class'] .= (Str::length($item['property']['class']) > 0 ? ' ' : null).'active';
                 }
 
                 // tab special properties for bootstrap
-                $item['linkProperty']['aria-controls'] = $elements['tabAnchor'] . $tabIdx;
+                $item['linkProperty']['aria-controls'] = $elements['tabAnchor'].$tabIdx;
                 $item['linkProperty']['role'] = 'tab';
                 $item['linkProperty']['data-toggle'] = 'tab';
 
@@ -90,7 +90,7 @@ 
                 $items[] = $item;
 
                 // draw tab content
-                $tabContent .= $dom->div(function () use ($item, $itemContent) {
+                $tabContent .= $dom->div(function() use ($item, $itemContent) {
                     if ($item['html'] === true) {
                         if ($item['!secure'] === true) {
                             return $itemContent;
@@ -100,7 +100,7 @@ 
                     } else {
                         return self::nohtml($itemContent);
                     }
-                }, ['role' => 'tabpanel', 'class' => 'tab-pane fade' . ($activeObject === true ? ' in active' : null), 'id' => $elements['tabAnchor'] . $tabIdx]);
+                }, ['role' => 'tabpanel', 'class' => 'tab-pane fade'.($activeObject === true ? ' in active' : null), 'id' => $elements['tabAnchor'].$tabIdx]);
                 $tabIdx++;
             }
         }
@@ -108,14 +108,14 @@ 
         // check if global class "nav" isset
         if ($elements['property']['class'] !== null) {
             if (!Str::contains('nav ', $elements['property']['class'])) {
-                $elements['property']['class'] = 'nav ' . $elements['property']['class'];
+                $elements['property']['class'] = 'nav '.$elements['property']['class'];
             }
         } else {
             $elements['property']['class'] = 'nav';
         }
 
         // render final output
-        return $dom->div(function () use ($elements, $items, $tabContent, $dom) {
+        return $dom->div(function() use ($elements, $items, $tabContent, $dom) {
             // drow listing
             $listing = Listing::display([
                 'type' => 'ul',
@@ -128,11 +128,11 @@ 
                     $elements['tabProperty']['class'] = 'tab-content';
                 }
 
-                $tabContent = $dom->div(function () use ($tabContent) {
+                $tabContent = $dom->div(function() use ($tabContent) {
                     return $tabContent;
                 }, $elements['tabProperty']);
             }
-            return $listing . $tabContent;
+            return $listing.$tabContent;
         }, $blockProperty);
     }
 }

src/Helper/HTML/Form.php

Unused Use Statements -5 removed lines

@@ -4,16 +4,11 @@
 
 use Ffcms\Core\App;
 use Ffcms\Core\Arch\Model;
-use Ffcms\Core\Exception\NativeException;
 use Ffcms\Core\Exception\SyntaxException;
 use Ffcms\Core\Helper\FileSystem\File;
-use Ffcms\Core\Helper\HTML\Form\Constructor;
 use Ffcms\Core\Helper\HTML\Form\FieldSelector;
 use Ffcms\Core\Helper\HTML\System\NativeGenerator;
 use Ffcms\Core\Helper\Type\Any;
-use Ffcms\Core\Helper\Type\Arr;
-use Ffcms\Core\Helper\Type\Obj;
-use Ffcms\Core\Helper\Type\Str;
 
 /**
  * Class Form. Simple HTML model generator for fast form building.

Spacing +5 added lines, -5 removed lines

@@ -89,7 +89,7 @@ 
     {
         $form = self::buildSingleTag('form', $this->formProperty, false);
         if ($this->model->_tokenRequired) {
-            $form .= PHP_EOL . $this->field->hidden('_csrf_token', ['value' => $this->model->_csrf_token]);
+            $form .= PHP_EOL.$this->field->hidden('_csrf_token', ['value' => $this->model->_csrf_token]);
         }
 
         return $form;
@@ -124,7 +124,7 @@ 
     public function submitButton($title, array $property = [])
     {
         $property['type'] = 'submit';
-        $property['name'] = $this->name . '[submit]';
+        $property['name'] = $this->name.'[submit]';
         $property['value'] = $title;
         return self::buildSingleTag('input', $property);
     }
@@ -138,10 +138,10 @@ 
     {
         // pre-validate form fields based on model rules and jquery.validation
         if ($validate) {
-            App::$Alias->addPlainCode('js', '$().ready(function() { $("#' . $this->name . '").validate(); });');
+            App::$Alias->addPlainCode('js', '$().ready(function() { $("#'.$this->name.'").validate(); });');
             App::$Alias->setCustomLibrary('js', '/vendor/bower/jquery-validation/dist/jquery.validate.min.js');
             if (App::$Request->getLanguage() !== 'en') {
-                $localeFile = '/vendor/bower/jquery-validation/src/localization/messages_' . App::$Request->getLanguage() . '.js';
+                $localeFile = '/vendor/bower/jquery-validation/src/localization/messages_'.App::$Request->getLanguage().'.js';
                 if (File::exist($localeFile)) {
                     App::$Alias->setCustomLibrary('js', $localeFile);
                 }
@@ -152,7 +152,7 @@ 
                 $formName = $this->model->getFormName();
                 if (Any::isArray($badAttr) && count($badAttr) > 0) {
                     foreach ($badAttr as $attr) {
-                        $itemId = $formName . '-' . $attr;
+                        $itemId = $formName.'-'.$attr;
                         try {
                             $render = App::$View->render(static::$structLayer['jsnotify'], ['itemId' => $itemId]);
                             App::$Alias->addPlainCode('js', $render);

src/Helper/HTML/Form/Constructor.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     }
 
     /**
-     * @param string|array $name
+     * @param string $name
      * @param string|array|null $value
      * @param array|null $properties
      * @return null|string

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Ffcms\Core\App;
 use Ffcms\Core\Arch\Model;
-use Ffcms\Core\Exception\SyntaxException;
 use Ffcms\Core\Helper\Type\Any;
-use Ffcms\Core\Helper\Type\Obj;
 use Ffcms\Core\Helper\Type\Str;
 
 /**

Spacing +5 added lines, -5 removed lines

@@ -108,7 +108,7 @@ 
                 break;
             default:
                 if (App::$Debug) {
-                    App::$Debug->addMessage('Field has unknown type: ' . App::$Security->strip_tags($name));
+                    App::$Debug->addMessage('Field has unknown type: '.App::$Security->strip_tags($name));
                 }
         }
 
@@ -160,12 +160,12 @@ 
         if (Str::contains('.', $name)) {
             $splitedName = explode('.', $name);
             foreach ($splitedName as $nameKey) {
-                $properties['name'] .= '[' . $nameKey . ']';
-                $properties['id'] .= '-' . $nameKey;
+                $properties['name'] .= '['.$nameKey.']';
+                $properties['id'] .= '-'.$nameKey;
             }
         } else { // standard property definition - add field name
-            $properties['name'] .= '[' . $name . ']';
-            $properties['id'] .= '-' . $name;
+            $properties['name'] .= '['.$name.']';
+            $properties['id'] .= '-'.$name;
         }
     }
 }