Completed
Push — 3.1.x ( 390ae3...4da32f )
by Matt
02:09
created
ext.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@
 block discarded – undo
117 117
 	 * Notification handler to call notification enable/disable/purge steps
118 118
 	 *
119 119
 	 * @param string $step               The step (enable, disable, purge)
120
-	 * @param array  $notification_types The notification type names
120
+	 * @param string[]  $notification_types The notification type names
121 121
 	 * @return string Return notifications as temporary state
122 122
 	 * @access protected
123 123
 	 */
Please login to merge, or discard this patch.
conditions/type/base.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -258,8 +258,7 @@
 block discarded – undo
258 258
 			if ($group_rule['autogroups_group_id'] == $current_rule['autogroups_group_id'] &&
259 259
 				$group_rule['autogroups_type_id'] != $current_rule['autogroups_type_id'] &&
260 260
 				sizeof($user_id_ary)
261
-			)
262
-			{
261
+			) {
263 262
 				// Load other auto group rule's condition type and get new data for our user(s)
264 263
 				$condition = $this->container->get($group_rule['autogroups_type_name']);
265 264
 				$condition_user_data = $condition->get_users_for_condition(array(
Please login to merge, or discard this patch.
controller/admin_controller.php 1 patch
Braces   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -254,11 +254,14 @@
 block discarded – undo
254 254
 			trigger_error($this->user->lang('ACP_AUTOGROUPS_INVALID_RANGE') . adm_back_link($this->u_action), E_USER_WARNING);
255 255
 		}
256 256
 
257
-		if ($autogroups_id != 0) // Update existing auto group data
257
+		if ($autogroups_id != 0)
258
+		{
259
+			// Update existing auto group data
258 260
 		{
259 261
 			$sql = 'UPDATE ' . $this->autogroups_rules_table . '
260 262
 				SET ' . $this->db->sql_build_array('UPDATE', $data) . '
261 263
 				WHERE autogroups_id = ' . (int) $autogroups_id;
264
+		}
262 265
 			$this->db->sql_query($sql);
263 266
 		}
264 267
 		else // Insert new auto group data
Please login to merge, or discard this patch.