Ubiquity\annotations\BaseAnnotationTrait::getPropertiesAndValues()

Complexity

Conditions	8
Paths	8

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function getPropertiesAndValues($props = NULL) {
		$ret = [];
		$defaultParameters=$this->getDefaultParameters();

It seems like getDefaultParameters() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		if (\is_null ( $props ))
			$props = $this->getProperties ( $this );

The call to Ubiquity\annotations\BaseAnnotationTrait::getProperties() has too many arguments starting with $this.

			foreach ( $props as $prop ) {
				$prop->setAccessible ( true );
				$name=$prop->getName();
				$v = $prop->getValue ( $this );
				if ($v !== null && $v !== '' && isset ( $v )) {
					if(!isset($defaultParameters[$name]) || $defaultParameters[$name]!==$v){
						$ret [$name] = $v;
					}
				}
			}
			return $ret;
	}