Ubiquity\annotations\BaseAnnotationTrait

Complexity

Total Complexity

9

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getProperties()	0	4	1
B	getPropertiesAndValues()	0	16	8

<?php
namespace Ubiquity\annotations;

use Ubiquity\utils\base\UArray;

/**
 * Ubiquity\annotations$BaseAnnotationTrait
 * This class is part of Ubiquity
 * @author jc
 * @version 1.0.0
 *
 */
trait BaseAnnotationTrait {
	public function getProperties() {
		$reflect = new \ReflectionClass ( $this );
		$props = $reflect->getProperties ();
		return $props;
	}

	public function getPropertiesAndValues($props = NULL) {
		$ret = [];
		$defaultParameters=$this->getDefaultParameters();

It seems like getDefaultParameters() must be provided by classes using this trait. How about adding it as abstract method to this trait?

		if (\is_null ( $props ))
			$props = $this->getProperties ( $this );

The call to Ubiquity\annotations\BaseAnnotationTrait::getProperties() has too many arguments starting with $this.

			foreach ( $props as $prop ) {
				$prop->setAccessible ( true );
				$name=$prop->getName();
				$v = $prop->getValue ( $this );
				if ($v !== null && $v !== '' && isset ( $v )) {
					if(!isset($defaultParameters[$name]) || $defaultParameters[$name]!==$v){
						$ret [$name] = $v;
					}
				}
			}
			return $ret;
	}
}