Completed
Push — master ( a09b4a...382e94 )
by Tobias
08:18
created

LegacyTranslationReader::__construct()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 2.2559

Importance

Changes 0
Metric Value
dl 0
loc 7
ccs 3
cts 5
cp 0.6
rs 9.4285
c 0
b 0
f 0
cc 2
eloc 4
nc 2
nop 1
crap 2.2559
1
<?php
2
3
/*
4
 * This file is part of the PHP Translation package.
5
 *
6
 * (c) PHP Translation team <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Translation\SymfonyStorage;
13
14
use Symfony\Component\Translation\MessageCatalogue;
15
use Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Translation\SymfonyStorage\TranslationLoader.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
16
17
/**
18
 * This loader is just a wrapper for Symfony TranslationLoader
19
 * and provide a BC layer for Symfony 2.7 to 3.3.
20
 *
21
 * @author Victor Bocharsky <[email protected]>
22
 */
23
final class LegacyTranslationReader // implements Symfony\Component\Translation\Reader\TranslationReaderInterface
24
{
25
    /**
26
     * @var TranslationLoader
27
     */
28
    private $loader;
29
30 1
    public function __construct($loader)
31
    {
32 1
        if (!$loader instanceof TranslationLoader) {
0 ignored issues
show
Bug introduced by
The class Symfony\Bundle\Framework...ation\TranslationLoader does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
33 1
            throw new \LogicException(sprintf('PHP-Translation/SymfonyStorage does not support a TranslationReader of type "%s".', get_class($loader)));
34
        }
35
        $this->loader = $loader;
36
    }
37
38
    public function read($directory, MessageCatalogue $catalogue)
39
    {
40
        $this->loader->loadMessages($directory, $catalogue);
41
    }
42
}
43