LegacyTranslationReader - Code Metrics - Inspection of "Better travis config (#24)" - php-translation/symfony-storage - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a09b4a...382e94 )

by Tobias

created 2017-12-27 11:38 UTC

LegacyTranslationReader A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

37.5%

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	0
dl	0
loc	20
ccs	3
cts	8
cp	0.375
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	read()	0	4	1

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\SymfonyStorage;

use Symfony\Component\Translation\MessageCatalogue;
use Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * This loader is just a wrapper for Symfony TranslationLoader
 * and provide a BC layer for Symfony 2.7 to 3.3.
 *
 * @author Victor Bocharsky <[email protected]>
 */
final class LegacyTranslationReader // implements Symfony\Component\Translation\Reader\TranslationReaderInterface
{
    /**
     * @var TranslationLoader
     */
    private $loader;

    public function __construct($loader)
    {
        if (!$loader instanceof TranslationLoader) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            throw new \LogicException(sprintf('PHP-Translation/SymfonyStorage does not support a TranslationReader of type "%s".', get_class($loader)));
        }
        $this->loader = $loader;
    }

    public function read($directory, MessageCatalogue $catalogue)
    {
        $this->loader->loadMessages($directory, $catalogue);
    }
}


Push — master ( a09b4a...382e94 )

LegacyTranslationReader A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		/*
4		* This file is part of the PHP Translation package.
5		*
6		* (c) PHP Translation team <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Translation\SymfonyStorage;
13
14		use Symfony\Component\Translation\MessageCatalogue;
15		use Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader;
		0 ignored issues – show Bug introduced 2017-12-27 11:46 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Translation\SymfonyStorage\TranslationLoader`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
16
17		/**
18		* This loader is just a wrapper for Symfony TranslationLoader
19		* and provide a BC layer for Symfony 2.7 to 3.3.
20		*
21		* @author Victor Bocharsky <[email protected]>
22		*/
23		final class LegacyTranslationReader // implements Symfony\Component\Translation\Reader\TranslationReaderInterface
24		{
25		/**
26		* @var TranslationLoader
27		*/
28		private $loader;
29
30	1	public function __construct($loader)
31		{
32	1	if (!$loader instanceof TranslationLoader) {
		0 ignored issues – show Bug introduced 2017-12-27 11:46 UTC by Report Bug Copy Issue Report The class `Symfony\Bundle\Framework...ation\TranslationLoader` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
33	1	throw new \LogicException(sprintf('PHP-Translation/SymfonyStorage does not support a TranslationReader of type "%s".', get_class($loader)));
34		}
35		$this->loader = $loader;
36		}
37
38		public function read($directory, MessageCatalogue $catalogue)
39		{
40		$this->loader->loadMessages($directory, $catalogue);
41		}
42		}
43

php-translation / symfony-storage

Push — master ( a09b4a...382e94 )

LegacyTranslationReader A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like