Completed
Pull Request — master (#25)
by Aydin
06:22 queued 03:13
created
src/Exercise/MyFirstIo.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
     }
72 72
 
73 73
     /**
74
-     * @return array
74
+     * @return string[]
75 75
      */
76 76
     public function getArgs()
77 77
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
11 11
 use PhpSchool\PhpWorkshop\Exercise\TemporaryDirectoryTrait;
12 12
 use PhpSchool\PhpWorkshop\ExerciseCheck\FunctionRequirementsExerciseCheck;
13
-use PhpSchool\PhpWorkshop\ExerciseCheck\StdOutExerciseCheck;
14 13
 use PhpSchool\PhpWorkshop\ExerciseDispatcher;
15 14
 use Symfony\Component\Filesystem\Filesystem;
16 15
 
Please login to merge, or discard this patch.
test/Exercise/TimeServerTest.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -3,19 +3,13 @@
 block discarded – undo
3 3
 
4 4
 namespace PhpSchool\LearnYouPhpTest\Exercise;
5 5
 
6
-use Faker\Factory;
7
-use Faker\Generator;
8
-use Hoa\Core\Exception\Exception;
9 6
 use Hoa\Socket\Client;
10
-use PhpSchool\LearnYouPhp\Exercise\ArrayWeGo;
11 7
 use PhpSchool\LearnYouPhp\Exercise\TimeServer;
12 8
 use PhpSchool\LearnYouPhp\TcpSocketFactory;
13 9
 use PhpSchool\PhpWorkshop\Result\Failure;
14 10
 use PhpSchool\PhpWorkshop\Result\StdOutFailure;
15 11
 use PhpSchool\PhpWorkshop\Result\Success;
16 12
 use PHPUnit_Framework_TestCase;
17
-use PhpSchool\LearnYouPhp\Exercise\MyFirstIo;
18
-use Symfony\Component\Filesystem\Filesystem;
19 13
 
20 14
 /**
21 15
  * Class TimeServerTest
Please login to merge, or discard this patch.
test/Exercise/ConcernedAboutSeparationTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use PhpParser\ParserFactory;
8 8
 use PhpSchool\LearnYouPhp\Exercise\ConcernedAboutSeparation;
9 9
 use PhpSchool\PhpWorkshop\Result\Failure;
10
-use PhpSchool\PhpWorkshop\Result\FailureInterface;
11 10
 use PhpSchool\PhpWorkshop\Result\Success;
12 11
 use PhpSchool\PhpWorkshop\Solution\SolutionInterface;
13 12
 use PHPUnit_Framework_TestCase;
Please login to merge, or discard this patch.
src/Exercise/DependencyHeaven.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
     /**
78 78
      * @param string $endpoint
79
-     * @return RequestInterface
79
+     * @return Request
80 80
      */
81 81
     private function newApiRequest($endpoint)
82 82
     {
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     }
93 93
 
94 94
     /**
95
-     * @return array
95
+     * @return string[]
96 96
      */
97 97
     public function getRequiredPackages()
98 98
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use PhpSchool\PhpWorkshop\Exercise\CgiExercise;
9 9
 use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
10 10
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
11
-use PhpSchool\PhpWorkshop\ExerciseCheck\CgiOutputExerciseCheck;
12 11
 use PhpSchool\PhpWorkshop\ExerciseCheck\ComposerExerciseCheck;
13 12
 use PhpSchool\PhpWorkshop\ExerciseDispatcher;
14 13
 use PhpSchool\PhpWorkshop\Solution\DirectorySolution;
Please login to merge, or discard this patch.
src/Exercise/ConcernedAboutSeparation.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -10,8 +10,6 @@
 block discarded – undo
10 10
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
11 11
 use PhpSchool\PhpWorkshop\Exercise\TemporaryDirectoryTrait;
12 12
 use PhpSchool\PhpWorkshop\ExerciseCheck\SelfCheck;
13
-use PhpSchool\PhpWorkshop\ExerciseCheck\StdOutExerciseCheck;
14
-use PhpSchool\PhpWorkshop\ExerciseDispatcher;
15 13
 use PhpSchool\PhpWorkshop\Result\Failure;
16 14
 use PhpSchool\PhpWorkshop\Result\ResultInterface;
17 15
 use PhpSchool\PhpWorkshop\Result\Success;
Please login to merge, or discard this patch.
src/Exercise/ArrayWeGo.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
11 11
 use PhpSchool\PhpWorkshop\Exercise\TemporaryDirectoryTrait;
12 12
 use PhpSchool\PhpWorkshop\ExerciseCheck\FunctionRequirementsExerciseCheck;
13
-use PhpSchool\PhpWorkshop\ExerciseCheck\StdOutExerciseCheck;
14 13
 use PhpSchool\PhpWorkshop\ExerciseDispatcher;
15 14
 use Symfony\Component\Filesystem\Filesystem;
16 15
 
Please login to merge, or discard this patch.
src/Exercise/ExceptionalCoding.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 use PhpSchool\PhpWorkshop\Exercise\ExerciseType;
11 11
 use PhpSchool\PhpWorkshop\Exercise\TemporaryDirectoryTrait;
12 12
 use PhpSchool\PhpWorkshop\ExerciseCheck\FunctionRequirementsExerciseCheck;
13
-use PhpSchool\PhpWorkshop\ExerciseCheck\StdOutExerciseCheck;
14 13
 use PhpSchool\PhpWorkshop\ExerciseDispatcher;
15 14
 use Symfony\Component\Filesystem\Filesystem;
16 15
 
Please login to merge, or discard this patch.