Completed
Pull Request — master (#14)
by Michael
02:11
created
src/CliMenu.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     protected $parent;
62 62
 
63 63
     /**
64
-     * @param $title
64
+     * @param string|false $title
65 65
      * @param array $items
66 66
      * @param TerminalInterface|null $terminal
67 67
      * @param MenuStyle|null $style
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
     /**
205 205
      * Move the selection ina  given direction, up / down
206 206
      *
207
-     * @param $direction
207
+     * @param string $direction
208 208
      */
209 209
     protected function moveSelection($direction)
210 210
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,11 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace PhpSchool\CliMenu;
4 4
 
5
-use Assert\Assertion;
6 5
 use PhpSchool\CliMenu\Exception\InvalidInstantiationException;
7 6
 use PhpSchool\CliMenu\Exception\InvalidTerminalException;
8 7
 use PhpSchool\CliMenu\MenuItem\LineBreakItem;
9
-use PhpSchool\CliMenu\MenuItem\MenuItem;
10 8
 use PhpSchool\CliMenu\MenuItem\MenuItemInterface;
11 9
 use PhpSchool\CliMenu\MenuItem\StaticItem;
12 10
 use PhpSchool\CliMenu\Terminal\TerminalFactory;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
                 : $this->selectedItem++;
217 217
 
218 218
             if (!array_key_exists($this->selectedItem, $this->items)) {
219
-                $this->selectedItem  = $direction === 'up'
219
+                $this->selectedItem = $direction === 'up'
220 220
                     ? end($itemKeys)
221 221
                     : reset($itemKeys);
222 222
             } elseif ($this->getSelectedItem()->canSelect()) {
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
             $this->drawMenuItem(new LineBreakItem($this->style->getTitleSeparator()));
264 264
         }
265 265
 
266
-        array_map(function ($item, $index) {
266
+        array_map(function($item, $index) {
267 267
             $this->drawMenuItem($item, $index === $this->selectedItem);
268 268
         }, $this->items, array_keys($this->items));
269 269
 
Please login to merge, or discard this patch.
src/CliMenuBuilder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
     }
362 362
 
363 363
     /**
364
-     * @return array
364
+     * @return SelectableItem[]
365 365
      */
366 366
     private function getDefaultItems()
367 367
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
     {
368 368
         $actions = [];
369 369
         if ($this->parent) {
370
-            $actions[] = new SelectableItem($this->goBackButtonText, function (CliMenu $child) {
370
+            $actions[] = new SelectableItem($this->goBackButtonText, function(CliMenu $child) {
371 371
                 if ($parent = $child->getParent()) {
372 372
                     $child->closeThis();
373 373
                     $parent->open();
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
             });
376 376
         }
377 377
         
378
-        $actions[] = new SelectableItem($this->exitButtonText, function (CliMenu $menu) {
378
+        $actions[] = new SelectableItem($this->exitButtonText, function(CliMenu $menu) {
379 379
             $menu->close();
380 380
         });
381 381
         return $actions;
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
      */
398 398
     private function itemsHaveExtra(array $items)
399 399
     {
400
-        return !empty(array_filter($items, function (MenuItemInterface $item) {
400
+        return !empty(array_filter($items, function(MenuItemInterface $item) {
401 401
             return $item->showsItemExtra();
402 402
         }));
403 403
     }
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
      */
411 411
     private function getMenuStyle()
412 412
     {
413
-        $diff = array_udiff_assoc($this->style, $this->getStyleClassDefaults(), function ($current, $default) {
413
+        $diff = array_udiff_assoc($this->style, $this->getStyleClassDefaults(), function($current, $default) {
414 414
             if ($current instanceof TerminalInterface) {
415 415
                 return 0;
416 416
             }
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
      */
461 461
     private function buildSubMenus(array $items)
462 462
     {
463
-        return array_map(function ($item) {
463
+        return array_map(function($item) {
464 464
             if (!is_string($item)) {
465 465
                 return $item;
466 466
             }
Please login to merge, or discard this patch.
src/Terminal/WindowsTerminal.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
     /**
54 54
      * Check if TTY is in raw mode
55 55
      *
56
-     * @return bool
56
+     * @return boolean|null
57 57
      */
58 58
     public function isRaw()
59 59
     {
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     /**
64 64
      * Test whether terminal is valid TTY
65 65
      *
66
-     * @return bool
66
+     * @return boolean|null
67 67
      */
68 68
     public function isTTY()
69 69
     {
Please login to merge, or discard this patch.
examples/ascii-art.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8 8
 $art = <<<ART
9 9
         _ __ _
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 LEARNING FOR ELEPHPANTS
16 16
 ART;
17 17
 
18
-$itemCallable = function (CliMenu $menu) {
18
+$itemCallable = function(CliMenu $menu) {
19 19
     echo $menu->getSelectedItem()->getText();
20 20
 };
21 21
 
Please login to merge, or discard this patch.
examples/basic-separation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8
-$itemCallable = function (CliMenu $menu) {
8
+$itemCallable = function(CliMenu $menu) {
9 9
     echo $menu->getSelectedItem()->getText();
10 10
 };
11 11
 
Please login to merge, or discard this patch.
examples/basic.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8
-$itemCallable = function (CliMenu $menu) {
8
+$itemCallable = function(CliMenu $menu) {
9 9
     echo $menu->getSelectedItem()->getText();
10 10
 };
11 11
 
Please login to merge, or discard this patch.
examples/crazy-separation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8
-$itemCallable = function (CliMenu $menu) {
8
+$itemCallable = function(CliMenu $menu) {
9 9
     echo $menu->getSelectedItem()->getText();
10 10
 };
11 11
 
Please login to merge, or discard this patch.
examples/custom-styles.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8
-$itemCallable = function (CliMenu $menu) {
8
+$itemCallable = function(CliMenu $menu) {
9 9
     echo $menu->getSelectedItem()->getText();
10 10
 };
11 11
 
Please login to merge, or discard this patch.
examples/item-extra.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 use PhpSchool\CliMenu\CliMenu;
4 4
 use PhpSchool\CliMenu\CliMenuBuilder;
5 5
 
6
-require_once(__DIR__ . '/../vendor/autoload.php');
6
+require_once(__DIR__.'/../vendor/autoload.php');
7 7
 
8
-$itemCallable = function (CliMenu $menu) {
8
+$itemCallable = function(CliMenu $menu) {
9 9
     echo $menu->getSelectedItem()->getText();
10 10
 };
11 11
 
Please login to merge, or discard this patch.