php-rpc / cruds

src/DependencyInjection/CrudsEntitiesConfigurator.php

Doc Comments +1 added lines, -1 removed lines

@@ -227,7 +227,7 @@
      * @param string $actionName
      * @param string $path
      * @param string $action
-     * @param array  $methods
+     * @param string[]  $methods
      * @param array  $options
      *
      * @return Definition

Spacing +14 added lines, -14 removed lines

@@ -42,7 +42,7 @@ 
         $mount      = $config['mount'];
 
         if (null === $manager) {
-            $manager    = $this->normalize('cruds.class_' . $class . '.object_manager');
+            $manager    = $this->normalize('cruds.class_'.$class.'.object_manager');
             $managerDef = new Definition(ObjectManager::class);
             $managerDef->setPublic(false);
             $managerDef->setFactory([new Reference('doctrine'), 'getManagerForClass']);
@@ -52,7 +52,7 @@ 
         $manager = new Reference($this->filterReference($manager));
 
         if (null === $repository) {
-            $repository    = $this->normalize('cruds.class_' . $class . '.entity_repository');
+            $repository    = $this->normalize('cruds.class_'.$class.'.entity_repository');
             $repositoryDef = new Definition(EntityRepository::class);
             $repositoryDef->setPublic(false);
             $repositoryDef->setFactory([$manager, 'getRepository']);
@@ -71,10 +71,10 @@ 
             $actionConfig['class']      = $class;
             $actionConfig['mount']      = $mount;
             $actionConfig['repository'] = $repository;
-            $actionConfig['path']       = $prefix . $actionConfig['path'];
+            $actionConfig['path']       = $prefix.$actionConfig['path'];
             $actionConfig['manager']    = $manager;
             $actionConfig['prefix']     = $prefix;
-            $function                   = new \ReflectionMethod($this, 'register' . ucfirst($action) . 'Action');
+            $function                   = new \ReflectionMethod($this, 'register'.ucfirst($action).'Action');
             $args                       = [];
 
             foreach ($function->getParameters() as $parameter) {
@@ -94,7 +94,7 @@ 
         $controllerId = $this->generateControllerId($name, $actionName);
 
         if (null === $factory) {
-            $factory = $controllerId . '.entity_factory';
+            $factory = $controllerId.'.entity_factory';
 
             if (class_exists(ChildDefinition::class)) {
                 $factoryDef = new ChildDefinition('cruds.factory.reflection');
@@ -129,7 +129,7 @@ 
 
         $this->container->setDefinition($controllerId, $definition);
 
-        $action = $controllerId . ':' . CreateController::ACTION;
+        $action = $controllerId.':'.CreateController::ACTION;
         $this->registerRoute(
             $mount,
             $name,
@@ -156,7 +156,7 @@ 
         $controllerId = $this->generateControllerId($name, $actionName);
         $this->container->setDefinition($controllerId, $definition);
 
-        $action = $controllerId . ':' . ReadController::ACTION;
+        $action = $controllerId.':'.ReadController::ACTION;
         $this->registerRoute(
             $mount,
             $name,
@@ -191,7 +191,7 @@ 
         $controllerId = $this->generateControllerId($name, $actionName);
         $this->container->setDefinition($controllerId, $definition);
 
-        $action = $controllerId . ':' . UpdateController::ACTION;
+        $action = $controllerId.':'.UpdateController::ACTION;
         $this->registerRoute(
             $mount,
             $name,
@@ -220,7 +220,7 @@ 
         $controllerId = $controllerId = $this->generateControllerId($name, $actionName);
         $this->container->setDefinition($controllerId, $definition);
 
-        $action = $controllerId . ':' . DeleteController::ACTION;
+        $action = $controllerId.':'.DeleteController::ACTION;
         $definition->setPublic(true);
         $this->registerRoute(
             $mount,
@@ -270,7 +270,7 @@ 
         $controllerId = $this->generateControllerId($name, $actionName);
         $this->container->setDefinition($controllerId, $definition);
 
-        $action = $controllerId . ':' . SearchController::ACTION;
+        $action = $controllerId.':'.SearchController::ACTION;
         $this->registerRoute(
             $mount,
             $name,
@@ -296,12 +296,12 @@ 
         $controllerId = $this->generateControllerId($name, $actionName);
         $this->container->setDefinition($controllerId, $definition);
 
-        $action = $controllerId . ':' . CountController::ACTION;
+        $action = $controllerId.':'.CountController::ACTION;
         $this->registerRoute(
             $mount,
             $name,
             $actionName,
-            $prefix . $count_path,
+            $prefix.$count_path,
             $action,
             ['GET', 'POST'],
             ['class' => $class, 'arguments' => ['criteria']]
@@ -323,7 +323,7 @@ 
 
     private function generateControllerId(string $name, string $actionName): string
     {
-        return $this->normalize('cruds.generated_controller.' . $name . '.' . $actionName);
+        return $this->normalize('cruds.generated_controller.'.$name.'.'.$actionName);
     }
 
     /**
@@ -361,7 +361,7 @@ 
             'addRoute',
             [
                 $mount,
-                $this->normalize('cruds.routing.' . $name . '.' . $actionName),
+                $this->normalize('cruds.routing.'.$name.'.'.$actionName),
                 $path,
                 $action,
                 $methods,

tests/Unit/Controller/SearchControllerTest.php

Doc Comments +4 added lines, -1 removed lines

@@ -95,6 +95,9 @@ 
         self::assertSame([$f1, $f2, $f3, $f4], $result->toArray());
     }
 
+    /**
+     * @param integer $a
+     */
     private function createFixture($a, $b, $c)
     {
         $entity    = new AbcClass();
@@ -106,7 +109,7 @@ 
     }
 
     /**
-     * @return ReferenceProviderInterface|\PHPUnit_Framework_MockObject_MockObject
+     * @return ReferenceProviderInterface
      */
     private function getReferenceProvider()
     {

tests/Fixtures/SymfonySerializer/SymfonyTestKernel.php

Spacing +2 added lines, -2 removed lines

@@ -13,14 +13,14 @@
     {
         parent::registerContainerConfiguration($loader);
 
-        $loader->load(__DIR__ . '/config.yml');
+        $loader->load(__DIR__.'/config.yml');
     }
 
     /** {@inheritdoc} */
     protected function buildContainer()
     {
         $container = parent::buildContainer();
-        $container->addResource(new FileResource(__DIR__ . '/config.yml'));
+        $container->addResource(new FileResource(__DIR__.'/config.yml'));
 
         return $container;
     }

tests/Fixtures/JmsSerializer/JmsTestKernel.php

Spacing +2 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
     {
         parent::registerContainerConfiguration($loader);
 
-        return $loader->load(__DIR__ . '/config.yml');
+        return $loader->load(__DIR__.'/config.yml');
     }
 
     /** {@inheritdoc} */
@@ -30,7 +30,7 @@ 
     protected function buildContainer()
     {
         $container = parent::buildContainer();
-        $container->addResource(new FileResource(__DIR__ . '/config.yml'));
+        $container->addResource(new FileResource(__DIR__.'/config.yml'));
 
         return $container;
     }

tests/Fixtures/Common/CrudsTestKernel.php

Spacing +6 added lines, -6 removed lines

@@ -27,24 +27,24 @@ 
 
     public function getLogDir()
     {
-        return __DIR__ . '/../../../build/' . $this->getClassName() . '/logs';
+        return __DIR__.'/../../../build/'.$this->getClassName().'/logs';
     }
 
     /** {@inheritdoc} */
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
-        return $loader->load(__DIR__ . '/config.yml');
+        return $loader->load(__DIR__.'/config.yml');
     }
 
     public function getCacheDir()
     {
-        return __DIR__ . '/../../../build/' . $this->getClassName() . '/cache';
+        return __DIR__.'/../../../build/'.$this->getClassName().'/cache';
     }
 
     protected function initializeContainer()
     {
         $class = $this->getContainerClass();
-        $cache = new ConfigCache($this->getCacheDir() . '/' . $class . '.php', $this->debug);
+        $cache = new ConfigCache($this->getCacheDir().'/'.$class.'.php', $this->debug);
 
         $container = $this->buildContainer();
         $container->compile();
@@ -57,8 +57,8 @@ 
     protected function buildContainer()
     {
         $container = parent::buildContainer();
-        $container->addResource(new FileResource(__DIR__ . '/config.yml'));
-        $container->addResource(new FileResource(__DIR__ . '/routing.yml'));
+        $container->addResource(new FileResource(__DIR__.'/config.yml'));
+        $container->addResource(new FileResource(__DIR__.'/routing.yml'));
 
         return $container;
     }

tests/Unit/DefaultCriteriaConfiguratorTest.php

Indentation +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     {
         $mock = self::prophesize(CriteriaConfiguratorInterface::class);
         $mock->configure(Argument::exact($fqcn), Argument::exact($criteria), Argument::exact($data))
-             ->shouldBeCalled();
+                ->shouldBeCalled();
 
         return $mock->reveal();
     }

tests/KernelProvider.php

Spacing +2 added lines, -2 removed lines

@@ -17,11 +17,11 @@
     public static function getClass()
     {
         if (false === ($alias = getenv(self::ENV_VAR))) {
-            throw new \LogicException('Cannot obtain kernel alias from "' . self::ENV_VAR . '"" ENV variable');
+            throw new \LogicException('Cannot obtain kernel alias from "'.self::ENV_VAR.'"" ENV variable');
         }
 
         if (!array_key_exists($alias, self::$map)) {
-            throw new \LogicException('Invalid kernel alias: ' . $alias);
+            throw new \LogicException('Invalid kernel alias: '.$alias);
         }
 
         return self::$map[$alias];

src/DependencyInjection/Configuration.php

Spacing +15 added lines, -15 removed lines

@@ -71,7 +71,7 @@ 
             ->defaultValue('api')
             ->cannotBeEmpty()
             ->info(
-                'Route mount. You can create different entries ' .
+                'Route mount. You can create different entries '.
                 'with different mounts. You can use this value when loading routes'
             )
             ->example('my-mount-name');
@@ -81,7 +81,7 @@ 
             ->scalarNode('repository')
             ->defaultNull()
             ->info(
-                'Object repository. service reference,' . PHP_EOL .
+                'Object repository. service reference,'.PHP_EOL.
                 'default to factory-acquired doctrine repository for class'
             )
             ->example('@my_entity.repository');
@@ -91,7 +91,7 @@ 
             ->scalarNode('manager')
             ->defaultNull()
             ->info(
-                'Object manager. service reference,' . PHP_EOL .
+                'Object manager. service reference,'.PHP_EOL.
                 'default to factory-acquired doctrine manager for class'
             )
             ->example('@my_entity.repository');
@@ -104,7 +104,7 @@ 
             ->beforeNormalization()
             ->ifArray()
             ->then(
-                function (array $v) {
+                function(array $v) {
                     if (array_keys($v) !== range(0, count($v) - 1)) {
                         return $v;
                     }
@@ -139,9 +139,9 @@ 
             ->defaultNull()
             ->example('@my_entity.factory')
             ->info(
-                'Service ID implementing ' . PHP_EOL .
-                EntityFactoryInterface::class . PHP_EOL .
-                'Defaults to ' . ReflectionConstructorFactory::class
+                'Service ID implementing '.PHP_EOL.
+                EntityFactoryInterface::class.PHP_EOL.
+                'Defaults to '.ReflectionConstructorFactory::class
             );
 
         $create
@@ -150,9 +150,9 @@ 
             ->defaultNull()
             ->example('@my_entity.factory')
             ->info(
-                'Service ID implementing ' . PHP_EOL .
-                EntityFactoryInterface::class . PHP_EOL .
-                'Defaults to ' . ReflectionConstructorFactory::class
+                'Service ID implementing '.PHP_EOL.
+                EntityFactoryInterface::class.PHP_EOL.
+                'Defaults to '.ReflectionConstructorFactory::class
             );
 
         $this->configureActionNode($create, 'create');
@@ -173,7 +173,7 @@ 
 
         $criteria = $search->children()->variableNode('criteria');
         $criteria->info(
-            'Criteria modifiers. Array will be treated as nested criteria,' . PHP_EOL .
+            'Criteria modifiers. Array will be treated as nested criteria,'.PHP_EOL.
             'allowing configuring several modifiers by key:value'
         );
         $criteria->defaultValue('cruds.criteria.entity');
@@ -201,9 +201,9 @@ 
             ->defaultNull()
             ->example('@my_entity.processor')
             ->info(
-                'Service ID implementing ' . PHP_EOL .
-                EntityProcessorInterface::class . PHP_EOL .
-                'Defaults to ' . PropertyAccessProcessor::class
+                'Service ID implementing '.PHP_EOL.
+                EntityProcessorInterface::class.PHP_EOL.
+                'Defaults to '.PropertyAccessProcessor::class
             );
 
         $this->configureActionNode($update, 'update');
@@ -225,6 +225,6 @@ 
             ->children()
             ->scalarNode('path')
             ->info('Action path (will be prefixed with entity prefix)')
-            ->defaultValue('/' . $action);
+            ->defaultValue('/'.$action);
     }
 }

src/DependencyInjection/CrudsExtension.php

Spacing +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
     /** {@inheritdoc} */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('cruds.yml');
 
         $config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
@@ -20,7 +20,7 @@ 
         $configurator = new CrudsEntitiesConfigurator($container);
         $container->addObjectResource($configurator);
         foreach ($config['entities'] as $name => $entityConfig) {
-            $entityConfig['prefix'] = $entityConfig['prefix'] ?: '/' . $name;
+            $entityConfig['prefix'] = $entityConfig['prefix'] ?: '/'.$name;
             $configurator->processEntityConfiguration($name, $entityConfig);
         }
 
@@ -29,7 +29,7 @@ 
                 continue;
             }
 
-            $container->removeDefinition('cruds.api.listener.' . $listener);
+            $container->removeDefinition('cruds.api.listener.'.$listener);
         }
     }
 }