Passed
Pull Request — master (#21)
by Pavel
06:33
created
DependencyInjection/Compiler/DoctrineOrmCompilerPass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
             return;
22 22
         }
23 23
 
24
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../../Resources/config'));
24
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../../Resources/config'));
25 25
         $loader->load('doctrine.yml');
26 26
 
27 27
         $factory = $container->getDefinition('cruds.factory.reflection');
Please login to merge, or discard this patch.
DependencyInjection/CrudsEntitiesConfigurator.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@
 block discarded – undo
227 227
      * @param string $actionName
228 228
      * @param string $path
229 229
      * @param string $action
230
-     * @param array  $methods
230
+     * @param string[]  $methods
231 231
      * @param array  $options
232 232
      *
233 233
      * @return Definition
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         $mount      = $config['mount'];
43 43
 
44 44
         if (null === $manager) {
45
-            $manager    = $this->normalize('cruds.class_' . $class . '.object_manager');
45
+            $manager    = $this->normalize('cruds.class_'.$class.'.object_manager');
46 46
             $managerDef = new Definition(ObjectManager::class);
47 47
             $managerDef->setPublic(false);
48 48
             $managerDef->setFactory([new Reference('doctrine'), 'getManagerForClass']);
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
         $manager = new Reference($this->filterReference($manager));
53 53
 
54 54
         if (null === $repository) {
55
-            $repository    = $this->normalize('cruds.class_' . $class . '.entity_repository');
55
+            $repository    = $this->normalize('cruds.class_'.$class.'.entity_repository');
56 56
             $repositoryDef = new Definition(EntityRepository::class);
57 57
             $repositoryDef->setPublic(false);
58 58
             $repositoryDef->setFactory([$manager, 'getRepository']);
@@ -71,10 +71,10 @@  discard block
 block discarded – undo
71 71
             $actionConfig['class']      = $class;
72 72
             $actionConfig['mount']      = $mount;
73 73
             $actionConfig['repository'] = $repository;
74
-            $actionConfig['path']       = $prefix . $actionConfig['path'];
74
+            $actionConfig['path']       = $prefix.$actionConfig['path'];
75 75
             $actionConfig['manager']    = $manager;
76 76
             $actionConfig['prefix']     = $prefix;
77
-            $function                   = new \ReflectionMethod($this, 'register' . ucfirst($action) . 'Action');
77
+            $function                   = new \ReflectionMethod($this, 'register'.ucfirst($action).'Action');
78 78
             $args                       = [];
79 79
 
80 80
             foreach ($function->getParameters() as $parameter) {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         $controllerId = $this->generateControllerId($name, $actionName);
95 95
 
96 96
         if (null === $factory) {
97
-            $factory = $controllerId . '.entity_factory';
97
+            $factory = $controllerId.'.entity_factory';
98 98
 
99 99
             if (class_exists(ChildDefinition::class)) {
100 100
                 $factoryDef = new ChildDefinition('cruds.factory.reflection');
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
         $this->container->setDefinition($controllerId, $definition);
131 131
 
132
-        $action = $controllerId . ':' . CreateController::ACTION;
132
+        $action = $controllerId.':'.CreateController::ACTION;
133 133
         $this->registerRoute(
134 134
             $mount,
135 135
             $name,
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
         $controllerId = $this->generateControllerId($name, $actionName);
157 157
         $this->container->setDefinition($controllerId, $definition);
158 158
 
159
-        $action = $controllerId . ':' . ReadController::ACTION;
159
+        $action = $controllerId.':'.ReadController::ACTION;
160 160
         $this->registerRoute(
161 161
             $mount,
162 162
             $name,
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
         $controllerId = $this->generateControllerId($name, $actionName);
192 192
         $this->container->setDefinition($controllerId, $definition);
193 193
 
194
-        $action = $controllerId . ':' . UpdateController::ACTION;
194
+        $action = $controllerId.':'.UpdateController::ACTION;
195 195
         $this->registerRoute(
196 196
             $mount,
197 197
             $name,
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
         $controllerId = $controllerId = $this->generateControllerId($name, $actionName);
221 221
         $this->container->setDefinition($controllerId, $definition);
222 222
 
223
-        $action = $controllerId . ':' . DeleteController::ACTION;
223
+        $action = $controllerId.':'.DeleteController::ACTION;
224 224
         $definition->setPublic(true);
225 225
         $this->registerRoute(
226 226
             $mount,
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
         $controllerId = $this->generateControllerId($name, $actionName);
271 271
         $this->container->setDefinition($controllerId, $definition);
272 272
 
273
-        $action = $controllerId . ':' . SearchController::ACTION;
273
+        $action = $controllerId.':'.SearchController::ACTION;
274 274
         $this->registerRoute(
275 275
             $mount,
276 276
             $name,
@@ -296,12 +296,12 @@  discard block
 block discarded – undo
296 296
         $controllerId = $this->generateControllerId($name, $actionName);
297 297
         $this->container->setDefinition($controllerId, $definition);
298 298
 
299
-        $action = $controllerId . ':' . CountController::ACTION;
299
+        $action = $controllerId.':'.CountController::ACTION;
300 300
         $this->registerRoute(
301 301
             $mount,
302 302
             $name,
303 303
             $actionName,
304
-            $prefix . $count_path,
304
+            $prefix.$count_path,
305 305
             $action,
306 306
             ['GET', 'POST'],
307 307
             ['class' => $class, 'arguments' => ['criteria']]
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 
324 324
     private function generateControllerId(string $name, string $actionName): string
325 325
     {
326
-        return $this->normalize('cruds.generated_controller.' . $name . '.' . $actionName);
326
+        return $this->normalize('cruds.generated_controller.'.$name.'.'.$actionName);
327 327
     }
328 328
 
329 329
     /**
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
             'addRoute',
362 362
             [
363 363
                 $mount,
364
-                $this->normalize('cruds.routing.' . $name . '.' . $actionName),
364
+                $this->normalize('cruds.routing.'.$name.'.'.$actionName),
365 365
                 $path,
366 366
                 $action,
367 367
                 $methods,
Please login to merge, or discard this patch.
DependencyInjection/CrudsExtension.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
     /** {@inheritdoc} */
13 13
     public function load(array $configs, ContainerBuilder $container)
14 14
     {
15
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
15
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
16 16
         $loader->load('cruds.yml');
17 17
 
18 18
         $config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
         $configurator = new CrudsEntitiesConfigurator($container);
21 21
         $container->addObjectResource($configurator);
22 22
         foreach ($config['entities'] as $name => $entityConfig) {
23
-            $entityConfig['prefix'] = $entityConfig['prefix'] ?: '/' . $name;
23
+            $entityConfig['prefix'] = $entityConfig['prefix'] ?: '/'.$name;
24 24
             $configurator->processEntityConfiguration($name, $entityConfig);
25 25
         }
26 26
 
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
                 continue;
30 30
             }
31 31
 
32
-            $container->removeDefinition('cruds.api.listener.' . $listener);
32
+            $container->removeDefinition('cruds.api.listener.'.$listener);
33 33
         }
34 34
     }
35 35
 }
Please login to merge, or discard this patch.
DependencyInjection/Configuration.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
             ->beforeNormalization()
92 92
             ->ifArray()
93 93
             ->then(
94
-                function (array $v) {
94
+                function(array $v) {
95 95
                     if (array_keys($v) !== range(0, count($v) - 1)) {
96 96
                         return $v;
97 97
                     }
Please login to merge, or discard this patch.
Tests/Unit/Controller/CountControllerTest.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 use ScayTrase\Api\Cruds\PublicPropertyMapper;
11 11
 use ScayTrase\Api\Cruds\ReferenceProviderInterface;
12 12
 use ScayTrase\Api\Cruds\Tests\Fixtures\AbcClass;
13
-use ScayTrase\Api\Cruds\Tests\Unit\AbstractControllerTest;
14 13
 use Symfony\Component\EventDispatcher\Event;
15 14
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
16 15
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,6 +49,9 @@  discard block
 block discarded – undo
49 49
         self::assertSame(3, $controller->countAction(['a' => [1, 2, 4]]));
50 50
     }
51 51
 
52
+    /**
53
+     * @param integer $a
54
+     */
52 55
     private function createFixture($a, $b, $c)
53 56
     {
54 57
         $entity    = new AbcClass();
@@ -60,7 +63,7 @@  discard block
 block discarded – undo
60 63
     }
61 64
 
62 65
     /**
63
-     * @return ReferenceProviderInterface|\PHPUnit_Framework_MockObject_MockObject
66
+     * @return \PHPUnit\Framework\MockObject\MockObject
64 67
      */
65 68
     private function getReferenceProvider()
66 69
     {
Please login to merge, or discard this patch.
DependencyInjection/Compiler/SymfonyFormsCompilerPass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
             return;
17 17
         }
18 18
 
19
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../../Resources/config'));
19
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../../Resources/config'));
20 20
         $loader->load('forms.yml');
21 21
     }
22 22
 }
Please login to merge, or discard this patch.
Tests/KernelProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,11 +17,11 @@
 block discarded – undo
17 17
     public static function getClass()
18 18
     {
19 19
         if (false === ($alias = getenv(self::ENV_VAR))) {
20
-            throw new \LogicException('Cannot obtain kernel alias from "' . self::ENV_VAR . '"" ENV variable');
20
+            throw new \LogicException('Cannot obtain kernel alias from "'.self::ENV_VAR.'"" ENV variable');
21 21
         }
22 22
 
23 23
         if (!array_key_exists($alias, self::$map)) {
24
-            throw new \LogicException('Invalid kernel alias: ' . $alias);
24
+            throw new \LogicException('Invalid kernel alias: '.$alias);
25 25
         }
26 26
 
27 27
         return self::$map[$alias];
Please login to merge, or discard this patch.
dump_reference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 use ScayTrase\Api\Cruds\DependencyInjection\Configuration;
4 4
 use Symfony\Component\Config\Definition\Dumper\YamlReferenceDumper;
5 5
 
6
-require_once __DIR__ . '/bootstrap.php';
6
+require_once __DIR__.'/bootstrap.php';
7 7
 
8 8
 $config = new Configuration();
9 9
 $dumper = new YamlReferenceDumper();
Please login to merge, or discard this patch.
Exception/EntityProcessingException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         }
35 35
 
36 36
         return new static(
37
-            'Invalid data submitted for entity: ' . PHP_EOL .
37
+            'Invalid data submitted for entity: '.PHP_EOL.
38 38
             Yaml::dump($errors)
39 39
         );
40 40
     }
Please login to merge, or discard this patch.