Completed
Pull Request — master (#15)
by Pavel
11:23
created
Tests/Unit/Controller/CountControllerTest.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 use ScayTrase\Api\Cruds\PublicPropertyMapper;
11 11
 use ScayTrase\Api\Cruds\ReferenceProviderInterface;
12 12
 use ScayTrase\Api\Cruds\Tests\Fixtures\AbcClass;
13
-use ScayTrase\Api\Cruds\Tests\Unit\AbstractControllerTest;
14 13
 use Symfony\Component\EventDispatcher\Event;
15 14
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
16 15
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,6 +95,9 @@  discard block
 block discarded – undo
95 95
         self::assertSame([$f1, $f2, $f3, $f4], $result->toArray());
96 96
     }
97 97
 
98
+    /**
99
+     * @param integer $a
100
+     */
98 101
     private function createFixture($a, $b, $c)
99 102
     {
100 103
         $entity    = new AbcClass();
@@ -106,7 +109,7 @@  discard block
 block discarded – undo
106 109
     }
107 110
 
108 111
     /**
109
-     * @return ReferenceProviderInterface|\PHPUnit_Framework_MockObject_MockObject
112
+     * @return ReferenceProviderInterface
110 113
      */
111 114
     private function getReferenceProvider()
112 115
     {
Please login to merge, or discard this patch.
Tests/Unit/Controller/SearchControllerTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,6 +95,9 @@  discard block
 block discarded – undo
95 95
         self::assertSame([$f1, $f2, $f3, $f4], $result->toArray());
96 96
     }
97 97
 
98
+    /**
99
+     * @param integer $a
100
+     */
98 101
     private function createFixture($a, $b, $c)
99 102
     {
100 103
         $entity    = new AbcClass();
@@ -106,7 +109,7 @@  discard block
 block discarded – undo
106 109
     }
107 110
 
108 111
     /**
109
-     * @return ReferenceProviderInterface|\PHPUnit_Framework_MockObject_MockObject
112
+     * @return ReferenceProviderInterface
110 113
      */
111 114
     private function getReferenceProvider()
112 115
     {
Please login to merge, or discard this patch.
DependencyInjection/CrudsEntitiesConfigurator.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -65,10 +65,10 @@  discard block
 block discarded – undo
65 65
             $actionConfig['class']      = $class;
66 66
             $actionConfig['mount']      = $mount;
67 67
             $actionConfig['repository'] = $repositoryDefinition;
68
-            $actionConfig['path']       = $prefix . $actionConfig['path'];
68
+            $actionConfig['path']       = $prefix.$actionConfig['path'];
69 69
             $actionConfig['manager']    = $manager;
70 70
             $actionConfig['prefix']     = $prefix;
71
-            $function                   = new \ReflectionMethod($this, 'register' . ucfirst($action) . 'Action');
71
+            $function                   = new \ReflectionMethod($this, 'register'.ucfirst($action).'Action');
72 72
             $args                       = [];
73 73
 
74 74
             foreach ($function->getParameters() as $parameter) {
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         $controllerId = $this->generateControllerId($name, $actionName);
123 123
         $this->container->setDefinition($controllerId, $definition);
124 124
 
125
-        $action = $controllerId . ':' . CreateController::ACTION;
125
+        $action = $controllerId.':'.CreateController::ACTION;
126 126
         $this->registerRoute(
127 127
             $mount,
128 128
             $name,
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
      */
151 151
     private function generateControllerId($name, $actionName)
152 152
     {
153
-        return $this->normalize('cruds.generated_controller.' . $name . '.' . $actionName);
153
+        return $this->normalize('cruds.generated_controller.'.$name.'.'.$actionName);
154 154
     }
155 155
 
156 156
     /**
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
             'addRoute',
182 182
             [
183 183
                 $mount,
184
-                $this->normalize('cruds.routing.' . $name . '.' . $actionName),
184
+                $this->normalize('cruds.routing.'.$name.'.'.$actionName),
185 185
                 $path,
186 186
                 $action,
187 187
                 $methods,
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
         $controllerId = $this->generateControllerId($name, $actionName);
216 216
         $this->container->setDefinition($controllerId, $definition);
217 217
 
218
-        $action = $controllerId . ':' . ReadController::ACTION;
218
+        $action = $controllerId.':'.ReadController::ACTION;
219 219
         $this->registerRoute(
220 220
             $mount,
221 221
             $name,
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
         $controllerId = $this->generateControllerId($name, $actionName);
250 250
         $this->container->setDefinition($controllerId, $definition);
251 251
 
252
-        $action = $controllerId . ':' . UpdateController::ACTION;
252
+        $action = $controllerId.':'.UpdateController::ACTION;
253 253
         $this->registerRoute(
254 254
             $mount,
255 255
             $name,
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
         $controllerId = $controllerId = $this->generateControllerId($name, $actionName);
277 277
         $this->container->setDefinition($controllerId, $definition);
278 278
 
279
-        $action = $controllerId . ':' . DeleteController::ACTION;
279
+        $action = $controllerId.':'.DeleteController::ACTION;
280 280
         $this->registerRoute(
281 281
             $mount,
282 282
             $name,
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
         $controllerId = $this->generateControllerId($name, $actionName);
317 317
         $this->container->setDefinition($controllerId, $definition);
318 318
 
319
-        $action = $controllerId . ':' . SearchController::ACTION;
319
+        $action = $controllerId.':'.SearchController::ACTION;
320 320
         $this->registerRoute(
321 321
             $mount,
322 322
             $name,
@@ -341,12 +341,12 @@  discard block
 block discarded – undo
341 341
         $controllerId = $this->generateControllerId($name, $actionName);
342 342
         $this->container->setDefinition($controllerId, $definition);
343 343
 
344
-        $action = $controllerId . ':' . CountController::ACTION;
344
+        $action = $controllerId.':'.CountController::ACTION;
345 345
         $this->registerRoute(
346 346
             $mount,
347 347
             $name,
348 348
             $actionName,
349
-            $prefix . $count_path,
349
+            $prefix.$count_path,
350 350
             $action,
351 351
             ['GET', 'POST'],
352 352
             ['class' => $class, 'arguments' => ['criteria']]
Please login to merge, or discard this patch.