Inspection of "worker format" - php-resta/resta-core - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 1dec6d...a46529 )

by Php Easy Api

created 2019-06-26 09:08 UTC

Status

Spacing +39 added lines, -39 removed lines patch added patch discarded remove patch

@@ -31,14 +31,14 @@  discard block
 block discarded – undo
      * @param string $method
      * @param bool $break
      */
-    private function allWorkers($method='start',$break=false)
+    private function allWorkers($method = 'start', $break = false)
     {
-        foreach(app()->get('worker') as $key=>$item){
+        foreach (app()->get('worker') as $key=>$item) {
             $this->argument['worker'] = ucfirst($key);
             $this->argument[$key] = ucfirst($key);
             $this->{$method}();
 
-            if($break) break;
+            if ($break) break;
         }
         exit();
     }
@@ -48,22 +48,22 @@  discard block
 block discarded – undo
      */
     public function start()
     {
-        if(is_null($this->argument['worker'])){
+        if (is_null($this->argument['worker'])) {
             $this->allWorkers();
             exit();
         }
 
         $workerName = $this->projectName().'-'.$this->argument['worker'];
         app()->terminate('WORKER');
-        app()->register('WORKER',$workerName);
+        app()->register('WORKER', $workerName);
         app()->terminate('PROJECT_NAME');
-        app()->register('PROJECT_NAME',strtolower($this->projectName()));
-        app()->register('WORKER_START',true);
-        app()->register('WORKER_STOP',false);
-        app()->register('WORKER_STATUS',false);
-        app()->register('WORKER_CLEAR',false);
+        app()->register('PROJECT_NAME', strtolower($this->projectName()));
+        app()->register('WORKER_START', true);
+        app()->register('WORKER_STOP', false);
+        app()->register('WORKER_STATUS', false);
+        app()->register('WORKER_CLEAR', false);
 
-        app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
+        app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
     }
 
     /**
@@ -71,22 +71,22 @@  discard block
 block discarded – undo
      */
     public function stop()
     {
-        if(is_null($this->argument['worker'])){
+        if (is_null($this->argument['worker'])) {
             $this->allWorkers('stop');
             exit();
         }
 
         $workerName = $this->projectName().'-'.$this->argument['worker'];
         app()->terminate('WORKER');
-        app()->register('WORKER',$workerName);
+        app()->register('WORKER', $workerName);
         app()->terminate('PROJECT_NAME');
-        app()->register('PROJECT_NAME',strtolower($this->projectName()));
-        app()->register('WORKER_START',false);
-        app()->register('WORKER_STOP',true);
-        app()->register('WORKER_STATUS',false);
-        app()->register('WORKER_CLEAR',false);
+        app()->register('PROJECT_NAME', strtolower($this->projectName()));
+        app()->register('WORKER_START', false);
+        app()->register('WORKER_STOP', true);
+        app()->register('WORKER_STATUS', false);
+        app()->register('WORKER_CLEAR', false);
 
-        app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
+        app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
     }
 
     /**
@@ -94,20 +94,20 @@  discard block
 block discarded – undo
      */
     public function status()
     {
-        if(is_null($this->argument['worker'])){
-            $this->allWorkers('status',true);
+        if (is_null($this->argument['worker'])) {
+            $this->allWorkers('status', true);
             exit();
         }
 
         $workerName = $this->projectName().'-'.$this->argument['worker'];
-        app()->register('WORKER',$workerName);
-        app()->register('PROJECT_NAME',strtolower($this->projectName()));
-        app()->register('WORKER_START',false);
-        app()->register('WORKER_STOP',false);
-        app()->register('WORKER_STATUS',true);
-        app()->register('WORKER_CLEAR',false);
-
-        app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
+        app()->register('WORKER', $workerName);
+        app()->register('PROJECT_NAME', strtolower($this->projectName()));
+        app()->register('WORKER_START', false);
+        app()->register('WORKER_STOP', false);
+        app()->register('WORKER_STATUS', true);
+        app()->register('WORKER_CLEAR', false);
+
+        app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
     }
 
     /**
@@ -115,22 +115,22 @@  discard block
 block discarded – undo
      */
     public function clear()
     {
-        if(is_null($this->argument['worker'])){
+        if (is_null($this->argument['worker'])) {
             $this->allWorkers('clear');
             exit();
         }
 
         $workerName = $this->projectName().'-'.$this->argument['worker'];
         app()->terminate('WORKER');
-        app()->register('WORKER',$workerName);
+        app()->register('WORKER', $workerName);
         app()->terminate('PROJECT_NAME');
-        app()->register('PROJECT_NAME',strtolower($this->projectName()));
-        app()->register('WORKER_START',false);
-        app()->register('WORKER_STOP',false);
-        app()->register('WORKER_STATUS',false);
-        app()->register('WORKER_CLEAR',true);
+        app()->register('PROJECT_NAME', strtolower($this->projectName()));
+        app()->register('WORKER_START', false);
+        app()->register('WORKER_STOP', false);
+        app()->register('WORKER_STATUS', false);
+        app()->register('WORKER_CLEAR', true);
 
-        app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
+        app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
     }
 
     /**
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
      */
     public function create()
     {
-        if(!file_exists(app()->path()->workers())){
+        if (!file_exists(app()->path()->workers())) {
             $this->directory['worker'] = app()->path()->workers();
             $this->file->makeDirectory($this);
         }
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
         $this->argument['workerClass'] = ucfirst($this->argument['worker']).'';
         $this->argument['projectName'] = strtolower($this->projectName());
 
-        $this->touch['worker/worker']= app()->path()->workers().'/'.$this->argument['worker'].'.php';
+        $this->touch['worker/worker'] = app()->path()->workers().'/'.$this->argument['worker'].'.php';
 
 
         $this->file->touch($this);

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -38,7 +38,9 @@
 block discarded – undo
             $this->argument[$key] = ucfirst($key);
             $this->{$method}();
 
-            if($break) break;
+            if($break) {
+                break;
+            }
         }
         exit();
     }

Please login to merge, or discard this patch.

src/resta/Worker/JobAbstract.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
      * @param ApplicationContracts $app
      * @param WorkerManagerContracts $worker
      */
-    public function __construct(ApplicationContracts $app,WorkerManagerContracts $worker)
+    public function __construct(ApplicationContracts $app, WorkerManagerContracts $worker)
     {
         parent::__construct($app);
 
@@ -41,19 +41,19 @@  discard block
 block discarded – undo
      */
     public function jobProcessor()
     {
-        if($this->app->get('WORKER_START')===true){
+        if ($this->app->get('WORKER_START')===true) {
             return 'start';
         }
 
-        if($this->app->get('WORKER_STOP')===true){
+        if ($this->app->get('WORKER_STOP')===true) {
             return 'stop';
         }
 
-        if($this->app->get('WORKER_STATUS')===true){
+        if ($this->app->get('WORKER_STATUS')===true) {
             return 'status';
         }
 
-        if($this->app->get('WORKER_CLEAR')===true){
+        if ($this->app->get('WORKER_CLEAR')===true) {
             return 'clear';
         }
     }

Please login to merge, or discard this patch.

src/resta/Support/Process.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,9 +13,9 @@
 block discarded – undo
      * @param null|string $command
      * @return mixed|void
      */
-    public function command($command=null)
+    public function command($command = null)
     {
-        $process = new ProcessHandler($command,root.'');
+        $process = new ProcessHandler($command, root.'');
         $process->run();
 
         // executes after the command finishes

Please login to merge, or discard this patch.

		@@ -31,14 +31,14 @@ discard block
		block discarded – undo
31	31	* @param string $method
32	32	* @param bool $break
33	33	*/
34		- private function allWorkers($method='start',$break=false)
	34	+ private function allWorkers($method = 'start', $break = false)
35	35	{
36		- foreach(app()->get('worker') as $key=>$item){
	36	+ foreach (app()->get('worker') as $key=>$item) {
37	37	$this->argument['worker'] = ucfirst($key);
38	38	$this->argument[$key] = ucfirst($key);
39	39	$this->{$method}();
40	40
41		- if($break) break;
	41	+ if ($break) break;
42	42	}
43	43	exit();
44	44	}
		@@ -48,22 +48,22 @@ discard block
		block discarded – undo
48	48	*/
49	49	public function start()
50	50	{
51		- if(is_null($this->argument['worker'])){
	51	+ if (is_null($this->argument['worker'])) {
52	52	$this->allWorkers();
53	53	exit();
54	54	}
55	55
56	56	$workerName = $this->projectName().'-'.$this->argument['worker'];
57	57	app()->terminate('WORKER');
58		- app()->register('WORKER',$workerName);
	58	+ app()->register('WORKER', $workerName);
59	59	app()->terminate('PROJECT_NAME');
60		- app()->register('PROJECT_NAME',strtolower($this->projectName()));
61		- app()->register('WORKER_START',true);
62		- app()->register('WORKER_STOP',false);
63		- app()->register('WORKER_STATUS',false);
64		- app()->register('WORKER_CLEAR',false);
	60	+ app()->register('PROJECT_NAME', strtolower($this->projectName()));
	61	+ app()->register('WORKER_START', true);
	62	+ app()->register('WORKER_STOP', false);
	63	+ app()->register('WORKER_STATUS', false);
	64	+ app()->register('WORKER_CLEAR', false);
65	65
66		- app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
	66	+ app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
67	67	}
68	68
69	69	/**
		@@ -71,22 +71,22 @@ discard block
		block discarded – undo
71	71	*/
72	72	public function stop()
73	73	{
74		- if(is_null($this->argument['worker'])){
	74	+ if (is_null($this->argument['worker'])) {
75	75	$this->allWorkers('stop');
76	76	exit();
77	77	}
78	78
79	79	$workerName = $this->projectName().'-'.$this->argument['worker'];
80	80	app()->terminate('WORKER');
81		- app()->register('WORKER',$workerName);
	81	+ app()->register('WORKER', $workerName);
82	82	app()->terminate('PROJECT_NAME');
83		- app()->register('PROJECT_NAME',strtolower($this->projectName()));
84		- app()->register('WORKER_START',false);
85		- app()->register('WORKER_STOP',true);
86		- app()->register('WORKER_STATUS',false);
87		- app()->register('WORKER_CLEAR',false);
	83	+ app()->register('PROJECT_NAME', strtolower($this->projectName()));
	84	+ app()->register('WORKER_START', false);
	85	+ app()->register('WORKER_STOP', true);
	86	+ app()->register('WORKER_STATUS', false);
	87	+ app()->register('WORKER_CLEAR', false);
88	88
89		- app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
	89	+ app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
90	90	}
91	91
92	92	/**
		@@ -94,20 +94,20 @@ discard block
		block discarded – undo
94	94	*/
95	95	public function status()
96	96	{
97		- if(is_null($this->argument['worker'])){
98		- $this->allWorkers('status',true);
	97	+ if (is_null($this->argument['worker'])) {
	98	+ $this->allWorkers('status', true);
99	99	exit();
100	100	}
101	101
102	102	$workerName = $this->projectName().'-'.$this->argument['worker'];
103		- app()->register('WORKER',$workerName);
104		- app()->register('PROJECT_NAME',strtolower($this->projectName()));
105		- app()->register('WORKER_START',false);
106		- app()->register('WORKER_STOP',false);
107		- app()->register('WORKER_STATUS',true);
108		- app()->register('WORKER_CLEAR',false);
109		-
110		- app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
	103	+ app()->register('WORKER', $workerName);
	104	+ app()->register('PROJECT_NAME', strtolower($this->projectName()));
	105	+ app()->register('WORKER_START', false);
	106	+ app()->register('WORKER_STOP', false);
	107	+ app()->register('WORKER_STATUS', true);
	108	+ app()->register('WORKER_CLEAR', false);
	109	+
	110	+ app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
111	111	}
112	112
113	113	/**
		@@ -115,22 +115,22 @@ discard block
		block discarded – undo
115	115	*/
116	116	public function clear()
117	117	{
118		- if(is_null($this->argument['worker'])){
	118	+ if (is_null($this->argument['worker'])) {
119	119	$this->allWorkers('clear');
120	120	exit();
121	121	}
122	122
123	123	$workerName = $this->projectName().'-'.$this->argument['worker'];
124	124	app()->terminate('WORKER');
125		- app()->register('WORKER',$workerName);
	125	+ app()->register('WORKER', $workerName);
126	126	app()->terminate('PROJECT_NAME');
127		- app()->register('PROJECT_NAME',strtolower($this->projectName()));
128		- app()->register('WORKER_START',false);
129		- app()->register('WORKER_STOP',false);
130		- app()->register('WORKER_STATUS',false);
131		- app()->register('WORKER_CLEAR',true);
	127	+ app()->register('PROJECT_NAME', strtolower($this->projectName()));
	128	+ app()->register('WORKER_START', false);
	129	+ app()->register('WORKER_STOP', false);
	130	+ app()->register('WORKER_STATUS', false);
	131	+ app()->register('WORKER_CLEAR', true);
132	132
133		- app()->resolve(WorkerManager::class,['args'=>$this->argument])->execute();
	133	+ app()->resolve(WorkerManager::class, ['args'=>$this->argument])->execute();
134	134	}
135	135
136	136	/**
		@@ -138,7 +138,7 @@ discard block
		block discarded – undo
138	138	*/
139	139	public function create()
140	140	{
141		- if(!file_exists(app()->path()->workers())){
	141	+ if (!file_exists(app()->path()->workers())) {
142	142	$this->directory['worker'] = app()->path()->workers();
143	143	$this->file->makeDirectory($this);
144	144	}
		@@ -147,7 +147,7 @@ discard block
		block discarded – undo
147	147	$this->argument['workerClass'] = ucfirst($this->argument['worker']).'';
148	148	$this->argument['projectName'] = strtolower($this->projectName());
149	149
150		- $this->touch['worker/worker']= app()->path()->workers().'/'.$this->argument['worker'].'.php';
	150	+ $this->touch['worker/worker'] = app()->path()->workers().'/'.$this->argument['worker'].'.php';
151	151
152	152
153	153	$this->file->touch($this);

		@@ -38,7 +38,9 @@
		block discarded – undo
38	38	$this->argument[$key] = ucfirst($key);
39	39	$this->{$method}();
40	40
41		- if($break) break;
	41	+ if($break) {
	42	+ break;
	43	+ }
42	44	}
43	45	exit();
44	46	}

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	* @param ApplicationContracts $app
26	26	* @param WorkerManagerContracts $worker
27	27	*/
28		- public function __construct(ApplicationContracts $app,WorkerManagerContracts $worker)
	28	+ public function __construct(ApplicationContracts $app, WorkerManagerContracts $worker)
29	29	{
30	30	parent::__construct($app);
31	31
		@@ -41,19 +41,19 @@ discard block
		block discarded – undo
41	41	*/
42	42	public function jobProcessor()
43	43	{
44		- if($this->app->get('WORKER_START')===true){
	44	+ if ($this->app->get('WORKER_START')===true) {
45	45	return 'start';
46	46	}
47	47
48		- if($this->app->get('WORKER_STOP')===true){
	48	+ if ($this->app->get('WORKER_STOP')===true) {
49	49	return 'stop';
50	50	}
51	51
52		- if($this->app->get('WORKER_STATUS')===true){
	52	+ if ($this->app->get('WORKER_STATUS')===true) {
53	53	return 'status';
54	54	}
55	55
56		- if($this->app->get('WORKER_CLEAR')===true){
	56	+ if ($this->app->get('WORKER_CLEAR')===true) {
57	57	return 'clear';
58	58	}
59	59	}

		@@ -13,9 +13,9 @@
		block discarded – undo
13	13	* @param null\|string $command
14	14	* @return mixed\|void
15	15	*/
16		- public function command($command=null)
	16	+ public function command($command = null)
17	17	{
18		- $process = new ProcessHandler($command,root.'');
	18	+ $process = new ProcessHandler($command, root.'');
19	19	$process->run();
20	20
21	21	// executes after the command finishes

php-resta / resta-core

Push — master ( 1dec6d...a46529 )

Status

Category

Spacing +39 added lines, -39 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch