Resta\Console\Source\Track\Track::log()

Complexity

Conditions	7
Paths	18

Size

Total Lines	38
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php

    public function log()

    {

        if(app()->has('track.path')){

            $trackPath = app()->get('track.path');

            $logger = $trackPath($this->argument);

        }

        else{

            $logger = app()->path()->appLog().''.DIRECTORY_SEPARATOR.''.date('Y').''.DIRECTORY_SEPARATOR.''.date('m').''.DIRECTORY_SEPARATOR.''.date('d').'-access.log';

        }


        if(!file_exists($logger)){

            echo 'No requests for a log tracker have been detected yet.';

            echo PHP_EOL;

            exit();

Using exit here is not recommended.

        }


        $tailCommand = 'tail -n 1 -f '.escapeshellarg($logger).'';


        while (@ ob_end_flush()); // end all output buffers if any


        $proc = popen($tailCommand, 'r');


        $number = 0;

        while (!feof($proc))

It seems like $proc can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

        {

            $result = fread($proc, 4096);

It seems like $proc can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

            if(preg_match('@\{(.*)\}@',$result,$output)){

                $outputArray = json_decode($output[0],1);


                $outputArray['trackNumber'] = ++$number;


                if(app()->has('track.log')){


                    $track = app()->get('track.log');

                    echo $track($outputArray,$this->argument);

                }

            }

            @ flush();

Are you sure the usage of flush() is correct as it seems to always return null.

It seems like you do not handle an error condition for flush(). This can introduce security issues, and is generally not recommended.

        }

}