Resta\Console\Source\Track\Track

Complexity

Total Complexity

7

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	log()	0	38	7

<?php


namespace Resta\Console\Source\Track;


use Resta\Console\ConsoleOutputter;

use Resta\Console\ConsoleListAccessor;


class Track extends ConsoleOutputter

{

    use ConsoleListAccessor;


    /**

     * @var $type

The doc comment $type at position 0 could not be parsed: Unknown type name '$type' at position 0 in $type.

     */

    public $type = 'track';


    /**

     * @var $define

The doc comment $define at position 0 could not be parsed: Unknown type name '$define' at position 0 in $define.

     */

    public $define = 'returns track information for application';


    /**

     * @var $commandRule

The doc comment $commandRule at position 0 could not be parsed: Unknown type name '$commandRule' at position 0 in $commandRule.

     */

    public $commandRule = [];


    /**

     * @return mixed|void

     */

    public function log()

    {

        if(app()->has('track.path')){

            $trackPath = app()->get('track.path');

            $logger = $trackPath($this->argument);

        }

        else{

            $logger = app()->path()->appLog().''.DIRECTORY_SEPARATOR.''.date('Y').''.DIRECTORY_SEPARATOR.''.date('m').''.DIRECTORY_SEPARATOR.''.date('d').'-access.log';

        }


        if(!file_exists($logger)){

            echo 'No requests for a log tracker have been detected yet.';

            echo PHP_EOL;

            exit();

Using exit here is not recommended.

        }


        $tailCommand = 'tail -n 1 -f '.escapeshellarg($logger).'';


        while (@ ob_end_flush()); // end all output buffers if any


        $proc = popen($tailCommand, 'r');


        $number = 0;

        while (!feof($proc))

It seems like $proc can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

        {

            $result = fread($proc, 4096);

It seems like $proc can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

            if(preg_match('@\{(.*)\}@',$result,$output)){

                $outputArray = json_decode($output[0],1);


                $outputArray['trackNumber'] = ++$number;


                if(app()->has('track.log')){


                    $track = app()->get('track.log');

                    echo $track($outputArray,$this->argument);

                }

            }

            @ flush();

Are you sure the usage of flush() is correct as it seems to always return null.

It seems like you do not handle an error condition for flush(). This can introduce security issues, and is generally not recommended.

        }


    }

}