GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Push — master ( 8e9a23...b956c8 )
by Jamie
03:03
created

Server::createInterfaceAttachment()   A

Complexity

Conditions 3
Paths 2

Size

Total Lines 9
Code Lines 5

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 12

Importance

Changes 0
Metric Value
dl 0
loc 9
ccs 0
cts 0
cp 0
rs 9.6666
c 0
b 0
f 0
cc 3
eloc 5
nc 2
nop 1
crap 12
1
<?php declare(strict_types=1);
2
3
namespace OpenStack\Compute\v2\Models;
4
5
use OpenStack\Common\Resource\HasWaiterTrait;
6
use OpenStack\Common\Resource\Creatable;
7
use OpenStack\Common\Resource\Deletable;
8
use OpenStack\Common\Resource\Listable;
9
use OpenStack\Common\Resource\Retrievable;
10
use OpenStack\Common\Resource\Updateable;
11
use OpenStack\Common\Resource\OperatorResource;
12
use OpenStack\Common\Transport\Utils;
13
use OpenStack\BlockStorage\v2\Models\VolumeAttachment;
14
use OpenStack\Networking\v2\Models\InterfaceAttachment;
15
use OpenStack\Compute\v2\Enum;
16
use OpenStack\Networking\v2\Extensions\SecurityGroups\Models\SecurityGroup;
17
use Psr\Http\Message\ResponseInterface;
18
19
/**
20
 * @property \OpenStack\Compute\v2\Api $api
21
 */
22
class Server extends OperatorResource implements
23
    Creatable,
24
    Updateable,
25
    Deletable,
26
    Retrievable,
27
    Listable
28
{
29
    use HasWaiterTrait;
30
31
    /** @var string */
32
    public $id;
33
34
    /** @var string */
35
    public $ipv4;
36
37
    /** @var string */
38
    public $ipv6;
39
40
    /** @var array */
41
    public $addresses;
42
43
    /** @var \DateTimeImmutable */
44
    public $created;
45
46
    /** @var \DateTimeImmutable */
47
    public $updated;
48
49
    /** @var Flavor */
50
    public $flavor;
51
52
    /** @var string */
53
    public $hostId;
54
55
    /** @var string */
56
    public $hypervisorHostname;
57
58
    /** @var Image */
59
    public $image;
60
61
    /** @var array */
62
    public $links;
63
64
    /** @var array */
65
    public $metadata;
66
67
    /** @var string */
68
    public $name;
69
70
    /** @var string */
71
    public $progress;
72
73
    /** @var string */
74
    public $status;
75
76
    /** @var string */
77
    public $tenantId;
78
79
    /** @var string */
80
    public $userId;
81
82
    /** @var string */
83
    public $adminPass;
84
85
    /** @var string */
86
    public $taskState;
87
88
    /** @var string */
89
    public $powerState;
90
91
    /** @var string */
92
    public $vmState;
93
94
    protected $resourceKey = 'server';
95
    protected $resourcesKey = 'servers';
96
    protected $markerKey = 'id';
97
98
    protected $aliases = [
99
        'block_device_mapping_v2'             => 'blockDeviceMapping',
100
        'accessIPv4'                          => 'ipv4',
101 2
        'accessIPv6'                          => 'ipv6',
102
        'tenant_id'                           => 'tenantId',
103 2
        'user_id'                             => 'userId',
104 2
        'security_groups'                     => 'securityGroups',
105
        'OS-EXT-STS:task_state'               => 'taskState',
106
        'OS-EXT-STS:power_state'              => 'powerState',
107
        'OS-EXT-STS:vm_state'                 => 'vmState',
108
        'OS-EXT-SRV-ATTR:hypervisor_hostname' => 'hypervisorHostname',
109
    ];
110 1
111
    /**
112 1
     * {@inheritDoc}
113
     *
114 1
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postServer}
115
     */
116
    public function create(array $userOptions): Creatable
117
    {
118
        if (!isset($userOptions['imageId']) && !isset($userOptions['blockDeviceMapping'][0]['uuid'])) {
119
            throw new \RuntimeException('imageId or blockDeviceMapping.uuid must be set.');
120 1
        }
121
122 1
        $response = $this->execute($this->api->postServer(), $userOptions);
123 1
        return $this->populateFromResponse($response);
124
    }
125
126
    /**
127
     * {@inheritDoc}
128 1
     */
129
    public function update()
130 1
    {
131
        $response = $this->execute($this->api->putServer(), $this->getAttrs(['id', 'name', 'ipv4', 'ipv6']));
132 1
        $this->populateFromResponse($response);
133
    }
134
135
    /**
136
     * {@inheritDoc}
137
     */
138
    public function delete()
139
    {
140 1
        $this->execute($this->api->deleteServer(), $this->getAttrs(['id']));
141
    }
142 1
143 1
    /**
144
     * {@inheritDoc}
145 1
     */
146 1
    public function retrieve()
147
    {
148
        $response = $this->execute($this->api->getServer(), $this->getAttrs(['id']));
149
        $this->populateFromResponse($response);
150
    }
151
152
    /**
153 2
     * Changes the root password for a server.
154
     *
155 2
     * @param string $newPassword The new root password
156 1
     */
157
    public function changePassword(string $newPassword)
158
    {
159 1
        $this->execute($this->api->changeServerPassword(), [
160 1
            'id'       => $this->id,
161 1
            'password' => $newPassword,
162 1
        ]);
163 1
    }
164
165
    /**
166
     * Reboots the server.
167
     *
168
     * @param string $type The type of reboot that will be performed. Either SOFT or HARD is supported.
169
     */
170 1
    public function reboot(string $type = Enum::REBOOT_SOFT)
171
    {
172 1
        if (!in_array($type, ['SOFT', 'HARD'])) {
173 1
            throw new \RuntimeException('Reboot type must either be SOFT or HARD');
174
        }
175 1
176 1
        $this->execute($this->api->rebootServer(), [
177
            'id'   => $this->id,
178
            'type' => $type,
179
        ]);
180
    }
181
182
    /**
183
     * Starts server
184 1
     */
185
    public function start()
186 1
    {
187 1
        $this->execute($this->api->startServer(), [
188 1
            'id' => $this->id,
189 1
            'os-start' => null
190
        ]);
191 1
    }
192 1
193
    /**
194
     * Stops server
195
     */
196
    public function stop()
197 1
    {
198
        $this->execute($this->api->stopServer(), [
199 1
            'id' => $this->id,
200 1
            'os-stop' => null
201
        ]);
202
    }
203
204
    /**
205 1
     * Rebuilds the server.
206
     *
207 1
     * @param array $options {@see \OpenStack\Compute\v2\Api::rebuildServer}
208 1
     */
209
    public function rebuild(array $options)
210
    {
211
        $options['id'] = $this->id;
212
        $response = $this->execute($this->api->rebuildServer(), $options);
213
214
        $this->populateFromResponse($response);
215 1
    }
216
217 1
    /**
218 1
     * Resizes the server to a new flavor. Once this operation is complete and server has transitioned
219 1
     * to an active state, you will either need to call {@see confirmResize()} or {@see revertResize()}.
220
     *
221
     * @param string $flavorId The UUID of the new flavor your server will be based on.
222
     */
223
    public function resize(string $flavorId)
224
    {
225
        $response = $this->execute($this->api->resizeServer(), [
226
            'id'       => $this->id,
227
            'flavorId' => $flavorId,
228 2
        ]);
229
230 2
        $this->populateFromResponse($response);
231
    }
232 2
233 2
    /**
234 2
     * Confirms a previous resize operation.
235
     */
236
    public function confirmResize()
237
    {
238
        $this->execute($this->api->confirmServerResize(), ['confirmResize' => null, 'id' => $this->id]);
239
    }
240
241
    /**
242 1
     * Reverts a previous resize operation.
243
     */
244 1
    public function revertResize()
245 1
    {
246
        $this->execute($this->api->revertServerResize(), ['revertResize' => null, 'id' => $this->id]);
247
    }
248
249
    /**
250
     * Gets a VNC console for a server.
251
     *
252
     * @param  string $type The type of VNC console: novnc|xvpvnc.
253
     *                      Defaults to novnc.
254
     *
255
     * @return array
256 1
     */
257
    public function getVncConsole($type = Enum::CONSOLE_NOVNC): array
258 1
    {
259 1
        $response = $this->execute($this->api->getVncConsole(), ['id' => $this->id, 'type' => $type]);
260
        return Utils::jsonDecode($response)['console'];
261
    }
262
263
    /**
264
     * Gets a RDP console for a server.
265
     *
266
     * @param  string $type The type of VNC console: rdp-html5 (default).
267
     *
268
     * @return array
269
     */
270
    public function getRDPConsole($type = Enum::CONSOLE_RDP_HTML5): array
271 1
    {
272
        $response = $this->execute($this->api->getRDPConsole(), ['id' => $this->id, 'type' => $type]);
273 1
        return Utils::jsonDecode($response)['console'];
274 1
    }
275
276
    /**
277
     * Gets a Spice console for a server.
278
     *
279
     * @param  string $type The type of VNC console: spice-html5.
280
     *
281
     * @return array
282
     */
283
    public function getSpiceConsole($type = Enum::CONSOLE_SPICE_HTML5): array
284 1
    {
285
        $response = $this->execute($this->api->getSpiceConsole(), ['id' => $this->id, 'type' => $type]);
286 1
        return Utils::jsonDecode($response)['console'];
287 1
    }
288
289
    /**
290
     * Gets a serial console for a server.
291
     *
292
     * @param  string $type The type of VNC console: serial.
293
     *
294
     * @return array
295 1
     */
296
    public function getSerialConsole($type = Enum::CONSOLE_SERIAL): array
297 1
    {
298 1
        $response = $this->execute($this->api->getSerialConsole(), ['id' => $this->id, 'type' => $type]);
299
        return Utils::jsonDecode($response)['console'];
300
    }
301
302
    /**
303
     * Creates an image for the current server.
304
     *
305
     * @param array $options {@see \OpenStack\Compute\v2\Api::createServerImage}
306
     */
307
    public function createImage(array $options)
308
    {
309
        $options['id'] = $this->id;
310
        $this->execute($this->api->createServerImage(), $options);
311
    }
312
313
    /**
314
     * Iterates over all the IP addresses for this server.
315
     *
316
     * @param array $options {@see \OpenStack\Compute\v2\Api::getAddressesByNetwork}
317
     *
318
     * @return array An array containing to two keys: "public" and "private"
319
     */
320
    public function listAddresses(array $options = []): array
321
    {
322
        $options['id'] = $this->id;
323
324
        $data = (isset($options['networkLabel'])) ? $this->api->getAddressesByNetwork() : $this->api->getAddresses();
325
        $response = $this->execute($data, $options);
326
        return Utils::jsonDecode($response)['addresses'];
327
    }
328
329
    /**
330
     * Returns Generator for InterfaceAttachment
331
     *
332
     * @return \Generator
333
     */
334
    public function listInterfaceAttachments(array $options = []): \Generator
0 ignored issues
show
Unused Code introduced by
The parameter $options is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
335
    {
336
        return $this->model(InterfaceAttachment::class)->enumerate($this->api->getInterfaceAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
337
    }
338
339
    /**
340
     * Gets an interface attachment.
341
     *
342
     * @param string $portId The unique ID of the port.
343
     * @return InterfaceAttachment
344
     */
345 View Code Duplication
    public function getInterfaceAttachment(string $portId): InterfaceAttachment
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
346
    {
347
        $response = $this->execute($this->api->getInterfaceAttachment(), [
348
            'id'     => $this->id,
349
            'portId' => $portId
350
        ]);
351
352
        return $this->model(InterfaceAttachment::class)->populateFromResponse($response);
353
    }
354
355
    /**
356
     * Creates an interface attachment.
357
     *
358
     * @param array $userOptions {@see \OpenStack\Compute\v2\Api::postInterfaceAttachment}
359
     * @return InterfaceAttachment
360
     */
361
    public function createInterfaceAttachment(array $userOptions): InterfaceAttachment
362
    {
363
        if (!isset($userOptions['networkId']) && !isset($userOptions['portId'])) {
364
            throw new \RuntimeException('networkId or portId must be set.');
365
        }
366
367
        $response = $this->execute($this->api->postInterfaceAttachment(), array_merge($userOptions, ['id' => $this->id]));
368
        return $this->model(InterfaceAttachment::class)->populateFromResponse($response);
369
    }
370
371
    /**
372
     * Detaches an interface attachment.
373
     *
374
     * @param string $portId
375
     */
376
    public function detachInterface(string $portId)
377
    {
378
        $this->execute($this->api->deleteInterfaceAttachment(), [
379
            'id' => $this->id,
380
            'portId' => $portId,
381
        ]);
382
    }
383
384
    /**
385
     * Retrieves metadata from the API.
386
     *
387
     * @return array
388
     */
389
    public function getMetadata(): array
390
    {
391
        $response = $this->execute($this->api->getServerMetadata(), ['id' => $this->id]);
392
        return $this->parseMetadata($response);
393
    }
394
395
    /**
396
     * Resets all the metadata for this server with the values provided. All existing metadata keys
397
     * will either be replaced or removed.
398
     *
399
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::putServerMetadata}
400
     */
401
    public function resetMetadata(array $metadata)
402
    {
403
        $response = $this->execute($this->api->putServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
404
        $this->metadata = $this->parseMetadata($response);
405
    }
406
407
    /**
408
     * Merges the existing metadata for the server with the values provided. Any existing keys
409
     * referenced in the user options will be replaced with the user's new values. All other
410
     * existing keys will remain unaffected.
411
     *
412
     * @param array $metadata {@see \OpenStack\Compute\v2\Api::postServerMetadata}
413
     *
414
     * @return array
415
     */
416
    public function mergeMetadata(array $metadata)
417
    {
418
        $response = $this->execute($this->api->postServerMetadata(), ['id' => $this->id, 'metadata' => $metadata]);
419
        $this->metadata = $this->parseMetadata($response);
420
    }
421
422
    /**
423
     * Retrieve the value for a specific metadata key.
424
     *
425
     * @param string $key {@see \OpenStack\Compute\v2\Api::getServerMetadataKey}
426
     *
427
     * @return mixed
428
     */
429 View Code Duplication
    public function getMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
430
    {
431
        $response = $this->execute($this->api->getServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
432
        $value = $this->parseMetadata($response)[$key];
433
        $this->metadata[$key] = $value;
434
        return $value;
435
    }
436
437
    /**
438
     * Remove a specific metadata key.
439
     *
440
     * @param string $key {@see \OpenStack\Compute\v2\Api::deleteServerMetadataKey}
441
     */
442 View Code Duplication
    public function deleteMetadataItem(string $key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
443
    {
444
        if (isset($this->metadata[$key])) {
445
            unset($this->metadata[$key]);
446
        }
447
448
        $this->execute($this->api->deleteServerMetadataKey(), ['id' => $this->id, 'key' => $key]);
449
    }
450
451
452
    /**
453
     * Add security group to a server (addSecurityGroup action)
454
     *
455
     * @param array $options {@see \OpenStack\Compute\v2\Api::postSecurityGroup}
456
     *
457
     * @return SecurityGroup
458
     */
459 View Code Duplication
    public function addSecurityGroup(array $options) : SecurityGroup
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
460
    {
461
        $options['id'] = $this->id;
462
463
        $response = $this->execute($this->api->postSecurityGroup(), $options);
464
465
        return $this->model(SecurityGroup::class)->populateFromResponse($response);
466
    }
467
468
    /**
469
     * Add security group to a server (addSecurityGroup action)
470
     *
471
     * @param array $options {@see \OpenStack\Compute\v2\Api::deleteSecurityGroup}
472
     */
473
    public function removeSecurityGroup(array $options)
474
    {
475
        $options['id'] = $this->id;
476
        $this->execute($this->api->deleteSecurityGroup(), $options);
477
    }
478
479
    public function parseMetadata(ResponseInterface $response): array
480
    {
481
        return Utils::jsonDecode($response)['metadata'];
482
    }
483
484
    /**
485
     * Returns Generator for SecurityGroups
486
     *
487
     * @return \Generator
488
     */
489
    public function listSecurityGroups(): \Generator
490
    {
491
        return $this->model(SecurityGroup::class)->enumerate($this->api->getSecurityGroups(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
492
    }
493
494
495
    /**
496
     * Returns Generator for VolumeAttachment
497
     *
498
     * @return \Generator
499
     */
500
    public function listVolumeAttachments(): \Generator
501
    {
502
        return $this->model(VolumeAttachment::class)->enumerate($this->api->getVolumeAttachments(), ['id' => $this->id]);
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface OpenStack\Common\Resource\ResourceInterface as the method enumerate() does only exist in the following implementations of said interface: OpenStack\BlockStorage\v2\Models\QuotaSet, OpenStack\BlockStorage\v2\Models\Snapshot, OpenStack\BlockStorage\v2\Models\Volume, OpenStack\BlockStorage\v2\Models\VolumeAttachment, OpenStack\BlockStorage\v2\Models\VolumeType, OpenStack\Common\Resource\OperatorResource, OpenStack\Compute\v2\Models\AvailabilityZone, OpenStack\Compute\v2\Models\Flavor, OpenStack\Compute\v2\Models\Host, OpenStack\Compute\v2\Models\Hypervisor, OpenStack\Compute\v2\Models\HypervisorStatistic, OpenStack\Compute\v2\Models\Image, OpenStack\Compute\v2\Models\Keypair, OpenStack\Compute\v2\Models\QuotaSet, OpenStack\Compute\v2\Models\Server, OpenStack\Identity\v2\Models\Catalog, OpenStack\Identity\v2\Models\Endpoint, OpenStack\Identity\v2\Models\Entry, OpenStack\Identity\v2\Models\Tenant, OpenStack\Identity\v2\Models\Token, OpenStack\Identity\v3\Models\Assignment, OpenStack\Identity\v3\Models\Catalog, OpenStack\Identity\v3\Models\Credential, OpenStack\Identity\v3\Models\Domain, OpenStack\Identity\v3\Models\Endpoint, OpenStack\Identity\v3\Models\Group, OpenStack\Identity\v3\Models\Policy, OpenStack\Identity\v3\Models\Project, OpenStack\Identity\v3\Models\Role, OpenStack\Identity\v3\Models\Service, OpenStack\Identity\v3\Models\Token, OpenStack\Identity\v3\Models\User, OpenStack\Images\v2\Models\Image, OpenStack\Images\v2\Models\Member, OpenStack\Metric\v1\Gnocchi\Models\Metric, OpenStack\Metric\v1\Gnocchi\Models\Resource, OpenStack\Metric\v1\Gnocchi\Models\ResourceType, OpenStack\Networking\v2\...ayer3\Models\FloatingIp, OpenStack\Networking\v2\...ns\Layer3\Models\Router, OpenStack\Networking\v2\...ps\Models\SecurityGroup, OpenStack\Networking\v2\...odels\SecurityGroupRule, OpenStack\Networking\v2\Models\InterfaceAttachment, OpenStack\Networking\v2\Models\LoadBalancer, OpenStack\Networking\v2\...adBalancerHealthMonitor, OpenStack\Networking\v2\...ls\LoadBalancerListener, OpenStack\Networking\v2\Models\LoadBalancerMember, OpenStack\Networking\v2\Models\LoadBalancerPool, OpenStack\Networking\v2\Models\LoadBalancerStat, OpenStack\Networking\v2\Models\LoadBalancerStatus, OpenStack\Networking\v2\Models\Network, OpenStack\Networking\v2\Models\Port, OpenStack\Networking\v2\Models\Quota, OpenStack\Networking\v2\Models\Subnet, OpenStack\ObjectStore\v1\Models\Account, OpenStack\ObjectStore\v1\Models\Container, OpenStack\ObjectStore\v1\Models\Object.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
503
    }
504
505
    /**
506
     * Attach a volume and returns volume that was attached
507
     *
508
     * @param $volumeId
509
     *
510
     * @return VolumeAttachment
511
     */
512
    public function attachVolume(string $volumeId): VolumeAttachment
513
    {
514
        $response =  $this->execute($this->api->postVolumeAttachments(), ['id' => $this->id, 'volumeId' => $volumeId]);
515
516
        return $this->model(VolumeAttachment::class)->populateFromResponse($response);
517
    }
518
519
    /**
520
     * Detach a volume
521
     *
522
     * @param $attachmentId
523
     *
524
     * @return void
525
     */
526
    public function detachVolume(string $attachmentId)
527
    {
528
        $this->execute($this->api->deleteVolumeAttachments(), ['id' => $this->id, 'attachmentId' => $attachmentId]);
529
    }
530
}
531