Issues in WebSocket.php (master) - Issues in master - php-api-clients/pusher - Measure and Improve Code Quality continuously with Scrutinizer

Issues (5)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/WebSocket.php (2 issues)

Labels

Bug 2

Severity

Major 2

Cees-Jan Kiewiet 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php declare(strict_types=1);

namespace ApiClients\Client\Pusher;

use PackageVersions\Versions;
use React\Dns\Resolver\Resolver;
use React\EventLoop\LoopInterface;
use React\Socket\Connector;
use Rx\DisposableInterface;
use Rx\Observable;
use Rx\ObserverInterface;
use Rx\Subject\ReplaySubject;
use Rx\Subject\Subject;
use Rx\Websocket\Client;

/**
 * Class WebSocket - WebSocket wrapper that queues messages while the connection is being established.
 */
final class WebSocket extends Subject
{
    private $ws;
    private $sendSubject;

    /**
     * @internal
     * @param  Observable                $ws
     * @throws \InvalidArgumentException
     */
    public function __construct(Observable $ws)
    {
        $this->sendSubject = new ReplaySubject();
        $this->ws = $ws;
    }

    public static function createFactory(string $url, bool $useMessageObject = false, array $subProtocols = [], LoopInterface $loop = null, Resolver $resolver = null): Subject
    {
        if (Versions::getVersion('rx/websocket')[0] === '1' || $resolver === null) {
            return new self(
                new Client($url, $useMessageObject, $subProtocols, $loop, $resolver)

            );
        }

        return new self(
            new Client($url, $useMessageObject, $subProtocols, $loop, new Connector(
                $loop,
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
                [
                    'dns' => $resolver,
                ]
            ))
        );
    }

    public function onNext($value): void
    {
        $this->sendSubject->onNext($value);
    }

    protected function _subscribe(ObserverInterface $observer): DisposableInterface
    {
        return $this->ws
            ->do(function (Subject $ms): void {
                // Replay buffered messages onto the MessageSubject
                $this->sendSubject->subscribe($ms);

                // Now that the connection has been established, use the message subject directly.
                $this->sendSubject = $ms;
            })
            ->finally(function (): void {
                // The connection has closed, so start buffering messages util it reconnects.
                $this->sendSubject = new ReplaySubject();
            })
            ->switch()
            ->repeatDelay()
            ->subscribe($observer);
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Pusher;
4
5		use PackageVersions\Versions;
6		use React\Dns\Resolver\Resolver;
7		use React\EventLoop\LoopInterface;
8		use React\Socket\Connector;
9		use Rx\DisposableInterface;
10		use Rx\Observable;
11		use Rx\ObserverInterface;
12		use Rx\Subject\ReplaySubject;
13		use Rx\Subject\Subject;
14		use Rx\Websocket\Client;
15
16		/**
17		* Class WebSocket - WebSocket wrapper that queues messages while the connection is being established.
18		*/
19		final class WebSocket extends Subject
20		{
21		private $ws;
22		private $sendSubject;
23
24		/**
25		* @internal
26		* @param Observable $ws
27		* @throws \InvalidArgumentException
28		*/
29	13	public function __construct(Observable $ws)
30		{
31	13	$this->sendSubject = new ReplaySubject();
32	13	$this->ws = $ws;
33	13	}
34
35	4	public static function createFactory(string $url, bool $useMessageObject = false, array $subProtocols = [], LoopInterface $loop = null, Resolver $resolver = null): Subject
36		{
37	4	if (Versions::getVersion('rx/websocket')[0] === '1' \|\| $resolver === null) {
38	3	return new self(
39	3	new Client($url, $useMessageObject, $subProtocols, $loop, $resolver)
		0 ignored issues – show Bug introduced 2017-09-20 09:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$resolver` defined by parameter `$resolver` on line 35 can also be of type `object<React\Dns\Resolver\Resolver>`; however, `Rx\Websocket\Client::__construct()` does only seem to accept `null\|object<React\Socket\ConnectorInterface>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
40		);
41		}
42
43	1	return new self(
44	1	new Client($url, $useMessageObject, $subProtocols, $loop, new Connector(
45	1	$loop,
		0 ignored issues – show Bug introduced 2017-09-20 09:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$loop` defined by parameter `$loop` on line `35` can be `null`; however, `React\Socket\Connector::__construct()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
46		[
47	1	'dns' => $resolver,
48		]
49		))
50		);
51		}
52
53	2	public function onNext($value): void
54		{
55	2	$this->sendSubject->onNext($value);
56	2	}
57
58	10	protected function _subscribe(ObserverInterface $observer): DisposableInterface
59		{
60	10	return $this->ws
61	10	->do(function (Subject $ms): void {
62		// Replay buffered messages onto the MessageSubject
63	5	$this->sendSubject->subscribe($ms);
64
65		// Now that the connection has been established, use the message subject directly.
66	5	$this->sendSubject = $ms;
67	10	})
68	10	->finally(function (): void {
69		// The connection has closed, so start buffering messages util it reconnects.
70	10	$this->sendSubject = new ReplaySubject();
71	10	})
72	10	->switch()
73	10	->repeatDelay()
74	10	->subscribe($observer);
75		}
76		}
77

GitHub Access Token became invalid

Issues (5)

Security Analysis no request data

src/WebSocket.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

php-api-clients / pusher

GitHub Access Token became invalid

Issues (5)

Security Analysis no request data

src/WebSocket.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like