GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.

WebSocket   A
last analyzed

Complexity

Total Complexity 6

Size/Duplication

Total Lines 58
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 6

Test Coverage

Coverage 100%

Importance

Changes 0
Metric Value
wmc 6
lcom 1
cbo 6
dl 0
loc 58
ccs 27
cts 27
cp 1
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 5 1
A createFactory() 0 17 3
A onNext() 0 4 1
A _subscribe() 0 18 1
1
<?php declare(strict_types=1);
2
3
namespace ApiClients\Client\Pusher;
4
5
use PackageVersions\Versions;
6
use React\Dns\Resolver\Resolver;
7
use React\EventLoop\LoopInterface;
8
use React\Socket\Connector;
9
use Rx\DisposableInterface;
10
use Rx\Observable;
11
use Rx\ObserverInterface;
12
use Rx\Subject\ReplaySubject;
13
use Rx\Subject\Subject;
14
use Rx\Websocket\Client;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, ApiClients\Client\Pusher\Client.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
15
16
/**
17
 * Class WebSocket - WebSocket wrapper that queues messages while the connection is being established.
18
 */
19
final class WebSocket extends Subject
20
{
21
    private $ws;
22
    private $sendSubject;
23
24
    /**
25
     * @internal
26
     * @param  Observable                $ws
27
     * @throws \InvalidArgumentException
28
     */
29 13
    public function __construct(Observable $ws)
30
    {
31 13
        $this->sendSubject = new ReplaySubject();
32 13
        $this->ws = $ws;
33 13
    }
34
35 4
    public static function createFactory(string $url, bool $useMessageObject = false, array $subProtocols = [], LoopInterface $loop = null, Resolver $resolver = null): Subject
36
    {
37 4
        if (Versions::getVersion('rx/websocket')[0] === '1' || $resolver === null) {
38 3
            return new self(
39 3
                new Client($url, $useMessageObject, $subProtocols, $loop, $resolver)
0 ignored issues
show
Bug introduced by
It seems like $resolver defined by parameter $resolver on line 35 can also be of type object<React\Dns\Resolver\Resolver>; however, Rx\Websocket\Client::__construct() does only seem to accept null|object<React\Socket\ConnectorInterface>, maybe add an additional type check?

This check looks at variables that have been passed in as parameters and are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
40
            );
41
        }
42
43 1
        return new self(
44 1
            new Client($url, $useMessageObject, $subProtocols, $loop, new Connector(
45 1
                $loop,
0 ignored issues
show
Bug introduced by
It seems like $loop defined by parameter $loop on line 35 can be null; however, React\Socket\Connector::__construct() does not accept null, maybe add an additional type check?

It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null.

We recommend to add an additional type check (or disallow null for the parameter):

function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
Loading history...
46
                [
47 1
                    'dns' => $resolver,
48
                ]
49
            ))
50
        );
51
    }
52
53 2
    public function onNext($value): void
54
    {
55 2
        $this->sendSubject->onNext($value);
56 2
    }
57
58 10
    protected function _subscribe(ObserverInterface $observer): DisposableInterface
59
    {
60 10
        return $this->ws
61 10
            ->do(function (Subject $ms): void {
62
                // Replay buffered messages onto the MessageSubject
63 5
                $this->sendSubject->subscribe($ms);
64
65
                // Now that the connection has been established, use the message subject directly.
66 5
                $this->sendSubject = $ms;
67 10
            })
68 10
            ->finally(function (): void {
69
                // The connection has closed, so start buffering messages util it reconnects.
70 10
                $this->sendSubject = new ReplaySubject();
71 10
            })
72 10
            ->switch()
73 10
            ->repeatDelay()
74 10
            ->subscribe($observer);
75
    }
76
}
77