php-ai / php-ml

src/Phpml/DimensionReduction/LDA.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 namespace Phpml\DimensionReduction;
 
 
-use Phpml\Math\Statistic\Mean;
 use Phpml\Math\Matrix;
 
 class LDA extends EigenTransformerBase

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\DimensionReduction;
 
@@ -119,21 +119,21 @@ 
     protected function calculateMeans($data, $classes) : array
     {
         $means = [];
-        $counts= [];
+        $counts = [];
         $overallMean = array_fill(0, count($data[0]), 0.0);
 
         foreach ($data as $index => $row) {
             $label = array_search($classes[$index], $this->labels);
 
             foreach ($row as $col => $val) {
-                if (! isset($means[$label][$col])) {
+                if (!isset($means[$label][$col])) {
                     $means[$label][$col] = 0.0;
                 }
                 $means[$label][$col] += $val;
                 $overallMean[$col] += $val;
             }
 
-            if (! isset($counts[$label])) {
+            if (!isset($counts[$label])) {
                 $counts[$label] = 0;
             }
             $counts[$label]++;
@@ -147,7 +147,7 @@ 
 
         // Calculate overall mean of the dataset for each column
         $numElements = array_sum($counts);
-        $map = function ($el) use ($numElements) {
+        $map = function($el) use ($numElements) {
             return $el / $numElements;
         };
         $this->overallMean = array_map($map, $overallMean);
@@ -238,7 +238,7 @@ 
             throw new \Exception("LDA has not been fitted with respect to original dataset, please run LDA::fit() first");
         }
 
-        if (! is_array($sample[0])) {
+        if (!is_array($sample[0])) {
             $sample = [$sample];
         }
 

src/Phpml/DimensionReduction/EigenTransformerBase.php

Spacing +2 added lines, -2 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace Phpml\DimensionReduction;
 
@@ -52,7 +52,7 @@ 
     {
         $eig = new EigenvalueDecomposition($matrix);
         $eigVals = $eig->getRealEigenvalues();
-        $eigVects= $eig->getEigenvectors();
+        $eigVects = $eig->getEigenvectors();
 
         $totalEigVal = array_sum($eigVals);
         // Sort eigenvalues in descending order

src/Phpml/DimensionReduction/PCA.php

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\DimensionReduction;
 
@@ -86,7 +86,7 @@ 
     {
         // Calculate means for each dimension
         $this->means = [];
-        for ($i=0; $i < $n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $column = array_column($data, $i);
             $this->means[] = Mean::arithmetic($column);
         }
@@ -109,7 +109,7 @@ 
 
         // Normalize data
         foreach ($data as $i => $row) {
-            for ($k=0; $k < $n; $k++) {
+            for ($k = 0; $k < $n; $k++) {
                 $data[$i][$k] -= $this->means[$k];
             }
         }
@@ -131,7 +131,7 @@ 
             throw new \Exception("PCA has not been fitted with respect to original dataset, please run PCA::fit() first");
         }
 
-        if (! is_array($sample[0])) {
+        if (!is_array($sample[0])) {
             $sample = [$sample];
         }
 

src/Phpml/Math/LinearAlgebra/LUDecomposition.php

Doc Comments +3 added lines, -3 removed lines

@@ -131,7 +131,7 @@ 
     /**
      *	Get lower triangular factor.
      *
-     *	@return array Lower triangular factor
+     *	@return Matrix Lower triangular factor
      */
     public function getL()
     {
@@ -154,7 +154,7 @@ 
     /**
      *	Get upper triangular factor.
      *
-     *	@return array Upper triangular factor
+     *	@return Matrix Upper triangular factor
      */
     public function getU()
     {
@@ -197,7 +197,7 @@ 
     /**
      *	Is the matrix nonsingular?
      *
-     *	@return true if U, and hence A, is nonsingular.
+     *	@return boolean if U, and hence A, is nonsingular.
      */
     public function isNonsingular()
     {

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 /**
  *	@package JAMA
  *
@@ -102,7 +102,7 @@ 
             }
             // Find pivot and exchange if necessary.
             $p = $j;
-            for ($i = $j+1; $i < $this->m; ++$i) {
+            for ($i = $j + 1; $i < $this->m; ++$i) {
                 if (abs($LUcolj[$i]) > abs($LUcolj[$p])) {
                     $p = $i;
                 }
@@ -120,7 +120,7 @@ 
             }
             // Compute multipliers.
             if (($j < $this->m) && ($this->LU[$j][$j] != 0.0)) {
-                for ($i = $j+1; $i < $this->m; ++$i) {
+                for ($i = $j + 1; $i < $this->m; ++$i) {
                     $this->LU[$i][$j] /= $this->LU[$j][$j];
                 }
             }
@@ -244,23 +244,23 @@ 
             throw MatrixException::notSquareMatrix();
         }
 
-        if (! $this->isNonsingular()) {
+        if (!$this->isNonsingular()) {
             throw MatrixException::singularMatrix();
         }
 
         // Copy right hand side with pivoting
         $nx = $B->getColumns();
-        $X  = $this->getSubMatrix($B->toArray(), $this->piv, 0, $nx-1);
+        $X  = $this->getSubMatrix($B->toArray(), $this->piv, 0, $nx - 1);
         // Solve L*Y = B(piv,:)
         for ($k = 0; $k < $this->n; ++$k) {
-            for ($i = $k+1; $i < $this->n; ++$i) {
+            for ($i = $k + 1; $i < $this->n; ++$i) {
                 for ($j = 0; $j < $nx; ++$j) {
                     $X[$i][$j] -= $X[$k][$j] * $this->LU[$i][$k];
                 }
             }
         }
         // Solve U*X = Y;
-        for ($k = $this->n-1; $k >= 0; --$k) {
+        for ($k = $this->n - 1; $k >= 0; --$k) {
             for ($j = 0; $j < $nx; ++$j) {
                 $X[$k][$j] /= $this->LU[$k][$k];
             }
@@ -284,11 +284,11 @@ 
     {
         $m = count($RL);
         $n = $jF - $j0;
-        $R = array_fill(0, $m, array_fill(0, $n+1, 0.0));
+        $R = array_fill(0, $m, array_fill(0, $n + 1, 0.0));
 
         for ($i = 0; $i < $m; ++$i) {
             for ($j = $j0; $j <= $jF; ++$j) {
-                $R[$i][$j - $j0]= $matrix[ $RL[$i] ][$j];
+                $R[$i][$j - $j0] = $matrix[$RL[$i]][$j];
             }
         }
 

src/Phpml/Math/Matrix.php

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Math;
 
@@ -180,7 +180,7 @@ 
     public function transpose()
     {
         if ($this->rows == 1) {
-            $matrix = array_map(function ($el) {
+            $matrix = array_map(function($el) {
                 return [$el];
             }, $this->matrix[0]);
         } else {
@@ -284,8 +284,8 @@ 
         $a2 = $other->toArray();
 
         $newMatrix = [];
-        for ($i=0; $i < $this->rows; $i++) {
-            for ($k=0; $k < $this->columns; $k++) {
+        for ($i = 0; $i < $this->rows; $i++) {
+            for ($k = 0; $k < $this->columns; $k++) {
                 $newMatrix[$i][$k] = $a1[$i][$k] + $sign * $a2[$i][$k];
             }
         }
@@ -349,7 +349,7 @@ 
     protected function getIdentity()
     {
         $array = array_fill(0, $this->rows, array_fill(0, $this->columns, 0));
-        for ($i=0; $i < $this->rows; $i++) {
+        for ($i = 0; $i < $this->rows; $i++) {
             $array[$i][$i] = 1;
         }